[{"id":3684087,"web_url":"http://patchwork.ozlabs.org/comment/3684087/","msgid":"","list_archive_url":null,"date":"2026-04-29T14:21:26","subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 2026-04-28T14:28:48, Heinrich Schuchardt\n wrote:\n> .clang-format: add U-Boot specific for each macros\n>\n> Formatting via clang-format is controlled by .clang-format.\n> For each statements should be formatted with a brace at the line end:\n>\n> for_each() {\n> }\n>\n> This requires clang-format to know that the symbol is not a function\n> but a for each macro. We use some for each macros which don't exist in\n> Linux. Add these to file .clang-format.\n>\n> Signed-off-by: Heinrich Schuchardt \n>\n> .clang-format | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 51 insertions(+)\n\nReviewed-by: Simon Glass \n\n> diff --git a/.clang-format b/.clang-format\n> @@ -748,6 +748,57 @@ ForEachMacros:\n> + # U-Boot specific\n> + - '__for_each_child_of_node'\n\nShould the 'git grep' recipe include drivers/ and arch/ as well?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=fHAGgCSH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"fHAGgCSH\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5KHb6zqFz1xqf\n\tfor ; Thu, 30 Apr 2026 00:21:47 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C65FE848BE;\n\tWed, 29 Apr 2026 16:21:43 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id DA72A848CF; Wed, 29 Apr 2026 16:21:42 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n [IPv6:2a00:1450:4864:20::632])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F3EE9848BD\n for ; Wed, 29 Apr 2026 16:21:40 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n a640c23a62f3a-bb91b426e40so211250866b.0\n for ; Wed, 29 Apr 2026 07:21:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777472500; cv=none;\n d=google.com; s=arc-20240605;\n b=NY47c1ZaaPaQ45nS/eThpe7Hz6WxbBw7c430ejtqR6PzHCUOksmFFF1na+TRXBmBTK\n jCZfDe7WCTcRAViNb6vlZDBn1k2aDxlDHEAh8B0/5xz+zsFhUvKe8KDDY+e4u0CVIJzT\n /eN8MCiJqlPgjVM2wrljJa0u+zekvqCXbQyhOEsyEaV03nXLKxceKt0q11LwAWm42ws9\n RwFvWih2Q/MayGzO6mdNSqHhBR7q9SJH0mvK8VRMHwrf70MqZK97F6fF+wBKZpZniF15\n NWw6eoFFJXATCVYFnrwD/D/Hg3mHjI94d6CdNs6AWBa+8bbd4k8QIvBJFZyDfyMc7JYm\n 3oGg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=E23U+c6Fyqj2bO9ovOOl0hc+xFd9hL7CNO1HTC2iB+4=;\n fh=AkkFQGgex4/uJFFEvqZIjF/kHc3dyQYXt0MIVYfaUkA=;\n b=EhJAhGd/m9dYhaFO18HKdACnb9SI4/eMltMbGcBF7MzGzeclRTr2jI7ODJTc+jzCp6\n 9NsRyd3vfQjStSK9+ubCd8QcWpaMuVRCoV9fRRGcWD5ZfH0Aasjq7Hu2M1Mxssr6MZpv\n vJMhnsOk28pHbphtFstk+e/ZXPJH1LBr46F6eQ+6UAgrcEQkCoNnOKgBdUgCbDliyRbS\n T9Vcvxu9MITUcyBZad8ZZNKv9WCkM8NiywMYC0RG8QVMVbtMWxQUAdLXG1JcC8vFQjCi\n KfK6jOHiY44ADcoNv3hVHZh2S3yJGlI/piorApqtebIEKMFJ2enqm2G8hlI7TJ1A1KMo\n PaZQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777472500; x=1778077300; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=E23U+c6Fyqj2bO9ovOOl0hc+xFd9hL7CNO1HTC2iB+4=;\n b=fHAGgCSHY7Lt9lFR0lzQWotoR1T7MHGU4bxG0myvTxRdCtM5dU7uXB+q3aXayo5EtK\n D7YFfh6A1CLYr0usM0qxPuaNk3uIcWe2mBRFOyxOz4Uj5DwQVbfdZe7llmrH1htCdBk0\n l5KPdvLFVV0NSyLCDupNmACGyqEmUJh5c09p0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777472500; x=1778077300;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=E23U+c6Fyqj2bO9ovOOl0hc+xFd9hL7CNO1HTC2iB+4=;\n b=gdD9VfA9IvUpgrQcnFYfKjzvxDZBBdoMhhG35mxAFNub6EkL0opugvd5ie3meOSWz+\n w/daHiBkDMIdbKoNnE/9Yrp01VmGU+jGmpnkjqcROo7dZ018C6RI7eMWG26Ux/Iud8+8\n VcINOs7iKUgiPccSCQHLfztMluuX3iryUlSKzP60hF6Gi2b5POMxsXN1psedyfmQRmsQ\n CK4GNx+yV3sbj9k/sasFsWcrfi2yWz43wEbyv566qM14fYoW1Fs7NrrSVoboeDzwBYJ1\n dhBbHKl8R1hQCBd+G4gHaEY16CdrWTSkFfslhwuMpXBaet56nbZDq3cIMdGXkSTVuUnc\n Pz3Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8bjMdPZzOCtgQG0klCEBR9woQIWAfBxhZXyDlrd/vuxCSVLuMeJhzEgtofq8T2gxHoyDXXIwg=@lists.denx.de","X-Gm-Message-State":"AOJu0YyTrGyAo0I3u6CFCO994v1BZ7w1MLoS0jlsWmabuwAvqhS2dK2s\n iPv2PJtpYTq4VVDWZ2ObtJnXfe2rpPS8wjCWYojTAprDRyA2RotCFTKUxl9LjPEUc46+5T71TrU\n uMZU5YP/02ghL87tHzdypZtHZUIvm/NGMW9j526Lb","X-Gm-Gg":"AeBDiesDIlkjNlNdyiQEfWNw19tCr4ZK6+9GwC721wvX/fczQylLOnW4+oYajGy1ooW\n 2GhwoQrPwEzOmjDnH3QxqOldt81ksemhtExzuK8E5Zfr+zzXFw1OVYcppqwhce5Ql1RZ30z+7p2\n GNSqctwgI/Lwvr0gc2tFIpN2luhdo6TDcd334yJBd7dYUPKcKeRtFbSX7wF9LDWNc3UFtb0qono\n 41HtjGJyIxBYfLOVR8yp0haSj1JCkiaOuyBX7NNLzCRhMQj3uUyzs4/EcT7cxcinbH/oM2ESSn4\n ijrtD457tfC/4QZ8","X-Received":"by 2002:a17:906:f590:b0:ba9:aeaa:fd01 with SMTP id\n a640c23a62f3a-bb93ee51c1fmr261147866b.43.1777472500397; Wed, 29 Apr 2026\n 07:21:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428142848.48156-1-heinrich.schuchardt@canonical.com>","In-Reply-To":"<20260428142848.48156-1-heinrich.schuchardt@canonical.com>","From":"Simon Glass ","Date":"Wed, 29 Apr 2026 08:21:26 -0600","X-Gm-Features":"AVHnY4KGf6-XmJ7zkekVDunrqsPDHpgOIwUrhwwRXnDb-iU8Jo5zNHr9tZ9MvjY","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","To":"heinrich.schuchardt@canonical.com","Cc":"Tom Rini , Javier Tia ,\n Simon Glass ,\n u-boot@lists.denx.de, Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3684105,"web_url":"http://patchwork.ozlabs.org/comment/3684105/","msgid":"","list_archive_url":null,"date":"2026-04-29T14:42:21","subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","submitter":{"id":82181,"url":"http://patchwork.ozlabs.org/api/people/82181/","name":"Heinrich Schuchardt","email":"heinrich.schuchardt@canonical.com"},"content":"On 4/29/26 16:21, Simon Glass wrote:\n> Hi Heinrich,\n> \n> On 2026-04-28T14:28:48, Heinrich Schuchardt\n> wrote:\n>> .clang-format: add U-Boot specific for each macros\n>>\n>> Formatting via clang-format is controlled by .clang-format.\n>> For each statements should be formatted with a brace at the line end:\n>>\n>> for_each() {\n>> }\n>>\n>> This requires clang-format to know that the symbol is not a function\n>> but a for each macro. We use some for each macros which don't exist in\n>> Linux. Add these to file .clang-format.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>>\n>> .clang-format | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 51 insertions(+)\n> \n> Reviewed-by: Simon Glass \n> \n>> diff --git a/.clang-format b/.clang-format\n>> @@ -748,6 +748,57 @@ ForEachMacros:\n>> + # U-Boot specific\n>> + - '__for_each_child_of_node'\n> \n> Should the 'git grep' recipe include drivers/ and arch/ as well?\n\nThanks for reviewing.\n\nWhat I did was removing the directory restriction completely.\n\nIf we really need a comment, it would have to be in the # U-Boot section.\n\nBest regards\n\nHeinrich","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.a=rsa-sha256 header.s=20251003 header.b=AEKQDJfU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=canonical.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (4096-bit key;\n unprotected) header.d=canonical.com header.i=@canonical.com\n header.b=\"AEKQDJfU\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=canonical.com","phobos.denx.de; spf=pass\n smtp.mailfrom=heinrich.schuchardt@canonical.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5KlW4d4yz1yHZ\n\tfor ; Thu, 30 Apr 2026 00:42:31 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4AC3B84894;\n\tWed, 29 Apr 2026 16:42:28 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 188A984855; Wed, 29 Apr 2026 16:42:27 +0200 (CEST)","from smtp-relay-internal-0.canonical.com\n (smtp-relay-internal-0.canonical.com [185.125.188.122])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 342ED84894\n for ; Wed, 29 Apr 2026 16:42:24 +0200 (CEST)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id C18543F7DD\n for ; Wed, 29 Apr 2026 14:42:23 +0000 (UTC)","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-48919890a95so74203325e9.2\n for ; Wed, 29 Apr 2026 07:42:23 -0700 (PDT)","from [192.168.103.108]\n (ip-176-199-115-125.um44.pools.vodafone-ip.de. [176.199.115.125])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7c5be6dfsm62019835e9.10.2026.04.29.07.42.21\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 29 Apr 2026 07:42:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20251003; t=1777473743;\n bh=N3yCeZvcsjUY4SixfM+7vopkbLS6cJUZlKSA4YGQALI=;\n h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n In-Reply-To:Content-Type;\n b=AEKQDJfUfYG4ngQX9TknUxsTaYxkf8Nnffh8kSGB9s1t3vRkKxH5PqmxHBcTtS4yz\n dvjI9MZFAtnEAJ8/3nFBgoJho5MahZp1vVVX2hSdHREhSKgupWra/lcYdo754fWC/7\n bk7XIscOEKu3qw/T6LW/72zAxKA/eqGiGHtuJMJyzVS0veq9nT2WzdTpJj8463Eo9f\n cdQTZiem8sdnvHggUqm/8HTNs108rvmt2OLl8xqwUZ3t7Nj3t3bLoSBq2YEv9ChAYj\n B7rpKW9LkD9axHdA2dc6uymdr3aW4zHu6VyfA2cuseDdKHhdMRktuBNojnFxM09WS9\n bv4fhRmIziwfQgKC/SXE6gGan4SrxEd+B7pUJ73djEUW3uKAnWjEsTOr0ilTJY4deR\n hgW8GUOuRH/VUurJq/Gqswx8A0qMyIwF9KRbAD3EZrByFWqk/OiwcjugId8BiMNgcm\n b+XV0bbItxz0rMDRe5G5CzNDecdxQp/yCCYl5a7unHSsTtHDB5QI+dQsvbPA0k+RjJ\n zMhvJBCLoaGj8eAUnrgp+518g5kBhIF8spYvkuP9dbJtgXWl+CdXcOLuvK7ki7B7U4\n zOkosq7aUWabfuehkKd3Iq33aec9pm5fpTYWv6YnhC/GlZ1KcD8mL9By7oMS0ZDFtY\n T97erCZzyzQ9cZAG/9mkH9Ws=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777473743; x=1778078543;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=N3yCeZvcsjUY4SixfM+7vopkbLS6cJUZlKSA4YGQALI=;\n b=E2YXbwM6qFg8yLZ2B5FpQECgWIVjeIJpED6SUwqm46hbDpEU4sVx0R3VfUTOKDFz8C\n //1DXfc3xofOE1SV20/Lkxg3GYkXwJO5y5agojuFTGvSn8n5bxexa1TyattWa4r8iX4L\n nyRu0WCeldJX0M9e2N9kUzVNWaSJT/TuEGeRDW//BwStSy7iI6gUK5m6SpaREc4CZgy+\n R8ZvMCXlrr9whGqvyHwcxEhUkdewPmHQAYARqA6OvN3y8i/I5e/I5vorpe8aIypRV4+h\n b0/QoNUOwMu7VTEJ6oHxFKMsxPSJf2/N6Y6Qv+frtGG8U62jxul11kTW23WeAIKGM5i2\n mEUQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8WoN2YfMI3zEfUlnLkyvGpjPaLBzRccOwsZvESoO99CpwfVsQChzbVw0G7eYLKxkt8g81Yl4w=@lists.denx.de","X-Gm-Message-State":"AOJu0YzpqieTZcO6Zszaqh1hI+VvwJKcDT89CSTvSKsYkUy99/HQK1Tn\n YlxyReol9VkO93RiD/Vb6vsPp7v1xtzcZpTob1EJtI9Ttr1qvXbNGWt0tovwfsjZGq0pfyTkiSZ\n NpOuN46Lh56vuOm/zR+vwzxtbgdbi1cUJITrllKn89SCfwFJ+NU3TXQ/orUJxEpU7iLLCoAs=","X-Gm-Gg":"AeBDiesp2zWkCVLzITRCAgB6FQB+Bv/bXi6RvxoIhNVozCuF6F1e8WkTzOj1SbT+W55\n MXXedQq+/lwVajXoLBCdS1zZkfrHHLirn4KKN60pZG+FZkuz5SRqEqTTI2Zv6Syftu6MBNhdnrD\n OluR3zfDWO7uai7g+4klG29tLlCuM+U1/6JCVa7kCQSluz71b2r5BJOwnFbDNaGp6o9c8v2pPq9\n f0cgmh96RJ8hesSCqFN1s0+Adak3gwiPg7r3/dWIknIQb9AhFKMuSO5Yroj5Cl1/RjQnt7jHArm\n kqTzOQnJvSVBLdwDjv9a5iPrPdkArbBNCbJq3NYLlMlxnn5Jwkgk1gvsYwgztJc+G4f1TK/Pk5T\n glkTHozYQWjsw3a9Sr/XFtJL8r1EzKLJoccTB1STtUQpQtfdNd8blojDN3/+5CjvGFVjbNUawg+\n xpjkrbrRmrKrvLlN8o1upjBhMtftp/csCg3XKi+83kEJkKWA7Ek3cNety8BXDt1sNcmOw=","X-Received":["by 2002:a05:600c:859a:b0:48a:56de:d62a with SMTP id\n 5b1f17b1804b1-48a7b519560mr52943845e9.11.1777473743299;\n Wed, 29 Apr 2026 07:42:23 -0700 (PDT)","by 2002:a05:600c:859a:b0:48a:56de:d62a with SMTP id\n 5b1f17b1804b1-48a7b519560mr52943345e9.11.1777473742857;\n Wed, 29 Apr 2026 07:42:22 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 29 Apr 2026 16:42:21 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","To":"Simon Glass ","Cc":"Tom Rini , Javier Tia ,\n u-boot@lists.denx.de, Quentin Schulz ","References":"<20260428142848.48156-1-heinrich.schuchardt@canonical.com>\n ","Content-Language":"en-US","From":"Heinrich Schuchardt ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3684109,"web_url":"http://patchwork.ozlabs.org/comment/3684109/","msgid":"","list_archive_url":null,"date":"2026-04-29T14:45:56","subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn Wed, 29 Apr 2026 at 08:42, Heinrich Schuchardt\n wrote:\n>\n> On 4/29/26 16:21, Simon Glass wrote:\n> > Hi Heinrich,\n> >\n> > On 2026-04-28T14:28:48, Heinrich Schuchardt\n> > wrote:\n> >> .clang-format: add U-Boot specific for each macros\n> >>\n> >> Formatting via clang-format is controlled by .clang-format.\n> >> For each statements should be formatted with a brace at the line end:\n> >>\n> >> for_each() {\n> >> }\n> >>\n> >> This requires clang-format to know that the symbol is not a function\n> >> but a for each macro. We use some for each macros which don't exist in\n> >> Linux. Add these to file .clang-format.\n> >>\n> >> Signed-off-by: Heinrich Schuchardt \n> >>\n> >> .clang-format | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++\n> >> 1 file changed, 51 insertions(+)\n> >\n> > Reviewed-by: Simon Glass \n> >\n> >> diff --git a/.clang-format b/.clang-format\n> >> @@ -748,6 +748,57 @@ ForEachMacros:\n> >> + # U-Boot specific\n> >> + - '__for_each_child_of_node'\n> >\n> > Should the 'git grep' recipe include drivers/ and arch/ as well?\n>\n> Thanks for reviewing.\n>\n> What I did was removing the directory restriction completely.\n>\n> If we really need a comment, it would have to be in the # U-Boot section.\n\nIt doesn't seem important. I was referring to the '# Taken from:' comment.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=fIsU83wi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"fIsU83wi\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Kqq2vcGz1yHX\n\tfor ; Thu, 30 Apr 2026 00:46:15 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CA89384894;\n\tWed, 29 Apr 2026 16:46:12 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4F072848B4; Wed, 29 Apr 2026 16:46:11 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n [IPv6:2a00:1450:4864:20::632])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 69CE5841D7\n for ; Wed, 29 Apr 2026 16:46:09 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n a640c23a62f3a-baebe98afa0so741251366b.3\n for ; Wed, 29 Apr 2026 07:46:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777473969; cv=none;\n d=google.com; s=arc-20240605;\n b=QU1ZclFrYKKb8eQMRR1a7O0/QXcRjGmacuWbMwcBM5xSyn/ys/Wsknq/B69oR9rd6P\n 14QuNq+4Tm3vp6tZolsW0b6XffSPXZCSIkZqwMAqUpJuxfLeBSJ0x2ISGtjGng8Rl8la\n h3FPgbXbnVjPNGtMydStm3VeO1wg6Cx4dROu+kgGBy/GT9O5NUdCN9IdLgYVKdznvozb\n TbUKQpyi0gSHhkpn+PpTtl4CH7eMPALkN/ZAgikDFsNTiilj9GWYw34c3DElOeb2RV0M\n 8KyzBe1O4Hefq6kzO0wzOjuH803UD5psQaGlcpn8EeUlT/toDRQ229KLWnyE2pp5lKak\n wYMQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=JDiJ7u/7VQtGyvXRNslL5D1lLFSODnAtsUgUDlLSYrE=;\n fh=RcQxRqe7UycvZcV76VWjauwHMbRaiieYSPPzjcGeqlY=;\n b=VlfDAqo8X/rSeU2Uqv3p8W/lHa0Dhube5w9eUTH9z4w59XhEwu2k+RgwwxAVQssFO7\n y3QVUWu27HnqPZ9cSWv2laZE54q/OoVi2jskqbltmh717tdElM3PQNKzjM97/Cyc6U/2\n HiTv3rMyhMx3t5Y52b6/ISgbBn87pfC/fHSmV976A6NAsf39ZwOtLZoQyDVd6mPzKHNf\n X6UHE1Di44Fu+bsRnKlUfPXTom98MxN29XrU0SEdioH15RvM3H+MgIpkUepdjfR3uNwu\n oESt9FBFNVC+WpD6z2OzWskDWW+JWF8NKpfYtL4triw8+sW4dDCs08A7j3Rozjau6cNU\n qnGw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1777473969; x=1778078769; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=JDiJ7u/7VQtGyvXRNslL5D1lLFSODnAtsUgUDlLSYrE=;\n b=fIsU83wiFqHEZAJUqc5QVKBNCJmj3kqn2VQe60iQ0Nm9UIiACit6gmgwZfctyICHTU\n JXp9DrtIQf66ZDhLHgMaTVjgsiegHozx5l2KUvquQAs1zb7YEu3Mw1uuLnZxgoiPIbOO\n C7mQ5uVyFgY7wpaxxFSgp3lBL00VCc0Ok/sYc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777473969; x=1778078769;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=JDiJ7u/7VQtGyvXRNslL5D1lLFSODnAtsUgUDlLSYrE=;\n b=GELbcwDi/AEWEspwkvO0s4ufto1Ju2d/lPcOCUW21ad4ruHhFtQfKQqWwsRgAAVg0N\n /GXZ3y05YrtbHSlbTBAZG9ajilMzMgV2mDhGh5emTDi65S+Ii0nMszZhj+fafLyGPgLt\n 6tmr0hw7DHUATlra25kYHSFMEf/OGvZFSHbH2cMYSZ8/XE+6oZ+rS26lkAq8XnWPcM1j\n EZc68rTqBB4019hlsQzzMqEQfxINdlpzoQtj2g7XgaaK8QjH0lGZP8HVQ8m23vNBPZNC\n 8Fg533oSLBgsB4loqO7a3upLC0vAZJ9eLvEG4ZQgsIK65RmVnfxBgKF1AgrEInFYg75V\n JwUQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8/RLCUUndnCm1M+ZfxeqRkauYuOIi8vbJpSzMaeTU1wAOp+V3GzI8MokzRhVAYyg+3EqITXsU=@lists.denx.de","X-Gm-Message-State":"AOJu0YyvQ2Pquwg76ePz7h3YLPQjyduIMqGhLx4milqLJimo5JPRYxp4\n BCHs4WlIjnCuNwv9wmR275g3wWZMGogyDpvghX03DlEMFFxGC/vgkxju1SATVwQNOevR0WFnrgQ\n BZURzOufdZ6zvLRSPvMiUfoeQPPOFg+k74R2SDAzT8XYf7LH+nHetrw==","X-Gm-Gg":"AeBDievSfML3YJCygnwJI+PLR9F/IutM+zx3ASnRZNMgZpDMUCTG9cFW/1q7HcaaX3z\n 1yYJgqyEPNM1XZzKUHCnoWd82zD46QwWpvWrc0baZjAFjtOvzJsyJDQIKmoyJWXQaQ+e1zXcCdc\n RDYYzkutcxXRuH1DDw8d5e7XG+XAtWe6EzqolsJqLNyPMBJg9oG5ZtvwXCYFQAgkaYNX3Pay3rE\n EPeHzmw7Ty5iC5r16H7cK+i5IXBjUXN4OSFckKd0Mn3hufLfLKsZn/wie6JnVvWOa9yqTDBF+r1\n TaedF8wF9gW7mLma","X-Received":"by 2002:a17:907:3e9a:b0:ba8:a21f:9c4e with SMTP id\n a640c23a62f3a-bb93ce89d43mr262565366b.11.1777473968858; Wed, 29 Apr 2026\n 07:46:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428142848.48156-1-heinrich.schuchardt@canonical.com>\n \n ","In-Reply-To":"","From":"Simon Glass ","Date":"Wed, 29 Apr 2026 08:45:56 -0600","X-Gm-Features":"AVHnY4JFImAs1DtBG8n1fnPZhPcel_6iwNuf0kFvOAsQbwkN7Yikei-ino2vDCM","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/1] .clang-format: add U-Boot specific for each macros","To":"Heinrich Schuchardt ","Cc":"Tom Rini , Javier Tia ,\n u-boot@lists.denx.de, Quentin Schulz ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]