[{"id":3683972,"web_url":"http://patchwork.ozlabs.org/comment/3683972/","msgid":"","list_archive_url":null,"date":"2026-04-29T10:19:41","subject":"Re: [PATCH 1/6] target/i386/mshv: remove duplicate function for\n reading vcpu registers","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Tue, Apr 28, 2026 at 04:50:48PM +0300, Doru Blânzeanu wrote:\n> Remove function `fetch_guest_state` because it is a duplicate function\n> of `mshv_load_regs` function.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> target/i386/mshv/mshv-cpu.c | 21 +--------------------\n> 1 file changed, 1 insertion(+), 20 deletions(-)\n> \n> diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c\n> index 4ed6e7548f..9defd05db6 100644\n> --- a/target/i386/mshv/mshv-cpu.c\n> +++ b/target/i386/mshv/mshv-cpu.c\n> @@ -1291,25 +1291,6 @@ static int handle_pio_non_str(const CPUState *cpu,\n> return 0;\n> }\n> \n> -static int fetch_guest_state(CPUState *cpu)\n> -{\n> - int ret;\n> -\n> - ret = mshv_get_standard_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get standard registers\");\n> - return -1;\n> - }\n> -\n> - ret = mshv_get_special_regs(cpu);\n> - if (ret < 0) {\n> - error_report(\"Failed to get special registers\");\n> - return -1;\n> - }\n> -\n> - return 0;\n> -}\n> -\n> static int read_memory(const CPUState *cpu, uint64_t initial_gva,\n> uint64_t initial_gpa, uint64_t gva, uint8_t *data,\n> size_t len)\n> @@ -1429,7 +1410,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_port_intercept_message *info)\n> X86CPU *x86_cpu = X86_CPU(cpu);\n> CPUX86State *env = &x86_cpu->env;\n> \n> - ret = fetch_guest_state(cpu);\n> + ret = mshv_load_regs(cpu);\n> if (ret < 0) {\n> error_report(\"Failed to fetch guest state\");\n> return -1;\n> -- \n> 2.53.0\n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=PgOy66jy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5CxT1nqJz1xqf\n\tfor ; Wed, 29 Apr 2026 20:20:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI21I-0007i3-5X; Wed, 29 Apr 2026 06:19:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI21F-0007hr-Uc\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:19:50 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wI21E-0004ZN-EK\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:19:49 -0400","from example.com (unknown [167.220.208.81])\n by linux.microsoft.com (Postfix) with ESMTPSA id 18E0B20B716C;\n Wed, 29 Apr 2026 03:19:44 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 18E0B20B716C","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1777457986;\n bh=IO+7MXl7aePOSBkWGtmNA9lbM7o9BOOvEpcE1ryBj0A=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=PgOy66jydOOXJG2CsY7B3nEfUfnoTOxjDGOps+gQqvORJkbzAUUWmUvUUs21zVHdk\n HlmL3R9MS3TEF5YXrvh4XL7n21HKurEBHKFQGwC452/P+Cb03ofdLZAwHPo0Yz83XK\n ZUAUDXoVRzVcw1WscmNBHpilmzOtpLk54Y/TPti8=","Date":"Wed, 29 Apr 2026 12:19:41 +0200","From":"Magnus Kulke ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Wei Liu ,\n Paolo Bonzini , Zhao Liu ","Subject":"Re: [PATCH 1/6] target/i386/mshv: remove duplicate function for\n reading vcpu registers","Message-ID":"","References":"<20260428135053.251200-1-dblanzeanu@linux.microsoft.com>\n <20260428135053.251200-2-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260428135053.251200-2-dblanzeanu@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]