[{"id":3683973,"web_url":"http://patchwork.ozlabs.org/comment/3683973/","msgid":"","list_archive_url":null,"date":"2026-04-29T10:21:18","subject":"Re: [PATCH 2/6] accel/mshv: move vcpu arch specific initialization\n after vcpu creation","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Tue, Apr 28, 2026 at 04:50:49PM +0300, Doru Blânzeanu wrote:\n> Call mshv_arch_init_vcpu after the vcpu is created to ensure a valid\n> vcpu fd.\n> \n> Signed-off-by: Doru Blânzeanu \n> ---\n> accel/mshv/mshv-all.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index 58af674bd9..e3da583f21 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -415,13 +415,14 @@ static int mshv_init_vcpu(CPUState *cpu)\n> int ret;\n> \n> cpu->accel = g_new0(AccelCPUState, 1);\n> - mshv_arch_init_vcpu(cpu);\n> \n> ret = mshv_create_vcpu(vm_fd, vp_index, &cpu->accel->cpufd);\n> if (ret < 0) {\n> return -1;\n> }\n> \n> + mshv_arch_init_vcpu(cpu);\n> +\n> cpu->accel->dirty = true;\n> \n> return 0;\n> -- \n> 2.53.0\n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=ADngnGGA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5Cyk6BK9z1xqf\n\tfor ; Wed, 29 Apr 2026 20:21:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI22p-0008Iz-3U; Wed, 29 Apr 2026 06:21:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI22n-0008Ir-Im\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:21:25 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wI22m-0005Bl-Ar\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 06:21:25 -0400","from example.com (unknown [167.220.208.81])\n by linux.microsoft.com (Postfix) with ESMTPSA id D7ACB20B716C;\n Wed, 29 Apr 2026 03:21:21 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com D7ACB20B716C","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1777458083;\n bh=2hRgn57ucZhX/HmVmq5A/dok+6CpOS0yLW+Nl+yhg6s=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=ADngnGGAGiETuPK45W4/DdMtZFkFY+QrNsKZ2XbCBtKd9/tHEd5Uf68tdf34O2yRl\n iODrIvx3S/WHsDSwc6CnFf+eD5lxC1fL8GeyVTNi9XE98TZ7+CZ5GuudnUZtN5OR65\n ZRY2Qnc0gzt6qQy+LrzR4UR36UZXx9EarY6Dn6bk=","Date":"Wed, 29 Apr 2026 12:21:18 +0200","From":"Magnus Kulke ","To":"Doru =?iso-8859-1?q?Bl=E2nzeanu?= ","Cc":"qemu-devel@nongnu.org, Wei Liu ,\n Paolo Bonzini , Zhao Liu ","Subject":"Re: [PATCH 2/6] accel/mshv: move vcpu arch specific initialization\n after vcpu creation","Message-ID":"","References":"<20260428135053.251200-1-dblanzeanu@linux.microsoft.com>\n <20260428135053.251200-3-dblanzeanu@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260428135053.251200-3-dblanzeanu@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]