[{"id":3683564,"web_url":"http://patchwork.ozlabs.org/comment/3683564/","msgid":"<88f8f165-ad24-4cd6-aed5-3b2f9200ed5c@linaro.org>","list_archive_url":null,"date":"2026-04-28T16:23:58","subject":"Re: [PATCH v2] hw/intc/xics: Add a check for an invalid server id","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 28/4/26 12:36, Gautam Menghani wrote:\n> From: kiki \n> \n> A malformed IVE value can result in an invalid server field being\n> passed to icp_irq(). The function assumes the server id is valid and\n> may access invalid state otherwise, potentially leading to a crash.\n> \n> Fix this by validating the server id before using it and ignoring\n> invalid values.\n> \n> Reported-by: Zexiang Zhang \n> Signed-off-by: Zexiang Zhang \n> Signed-off-by: Gautam Menghani \n> ---\n> v2:\n> 1. Fix build error and subject line\n> \n> hw/intc/xics.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LkNp3dGu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4m3l4W9Mz1xrS\n\tfor ; Wed, 29 Apr 2026 02:24:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHlER-0002Ua-KI; Tue, 28 Apr 2026 12:24:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHlEC-0002U2-Uj\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:24:06 -0400","from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHlE9-0007Te-QA\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:24:03 -0400","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-488ba840146so104843045e9.1\n for ; Tue, 28 Apr 2026 09:24:01 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a775f69cdsm21172115e9.27.2026.04.28.09.23.58\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 09:23:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777393440; x=1777998240; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=05EgCJHridX2fRXB0kppii82iwwIPpM2gax1H5yzxJs=;\n b=LkNp3dGuNKVkI7bWE7NZPipPY2OccZTCHjOyVvcZwlMxcvXAUjw7H+AOXuIon5Q0t8\n UpOGzYHy8z48X+KHZEHZQlAIHqZcl2g1Fdl7evyZz4GislcBnkhRGq/Ep2x6+f0cBcFf\n DqIkWfiy3fIY3u2U3Dm16Yuo/Cho0oh9CDYEKzbJ87i7iPlgUQM1cKY8zg4mG+xwxI19\n FsUrFzBhDEJ2gkA3/kMtfgJAvjeIU2Hpe4reG2YGw5/qPgYhbo0Zv+Jc6YSsymUa3Fge\n Ep6eoqu9Fc64kF/tch/AOYIdzTncnaAOWwRV5ZuBBb/jEtCtzneZztScKhNKlnukKGR7\n OIvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777393440; x=1777998240;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=05EgCJHridX2fRXB0kppii82iwwIPpM2gax1H5yzxJs=;\n b=Vpx+MKdN5AZ8+1l0D/lzTobazeogLuPT+PZxQvh74waIl/TqhTga23hjyZ3q6xQmqe\n Edn2iEgyIyor/C6BPQeE2LK5nL0ws+FEWkZ9F7liCXOV4TM1U70VFc0SqpI4KqZaBuF0\n P4DeqpnD6qzTd/Tek3/iTF8n/BibziEjmjb6h/7DCP1W2sa6m6PpRAIE8YqslhgxAqYr\n r7MJiT2Vo7rqXxS7djeBZNY0scVw81GLRRkLj3PXm10bzJX+SL3wbNdu7Rlw2EZzospj\n h96lzSGEBag8mgqYVmVw3oIVAZ0qog6KK2HahBn+v1qW+0/38zqv6ui0+pSjWVIrPvBs\n ieVg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9fyi2jHzC416Be4m2iQ1Iob0fKBnkE5Zv/+s+RBzZzSu4A/WSPPXZTpUsnifTjP8GPaD/DJZXVmQtL@nongnu.org","X-Gm-Message-State":"AOJu0Yy/MiDpaiRFQH6WmAUZzRWzrw9uCxECpxobQSNlCW26bOCvkFUf\n 4v2qXm/N8WDKu4hGEZDJG1FyzrUHkPmc6wTMEA1enbvxh45ucQTYCVnqhvj1d/cJxDQ=","X-Gm-Gg":"AeBDievF8vC9DopEJhw9Zq7p/T+Ff0Vfl3BgJB+OSpnmFhUdZd2+mY94T/Ox5a6Ewk+\n nP/D1jelQjyGzwnES78+pxZQoVtKgnOGmePf8h9Fe8Th0Q3dkw2i2oXZAEyoTunGioJjItHcVCV\n CSD4gdv3JmalWaU/T1Y0LXutIQrygqq/p5pwpGNk+VUJQh0ly2yfHdKNuHcbAOqme5waw0Zj/Ja\n y//Wb+6rvSxjUTVF/+s1yFqr55+YLnEk3XDdOUY6tdD+XiUFD10eOVhKV/pcAidCb3RDdEx/NUu\n bBuMu5Cd7G7Mk3mhsOyr3/ymdyXjCe37oErtQyCqoY+MGT6OW92emA5Nf+iAzvgfONMbj1tOEKn\n DVMh1TYkwtdxKSXuuAuBDgX4jWkSD6K0h8CujVIsPdRDNDu268PoCj6O2QquyEaMV+e72E2Fhnb\n nfdv1v52G7A8Ua0LKuQ919nuBPAtXpQ9lDFBlEqufjZde8YaHg6RxzTEbAGxbVoLiKBHSqXoBZ6\n NVoDP4kT1eDMhg=","X-Received":"by 2002:a05:600c:1d1a:b0:489:201c:dc46 with SMTP id\n 5b1f17b1804b1-48a77b04774mr57405755e9.12.1777393439955;\n Tue, 28 Apr 2026 09:23:59 -0700 (PDT)","Message-ID":"<88f8f165-ad24-4cd6-aed5-3b2f9200ed5c@linaro.org>","Date":"Tue, 28 Apr 2026 18:23:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] hw/intc/xics: Add a check for an invalid server id","Content-Language":"en-US","To":"Gautam Menghani , npiggin@gmail.com,\n harshpb@linux.ibm.com, adityag@linux.ibm.com","Cc":"kiki , qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n Gautam Menghani ","References":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]