[{"id":3683565,"web_url":"http://patchwork.ozlabs.org/comment/3683565/","msgid":"<88f8f165-ad24-4cd6-aed5-3b2f9200ed5c@linaro.org>","list_archive_url":null,"date":"2026-04-28T16:23:58","subject":"Re: [PATCH v2] hw/intc/xics: Add a check for an invalid server id","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 28/4/26 12:36, Gautam Menghani wrote:\n> From: kiki \n> \n> A malformed IVE value can result in an invalid server field being\n> passed to icp_irq(). The function assumes the server id is valid and\n> may access invalid state otherwise, potentially leading to a crash.\n> \n> Fix this by validating the server id before using it and ignoring\n> invalid values.\n> \n> Reported-by: Zexiang Zhang \n> Signed-off-by: Zexiang Zhang \n> Signed-off-by: Gautam Menghani \n> ---\n> v2:\n> 1. Fix build error and subject line\n> \n> hw/intc/xics.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=LkNp3dGu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4m453FGJz1xrS\n\tfor ; Wed, 29 Apr 2026 02:24:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHlEI-0002UR-Pi; Tue, 28 Apr 2026 12:24:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHlEE-0002UB-Tn\n for qemu-ppc@nongnu.org; Tue, 28 Apr 2026 12:24:08 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHlEA-0007Td-Pi\n for qemu-ppc@nongnu.org; Tue, 28 Apr 2026 12:24:05 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-4891c00e7aeso89509495e9.2\n for ; Tue, 28 Apr 2026 09:24:01 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a775f69cdsm21172115e9.27.2026.04.28.09.23.58\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 09:23:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777393440; x=1777998240; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=05EgCJHridX2fRXB0kppii82iwwIPpM2gax1H5yzxJs=;\n b=LkNp3dGuNKVkI7bWE7NZPipPY2OccZTCHjOyVvcZwlMxcvXAUjw7H+AOXuIon5Q0t8\n UpOGzYHy8z48X+KHZEHZQlAIHqZcl2g1Fdl7evyZz4GislcBnkhRGq/Ep2x6+f0cBcFf\n DqIkWfiy3fIY3u2U3Dm16Yuo/Cho0oh9CDYEKzbJ87i7iPlgUQM1cKY8zg4mG+xwxI19\n FsUrFzBhDEJ2gkA3/kMtfgJAvjeIU2Hpe4reG2YGw5/qPgYhbo0Zv+Jc6YSsymUa3Fge\n Ep6eoqu9Fc64kF/tch/AOYIdzTncnaAOWwRV5ZuBBb/jEtCtzneZztScKhNKlnukKGR7\n OIvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777393440; x=1777998240;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=05EgCJHridX2fRXB0kppii82iwwIPpM2gax1H5yzxJs=;\n b=GAAINhN2B/WnWtWRtHfqHTYS1vjKhVcm5FJxmSp7WgYkWrlGLXsn+a0WKsr0wSTMl0\n XqYsIfdMVBkr/EbFlx1osYWk7QRT0HTe4mxgzUz9D6m/Fs1nJfqvxZys+wZWa7CZWrca\n w6TvTiOIioiZH0+/NtUuJ71JwTtKbdLvGroHY/0eq+ZnFEj0MYsZlvXezYvLjQyr3q9Y\n GYkpiKNMp2pui4Ia0xXqpaPoke39B8i5ZSiNKnG4PTQ8S8QSonZ+zJ/p+NL9uhv5Mmla\n kdQ6/aGNj1hS97b8yo/EbiEvygLw0WKd4nFGvmU6vPxME4UI6Ka8K6pYhZ7jSuidriPM\n CMRg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/P7OiqHPSqP97VXuq3owWIy0swoP9gxA4LKGIHtKKhfI0eeodEyiYY/iRA4Aa7So3qZ9FKjKG9QA==@nongnu.org","X-Gm-Message-State":"AOJu0YxnkfeOiQwbaj3Yw/HGr2aKfTaeeoxeVBvoX1893nqpupI0ZN6w\n LpRAKoM+0qntmtBvkJjZ+yCzxI6oChAWQnnhShYLiVwPOoBtuRir/5JEnQBQfTXxXSo=","X-Gm-Gg":"AeBDieuRSwMFIS5r1O/KCJgXhfrG1dww9Fr9iSy//P5vDR0ulNnCEbMUMt10zZmg5pQ\n DyYdoX6IXkt5k5IG33vlgcTMzeAGPuKpW1T639SWDG5MFnQW/k6mw0CFpjJRFKPadXgXpihCYvT\n FRphEgCiLor187i5Y4vU3ydrzBEBTEkpoZX75CLdwH7vT0OsT4KMlk6bESm9fzAGOqbrRi9sH+1\n YtzX8kfZz2UMK3+Kzw9O8sejbarUA5VcqD19DgW4wk8cj0rTT4yYSLl7mrVzfhw3kLMNzkbq3Kw\n gSljhCQksFX0U/5F92CQW7aCV2FGbh7XAkYZTotMQRa7Kl3RG5lky2ZLQ6J6WrsIgxPZo5KU2j5\n QsQOc2M/udaSmhRRQiBRL+jwnnT78lTQVXqxOUPtn8X5ZDsTC4xFBMO9V3eflN+438UxoWbXB7C\n VXGj2OAmWg6wOn7aQ/LswHCIMe79k8DtYh0+yAjMlDuY1Ea1VnuukqUCwn0HYXRkOWWe0AFRoNx\n qtTUg9Qjrk/DnY=","X-Received":"by 2002:a05:600c:1d1a:b0:489:201c:dc46 with SMTP id\n 5b1f17b1804b1-48a77b04774mr57405755e9.12.1777393439955;\n Tue, 28 Apr 2026 09:23:59 -0700 (PDT)","Message-ID":"<88f8f165-ad24-4cd6-aed5-3b2f9200ed5c@linaro.org>","Date":"Tue, 28 Apr 2026 18:23:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] hw/intc/xics: Add a check for an invalid server id","Content-Language":"en-US","To":"Gautam Menghani , npiggin@gmail.com,\n harshpb@linux.ibm.com, adityag@linux.ibm.com","Cc":"kiki , qemu-ppc@nongnu.org, qemu-devel@nongnu.org,\n Gautam Menghani ","References":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260428103645.50617-1-Gautam.Menghani@ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]