[{"id":3683525,"web_url":"http://patchwork.ozlabs.org/comment/3683525/","msgid":"<20260428144417.4093-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-28T14:44:17","subject":"Re: [LTP] aio_cancel: Fix incorrect strerror() usage","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Martin,\n\n--- [PATCH 1/2] ---\n\nOn 2026-04-28, Martin Doucha wrote:\n> aio_cancel: Fix incorrect strerror() usage\n\nThis is fixing a real bug but both patches in this series are missing\nFixes: tags.\n\n--- [PATCH 2/2] ---\n\nOn 2026-04-28, Martin Doucha wrote:\n> aio_cancel_6-1: Rewrite test\n\n> +\tif (gret != AIO_CANCELED) {\n> +\t\tprintf(TNAME \" Unexpected aio_cancel() return value: %s\\n\",\n> +\t\t\tstrerror(gret));\n\nstrerror() expects an errno value; AIO_CANCELED, AIO_NOTCANCELED, and\nAIO_ALLDONE are not errno values (they are 0, 1, 2 on Linux, mapping to\n\"Success\", \"Operation not permitted\", \"No such file or directory\").\nUse \"%d\" to print the raw integer instead.\n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- 5-1.c:70, 7-1.c:56 — nanosleep() used for synchronization in a\n polling loop (sleep-based sync).\n\n---\nNote:\n\nOur agent completed the review of the patch. The agent can sometimes\nproduce false positives although often its findings are genuine. If you\nfind issues with the review, please comment this email or ignore the\nsuggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=J6YsXzUf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4jrC6520z1yHv\n\tfor ; Wed, 29 Apr 2026 00:44:27 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id AFB013C9B85\n\tfor ; Tue, 28 Apr 2026 16:44:24 +0200 (CEST)","from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 34AEB3C66CA\n for ; Tue, 28 Apr 2026 16:44:21 +0200 (CEST)","from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com\n [IPv6:2607:f8b0:4864:20::f44])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 79038600350\n for ; Tue, 28 Apr 2026 16:44:20 +0200 (CEST)","by mail-qv1-xf44.google.com with SMTP id\n 6a1803df08f44-8a3342d301aso111346526d6.2\n for ; Tue, 28 Apr 2026 07:44:20 -0700 (PDT)","from\n runnervmhkfpo.ih4hag31ne3evk1eddqqqnr0uc.cx.internal.cloudapp.net\n ([48.211.210.123]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b3e2976bcbsm22296936d6.36.2026.04.28.07.44.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 07:44:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777387459; x=1777992259; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tBqeDaQfRj6Ez/XFff7uZLqqqCbzFLjmt/cgm4UQs+M=;\n b=J6YsXzUfjgbw7AnXXwL6zRXBYDMfZO8NRg/RDupk+LsgZD7haLRsy0xexelh2+jFuU\n xIF1aUm/CIFdQ2wAmNO9gKoeV4BQeybPNHFaYe9XYSnwtVLCE771JxWBSnMaV4aNb65c\n viIOcSIFJXB4PInX5g87QMaUYwmLrOf8x0L2mj7PWM9D2yuJu3FliTK3/wCpPy6L8mK2\n t+LXeVSr0aKm3fcdoOFVShnGmeKphDPtICJ5wdS7xk0AuU1nr3ONemtIFUgZO/CBqt7T\n KoT2zMnvEzju7SZEGY0gj0b1J+Ecu6ie13wYwdxNx+OIKKWUaNw1OUNAw5LA6xDX8YKf\n pFzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777387459; x=1777992259;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tBqeDaQfRj6Ez/XFff7uZLqqqCbzFLjmt/cgm4UQs+M=;\n b=EcdP6v/4Kqvoa0Sd/xzkk3753af150hcTB0VFDREsHgCxKngAIbWXd8NSFc64izKM2\n EBFANTJM+UszCl9F6F3P4H15s4PnR8MMCAk2ChpCcgovRGEnxP62MG1zIPACPrNegrSM\n 2P6iSEKBRnmNU0bn0JseZTzRVf7XAWkoz9Pe0bYjJOsFlUW0bvDjjCvO6ehSZS47dobU\n Alw7tTlWak8E1jCfrZfblL8Aa7IAiYHzTPerUfbldrqndyrlwXROYK1UkXyXrSpw7E7i\n 3d7IAQpX5RsomKUBi9G+xofFPYMaGK0NAfYwyksS8vZTPthPjIYt12vr8P7iukIQxVW1\n dJiA==","X-Gm-Message-State":"AOJu0YxNBFGtqSm6pG/UOXL0VksTfYzgQGgC48wp2ta/UWwQVIdOMA0G\n r/Ru2GLpdIldLSxrwr0kVW3yPe6uSNfP3p229eZhB5R7xtPogmYNvEPY","X-Gm-Gg":"AeBDietkzNdzv0kfj38jf+uNBA/UgB24Ojd2j6SWaEmuiYYXFOzQJfXSa9zSKiKFXI2\n JQP0yeJ8MbQOgNgtsw+P6UzGRqul0ezuj7BeTS2ll3D1fwL/XvAF6oGRJKOtWpSYrW8GPyrr8+v\n xFc4o/hkBS6lWhEVAvHeRGmSQ3ha4kr2ECNXBANFLG+g4avk8YZmlAfpG1rxCYXmv4n/7xBKtMu\n DdA8qFqyJAFZcjRwAe+mUv9f92kpTOEnuqnAU1Avm4WQcPhizs/GECrz0yI0ZrotBEYOYajQuIL\n J0+Y7NY5+zIFPmF7UCN/hkntP0iNJPM/W66rHd1pme2CZngBtEka7UKU2zSmsbfzOmtpPdm3XgL\n 7kEK0dLfYbGm4f7jmea5ghG9GRCGnB5ycs1HwmDCyHyaSt02R8HbIiZWWZiKO8lKBMOGNnva/d5\n yI5ocQ5I70eTi+AfE4ewaSgodyJ51bUyZbpdWqZcugoBiSW4AH/+hfFS3PA4N5uebKK00BBPrHe\n T/ZJkOg67go5o3wCkWXN53pcv+AsBUgd57cwazPM9PhNhmwoO8=","X-Received":"by 2002:ad4:5bc2:0:b0:8b1:f2b7:cfb3 with SMTP id\n 6a1803df08f44-8b3e2fff731mr51703756d6.20.1777387458904;\n Tue, 28 Apr 2026 07:44:18 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Martin Doucha ","Date":"Tue, 28 Apr 2026 14:44:17 +0000","Message-ID":"<20260428144417.4093-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260428133233.28050-1-mdoucha@suse.cz>","References":"<20260428133233.28050-1-mdoucha@suse.cz>","MIME-Version":"1.0","X-Spam-Status":"No, score=1.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Level":"*","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-2.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-2.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] aio_cancel: Fix incorrect strerror() usage","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}},{"id":3683843,"web_url":"http://patchwork.ozlabs.org/comment/3683843/","msgid":"<69f1afb3.050a0220.2034a7.c43a@mx.google.com>","list_archive_url":null,"date":"2026-04-29T07:13:54","subject":"Re: [LTP] [PATCH 1/2] aio_cancel: Fix incorrect strerror() usage","submitter":{"id":82886,"url":"http://patchwork.ozlabs.org/api/people/82886/","name":"Andrea Cervesato","email":"andrea.cervesato@suse.com"},"content":"Hi Martin,\n\nplease update the patch as requested in the agent review, I will move\nthis to Change Requested waiting for v2.\n\nRegards,\n--\nAndrea Cervesato\nSUSE QE Automation Engineer Linux\nandrea.cervesato@suse.com","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=T7c0I9vk;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=J+/KvJ5O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g57p43v1Pz1yHX\n\tfor ; Wed, 29 Apr 2026 17:14:04 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 7CC703E289B\n\tfor ; Wed, 29 Apr 2026 09:14:02 +0200 (CEST)","from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 1B36F3E2114\n for ; Wed, 29 Apr 2026 09:13:57 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n [IPv6:2a00:1450:4864:20::32a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C07E210009F3\n for ; Wed, 29 Apr 2026 09:13:56 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n 5b1f17b1804b1-4891e5b9c1fso106213665e9.2\n for ; Wed, 29 Apr 2026 00:13:56 -0700 (PDT)","from p200300ef2f4fc90003f4f7286cdeff7d.dip0.t-ipconnect.de\n (p200300ef2f4fc9009ff26ae1d4042002.dip0.t-ipconnect.de.\n [2003:ef:2f4f:c900:9ff2:6ae1:d404:2002])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a7c5be6a4sm32656365e9.11.2026.04.29.00.13.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 00:13:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1777446842; h=message-id :\n to : in-reply-to : date : subject : list-id : list-unsubscribe :\n list-archive : list-post : list-help : list-subscribe : from :\n reply-to : cc : mime-version : content-type :\n content-transfer-encoding : sender : from;\n bh=vzpeiQyFckuKwAuxQpgfGVUb9h4Z3kJTVbLe37/P41E=;\n b=T7c0I9vk8aecJA1qyYl7lBADwEBtMbXEduL/NCcKJ2MmpJe6VE9XmyCpraqBwICHXDx0O\n FUhH4RqpZjt9ZAOYp7h5Y9/lXuPygz1tRP3p/bEAhiQAMEM5oscxoTPmCiqYzcErFcAaadx\n b3ABtw+lcuNob5drUZ/k616yZbehVBk=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1777446836; x=1778051636; darn=lists.linux.it;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=nHK9LKFJLtK8dx7/dZav6K+vS5g2N4o/LxE4xaBBTyo=;\n b=J+/KvJ5OjCODZsBJd/PB0d4x/NfyiFqfax5L9/+bArwfCyf20tz0wAP4a1GdhdRO1/\n wxFzWGQMtGQxhoRrnylQRz3IYisGzhrpEOJkJiqXTugzOV8rPqFAmZYaRASy/CimGdgf\n W3aNrZm/ATYS0UJdZI2mz0GP8aekEkTN3gijhrDuJmQvbHyob609V0Mf1c0YTfkMqHFg\n H/xZmGrz5kjJJlasNqzYIzSkCmC7fQuoLeiTQPZzZkC0Ox3wq7xAYlOxyPYpq/aGPB7R\n oTG8Th21kHCDxfFKU4ilCV1yK8r+4gsb77rETlj1YiwDP6XYB/4IB58iwtsgqMbV94s5\n smfQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777446836; x=1778051636;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nHK9LKFJLtK8dx7/dZav6K+vS5g2N4o/LxE4xaBBTyo=;\n b=ne5BdaD0/3tp3W6cYR96og+KD+5Dh6j6IxxG5uYt6AG42f/McdPvASl5Nmql4E3voG\n hahh+vpkw9Wmz2lJ7vdu1wTVMXgC0tF4VBnHhv04fIxP+X7E0Ak445ZnriXWe2DyMfyi\n 1jXTFpOiEMb04tC1AKcLoWgBOcKwT9XCIAghOVBn5/xJWiKoEyEBrci0vF2HK788Jmd7\n BuPzg/Xfi6d/jr2G4yUQJpWIjsuGVHIyYboJq/DPOfAVNf7G5HjfngpoWftbejnREAin\n hB/ZAxw7cWVM31WdT9M0I0t1xpjZJKBhGLvRNrLFyq4ZqLUwAcUH+d6anOYHeOnO+/EE\n wLAw==","X-Gm-Message-State":"AOJu0YyuCL34gg4bIRhCSm/KzR5neU/a1UNjgdWzD9rqcWBi456b8G6W\n c1T1YK66OuWJBBoqngZT6Epmte9gHgrFuQeNBMKcibRdyMcOkntsVtj2I7VYoLK6qs1SfJ38L4u\n l0Q6FK55uHQ==","X-Gm-Gg":"AeBDievGtcWR773rYWkbbWd7HeR96XqZT4VSFcY0F09gKSqE9kuFOG1nzxxXSFml0ep\n wByw3QmK8e8UG4lh3xC34MtBeZN6qZPhyar4xAzS3NX/ksWa4QcClQ3OiUeQCZXzLsn7v92M/nX\n /jYKHVzRvyeyleRB/XAf5SbcpYpgjudKgm5+PsjRTfyal+MUREqlYD9C1F8amHBOLw+I83sPMYU\n D2DtwyJTuzLvF/ut9kI4ShWMGjU9PjzPoJx6XbPZrO8juKElBYsUjGvyYhirYoZ5JHGoXkFz1Vu\n kgSUMFAGPqIHjgPgh2VLWwweFdSHh8e4wm5LBvBzzR8AVeN7CBQJPIBhfwFq9UjNSVSYPjirXiZ\n bQe7IhPvHyB/yHZQtzf+vM/JmOyWvsDILGmugz+VSsoVx0XQVA5ebsQNZQudHE+wwklOHNNGdcV\n MVWXNtvxf7s9FFL7THEhGe3QPAWFJ9qFgJ5TsUVG2+exjlcIu5Iyiq9MEf5px69KP+QU4vgDzt+\n 42EcGj9L6rMHPcVTclCzZ2lhfYvA63qdYIjb9dkN71tssYP2sWil3VNT2T7tgsYcsEdqHk+kpjW\n wvhBz/nde4f/","X-Received":"by 2002:a05:600c:138b:b0:48a:563c:c8c0 with SMTP id\n 5b1f17b1804b1-48a77ae59c8mr101858405e9.7.1777446836021;\n Wed, 29 Apr 2026 00:13:56 -0700 (PDT)","Message-ID":"<69f1afb3.050a0220.2034a7.c43a@mx.google.com>","To":"\"Martin Doucha\" ","In-Reply-To":"<20260428133233.28050-1-mdoucha@suse.cz>","Date":"Wed, 29 Apr 2026 07:13:54 +0000","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-4.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-4.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH 1/2] aio_cancel: Fix incorrect strerror() usage","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Andrea Cervesato via ltp ","Reply-To":"Andrea Cervesato ","Cc":"ltp@lists.linux.it","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]