[{"id":3684006,"web_url":"http://patchwork.ozlabs.org/comment/3684006/","msgid":"","list_archive_url":null,"date":"2026-04-29T11:30:54","subject":"Re: [PATCH 4/6] tests: Rename id of tpmdev to tpm0","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/people/91136/","name":"Arun Menon","email":"armenon@redhat.com"},"content":"Hi,\n\nOn Tue, Apr 28, 2026 at 01:07:16PM +0000, Stefan Berger wrote:\n> Rename the id of the tpmdev from dev to tpm0 because this 'dev' cannot\n> be used when the tpm-tis-i2c device is used.\n> \n> Signed-off-by: Stefan Berger \n> ---\n> tests/qtest/tpm-tests.c | 4 ++--\n> tests/qtest/tpm-util.c | 8 ++++----\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/tests/qtest/tpm-tests.c b/tests/qtest/tpm-tests.c\n> index dcbf5457ed..d1fe4a85d4 100644\n> --- a/tests/qtest/tpm-tests.c\n> +++ b/tests/qtest/tpm-tests.c\n> @@ -49,8 +49,8 @@ void tpm_test_swtpm_test(const char *src_tpm_path, tx_func *tx,\n> args = g_strdup_printf(\n> \"%s \"\n> \"-chardev socket,id=chr,path=%s \"\n> - \"-tpmdev emulator,id=dev,chardev=chr \"\n> - \"-device %s,tpmdev=dev\",\n> + \"-tpmdev emulator,id=tpm0,chardev=chr \"\n> + \"-device %s,tpmdev=tpm0\",\n> machine_options ? : \"\", addr->u.q_unix.path, ifmodel);\n> \n> s = qtest_start(args);\n> diff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c\n> index 1a47099807..35e9d3f32e 100644\n> --- a/tests/qtest/tpm-util.c\n> +++ b/tests/qtest/tpm-util.c\n> @@ -227,8 +227,8 @@ void tpm_util_migration_start_qemu(QTestState **src_qemu,\n> src_qemu_args = g_strdup_printf(\n> \"%s \"\n> \"-chardev socket,id=chr,path=%s \"\n> - \"-tpmdev emulator,id=dev,chardev=chr \"\n> - \"-device %s,tpmdev=dev \",\n> + \"-tpmdev emulator,id=tpm0,chardev=chr \"\n> + \"-device %s,tpmdev=tpm0 \",\n> machine_options ? : \"\", src_tpm_addr->u.q_unix.path, ifmodel);\n> \n> *src_qemu = qtest_init(src_qemu_args);\n> @@ -236,8 +236,8 @@ void tpm_util_migration_start_qemu(QTestState **src_qemu,\n> dst_qemu_args = g_strdup_printf(\n> \"%s \"\n> \"-chardev socket,id=chr,path=%s \"\n> - \"-tpmdev emulator,id=dev,chardev=chr \"\n> - \"-device %s,tpmdev=dev \"\n> + \"-tpmdev emulator,id=tpm0,chardev=chr \"\n> + \"-device %s,tpmdev=tpm0 \"\n> \"-incoming %s\",\n> machine_options ? : \"\",\n> dst_tpm_addr->u.q_unix.path,\n> -- \n> 2.43.0\n> \n> \n\nReviewed-by: Arun Menon \n\n\nRegards,\nArun Menon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=J26CtpqP;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=VAak3Wmy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5FWG4FP9z1yHZ\n\tfor ; Wed, 29 Apr 2026 21:31:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wI38H-0003aZ-Tv; Wed, 29 Apr 2026 07:31:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI38E-0003ZC-Cs\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 07:31:06 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wI38C-0008RG-Qr\n for qemu-devel@nongnu.org; Wed, 29 Apr 2026 07:31:06 -0400","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-80-AUlwrD7BN1CmK6sh6I2ZTQ-1; Wed, 29 Apr 2026 07:31:01 -0400","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b24308165dso178874325ad.1\n for ; Wed, 29 Apr 2026 04:31:01 -0700 (PDT)","from fedora ([49.36.106.198]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b98895dbcesm20962585ad.63.2026.04.29.04.30.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Apr 2026 04:30:59 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777462262;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=/tSnpiDZlon3B1DFu9pPsHM6OQFqiSZzXuOtVwKLuKg=;\n b=J26CtpqPr2oMgvXLkrmq4KCFBSkYGBAOaluYiu20cIx6gHycMz5ivE1iUQG+sY33Td6jeB\n pLhC0lB6Cx7LNP7hbcsPfZ+0MKeZNVYYva/Us0IAFW2ajjAC7o1PiERitjPksRKF7WHyt+\n dXImVkay2WE/6/tFJVse+abCDJ7yRQ8=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777462260; x=1778067060; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=/tSnpiDZlon3B1DFu9pPsHM6OQFqiSZzXuOtVwKLuKg=;\n b=VAak3WmyKYaRKftaIegLmJ+J9EzQpZEzEzirkPYEkpvYinAisLAL6LKlTxyOpkQPUI\n GgV6PZbLNIpJAuA41p2TPhBFEC1Hp5FMSlPlqpiYeNzeXaeC1cuSKwlBhLhYD6hxblen\n EHzE5ek6P3dJ7gVhk473pZ8C3a3met3cp0ge8wLv4yIuytVGtXzyR6DRX3HcAC/4Vyo6\n ZF8Z7o69Tvo4nWjyt+GcgvAAnF+g9a5Inx5zbBl3HkAqAc2v0G/lmWzy+r8wr1Eh7Hi2\n 0MPxfdHALAzBxTmhHRe0UvoE9oUwtIGDJxR0pnZ8dfyJq+KJFdu5rq8xyprsM4PxhAoF\n 4qgg=="],"X-MC-Unique":"AUlwrD7BN1CmK6sh6I2ZTQ-1","X-Mimecast-MFC-AGG-ID":"AUlwrD7BN1CmK6sh6I2ZTQ_1777462260","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777462260; x=1778067060;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/tSnpiDZlon3B1DFu9pPsHM6OQFqiSZzXuOtVwKLuKg=;\n b=lQFuhSXwaLVrnZUw+TBCN6WELtrwaX9sT/VNNFH1RfdPtFSYw+7TkJf33kNNU4cNNK\n 3NJ/OqsQehChQDRU2ckrklNwcGdADI2I4H2JJn8NeQT7rHylpev7g4m10rnr0h7CSExX\n JnlA6rBYSN0luo66u15dkbxcnJ/k7D3Pbkv4YH0QhdhuOdvQGof8XvlSNKVLIJCBNGqD\n /2+jjeId5RorAMGg+IeyDBZbQXE8AABuOMDgbchwua/oBCC70cZrb3T9Ae26myz0L8fP\n SbxgOFUqD553sgVGk5xeloMZ4Ii72wD4Ochaug5pwU7WiznJ77f8nQo/66eDhTmjPgdM\n fMBA==","X-Gm-Message-State":"AOJu0YwV90VRoV83q+rs10CBeP6/rttpzsDmywQq/SM1CsHY0FCiD92v\n tRHNgdCazQO4Bnf0cXUnpT53kzsSqAYt4ns1ozpAfWwEIJFEkRX10GQwcZkknTI4OvgtdGXS4fm\n dt6zTToLOrryVL562QYWd8mp7mGzBvEQu4xb+iibuCVPLFFvUOZPKeirL17usoTzo","X-Gm-Gg":"AeBDiesBr0qOmC8H6vZTVHFDSqx8IvCxC6jIWRUEfbRg2AXicl1wfgA6lADe77N6T5F\n xwfiOPiBL1T6iuesYiXZTKx+oFG/xE33VehoOG4b3+ryMG/kd3Aav1zYmfRMi9M9vZE9gIol0p0\n EPQLiHRckr3vqxRnXPl6bGyxyo0vDaa8dZKO+p6khCJi3pex10W+TGsHVtDK3GS24IYHlm1Wcvj\n MCfTjXq0i0exAxyWTxh+2ZTKLR5HG3gH8GtR/IKYAVjFTrGWEnpyP+lycrAdSALg+SLTN+JHyKY\n gfqQKMztJcrNGQ1Cijm2ho6fCmowMvJbBfqUGI/qSrkTfsqODGYmuPRfSwVIWtBK7+Pe5FlyW5N\n o3SarzQgmZO/l3yh9998SQhw=","X-Received":["by 2002:a17:903:983:b0:2b2:5503:1b8d with SMTP id\n d9443c01a7336-2b97c3d4565mr71330495ad.6.1777462259976;\n Wed, 29 Apr 2026 04:30:59 -0700 (PDT)","by 2002:a17:903:983:b0:2b2:5503:1b8d with SMTP id\n d9443c01a7336-2b97c3d4565mr71330205ad.6.1777462259452;\n Wed, 29 Apr 2026 04:30:59 -0700 (PDT)"],"Date":"Wed, 29 Apr 2026 17:00:54 +0530","From":"Arun Menon ","To":"Stefan Berger ","Cc":"qemu-devel@nongnu.org, marcandre.lureau@redhat.com","Subject":"Re: [PATCH 4/6] tests: Rename id of tpmdev to tpm0","Message-ID":"","References":"<20260428130718.1325177-1-stefanb@linux.ibm.com>\n <20260428130718.1325177-5-stefanb@linux.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260428130718.1325177-5-stefanb@linux.ibm.com>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]