[{"id":3683418,"web_url":"http://patchwork.ozlabs.org/comment/3683418/","msgid":"","list_archive_url":null,"date":"2026-04-28T11:00:40","subject":"Re: [PATCH net] neighbour: neigh_xmit needs to release skb on\n -EAFNOSUPPORT","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Tue, Apr 28, 2026 at 12:20:52PM +0200, Pablo Neira Ayuso wrote:\n> Sashiko reports:\n> \n> \"... if the target neighbor table is NULL (for example, for\n> NEIGH_ND_TABLE when IPv6 is disabled), the code takes the out_unlock\n> path and bypasses the out_kfree_skb cleanup\"\n> \n> Fix this skb memleak by releasing the skb in case of -EAFNOSUPPORT.\n\nPlease, withdraw.\n\nFlorian Westphal already posted a similar fix that is already in\nnet.git\n\nThanks.\n\n> Fixes: f8f2eb9de69a (\"neighbour: add RCU protection to neigh_tables[]\")\n> Signed-off-by: Pablo Neira Ayuso ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=aETsHw7m;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12252-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"aETsHw7m\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4fT44Q5vz1xrS\n\tfor ; Tue, 28 Apr 2026 22:12:40 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 8A5F331339E0\n\tfor ; Tue, 28 Apr 2026 11:03:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C253F3F23BB;\n\tTue, 28 Apr 2026 11:00:47 +0000 (UTC)","from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 326C039891F;\n\tTue, 28 Apr 2026 11:00:45 +0000 (UTC)","from netfilter.org (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with UTF8SMTPSA id 59149600B5;\n\tTue, 28 Apr 2026 13:00:43 +0200 (CEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777374047; cv=none;\n b=o1ndADAR/+BanQJXqtMOvnYjek+0dli5O3ORHHCCPi1Ot9iNRWTNAYTAykwD0toWEA3JQkRK5kTveB0c/0EjRIIbSmGvZL0K5/y+sQ3wpLfg4KndJpCumn6hqQ+5Vy7LUfSxTwXHdkyam4yUqzdqQpSYLejy1jE7BYhjtf5KHaQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777374047; c=relaxed/simple;\n\tbh=Uefk//Or6MWKb4FY2PvkClVl4kqx5cq6unjXrhiqhsE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=DAh2tnVYN16AT6AQMI9qk7mm6h8xFQtlYFVmH478Vdky0DZn0VVegq0dx/IZBefHm1E0a4tb7UixRRhUeLF9KCByc4a74f/pbRDiugUO6HGvGdnLSwVHXmgGXMKfz53LGiCVYX/Jam5mYwFKD2ZG9/4X/x7ErINqroij+Ce6q3I=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=aETsHw7m; arc=none smtp.client-ip=217.70.190.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1777374043;\n\tbh=dwn6CWlk95VWnSN849r13HbnQotK1IIZo/b3BQl5OCM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aETsHw7mV+swGUDWBtiHGigJxGgYrppmYq5SfOK5rmn1gzT4yB4LVcZD6NZ96HLAy\n\t L08AMwMNL4NhEgbDzyGCPNV1h8rNbHF2rOCdEvbMCiwiL9RqBKIEuYfEdltX7p4XY9\n\t Zq702P9rLqNK/x+Q+aQUhsrmvYb+Rr5dNbCX1P2ud2hF2gtvh+ptLgMEkLj9lUUL9E\n\t tAfDOTqsO/ko3sgo33XJoClf1Xgi3CHmzAPxGi5e5dJCnuN9WRO5rfc6LBvMTljGst\n\t JgfGsAYo2AZVSS3nteHw7cg8nLCXpHtduP5mD47FTKduavxW1efvdqyrG4t1LtPzj2\n\t MKU4DUKHWk7Zg==","Date":"Tue, 28 Apr 2026 13:00:40 +0200","From":"Pablo Neira Ayuso ","To":"netdev@vger.kernel.org","Cc":"netfilter-devel@vger.kernel.org, edumazet@google.com,\n\tdavem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,\n\thorms@kernel.org","Subject":"Re: [PATCH net] neighbour: neigh_xmit needs to release skb on\n -EAFNOSUPPORT","Message-ID":"","References":"<20260428102052.53637-1-pablo@netfilter.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260428102052.53637-1-pablo@netfilter.org>"}}]