[{"id":3683153,"web_url":"http://patchwork.ozlabs.org/comment/3683153/","msgid":"","list_archive_url":null,"date":"2026-04-28T06:56:00","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v4 1/3] igc: remove unused\n autoneg_failed field","submitter":{"id":70275,"url":"http://patchwork.ozlabs.org/api/people/70275/","name":"Paul Menzel","email":"pmenzel@molgen.mpg.de"},"content":"[Cc: Removed stray *Looi*]\n\nDear Khai Wen Tan,\n\n\nThank you for your patch.\n\n\nAm 28.04.26 um 08:00 schrieb KhaiWenTan:\n\n(Should spaces be added in your name?)\n\n> From: Faizal Rahim \n> \n> autoneg_failed in struct igc_mac_info is never set in the igc driver.\n> Remove the field and the dead code checking it in\n> igc_config_fc_after_link_up().\n\nCould you please elaborate. Why is removal the correct fix, and it’s not \nan incomplete feature? Does auto-negotiation always succeed?\n\n> Reviewed-by: Looi, Hong Aun \n\nPlease order it to not use the comma: Hong Aun Looi\n\n> Reviewed-by: Aleksandr Loktionov \n> Signed-off-by: Faizal Rahim \n> Signed-off-by: KhaiWenTan \n> ---\n> drivers/net/ethernet/intel/igc/igc_hw.h | 1 -\n> drivers/net/ethernet/intel/igc/igc_mac.c | 16 +---------------\n> 2 files changed, 1 insertion(+), 16 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h\n> index be8a49a86d09..86ab8f566f44 100644\n> --- a/drivers/net/ethernet/intel/igc/igc_hw.h\n> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h\n> @@ -92,7 +92,6 @@ struct igc_mac_info {\n> \tbool asf_firmware_present;\n> \tbool arc_subsystem_valid;\n> \n> -\tbool autoneg_failed;\n> \tbool get_link_status;\n> };\n> \n> diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c\n> index 7ac6637f8db7..142beb9ae557 100644\n> --- a/drivers/net/ethernet/intel/igc/igc_mac.c\n> +++ b/drivers/net/ethernet/intel/igc/igc_mac.c\n> @@ -438,28 +438,14 @@ void igc_config_collision_dist(struct igc_hw *hw)\n> * Checks the status of auto-negotiation after link up to ensure that the\n> * speed and duplex were not forced. If the link needed to be forced, then\n> * flow control needs to be forced also. If auto-negotiation is enabled\n> - * and did not fail, then we configure flow control based on our link\n> - * partner.\n> + * then we configure flow control based on our link partner.\n> */\n> s32 igc_config_fc_after_link_up(struct igc_hw *hw)\n> {\n> \tu16 mii_status_reg, mii_nway_adv_reg, mii_nway_lp_ability_reg;\n> -\tstruct igc_mac_info *mac = &hw->mac;\n> \tu16 speed, duplex;\n> \ts32 ret_val = 0;\n> \n> -\t/* Check for the case where we have fiber media and auto-neg failed\n> -\t * so we had to force link. In this case, we need to force the\n> -\t * configuration of the MAC to match the \"fc\" parameter.\n> -\t */\n> -\tif (mac->autoneg_failed)\n> -\t\tret_val = igc_force_mac_fc(hw);\n> -\n> -\tif (ret_val) {\n> -\t\thw_dbg(\"Error forcing flow control settings\\n\");\n> -\t\tgoto out;\n> -\t}\n> -\n> \t/* In auto-neg, we need to check and see if Auto-Neg has completed,\n> \t * and if so, how the PHY and link partner has flow control\n> \t * configured.\n\n\nKind regards,\n\nPaul","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=HiqNafkd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4WSf52c9z1xvV\n\tfor ; Tue, 28 Apr 2026 16:56:50 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2AA3841039;\n\tTue, 28 Apr 2026 06:56:49 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 8UMbDm-hORsu; Tue, 28 Apr 2026 06:56:48 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 5F7CC41029;\n\tTue, 28 Apr 2026 06:56:48 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 217D71B8\n for ; Tue, 28 Apr 2026 06:56:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 1336682BF5\n for ; Tue, 28 Apr 2026 06:56:47 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id TjBucY_Ezjw4 for ;\n Tue, 28 Apr 2026 06:56:46 +0000 (UTC)","from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 8426482BBA\n for ; Tue, 28 Apr 2026 06:56:44 +0000 (UTC)","from [192.168.0.192] (ip5f5af76e.dynamic.kabel-deutschland.de\n [95.90.247.110])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pmenzel)\n by mx.molgen.mpg.de (Postfix) with ESMTPSA id EA5054C288718F;\n Tue, 28 Apr 2026 08:56:02 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5F7CC41029","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8426482BBA"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777359408;\n\tbh=qXFDS8v5zFEjIqAqJOstmv2FvpJKJyewf4Vc0tDS+8M=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=HiqNafkdG2u2ZW7DP1kJhAMucCj75njcelHYslMnblsjHO9YJz5JP7YtUUV5yl0T4\n\t fXNLMUHBwND+GKY+nUcxWMTrgnfFVpravCYmLSBB/y7DYZzS65QnvVoqGM/qrHClBr\n\t MZDsh+CuvUenNYA4bfRO8fMmbjhTn3Ond0i8WsaUCqABrVEj684h6ec4LU2RZsMv33\n\t Z1WIxn2+u+NBgFdzPr+VuIbdw59u3Ag1JbXUp2+rxVtTvj/lOeroyIQdTDbSKIlvgS\n\t viyUUTgVyh8d3oruVROFmn8CxGAiSgAS1Qt2SjJrU+Wll/FL8i2euCQE005zHmU8K7\n\t pYfKX8jqPQexA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=141.14.17.11;\n helo=mx3.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8426482BBA","Message-ID":"","Date":"Tue, 28 Apr 2026 08:56:00 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"khai.wen.tan@linux.intel.com","Cc":"anthony.l.nguyen@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net,\n edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, khai.wen.tan@intel.com,\n Faizal Rahim ,\n Aleksandr Loktionov ","References":"<20260428060009.311393-1-khai.wen.tan@linux.intel.com>\n <20260428060009.311393-2-khai.wen.tan@linux.intel.com>","Content-Language":"en-US","From":"Paul Menzel ","In-Reply-To":"<20260428060009.311393-2-khai.wen.tan@linux.intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Mailman-Original-Authentication-Results":"smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=molgen.mpg.de","Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v4 1/3] igc: remove unused\n autoneg_failed field","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3683367,"web_url":"http://patchwork.ozlabs.org/comment/3683367/","msgid":"<84b4f8bb-3c8c-4098-bc7f-7e9fd248c5ca@linux.intel.com>","list_archive_url":null,"date":"2026-04-28T10:39:06","subject":"Re: [Intel-wired-lan] [PATCH iwl-next v4 1/3] igc: remove unused\n autoneg_failed field","submitter":{"id":88801,"url":"http://patchwork.ozlabs.org/api/people/88801/","name":"Abdul Rahim, Faizal","email":"faizal.abdul.rahim@linux.intel.com"},"content":"Hi Paul,\n\nThank you for your review.\n\nOn 28/4/2026 2:56 pm, Paul Menzel wrote:\n> [Cc: Removed stray *Looi*]\n> \n> Dear Khai Wen Tan,\n> \n> \n> Thank you for your patch.\n> \n> \n> Am 28.04.26 um 08:00 schrieb KhaiWenTan:\n> \n> (Should spaces be added in your name?)\n> \n>> From: Faizal Rahim \n>>\n>> autoneg_failed in struct igc_mac_info is never set in the igc driver.\n>> Remove the field and the dead code checking it in\n>> igc_config_fc_after_link_up().\n> \n> Could you please elaborate. Why is removal the correct fix, and it’s not an \n> incomplete feature? Does auto-negotiation always succeed?\n> \n\nAuto-negotiation does not always succeed, but igc does not use\nautoneg_failed to handle that case, the field was never set anywhere\nin the igc driver.\n\nBefore this patch, the only igc references to autoneg_failed were\nthe struct member declaration and the read in\nigc_config_fc_after_link_up(). No igc code ever assigned it to true,\nand git history shows no commit that added a setter since the code\ncreation in 2018.\n\nThe field originates from the e1000/e1000e fiber/serdes forced-link\npath: when MAC-level auto-negotiation on fiber times out, the driver\nforces link up and sets autoneg_failed so the flow-control code knows\npause was not negotiated and must be forced. igc has no fiber or\nserdes media, it only supports copper (igc_media_type_copper), so\nthe code that sets autoneg_failed was never ported.\n\nOn copper, PHY auto-negotiation failure is handled differently:\n- No link at all: igc_check_for_copper_link() returns before reaching\n flow-control configuration, there's nothing to configure FC on.\n- Link present but autoneg not yet complete:\n igc_config_fc_after_link_up() checks MII_SR_AUTONEG_COMPLETE and\n returns early without resolving pause. The next link-status event\n re-triggers the check.\n- Autoneg completes (including via parallel detection fallback when\n the link partner doesn't autoneg): the PHY still sets\n AUTONEG_COMPLETE but LP_ABILITY won't have PAUSE bits since the\n partner never sent autoneg pages. The existing flow-control logic\n in igc_config_fc_after_link_up() handles that correctly, it falls\n through to igc_fc_none or igc_fc_rx_pause based on requested_mode.\n\nNone of these paths need autoneg_failed. Keeping the field would be \nmisleading to reader.\n\n\n>> Reviewed-by: Looi, Hong Aun \n> \n> Please order it to not use the comma: Hong Aun Looi\n> \n\nWill do, thanks.\n\n>> Reviewed-by: Aleksandr Loktionov \n>> Signed-off-by: Faizal Rahim \n>> Signed-off-by: KhaiWenTan \n>> ---\n>>   drivers/net/ethernet/intel/igc/igc_hw.h  |  1 -\n>>   drivers/net/ethernet/intel/igc/igc_mac.c | 16 +---------------\n>>   2 files changed, 1 insertion(+), 16 deletions(-)\n>>\n>> diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ \n>> ethernet/intel/igc/igc_hw.h\n>> index be8a49a86d09..86ab8f566f44 100644\n>> --- a/drivers/net/ethernet/intel/igc/igc_hw.h\n>> +++ b/drivers/net/ethernet/intel/igc/igc_hw.h\n>> @@ -92,7 +92,6 @@ struct igc_mac_info {\n>>       bool asf_firmware_present;\n>>       bool arc_subsystem_valid;\n>>\n>> -    bool autoneg_failed;\n>>       bool get_link_status;\n>>   };\n>>\n>> diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ \n>> ethernet/intel/igc/igc_mac.c\n>> index 7ac6637f8db7..142beb9ae557 100644\n>> --- a/drivers/net/ethernet/intel/igc/igc_mac.c\n>> +++ b/drivers/net/ethernet/intel/igc/igc_mac.c\n>> @@ -438,28 +438,14 @@ void igc_config_collision_dist(struct igc_hw *hw)\n>>    * Checks the status of auto-negotiation after link up to ensure that the\n>>    * speed and duplex were not forced.  If the link needed to be forced, \n>> then\n>>    * flow control needs to be forced also.  If auto-negotiation is enabled\n>> - * and did not fail, then we configure flow control based on our link\n>> - * partner.\n>> + * then we configure flow control based on our link partner.\n>>    */\n>>   s32 igc_config_fc_after_link_up(struct igc_hw *hw)\n>>   {\n>>       u16 mii_status_reg, mii_nway_adv_reg, mii_nway_lp_ability_reg;\n>> -    struct igc_mac_info *mac = &hw->mac;\n>>       u16 speed, duplex;\n>>       s32 ret_val = 0;\n>>\n>> -    /* Check for the case where we have fiber media and auto-neg failed\n>> -     * so we had to force link.  In this case, we need to force the\n>> -     * configuration of the MAC to match the \"fc\" parameter.\n>> -     */\n>> -    if (mac->autoneg_failed)\n>> -        ret_val = igc_force_mac_fc(hw);\n>> -\n>> -    if (ret_val) {\n>> -        hw_dbg(\"Error forcing flow control settings\\n\");\n>> -        goto out;\n>> -    }\n>> -\n>>       /* In auto-neg, we need to check and see if Auto-Neg has completed,\n>>        * and if so, how the PHY and link partner has flow control\n>>        * configured.\n> \n> \n> Kind regards,\n> \n> Paul\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=kFnD21sL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4cPN5xPNz1yHv\n\tfor ; Tue, 28 Apr 2026 20:39:20 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A69144128A;\n\tTue, 28 Apr 2026 10:39:18 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RNY1QlIWj7gP; Tue, 28 Apr 2026 10:39:16 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7601541289;\n\tTue, 28 Apr 2026 10:39:16 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 53D701B8\n for ; Tue, 28 Apr 2026 10:39:15 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 44B2960FE8\n for ; Tue, 28 Apr 2026 10:39:15 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id i9-F1Iv_HxdC for ;\n Tue, 28 Apr 2026 10:39:14 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E99A060FE7\n for ; Tue, 28 Apr 2026 10:39:13 +0000 (UTC)","from fmviesa008.fm.intel.com ([10.60.135.148])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 03:39:13 -0700","from mohdfai2-mobl.gar.corp.intel.com (HELO [10.247.81.233])\n ([10.247.81.233])\n by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 03:39:09 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7601541289","OpenDKIM Filter v2.11.0 smtp3.osuosl.org E99A060FE7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777372756;\n\tbh=pBkKGyCnHo/WumAxGthc6hrl9KJPldFDEDPlbU81Xl4=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=kFnD21sLPWcd1TywsOZQZvNifvojtZisFEs3q1Br8NI164FegoeuGh3Zd3h2/fyvc\n\t ppuQOPPyac/Qy6tdtszrEMPRFrnJLSSBLcUdafHLQt+WSgxMj3XQBxNyiKwFGLM1Xl\n\t vZde9YJW0TTavCswkN3B0TyrLNmtCBUVLqekZaMNidYeU0x2bFP+NvimJtY5nDh9VB\n\t u43Zc2yk/hRoLlEkPnlbSP8Tw9MqxttsmBHXZ2jk0It3VAuUzStFSG5p4WuO7/s/ZA\n\t zLvGpksOsdafxHtTzU7BKTyk6RKIVFn1JkdeSPhEbv6u6LEpG9r+aLmRzNb1Jj8vbz\n\t CkNPAuele5kww==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org E99A060FE7","X-CSE-ConnectionGUID":["jRjZ6suKTte6JH1nHWx/+w==","b4j4xyRwTby95FsK2JPPBw=="],"X-CSE-MsgGUID":["ZCqJMgfzQt+N5rdDPDVOfA==","+lgNgHwhSai15uUy7ChhtQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"82129665\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"82129665\"","E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"231273121\""],"X-ExtLoop1":"1","Message-ID":"<84b4f8bb-3c8c-4098-bc7f-7e9fd248c5ca@linux.intel.com>","Date":"Tue, 28 Apr 2026 18:39:06 +0800","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"Paul Menzel , khai.wen.tan@linux.intel.com","Cc":"anthony.l.nguyen@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net,\n edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, khai.wen.tan@intel.com,\n Aleksandr Loktionov ","References":"<20260428060009.311393-1-khai.wen.tan@linux.intel.com>\n <20260428060009.311393-2-khai.wen.tan@linux.intel.com>\n ","Content-Language":"en-US","From":"\"Abdul Rahim, Faizal\" ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777372754; x=1808908754;\n h=message-id:date:mime-version:subject:to:cc:references:\n from:in-reply-to:content-transfer-encoding;\n bh=Bgc9zNw8/VIIqORJYTIMHdUjkk5pjcVenC5PsPgEqi8=;\n b=OYwOZAqwpQhGYpftplENX2d9cWM0+hyvNX6thfvE2qEXvkJXvvGadM8Z\n /h3A4eg1fnVPMcL+7/fCeXkJ7VSJcBnUsCnq+t9nDR9QyHl/BkP+vFUin\n /Tkdw5Y+4PK2XxyTdSXYLtcYvO5CLT+SDrNI2JJcw6Cc0U5WtS6RlTVF8\n rNTFgQutJX3P/Rouc8qwi+OmVPd2nOMmJrJ9aOFPMsiZRDdUts+5CA5bl\n DCNc8eiOHs6LXVSXj7mT8HCkOdao0U04hEvwTo2d2KGgZIZ0SAQdfHE2x\n deWioRrsMZRsqc5sRcPgt6vc3+T6heyfBN5pb7Y5eTmVM3nhWEkd0Dvf9\n g==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=OYwOZAqw"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next v4 1/3] igc: remove unused\n autoneg_failed field","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]