[{"id":3683112,"web_url":"http://patchwork.ozlabs.org/comment/3683112/","msgid":"","list_archive_url":null,"date":"2026-04-28T05:15:01","subject":"Re: [PATCH v2 1/3] arm: socfpga: Consolidate dram_bank_mmu_setup()","submitter":{"id":91590,"url":"http://patchwork.ozlabs.org/api/people/91590/","name":"Sune Brian","email":"briansune@gmail.com"},"content":"On Tue, Apr 28, 2026 at 11:32 AM wrote:\n>\n> From: Alif Zakuan Yuslaimi \n>\n> Relocate the dram_bank_mmu_setup() implementation from misc_arria10.c to\n> the common socfpga misc.c and update the function to correctly handle both\n> pre-relocation and post-relocation cases for DRAM cache enabling for\n> consistent MMU/dcache setup across Arria10 and CycloneV platforms.\n>\n> These changes help to improve maintainability and consistency of DRAM\n> initialization as well as MMU configuration for Arria10 and CycloneV\n> platforms.\n>\n> New Kconfig is introduced to enable this implementation only on the default\n> Arria10 and CycloneV boards as this will increase the SPL size which\n> will exceed some Gen5 devices' SPL size limit.\n>\n> Fixes: e26ecebc684b (\"socfpga: arria10: Allow dcache_enable before relocation\")\n>\n> Signed-off-by: Alif Zakuan Yuslaimi \n> ---\n\nFor GEN5 cyclone V:\nCustom board\n512x16 DDR3 die x 3\nECC supported to max Cyclone V allowed\nNo boot issue on soft / hard reset\n\nlog:\nU-Boot SPL 2026.07-rc1-dirty (Apr 28 2026 - 13:09:08 +0800)\nDDRCAL: Scrubbing ECC RAM (2048 MiB).\nDDRCAL: SDRAM-ECC initialized success with 1057 ms\nTrying to boot from MMC1\n\n\nU-Boot 2026.07-rc1-dirty (Apr 28 2026 - 13:09:08 +0800)\n\nTested-by: Brian Sune \n\n> arch/arm/mach-socfpga/Kconfig | 1 +\n> arch/arm/mach-socfpga/misc.c | 31 ++++++++++++++++++++++++++++\n\n> 3 files changed, 32 insertions(+), 26 deletions(-)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mvr+VdLQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"mvr+VdLQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=briansune@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4TCd5z9lz1yHv\n\tfor ; Tue, 28 Apr 2026 15:15:25 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BDECC84106;\n\tTue, 28 Apr 2026 07:15:17 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0868A84106; Tue, 28 Apr 2026 07:15:17 +0200 (CEST)","from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n [IPv6:2607:f8b0:4864:20::333])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E048E83A91\n for ; Tue, 28 Apr 2026 07:15:14 +0200 (CEST)","by mail-ot1-x333.google.com with SMTP id\n 46e09a7af769-7dcd8ef572aso4018696a34.1\n for ; Mon, 27 Apr 2026 22:15:14 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1777353313; cv=none;\n d=google.com; s=arc-20240605;\n b=SlnRHSUdjhPYfwZ599xC1GwWapHF61Kb8Q2XfJ/waTMhR0pZ85J9LZNpIWbTps+yBm\n +JfQauOQOcwSnjGqwQIP1FsKwENFoZMyjcCZOVsEXAv9PwFZTrVDiub5hvQSIe7Q5etl\n Xz7B1T0StiRohMDY2duqpRxjdEml+214kBvx4otmVoJShdBfKYBTeO077jDSDIEcLebN\n T0xDKJnQOLrIxvCytRvG0Z067O7WazGqwOoEunJ6t+WcbQYlB/EfILZ+cdsH2QBb1Gn0\n 502p6Eie5rr/ogGQFHKi49KFhlslJzxgb3QMnlqLs7SD47zCC/y5/SpQ433+pyw4w8Ll\n EteQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=0lfuwFkuvxwzFtHO8MoQWFeJmT02YiZPsvmxx9tAgGk=;\n fh=QMZdvVsxvWCHNNEpcAbJd4pzxODbhoOY9yjXiTqL0Z0=;\n b=AZ7zMZR82K4Fo+vPxh1CERFXM0KM5pt9nlLKzUxCZRXZfpkAiFaCXPWIvcfnHA9/9w\n OV4l8AIU1GWByj+JdtMbZyrNlq6uZaoPjcHO0NiOnM54epY87nBipOvasbELBSOIwx/P\n 11JKfG8O46Rn1gCmRt8MagXG+XDlYD7MiaBoR68ZVuVaNXLOgIcG7wWRsep1/AdRFo9i\n XRzUfJN4HZemwAxjLBxgKJ1FJ0OIs6KjoVsFjMYsuHo4o6wa2yqZ6Cm7XoYB555PNiIe\n a47F1WVjzTlfkP/HwltZlZnqP7cSsLUU5THFy9vUEEXoTJ6CbtJ+KH4yAT1gHLfd+rvn\n h9+A==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777353313; x=1777958113; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=0lfuwFkuvxwzFtHO8MoQWFeJmT02YiZPsvmxx9tAgGk=;\n b=mvr+VdLQB4qcAYU5ftbdexqHdypYGVdHFDn/RMZtDAst9rz0k/vxfypcFdPpdEmNfx\n BB61H2+8/Lqq+qA27XvaBoOcvdjR1NzBUpLoZtvJDPsdsug38g2+LVWskjBlgFfQkNS5\n eg+6FYtkPN7UmZt7OHhT7NIETGGFoLlGfH7aiCgGtUvev/Cp77/LiaW3at7V3rExe8/P\n JIi0Unn3tquhNko3GJyEYaq+KXxafy1azQ2lMGmgdp5WGp07fVK2rIUuWTAwA8muUq+R\n cVO0z413U1EwbDzatKRVGQ/E8mPWvwerumPZOiqrIryr0Y+wr1McjAd+cSHw9ilW4T3z\n Ij2g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777353313; x=1777958113;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=0lfuwFkuvxwzFtHO8MoQWFeJmT02YiZPsvmxx9tAgGk=;\n b=i0BPA1Dmg/O4EZHVAlnqeYSMiJkP76ADli+M2J0UiKZDtIpflrTYIR1q4GVN/sWAkO\n N+sJCb+awgvTD/4VHkeznTevXY9UETIoZRIz75ku7ol/jJR19IvGOFLOPx5rVEXAUXIr\n Y8dz2AjpONpm+cVVdcWMf8Bb81WmfVUaVUy6p7t2NzgRmEDcvNTghbROdHZyW810p4YE\n 1mkxBRsgYGhzv9DrbWdX00/8p10x/aVAdnzo9rr0WuTO2RNWyOeHkxSgfR6YXMpLnMkf\n MmqHGKt7PrL8YJ78KCMLTXsEHByYk0OhaKPIrbuC4B3+2cMWnoAMW2ZQPIzG83qW3QS+\n JMeQ==","X-Gm-Message-State":"AOJu0YyslDYEpBoLhhBBS2w8e9Fr0m5UEeDPje4M3fpWEn7fbuSy20ny\n HSQEoealayJS5oAGjv/s7AcX530FYEXcVLNmaXMI71WlxHs0ds+FW33tibLqrKziPJ7uJ2C5LlJ\n JJ9uMgpX9NNpaOB0RAP/3SBMFsRr1N4g=","X-Gm-Gg":"AeBDieua7io17IDqL0idZPoisL1t8iW3AT4Nt4m+bioENWPbpknEu8EZKQpwH+8ewtU\n fSAqrw+/6gF1yLu2g6I270kFED5ohP+gRcA7wpRHv2t9S0tif/SZ9agIck0HVjm5k3fD7LEqkNv\n qgZlRny7xssHsoxtIJ9G/hJFc+MnmuM1IDE8KBWq76MpMeBD3LHu4Nr+Mi8y7b2TnY1qHMzreMP\n oD/m689PCQtLXFylEQhPSAQg6inmOYjzA6KALZZiQkAzkMun7mIJA9ivUsAcNGAONAQAvEkZuhc\n 0qazU7il22TDzjO0vZUDw/s0AIA3bQ==","X-Received":"by 2002:a05:6830:6d4e:b0:7d9:d2b6:1568 with SMTP id\n 46e09a7af769-7de9a0cb4f8mr1037082a34.17.1777353313476; Mon, 27 Apr 2026\n 22:15:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20260428033230.7777-1-alif.zakuan.yuslaimi@altera.com>\n <20260428033230.7777-2-alif.zakuan.yuslaimi@altera.com>","In-Reply-To":"<20260428033230.7777-2-alif.zakuan.yuslaimi@altera.com>","From":"Sune Brian ","Date":"Tue, 28 Apr 2026 13:15:01 +0800","X-Gm-Features":"AVHnY4KHaUXgJme3jAO8pr-1U-Fy8UW0FZvXjwLU9JlCkp6YdVNET0ZFjvDV_qE","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/3] arm: socfpga: Consolidate dram_bank_mmu_setup()","To":"alif.zakuan.yuslaimi@altera.com","Cc":"u-boot@lists.denx.de, Marek Vasut ,\n Simon Goldschmidt ,\n Tien Fong Chee , Tom Rini ,\n Yao Zi ,\n Patrice Chotard , Peng Fan ,\n Simon Glass ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]