[{"id":3683182,"web_url":"http://patchwork.ozlabs.org/comment/3683182/","msgid":"","list_archive_url":null,"date":"2026-04-28T07:26:32","subject":"Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix\n MX25L25635E","submitter":{"id":75269,"url":"http://patchwork.ozlabs.org/api/people/75269/","name":"Weijie Gao","email":"weijie.gao@mediatek.com"},"content":"On Tue, 2026-04-28 at 09:22 +0200, Miquel Raynal wrote:\n> Hi,\n> \n> On 28/04/2026 at 11:32:03 +08, Weijie Gao \n> wrote:\n> \n> > The datasheet can be found here:\n> > \nhttps://urldefense.com/v3/__https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,*203V,*20256Mb,*20v1.3.pdf__;JSUl!!CTRNKA9wMg0ARbw!lYeaxwC-knJH61lKpIB1VNkNkvLBAAyzS5JwtDo-x9YDy7jngWucI28Yjx2wnzvEsuVLYPR4LkWiSKXNWrnIq93KhJw$\n> > \n> \n> You can be a little more verbose here, about the why we need this?\n> \n> > @@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {\n> > \t{ INFO(\"mx25u51245g\", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |\n> > \t SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |\n> > SPI_NOR_4B_OPCODES) },\n> > \t{ INFO(\"mx25l12855e\", 0xc22618, 0, 64 * 1024, 256, 0) },\n> > -\t{ INFO(\"mx25l25635e\", 0xc22019, 0, 64 * 1024, 512,\n> > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> > +\t{ INFO(\"mx25l25635e\", 0xc22019, 0, 64 * 1024, 512, SECT_4K |\n> > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> \n> Is this something you really need to flag? Isn't it already provided\n> by\n> the SFDP tables?\n\nI need to use this without enabling SFDP to save some space. So it's\nstill necessary to add this flag. I can add this description to the\ncommit message.\n\n> \n> > \t{ INFO(\"mx25u25635f\", 0xc22539, 0, 64 * 1024, 512, SECT_4K |\n> > SPI_NOR_4B_OPCODES) },\n> > \t{ INFO(\"mx25v8035f\", 0xc22314, 0, 64 * 1024, 16, SECT_4K |\n> > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> > \t{ INFO(\"mx25r1635f\", 0xc22815, 0, 64 * 1024, 32, SECT_4K |\n> > SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> \n> Thanks,\n> Miquèl","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256\n header.s=dk header.b=pqS8wpHO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=mediatek.com header.i=@mediatek.com\n header.b=\"pqS8wpHO\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=mediatek.com","phobos.denx.de;\n spf=pass smtp.mailfrom=weijie.gao@mediatek.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4X7G3kLkz1xvV\n\tfor ; Tue, 28 Apr 2026 17:26:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DC02A83FB5;\n\tTue, 28 Apr 2026 09:26:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4472584255; Tue, 28 Apr 2026 09:26:45 +0200 (CEST)","from mailgw01.mediatek.com (unknown [60.244.123.138])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6BD5983A91\n for ; Tue, 28 Apr 2026 09:26:41 +0200 (CEST)","from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by\n mailgw01.mediatek.com (envelope-from )\n (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)\n with ESMTP id 1730139994; Tue, 28 Apr 2026 15:26:35 +0800","from mtkmbs11n2.mediatek.inc (172.21.101.187) by\n mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.29; Tue, 28 Apr 2026 15:26:33 +0800","from mcddlt001.gcn.mediatek.inc (10.19.240.15) by\n mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id\n 15.2.2562.29 via Frontend Transport; Tue, 28 Apr 2026 15:26:32 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,\n UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.2","X-UUID":["962c730c42d311f19781c1a04af40193-20260428","962c730c42d311f19781c1a04af40193-20260428"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n d=mediatek.com;\n s=dk;\n h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID;\n bh=AZ018JQxaxphSuz2r+kgN3ZVXalzPSdMexFIIzSwW/Q=;\n b=pqS8wpHO0zpqTynemG4j6rZB/tyRSe/0xN8/bc9IIUciP7BAivuIgNSrZ4XBFpubwt2egHipOb3v/5PMU2+2zvf0ugBTV8ySeUUfEIjcEDiXqZ43VYbNDTSMf2In8An5wEmmvI88RmALdGancquGoxwPbZAQHB/bjW/R2wYGFYA=;","X-CID-P-RULE":"Release_Ham","X-CID-O-INFO":"VERSION:1.3.12, REQID:d11a1450-6ade-46cc-975d-1d900d833291,\n IP:0,\n U\n RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:\n release,TS:0","X-CID-META":"VersionHash:e7bac3a, CLOUDID:be69ca44-8360-4d24-8500-9b9380fa4b0d,\n B\n ulkID:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102|836|865|888|898,TC:-\n 5,Content:0|15|50,EDM:-3,IP:nil,URL:99|80|1,File:130,RT:0,Bulk:nil,QS:nil,\n BEC:-1,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0","X-CID-BVR":"2,SSN|SDN","X-CID-BAS":"2,SSN|SDN,0,_","X-CID-FACTOR":"TF_CID_SPAM_SNR,TF_CID_SPAM_ULS","X-CID-RHF":"D41D8CD98F00B204E9800998ECF8427E","Message-ID":"","Subject":"Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix\n MX25L25635E","From":"Weijie Gao ","To":"Miquel Raynal ","CC":", GSS_MTK_Uboot_upstream\n , Tom Rini , Vignesh\n R , Takahiro Kuwano , Marek\n Vasut , Tudor Ambarus\n , Jeffrey Yu , Christoph Reiter\n , Venkatesh Yadav Abbarapu\n , Shiji Yang , Bernhard\n Messerklinger , Vaishnav Achath\n , Prasad Kummari ","Date":"Tue, 28 Apr 2026 15:26:32 +0800","In-Reply-To":"<87cxzjft1x.fsf@bootlin.com>","References":"\n <5fd1dfc2637fdc2f33b8ba68b46a35f8f320a6d1.1777345877.git.weijie.gao@mediatek.com>\n <87cxzjft1x.fsf@bootlin.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5-0ubuntu0.18.04.2 ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-MTK":"N","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3683199,"web_url":"http://patchwork.ozlabs.org/comment/3683199/","msgid":"<87cxzjft1x.fsf@bootlin.com>","list_archive_url":null,"date":"2026-04-28T07:22:18","subject":"Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix\n MX25L25635E","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/people/73368/","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"content":"Hi,\n\nOn 28/04/2026 at 11:32:03 +08, Weijie Gao wrote:\n\n> The datasheet can be found here:\n> https://www.mxic.com.tw/Lists/Datasheet/Attachments/8592/MX25L25635E,%203V,%20256Mb,%20v1.3.pdf\n\nYou can be a little more verbose here, about the why we need this?\n\n> @@ -330,7 +330,7 @@ const struct flash_info spi_nor_ids[] = {\n> \t{ INFO(\"mx25u51245g\", 0xc2253a, 0, 64 * 1024, 1024, SECT_4K |\n> \t SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },\n> \t{ INFO(\"mx25l12855e\", 0xc22618, 0, 64 * 1024, 256, 0) },\n> -\t{ INFO(\"mx25l25635e\", 0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> +\t{ INFO(\"mx25l25635e\", 0xc22019, 0, 64 * 1024, 512, SECT_4K |\n> SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n\nIs this something you really need to flag? Isn't it already provided by\nthe SFDP tables?\n\n> \t{ INFO(\"mx25u25635f\", 0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) },\n> \t{ INFO(\"mx25v8035f\", 0xc22314, 0, 64 * 1024, 16, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n> \t{ INFO(\"mx25r1635f\", 0xc22815, 0, 64 * 1024, 32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },\n\nThanks,\nMiquèl","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=sp5MNYhK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.b=\"sp5MNYhK\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","phobos.denx.de;\n spf=pass smtp.mailfrom=miquel.raynal@bootlin.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4XRh2s41z1xvV\n\tfor ; Tue, 28 Apr 2026 17:41:04 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E60EA846BD;\n\tTue, 28 Apr 2026 09:38:15 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 673E0842C7; Tue, 28 Apr 2026 09:22:28 +0200 (CEST)","from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id DB4B184255\n for ; Tue, 28 Apr 2026 09:22:25 +0200 (CEST)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n by smtpout-02.galae.net (Postfix) with ESMTPS id 65FEE1A3469;\n Tue, 28 Apr 2026 07:22:25 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n by smtpout-01.galae.net (Postfix) with ESMTPS id 355F1601D0;\n Tue, 28 Apr 2026 07:22:25 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id E2A5D107283B4;\n Tue, 28 Apr 2026 09:22:16 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n t=1777360944; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n content-transfer-encoding:in-reply-to:references;\n bh=EbBi4ATMabhJyFOU2lOLYX4/UxMX+jTOXzlIfq1uHW4=;\n b=sp5MNYhKzrIg6GK4/qpPhFod9t/d8iF2VJgiLv7WDYqV2rjieZTLR/Gc4SsPY95B/RvC9w\n NDNYR7OhuSBmNddWjY55mmDMQo/tIo2QdLzjni8imDdemYl64wnA597lDVEw6IL19bzwIl\n 90DlrGgPBh7e1fdAeE3qNzW+MiFUgDXAbW5ZKZMIOcQuMDo5w0EyY/KoT9PttqC4aVxmGi\n urhYqZ+aRz/jhGMVHfBvpzJTuOf5h8LuIFgrrvzoHvt81RXfvR7pMgqPN8xSbz4lQDx2nX\n rrUlqL0nO0y1eZlga7tk2lMSeU14yf0+gcjtRvGRFtuJDCu9ZOtb2Ws1+s0iCw==","From":"Miquel Raynal ","To":"Weijie Gao ","Cc":", GSS_MTK_Uboot_upstream\n , Tom Rini ,\n Vignesh R , Takahiro Kuwano\n , Marek Vasut\n , Tudor Ambarus\n , Jeffrey Yu , Christoph Reiter\n , Venkatesh Yadav Abbarapu\n , Shiji Yang ,\n \"Bernhard Messerklinger\" , Vaishnav\n Achath , Prasad Kummari ","Subject":"Re: [PATCH 4/6] mtd: spi-nor-ids: Add 4K page support for Macronix\n MX25L25635E","In-Reply-To":"\n <5fd1dfc2637fdc2f33b8ba68b46a35f8f320a6d1.1777345877.git.weijie.gao@mediatek.com>\n (Weijie Gao's message of \"Tue, 28 Apr 2026 11:32:03 +0800\")","References":"\n <5fd1dfc2637fdc2f33b8ba68b46a35f8f320a6d1.1777345877.git.weijie.gao@mediatek.com>","User-Agent":"mu4e 1.12.7; emacs 30.2","Date":"Tue, 28 Apr 2026 09:22:18 +0200","Message-ID":"<87cxzjft1x.fsf@bootlin.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Last-TLS-Session-Version":"TLSv1.3","X-Mailman-Approved-At":"Tue, 28 Apr 2026 09:38:07 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]