[{"id":3683431,"web_url":"http://patchwork.ozlabs.org/comment/3683431/","msgid":"<877bprfs6k.fsf@bootlin.com>","list_archive_url":null,"date":"2026-04-28T07:41:07","subject":"Re: [PATCH 5/6] mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove\n W25Q256FW","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/people/73368/","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"content":"On 28/04/2026 at 11:32:11 +08, Weijie Gao wrote:\n\n> There's no part named W25Q256FW, only W25Q256JW (Non-DTR version) exists\n> with ID ef6019.\n>\n> The datasheet can be found here:\n> https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf\n>\n> Signed-off-by: Weijie Gao \n> ---\n> drivers/mtd/spi/spi-nor-ids.c | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n>\n> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c\n> index a157e370b89..492411a90f5 100644\n> --- a/drivers/mtd/spi/spi-nor-ids.c\n> +++ b/drivers/mtd/spi/spi-nor-ids.c\n> @@ -610,12 +610,7 @@ const struct flash_info spi_nor_ids[] = {\n> \t\t\tSPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)\n> \t},\n> \t{\n> -\t\tINFO(\"w25q256fw\", 0xef6019, 0, 64 * 1024, 512,\n> -\t\t\tSECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |\n> -\t\t\tSPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)\n> -\t},\n> -\t{\n> -\t\tINFO(\"w25q256jw\", 0xef7019, 0, 64 * 1024, 512,\n\nFYI, this ID is W25Q256JV-M.\n\n> +\t\tINFO(\"w25q256jw\", 0xef6019, 0, 64 * 1024, 512,\n> \t\t\tSECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |\n> \t\t\tSPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)\n> \t},\n\nReviewed-by: Miquel Raynal ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=ROE56rGt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.b=\"ROE56rGt\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=bootlin.com","phobos.denx.de;\n spf=pass smtp.mailfrom=miquel.raynal@bootlin.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4g5t3lsvz1xrS\n\tfor ; Tue, 28 Apr 2026 22:41:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8509483FB5;\n\tTue, 28 Apr 2026 14:41:01 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id EC2EE84698; Tue, 28 Apr 2026 09:41:16 +0200 (CEST)","from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CA60B8464E\n for ; Tue, 28 Apr 2026 09:41:13 +0200 (CEST)","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n by smtpout-03.galae.net (Postfix) with ESMTPS id 553AE4E42B5F;\n Tue, 28 Apr 2026 07:41:13 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n by smtpout-01.galae.net (Postfix) with ESMTPS id 1EC48601D0;\n Tue, 28 Apr 2026 07:41:13 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 054A810728430;\n Tue, 28 Apr 2026 09:41:05 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n t=1777362072; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n in-reply-to:references; bh=tRzTEotDpomL/4AWS5Ra9jHN1ITyC7BIQJMTE8kNMmk=;\n b=ROE56rGtZfKtMsnIWUF8Djg1o4oFpxMCj4EB3SWMlghvvVn113SsqP+Qa617LEqWTuNkg1\n C7qBm0NKl5FdiBpXpw7RpjEL+isOHX5AIOORH4K/2qpIba7iwOg/KojFM7r6Cqr5cih1rB\n rLctx77fGr5PCcGLtgd+IXFoi00NWL7HzFTeV1EnnQz2xpBB/7RrTDRy8R/2gopf86AKMk\n F1TK0puJY4riagCFEqmVBAttlBI1EcWEXvrBK0bw2KbVzspHl5a4dxFMWRBQLtdfBZ3ZKV\n U75ocbT2penfvqV6dQArD+n53YykvAzmOL8nliNgKhvZXh1xZ99KfutyviAZPg==","From":"Miquel Raynal ","To":"Weijie Gao ","Cc":", GSS_MTK_Uboot_upstream\n , Tom Rini ,\n Vignesh R , Takahiro Kuwano\n , Marek Vasut\n , Tudor Ambarus\n , Jeffrey Yu , Christoph Reiter\n , Venkatesh Yadav Abbarapu\n , Shiji Yang ,\n \"Bernhard Messerklinger\" , Vaishnav\n Achath , Prasad Kummari ","Subject":"Re: [PATCH 5/6] mtd: spi-nor-ids: Fix Winbond W25Q256JW and remove\n W25Q256FW","In-Reply-To":"\n <5f9c98f56655634a64be9fc1059173a8db609055.1777345877.git.weijie.gao@mediatek.com>\n (Weijie Gao's message of \"Tue, 28 Apr 2026 11:32:11 +0800\")","References":"\n <5f9c98f56655634a64be9fc1059173a8db609055.1777345877.git.weijie.gao@mediatek.com>","User-Agent":"mu4e 1.12.7; emacs 30.2","Date":"Tue, 28 Apr 2026 09:41:07 +0200","Message-ID":"<877bprfs6k.fsf@bootlin.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-Last-TLS-Session-Version":"TLSv1.3","X-Mailman-Approved-At":"Tue, 28 Apr 2026 14:41:00 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]