[{"id":3683141,"web_url":"http://patchwork.ozlabs.org/comment/3683141/","msgid":"","list_archive_url":null,"date":"2026-04-28T06:16:01","subject":"Re: [PATCH] hw/audio/fmopl.c: Convert malloc, free to g_malloc0,\n g_new and g_free","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Tue, Apr 28, 2026 at 3:48 AM Lucas Cardoso wrote:\n>\n> In accordance with QEMU's coding style guidelines, replace raw memory\n> allocation functions (malloc/free) with their GLib equivalents\n> (g_new/g_malloc0/g_free).\n>\n> Also removes the old generic error-handling code from\n> OPLOpenTable(), since the Glib functions abort the program automatically\n> if memory is exhausted.\n>\n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/1798\n> Signed-off-by: Lucas Cardoso \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> hw/audio/fmopl.c | 41 +++++++++++------------------------------\n> 1 file changed, 11 insertions(+), 30 deletions(-)\n>\n> diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c\n> index a63ad0f04d..aeefc4c9fe 100644\n> --- a/hw/audio/fmopl.c\n> +++ b/hw/audio/fmopl.c\n> @@ -607,26 +607,10 @@ static int OPLOpenTable( void )\n> double pom;\n>\n> /* allocate dynamic tables */\n> - if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)\n> - return 0;\n> - if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)\n> - {\n> - free(TL_TABLE);\n> - return 0;\n> - }\n> - if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)\n> - {\n> - free(TL_TABLE);\n> - free(SIN_TABLE);\n> - return 0;\n> - }\n> - if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)\n> - {\n> - free(TL_TABLE);\n> - free(SIN_TABLE);\n> - free(AMS_TABLE);\n> - return 0;\n> - }\n> + TL_TABLE = g_new(int32_t, TL_MAX * 2);\n> + SIN_TABLE = g_new(int32_t *, SIN_ENT * 4);\n> + AMS_TABLE = g_new(int32_t, AMS_ENT * 2);\n> + VIB_TABLE = g_new(int32_t, VIB_ENT * 2);\n> ENV_CURVE = g_new(int32_t, 2 * EG_ENT + 1);\n> /* make total level table */\n> for (t = 0;t < EG_ENT-1 ;t++){\n> @@ -696,10 +680,10 @@ static int OPLOpenTable( void )\n> static void OPLCloseTable( void )\n> {\n> g_free(ENV_CURVE);\n> - free(TL_TABLE);\n> - free(SIN_TABLE);\n> - free(AMS_TABLE);\n> - free(VIB_TABLE);\n> + g_free(TL_TABLE);\n> + g_free(SIN_TABLE);\n> + g_free(AMS_TABLE);\n> + g_free(VIB_TABLE);\n\nTo make this function idempotent, I would rather use\ng_clear_pointer(), but that might not be necessary\n\n> }\n>\n> /* CSM Key Control */\n> @@ -1081,11 +1065,8 @@ FM_OPL *OPLCreate(int clock, int rate)\n> /* allocate OPL state space */\n> state_size = sizeof(FM_OPL);\n> state_size += sizeof(OPL_CH)*max_ch;\n> - /* allocate memory block */\n> - ptr = malloc(state_size);\n> - if(ptr==NULL) return NULL;\n> - /* clear */\n> - memset(ptr,0,state_size);\n> + /* allocate memory block and zero-initialize */\n> + ptr = g_malloc0(state_size);\n> OPL = (FM_OPL *)ptr; ptr+=sizeof(FM_OPL);\n> OPL->P_CH = (OPL_CH *)ptr; ptr+=sizeof(OPL_CH)*max_ch;\n> /* set channel state pointer */\n> @@ -1128,7 +1109,7 @@ void OPLDestroy(FM_OPL *OPL)\n> }\n> #endif\n> OPL_UnLockTable();\n> - free(OPL);\n> + g_free(OPL);\n> }\n>\n> /* ---------- Option handlers ---------- */\n> --\n> 2.51.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=MSxu2Rqy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4VZN2tc0z1yHv\n\tfor ; Tue, 28 Apr 2026 16:16:44 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHbk8-0006u4-43; Tue, 28 Apr 2026 02:16:25 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHbk1-0006sC-O4\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 02:16:18 -0400","from mail-dy1-x132c.google.com ([2607:f8b0:4864:20::132c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHbjz-000136-VJ\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 02:16:17 -0400","by mail-dy1-x132c.google.com with SMTP id\n 5a478bee46e88-2d8ffdc31d0so2793981eec.0\n for ; Mon, 27 Apr 2026 23:16:15 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1777356974; cv=none;\n d=google.com; s=arc-20240605;\n b=fX+lymzwoErFm3aJdd2ygtomp49IRSLp5vSUiLp+FthPYSaZ/iizC4tMdDgme68sY0\n oWW+WaVLOJ5P35GwbS6iOeK+J2PhKhTZhzw4pJNOhTPm4aAIsTsZhVWVi9qBDFortVjI\n gzlXPUEsVGFoyzW/4moDwJ8zB19RAO2jk3Hd/nmGd55BMeHO9BNuDbjcmS26Dvs25UUU\n Gz6NCP4ESENMM5WSabBngjJIvHIPSF9QynCXaQaRohcat8jp/526vhLDXKw7LxFWaQSz\n TLnWDdMd1C7eNqBd3D8aBSr83KtYgM4//reok97PTjsjp6RvyVbRv6UjZ9U8+HlilJAn\n OLow==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=2dOBHRaGvuQxnPccomI7bJCXmVZwYQ5QB2PSNIreMPs=;\n fh=lOBSB/Hs2AAkL9G+pX/8nWevA4VW0M0kVZpTB7kbXLg=;\n b=fsW9jLXIHPyXWK0+8p7PLSVXMBPp8tUGjsN4/Prm+CtgX3CejirCaTdBR25VJCV0b1\n Xei8r0nu/nhEvvHfDWEUhA7NWpqZAyL+TmoUElcQznKJIbnuCTTq1bJFcURdHI973TZv\n pCeBO6Qz1F4p9J6gm48q18H7KFG9ekSz7NiQqRqQMaVurOFZE3N8AzVgCM+B8aBkM8Oh\n 7ZbkTliRa3Tl5ogB0WRgcXKgfpNorI5UhIQG1rXJUxljHce5zzekdIpDH8D5RIC6ugWC\n ntoGfr6S6iZ0SeXZ8w33arqqwtDI2n0U2A6WJTRVnnHJpvX+BgJEY3xlUMXeqbV3krIS\n N0Vw==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777356974; x=1777961774; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2dOBHRaGvuQxnPccomI7bJCXmVZwYQ5QB2PSNIreMPs=;\n b=MSxu2RqyQfVOLcay9dwhSThDYk7ikWfkYn4TYWigVwxjYJ6YIZW0sO6oNObUWc9Mre\n zVVieJHj2X7qt1b55PUlHJIMP+DI6FZGcjxsh+zbLVMxvHoHnnkHVZZuvp55Bhq1lrNH\n US8rpC/5Osez+uDwNvwZMNxMjLlZnMYk8fxpYYQrB9Rr1HX6Sem4H37ifiPtrnzWFIKs\n iRTw0OIlXEgZkdDt9NDR1rryXTviQHYnGEHDS+0dSNhNjuzrnurLVckaQPrR1F2yFasH\n wgZOV6Lx5wvk/vtZEDgZfiBO1/LTcl4WlQO0FePfXJ/vzxra67Bnx2QE/8giQEeaExT0\n 2Zbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777356974; x=1777961774;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=2dOBHRaGvuQxnPccomI7bJCXmVZwYQ5QB2PSNIreMPs=;\n b=rhoEuERYYDqLB1Ph+5x3AW+Scn8QHjmvCAEY/4YekbJWC9gyA2W/WGDwS6kT/ELcl8\n QUWJiiY3YsxsBhSsXIk2/WkzJUnvhUIG5LPEc4PNTsTzbl2HG9viF2F5f0Tv9IQri9wU\n bG0O/y+wqOfb84eHpMkwWg93PTXOsa91suzjO4FvIYWT8F/Y6pJPcXvAB+GysC8Md4U2\n kCsyvOt5zTPdKtCCLkKk0dILke7Kr+4ntzuW0/+HljKLRsk58hVeRK8IEYAXmbdKzOcE\n QvA0kaZntFgpWkBQlg8HkxwxfC5VlVW1mv7QhLt9KX5G9sI3u1MxzXXUc/gP+oFvPBxr\n o1Gw==","X-Gm-Message-State":"AOJu0YzB8kc8+JI2gsiz+c0xzZpmEEzL8v8kiAN6vAX6o6D/IX/kWVZH\n OfB+ygBreYMePVwg2l4nkjFtBy8Li0ormCoKKquu7pmA1obFPJVQn4j6btqqreQYobatYs+gh/V\n eTnugLND1JkNYe6i6Ny6oLLLXIj6Aq0Q=","X-Gm-Gg":"AeBDievfzKsQwHyRqn3NTrvzj7rYAy1sjfXdDTg5yK1QNjttLZXeeP5o+43kiVSI7mR\n zd4+M6vyDB4wau3iTGCEOnliSR76m9mmDizLeJ8r0iBD2saa/+2Jq/zfpzWcBZwhz8gxVlmL3g1\n d5REudebS10Z1Cqsh7PGwgUWWLR+Eggy71bScUKU1WLVtQpte4HZI7ocqvytHS+L7mKwczhZOv1\n 6T+VZizj+0rcj9gY0LhrnP1miT8irvJHTko9EP7Dik2XBVMxQCOUzeVWQXT2o0O1cpxz28Xssfp\n Qu9H5pV3vfh74ziYT3Tv4Gg3BS1BcW5uMuwUryJbl455on/XLX8=","X-Received":"by 2002:a05:7300:73c7:b0:2e6:e504:5435 with SMTP id\n 5a478bee46e88-2ed0a015a63mr879217eec.12.1777356974100; Mon, 27 Apr 2026\n 23:16:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20260427223928.2742270-1-luc.fast2004@gmail.com>","In-Reply-To":"<20260427223928.2742270-1-luc.fast2004@gmail.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Tue, 28 Apr 2026 10:16:01 +0400","X-Gm-Features":"AVHnY4JvwDhkzLh3hsw8skf9bQ9lbpQq6XEnVo-sr1AW0bKIGAMEek6IOmV5Nqs","Message-ID":"\n ","Subject":"Re: [PATCH] hw/audio/fmopl.c: Convert malloc, free to g_malloc0,\n g_new and g_free","To":"Lucas Cardoso ","Cc":"qemu-devel@nongnu.org, kraxel@redhat.com, qemu-trivial@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::132c;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-dy1-x132c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]