[{"id":3683172,"web_url":"http://patchwork.ozlabs.org/comment/3683172/","msgid":"<afBdXj_9r25Ssnz6@ashevche-desk.local>","list_archive_url":null,"date":"2026-04-28T07:10:22","subject":"Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()","submitter":{"id":46495,"url":"http://patchwork.ozlabs.org/api/people/46495/","name":"Andy Shevchenko","email":"andriy.shevchenko@intel.com"},"content":"On Mon, Apr 27, 2026 at 05:41:24PM -0400, Yury Norov wrote:\n> Switch from sign_extend32(FIELD_GET()) to the dedicated\n> FIELD_GET_SIGNED() and don't calculate the fields length explicitly.\n\n...\n\n>  \tfor (i = 0; i < ADDC_T_AVG; i++) {\n>  \t\ttmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD);\n> -\t\tdc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11);\n> -\t\tdc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);\n> +\t\tdc_re += FIELD_GET_SIGNED(0xfff000, tmp);\n> +\t\tdc_im += FIELD_GET_SIGNED(0xfff, tmp);\n\nIn the same driver the GENMASK() is being used, why not  doing it here while at it?\n\n>  \t}\n\n...\n\n>  \tfor (i = 0; i < ADDC_T_AVG; i++) {\n>  \t\ttmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD);\n> -\t\tdc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11);\n> -\t\tdc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);\n> +\t\tdc_re += FIELD_GET_SIGNED(0xfff000, tmp);\n> +\t\tdc_im += FIELD_GET_SIGNED(0xfff, tmp);\n>  \t}\n\nDitto, and it even looks like the same piece repeating twice in different\ncompilation units of the same driver...","headers":{"Return-Path":"\n <linux-rtc+bounces-6444-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=f4xJxPnq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6444-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"f4xJxPnq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.10","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4WsR05TZz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 17:14:51 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 55CDA30C05FA\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 07:10:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2FFA13AB292;\n\tTue, 28 Apr 2026 07:10:36 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.10])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 101DB39A049;\n\tTue, 28 Apr 2026 07:10:33 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n  by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 00:10:33 -0700","from kniemiec-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.213])\n  by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 00:10:25 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777360236; cv=none;\n b=av71NH/u8wHneighhMhkmfjrhPh+jWgzw53jUE2lA56ky8QrV/+ALpDdHDhOaggPYi5MwpCBmdiygAUbSYCnpysyJyVK1mEQ3NCkRxPTnQjpUoGcUYiazU5l4dXH6tvTE/Ocwj+A/YMRAtVTlgu2WWfV6n9VOKBmqRWBADGE2ao=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777360236; c=relaxed/simple;\n\tbh=X/LMtGLsAI98KpSAX0nwBX/szOSGt8ghowDeNGWHy9w=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=PJKtP4OST241h86/gE2YVnioYpPTXfTgLt9EpEhdRINlAI9JwD1QY+0SKy+zJmjFQgSzno29aoEQnosOM1bGV5ZfKYdarnV08iKIKq8uvM0xF41z1vI5Zf89o9I1mNJ/8px8kbETxcrEjG1KQaPhAZbW0P0+9b+XCby5hXgG9tc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=intel.com;\n spf=pass smtp.mailfrom=intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=f4xJxPnq; arc=none smtp.client-ip=198.175.65.10","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1777360234; x=1808896234;\n  h=date:from:to:cc:subject:message-id:references:\n   mime-version:in-reply-to;\n  bh=X/LMtGLsAI98KpSAX0nwBX/szOSGt8ghowDeNGWHy9w=;\n  b=f4xJxPnqOOjTKIvaiPGB6pHrYvEWO4yXkcteqRVtUluMDxppSp5tOLnw\n   2KgsWY6UoBmYCQ19SSw98sw4t2du3B3KengqB71mRjM3HkdSQzjETJORk\n   rOD6OYHl/elnjkgVwFeIg+9kO829Hx4l7O54aII3DLOWuPueIB4yaO0CW\n   OcyA42McGjN9ma56K43zghu4ROXZ8MTRxnnuOxkbA4vZOxpmokMdkBdNF\n   9WjyeR4KpdorfbVgedEbJK4xE9gUzntvMbJqjodIG25ybtEXMgE5LhP1b\n   H6n4W1wjghtluxi0TMKHZb04bfyk6IqXX9JpTK5EmUE/bN5e2pPaJzAGi\n   g==;","X-CSE-ConnectionGUID":["CSbc6oE4T3KR5bp7jStLDQ==","lVSkmhXlQ/mFlOhxzX6tFQ=="],"X-CSE-MsgGUID":["WHDjQXjcTWaFMQZovvK4UA==","tuF8HfU7RNWOHPfANBcGjg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"95674680\"","E=Sophos;i=\"6.23,203,1770624000\";\n   d=\"scan'208\";a=\"95674680\"","E=Sophos;i=\"6.23,203,1770624000\";\n   d=\"scan'208\";a=\"234150595\""],"X-ExtLoop1":"1","Date":"Tue, 28 Apr 2026 10:10:22 +0300","From":"Andy Shevchenko <andriy.shevchenko@intel.com>","To":"Yury Norov <ynorov@nvidia.com>","Cc":"Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,\n Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,\n \"H. Peter Anvin\" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,\n Peter Zijlstra <peterz@infradead.org>, Jonathan Cameron <jic23@kernel.org>,\n David Lechner <dlechner@baylibre.com>,\n Johannes Berg <johannes@sipsolutions.net>,\n David Laight <david.laight.linux@gmail.com>,\n Nuno =?iso-8859-1?q?S=E1?= <nuno.sa@analog.com>,\n Andy Shevchenko <andy@kernel.org>, Ping-Ke Shih <pkshih@realtek.com>,\n Richard Cochran <richardcochran@gmail.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>,\n Yury Norov <yury.norov@gmail.com>,\n Rasmus Villemoes <linux@rasmusvillemoes.dk>,\n Hans de Goede <hansg@kernel.org>, Linus Walleij <linusw@kernel.org>,\n Sakari Ailus <sakari.ailus@linux.intel.com>,\n Salah Triki <salah.triki@gmail.com>, Achim Gratz <Achim.Gratz@stromeko.de>,\n Ben Collins <bcollins@watter.com>, x86@kernel.org,\n linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,\n linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n linux-rtc@vger.kernel.org","Subject":"Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()","Message-ID":"<afBdXj_9r25Ssnz6@ashevche-desk.local>","References":"<20260427214127.406067-1-ynorov@nvidia.com>\n <20260427214127.406067-8-ynorov@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"<linux-rtc.vger.kernel.org>","List-Subscribe":"<mailto:linux-rtc+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-rtc+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260427214127.406067-8-ynorov@nvidia.com>","Organization":"Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6\n krs, Bertel Jungin Aukio 5, 02600 Espoo"}},{"id":3683383,"web_url":"http://patchwork.ozlabs.org/comment/3683383/","msgid":"<20260428114342.0d674fd8@pumpkin>","list_archive_url":null,"date":"2026-04-28T10:43:42","subject":"Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()","submitter":{"id":89989,"url":"http://patchwork.ozlabs.org/api/people/89989/","name":"David Laight","email":"david.laight.linux@gmail.com"},"content":"On Tue, 28 Apr 2026 10:10:22 +0300\nAndy Shevchenko <andriy.shevchenko@intel.com> wrote:\n\n> On Mon, Apr 27, 2026 at 05:41:24PM -0400, Yury Norov wrote:\n> > Switch from sign_extend32(FIELD_GET()) to the dedicated\n> > FIELD_GET_SIGNED() and don't calculate the fields length explicitly.  \n> \n> ...\n> \n> >  \tfor (i = 0; i < ADDC_T_AVG; i++) {\n> >  \t\ttmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD);\n> > -\t\tdc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11);\n> > -\t\tdc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);\n> > +\t\tdc_re += FIELD_GET_SIGNED(0xfff000, tmp);\n> > +\t\tdc_im += FIELD_GET_SIGNED(0xfff, tmp);  \n> \n> In the same driver the GENMASK() is being used, why not  doing it here while at it?\n\nTo me those bit masks look more readable than the GENMASK() calls would be.\n\n\tDavid\n\n> \n> >  \t}  \n> \n> ...\n> \n> >  \tfor (i = 0; i < ADDC_T_AVG; i++) {\n> >  \t\ttmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD);\n> > -\t\tdc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11);\n> > -\t\tdc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11);\n> > +\t\tdc_re += FIELD_GET_SIGNED(0xfff000, tmp);\n> > +\t\tdc_im += FIELD_GET_SIGNED(0xfff, tmp);\n> >  \t}  \n> \n> Ditto, and it even looks like the same piece repeating twice in different\n> compilation units of the same driver...\n>","headers":{"Return-Path":"\n <linux-rtc+bounces-6449-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=OnXstZmN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6449-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"OnXstZmN\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.43","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4d4b67SZz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 21:09:51 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D3654311366F\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 10:56:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1F5F73F9F45;\n\tTue, 28 Apr 2026 10:43:48 +0000 (UTC)","from mail-wm1-f43.google.com (mail-wm1-f43.google.com\n [209.85.128.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA3D3F9F36\n\tfor <linux-rtc@vger.kernel.org>; Tue, 28 Apr 2026 10:43:46 +0000 (UTC)","by mail-wm1-f43.google.com with SMTP id\n 5b1f17b1804b1-48a3e9862f0so60193075e9.1\n        for <linux-rtc@vger.kernel.org>; Tue, 28 Apr 2026 03:43:46 -0700 (PDT)","from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36])\n        by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a77af28e6sm41696855e9.6.2026.04.28.03.43.43\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Tue, 28 Apr 2026 03:43:44 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777373028; cv=none;\n b=Z14BFoAuye6OPuuf1+IYk4OBoL2zrLn43HyyargpQD7vYcvInQ3kjuWla2SGBj6jiMZCAOp0R0dQYNjkI+3mv4UZQCrzjM46Z7+6iNzCuBvj4PlT9KjX3ydck0rSSyM+ntIby2B/AZVy3TphbkV9rNgGOjP+tV2YOFmXj0NINek=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777373028; c=relaxed/simple;\n\tbh=Txo9jXdDRugPyX7qmDybQ2dYpzzLy0YS2OMMBLInikE=;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=SnHlNfVc10way5r92TlpbwLIsVdVrSF4rtrPwdmzFTy8a32/kL6NsRw85idOPfrCQp2nrIsi84H3eT6IujgFvBkdnRRTdOItApXAaQcwU33m+5rzB7BBetuaLoux1685EIygrFLaJdWU5G01P9l71JCM9QAWyTIShpIJPFfWK6w=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=OnXstZmN; arc=none smtp.client-ip=209.85.128.43","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1777373025; x=1777977825;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:subject:cc:to:from:date:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=hKtRqSF01B3I4gaZJfxuG2QF2TOpMdK++wbIpuZOUFw=;\n        b=OnXstZmN7ww1Q4bhga8AwQWndl6j+ndOBx2NRQaG/ke7OEbOxNum8W/rv6iVgWWpsP\n         q3CqBLQEPXY6iz2D7jDqte1G8jU5tZRYGnO5sYLmLOYq0HhrVh8lUNG2Pa+PTDRUbBj8\n         yXvz1CKuvbjoMO/5hlzvifIjmBs1huNuA2I2nkMOI0UGUJStbkpc26sEi5r1jR65caUI\n         rKz1BFO0+/M/uhxlM+PjQdZhsnYgbUuAwIfTbMeQZ7QefPDTYw6nsVY264kH03ze1LtD\n         lTRdJn7H0otmTRynmseltG+hfSWaQ6x3nMXcRRDxxFzlXhbdE1cKgLGYcmyphB1lBzLY\n         ZXsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1777373025; x=1777977825;\n        h=content-transfer-encoding:mime-version:references:in-reply-to\n         :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=hKtRqSF01B3I4gaZJfxuG2QF2TOpMdK++wbIpuZOUFw=;\n        b=VOIsyM95jHgUAyYd4T7SN2rywuhBpceBYpV8kh5r/BccCFa4HSeBRo0w8oiSWh352r\n         6qtm7hjr6jliJBmUwTbrJqk42q3Qb77JQqNBCojTIWgEUFif2x6HN7yDkYIIh2BGrTZb\n         zPfAXp3k6mQ5O4cFL8g+Ony2Wt1BDPCKypM6qxicbMHGtk9FuirxupqoIce2o/EhxGev\n         unwV8VjAPQhY8IHZ1XIU39MVwf6C224v6MFW9CN8YmIAmd+q4CApFRopur1d0LJOuq/8\n         ifg7Ka0ykSFPb4MSG7i4uneNbrTMqHtcAUEN5BCpEU/+eywE24/l3SOQNu7jgTB49OPp\n         XQbw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/YRJP9i5hCSsjbqwFlR5Glpg5blJ/KEbovQeFupu/hOu4DQbAbP+GkfWpFudTTGKYYHLtSLr4gXvc=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz6yD/VZ7HxL2dhwBMr3xRga2vzJdambd0CQoAS69L/UH0A/Cc5\n\tjJrsu0QeHk8Vy2J/ZEKh89xHIa3t76JjFTyB6m7eWuS1CM8HUKaointM","X-Gm-Gg":"AeBDiesuPEGBWFXIepGJaP3pL2iroJuG4tS8+2xIop+XB08+9A443K6V6+4FWu9Vv/X\n\tiGqAW0CP1Ea8eTSdLX2lAgwhdM7qRZNx8nyrOJYwKlgxeSO3VbkTyCHxw+qgy01kYhbfZN4hkzh\n\tG9jcD7lMYRxlC+/eBD50cWmwdWQhp91L8Iw/hmHG9PXUba+QHuttbfkva9R2NNujMpbpG6N2kvc\n\tYEN/d6wUcHarQQ2imDOPJUyDyZmmybo6IhqSdmcuH108Qshyn/7wcAgjE0bT6u+ED/qCovFepXd\n\trOwYYjGWucVUmnmLxE+GMt0gKUyaciDPn473WyeSCivMbkVZwB5BqJ3Eyv9aUQRjq/4SCVBkQd9\n\tLXyg30/HIcjtunznb/n9r1NLyoa71eJZ2FUi5CjL5QXTIPnk4TCn3ssH+NHR8Ayl167NqAmYky8\n\taXlsn2EyKfrjwa6v3NyyOWDSyfW6A2VnqG88hL7R69fDV16qGpf0B5OVo9wPrFDkeubIKyzJxlB\n\tm8=","X-Received":"by 2002:a05:600c:a08b:b0:48a:53cb:8604 with SMTP id\n 5b1f17b1804b1-48a78a536acmr28625155e9.14.1777373024680;\n        Tue, 28 Apr 2026 03:43:44 -0700 (PDT)","Date":"Tue, 28 Apr 2026 11:43:42 +0100","From":"David Laight <david.laight.linux@gmail.com>","To":"Andy Shevchenko <andriy.shevchenko@intel.com>","Cc":"Yury Norov <ynorov@nvidia.com>, Thomas Gleixner <tglx@kernel.org>,\n Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,\n Dave Hansen <dave.hansen@linux.intel.com>, \"H. Peter Anvin\" <hpa@zytor.com>,\n Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,\n Jonathan Cameron <jic23@kernel.org>, David Lechner <dlechner@baylibre.com>,\n Johannes Berg <johannes@sipsolutions.net>,\n Nuno =?utf-8?b?U8Oh?= <nuno.sa@analog.com>,\n Andy Shevchenko <andy@kernel.org>, Ping-Ke Shih <pkshih@realtek.com>,\n Richard Cochran <richardcochran@gmail.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>,\n Yury Norov <yury.norov@gmail.com>,\n Rasmus Villemoes <linux@rasmusvillemoes.dk>,\n Hans de Goede <hansg@kernel.org>, Linus Walleij <linusw@kernel.org>,\n Sakari Ailus <sakari.ailus@linux.intel.com>,\n Salah Triki <salah.triki@gmail.com>, Achim Gratz <Achim.Gratz@stromeko.de>,\n Ben Collins <bcollins@watter.com>, x86@kernel.org,\n linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,\n linux-wireless@vger.kernel.org, netdev@vger.kernel.org,\n linux-rtc@vger.kernel.org","Subject":"Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED()","Message-ID":"<20260428114342.0d674fd8@pumpkin>","In-Reply-To":"<afBdXj_9r25Ssnz6@ashevche-desk.local>","References":"<20260427214127.406067-1-ynorov@nvidia.com>\n\t<20260427214127.406067-8-ynorov@nvidia.com>\n\t<afBdXj_9r25Ssnz6@ashevche-desk.local>","X-Mailer":"Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf)","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"<linux-rtc.vger.kernel.org>","List-Subscribe":"<mailto:linux-rtc+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-rtc+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit"}}]