[{"id":3682955,"web_url":"http://patchwork.ozlabs.org/comment/3682955/","msgid":"","list_archive_url":null,"date":"2026-04-27T20:29:52","subject":"Re: [PATCH 32/41] hw/tpm: free PPI buffer on finalization","submitter":{"id":75097,"url":"http://patchwork.ozlabs.org/api/people/75097/","name":"Stefan Berger","email":"stefanb@linux.ibm.com"},"content":"On 4/27/26 3:42 PM, Marc-André Lureau wrote:\n> The PPI buffer is allocated with qemu_memalign() in instance_init but\n> never freed when the device is destroyed.\n> \n> Fixes: 46cd2c1050f0 (\"hw/tpm: add PPI support to tpm-tis-device for ARM64 virt\")\n> Signed-off-by: Marc-André Lureau \n\nReviewed-by: Stefan Berger \n\n> ---\n> hw/tpm/tpm_tis_sysbus.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c\n> index 6bec30c36fc..891766ee03c 100644\n> --- a/hw/tpm/tpm_tis_sysbus.c\n> +++ b/hw/tpm/tpm_tis_sysbus.c\n> @@ -150,11 +150,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data)\n> set_bit(DEVICE_CATEGORY_MISC, dc->categories);\n> }\n> \n> +static void tpm_tis_sysbus_finalize(Object *obj)\n> +{\n> + TPMStateSysBus *sbdev = TPM_TIS_SYSBUS(obj);\n> + TPMState *s = &sbdev->state;\n> +\n> + qemu_vfree(s->ppi.buf);\n> +}\n> +\n> static const TypeInfo tpm_tis_sysbus_info = {\n> .name = TYPE_TPM_TIS_SYSBUS,\n> .parent = TYPE_DYNAMIC_SYS_BUS_DEVICE,\n> .instance_size = sizeof(TPMStateSysBus),\n> .instance_init = tpm_tis_sysbus_initfn,\n> + .instance_finalize = tpm_tis_sysbus_finalize,\n> .class_init = tpm_tis_sysbus_class_init,\n> .interfaces = (const InterfaceInfo[]) {\n> { TYPE_TPM_IF },\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=gMtNR1AW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4FYl0jdRz1xvV\n\tfor ; Tue, 28 Apr 2026 06:30:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSae-00042I-W2; Mon, 27 Apr 2026 16:30:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSad-000408-NX\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:29:59 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSab-00024m-Uv\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:29:59 -0400","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63RDvMB92585373; Mon, 27 Apr 2026 20:29:55 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drnb52de7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:29:54 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63RKNjxH027316;\n Mon, 27 Apr 2026 20:29:53 GMT","from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dsa5g6nrx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:29:53 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com\n [10.39.53.229])\n by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63RKTr7b33358576\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 20:29:53 GMT","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 300B358059;\n Mon, 27 Apr 2026 20:29:53 +0000 (GMT)","from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id AFD3A58058;\n Mon, 27 Apr 2026 20:29:52 +0000 (GMT)","from [9.47.158.152] (unknown [9.47.158.152])\n by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 27 Apr 2026 20:29:52 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=c6BvwC\n /vnI4urO5zFqjJM5k+9ut1vHGmlzC4/lF1EIQ=; b=gMtNR1AWeur7KOwbg8Vnzb\n 9X7CHmXxaWzru3ILVrsWkKQb6bvneFuPkvrykxAMWo1GckAfDT057wDNNpePiOFw\n vNQR4USnvGVg6bLUaRwWR6zBPYeyTBXJHOS6gq373IB0L8KDP/KxWXWOOpMAUqLX\n 4pqkpK0G1SJG3mhHKXP+srrQs8PPHrYMtO6xW5uOaxWzGs1J50U3X6dm3/4CymMC\n d2YCL8jEQiLqgLaALj9SkVQUk1zm1Kx+foAXPG5lnZxojOqzmGO4zUfGhPKZJs21\n ZmmQB+BlRtHJX4kT8jO4ttlV4HrL81HpULpoj7XwYkXp3PPTHASysjZVgeyP5WIg\n ==","Message-ID":"","Date":"Mon, 27 Apr 2026 16:29:52 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 32/41] hw/tpm: free PPI buffer on finalization","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Stefan Berger ","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-32-c413f3605311@redhat.com>","Content-Language":"en-US","From":"Stefan Berger ","In-Reply-To":"<20260427-qom-tests-v1-32-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=AqDeGu9P c=1 sm=1 tr=0 ts=69efc742 cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=20KFwNOVAAAA:8\n a=VnNF1IyMAAAA:8 a=3YzR4anQ7WAeTY_66tUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI3MDIxNiBTYWx0ZWRfX70xV6zhrpgCI\n Whx6/u56u51q+LDUv6K+VP5onLT6Gh2k4Qn9KpqnERIhsMMRBVi0j36xzvtlRmVGC4t60O+UhNS\n y2rCs3SEv/yHkrJQ3irXFV/qq0k/RfBf4EWWWpGDhgtexhRVhr0myE+QMJqtnYaLKofjTAcBT1b\n xuW8+63ynHXviWJU+qlKjGiSDaNSG6MXnTRIlmAa/tFIK1B1lyi7CCdlNwJJLp3swwHHdILvQ9Z\n qdI5DNy5cSc4gOSzFfTC29D7lq9/JJ+jCoCRrXu8/z8rGOHSTKz8wVRDosH+VWd5aD0m0EFrtou\n CMnutZs/Q3fXlXEVSbczdzkvrKMUge6pNK5FZMiuhUyJEsWiUbcgVTDYbShdra8QRoeIN6mz1/2\n E6zaLlySYnSD+ejJdy2iJaBMmQ6lErH9Io3SuXNuM30RrDgEe0FSvHscWnRLlOCKyTTJyd0drrb\n 7oit8UMVmQ2HefpXRdQ==","X-Proofpoint-GUID":"KUHF9owHL20JkVV3yiTAxssDzjo0DBv6","X-Proofpoint-ORIG-GUID":"KUHF9owHL20JkVV3yiTAxssDzjo0DBv6","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015\n lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270216","Received-SPF":"pass client-ip=148.163.156.1;\n envelope-from=stefanb@linux.ibm.com;\n helo=mx0a-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]