[{"id":3682947,"web_url":"http://patchwork.ozlabs.org/comment/3682947/","msgid":"<43155ca34a6d250c8ed455a7c78887e1dfc62283.camel@linux.ibm.com>","list_archive_url":null,"date":"2026-04-27T20:20:33","subject":"Re: [PATCH 37/41] hw/ppc/pnv: drop extra ref on PHB after adding as\n child","submitter":{"id":88361,"url":"http://patchwork.ozlabs.org/api/people/88361/","name":"Miles Glenn","email":"milesg@linux.ibm.com"},"content":"Reviewed-by: Glenn Miles \n\nThanks,\n\nGlenn\n\nOn Mon, 2026-04-27 at 23:42 +0400, Marc-André Lureau wrote:\n> object_new() returns an object with refcount 1, and\n> object_property_add_child() adds another reference. The initial\n> reference must be dropped so the parent becomes the sole owner,\n> otherwise the PHB objects leak when the chip is destroyed.\n> \n> Fixes: 0d512c7120a2 (\"ppc/pnv: turn chip8->phbs[] into a PnvPHB* array\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/ppc/pnv.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\n> index 524563dcfc2..476255b722f 100644\n> --- a/hw/ppc/pnv.c\n> +++ b/hw/ppc/pnv.c\n> @@ -1590,6 +1590,7 @@ static void pnv_chip_power8_instance_init(Object *obj)\n> */\n> object_property_add_child(obj, \"phb[*]\", phb);\n> chip8->phbs[i] = PNV_PHB(phb);\n> + object_unref(phb);\n> }\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=HEHOZEad;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4FLv1zrfz1yHX\n\tfor ; Tue, 28 Apr 2026 06:20:55 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSRe-0001E5-EP; Mon, 27 Apr 2026 16:20:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSRa-0001DA-SH; Mon, 27 Apr 2026 16:20:39 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSRZ-0008SE-C2; Mon, 27 Apr 2026 16:20:38 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63R7oEY61895497; Mon, 27 Apr 2026 20:20:35 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drm1dsgn4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:20:35 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63RK8jdj017154;\n Mon, 27 Apr 2026 20:20:34 GMT","from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds9eh6qfp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:20:34 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com\n [10.241.53.105])\n by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63RKKXZw25756280\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 20:20:33 GMT","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id D69D35805D;\n Mon, 27 Apr 2026 20:20:33 +0000 (GMT)","from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 7F82C58043;\n Mon, 27 Apr 2026 20:20:33 +0000 (GMT)","from mambor8.rchland.ibm.com (unknown [9.10.239.198])\n by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 27 Apr 2026 20:20:33 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:reply-to:subject:to; s=pp1;\n bh=45xQP5OgGv8NwGuTvXtuISloDiOZ34uXHQNkR0hBd78=; b=HEHOZEadUK/A\n IleM5Np2X38KDzcvmmllslDTdNgWwwjSm27hLQalTxmxeaECRhQQ1E6mYbiJ68J7\n MFZczQW9h4xmm5jh2p353ZESw+uA3I/sliVVuws16y6t297lwXQHI+jnx+HGivfI\n 0qm8xDOlTw0QvXMBFt9miIQL2dVyJTnw6VBiUTLYijWF81gBbWSrQCb8wPHVO3C6\n GdLOpHvaHkRKPN3FRR3r5p0mXrNEiv1bbI+GWQtfNh2tB7H1xTMMkwlNERWIQzPf\n 7KHXVzp3uUYxrNoXy3hqyFCSaLcFl6aCfc8TpO3YuC1JGk23BQWxPyZ8SAldGrtu\n Zx0SOiw6GA==","Message-ID":"<43155ca34a6d250c8ed455a7c78887e1dfc62283.camel@linux.ibm.com>","Subject":"Re: [PATCH 37/41] hw/ppc/pnv: drop extra ref on PHB after adding as\n child","From":"Miles Glenn ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Nicholas Piggin , Aditya Gupta\n , qemu-ppc@nongnu.org","Date":"Mon, 27 Apr 2026 15:20:33 -0500","In-Reply-To":"<20260427-qom-tests-v1-37-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-37-c413f3605311@redhat.com>","Organization":"IBM","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5 (3.28.5-27.el8_10) ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"RXtfZXaKhfguhi-nNvKYlhp6AuZKJC3o","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI3MDIxNiBTYWx0ZWRfX6GlOioOcgW2U\n b1C61SdIxOduyuXA15RO393HVL3rA5Z0yeVlnGq5LK51hMpAHE3P5HLIMA9/iObgUWtahLD89Za\n 5l80a9LtkSeEzff7OSzhCRGulD51HrXNXH6w8N5RHfYxxk6Ay9R2LvVXt/h2u6XaWBR8asTdxEp\n p+AfttPa6BAGFce6cvLfcvIBIhXoOPaHKDVBY3pDZIbGz12dJL5EwigVsx57YHSSZVwmh5YAjoE\n 3pP7vdHHP7wqMQ8KM4I8LGeYCehCZCndWxfB14eFCiUFRxQgEan1qVcDN+ec5QcP2UE25YDusYD\n ZpEza7PF9QmM0RXnCcgBBYKAR+ixJsf5RorIMujS883gaVQq0NmndpVKt071X0lj+ziiNHWTFcO\n 8YZYNOgSqy6rOV9oo6nM47oNLpW9VGJ5tnyd4F5vej0rkS5K4GiZG/w5z4hzckJREcCReFSO3C6\n J09IUkyslG/cyHx12ig==","X-Authority-Analysis":"v=2.4 cv=VZLH+lp9 c=1 sm=1 tr=0 ts=69efc513 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=uozdTTcig5jTw1E28QsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-GUID":"domT5kWHgwWAPCJoMN_QfccbVeBpVcLH","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1011 suspectscore=0 adultscore=0 lowpriorityscore=0 phishscore=0\n spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270216","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=milesg@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"milesg@linux.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]