[{"id":3682946,"web_url":"http://patchwork.ozlabs.org/comment/3682946/","msgid":"<9b37c70b975e5633c7532fd2fe278024b01cd604.camel@linux.ibm.com>","list_archive_url":null,"date":"2026-04-27T20:19:32","subject":"Re: [PATCH 30/41] hw/gpio/pca9552: fix state_str leak in\n pca955x_set_led","submitter":{"id":88361,"url":"http://patchwork.ozlabs.org/api/people/88361/","name":"Miles Glenn","email":"milesg@linux.ibm.com"},"content":"Reviewed-by: Glenn Miles \n\nThanks,\n\nGlenn\n\nOn Mon, 2026-04-27 at 23:42 +0400, Marc-André Lureau wrote:\n> visit_type_str() allocates state_str, but the function never frees it\n> on any code path. Use g_autofree to ensure it is freed on return.\n> \n> Fixes: a90d8f84674d (\"misc/pca9552: Add qom set and get\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/gpio/pca9552.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c\n> index dd3f1536b65..472d8ad9571 100644\n> --- a/hw/gpio/pca9552.c\n> +++ b/hw/gpio/pca9552.c\n> @@ -342,7 +342,7 @@ static void pca955x_set_led(Object *obj, Visitor *v, const char *name,\n> PCA955xState *s = PCA955X(obj);\n> int led, rc, reg, val;\n> uint8_t state;\n> - char *state_str;\n> + g_autofree char *state_str = NULL;\n> \n> if (!visit_type_str(v, name, &state_str, errp)) {\n> return;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=iSPwiE/Q;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4FLk1Lbfz1yJX\n\tfor ; Tue, 28 Apr 2026 06:20:46 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSR5-0000yd-SQ; Mon, 27 Apr 2026 16:20:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSQe-0000w4-RK; Mon, 27 Apr 2026 16:19:45 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHSQb-000860-MJ; Mon, 27 Apr 2026 16:19:40 -0400","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63REMnhD2648672; Mon, 27 Apr 2026 20:19:34 GMT","from ppma22.wdc07v.mail.ibm.com\n (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4drn8v9cjp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:19:34 +0000 (GMT)","from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id\n 63RK8kc0027686;\n Mon, 27 Apr 2026 20:19:34 GMT","from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8])\n by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4ds8avpvsp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Mon, 27 Apr 2026 20:19:33 +0000 (GMT)","from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com\n [10.39.53.233])\n by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63RKJXjQ18612968\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Mon, 27 Apr 2026 20:19:33 GMT","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 0887A58056;\n Mon, 27 Apr 2026 20:19:33 +0000 (GMT)","from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 790DF5803F;\n Mon, 27 Apr 2026 20:19:32 +0000 (GMT)","from mambor8.rchland.ibm.com (unknown [9.10.239.198])\n by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Mon, 27 Apr 2026 20:19:32 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:reply-to:subject:to; s=pp1;\n bh=RRkCyPPWZQc2UQa/7gd8crIYR71gGvfkIJcPEYFWZ+I=; b=iSPwiE/Q1AJD\n CGLecZR8HY9fEHqUuYpvrBEjni1J74NZC5XTft4zHpIKhYuEIW/5whqAF/O1RmN1\n SA4bwW+DEEp1VDLZrXT4sU08ioGw+IiOORgMIq+vRLiu81g7S/BQolh8/UBkeS3E\n 48nkxJFnsDpfuz2NFxWNEZAA4p1r/f7tvOWvEy/aEDTPgmvRSNI1RhvxZ8Tiy9pb\n YQNjoNaTJlwRZERGJ2Y1tiHcGsD6pvpljwM3EIqWXgSzbPVu/U5HF8yRUvj77LeF\n o4KVC58v9yRR92+FaDjHkkwMlSRrIbQKCGA7x7GegqBpr5H7UAwdM5FekeN7S6kt\n h46R1gB9Uw==","Message-ID":"<9b37c70b975e5633c7532fd2fe278024b01cd604.camel@linux.ibm.com>","Subject":"Re: [PATCH 30/41] hw/gpio/pca9552: fix state_str leak in\n pca955x_set_led","From":"Miles Glenn ","To":"=?iso-8859-1?q?Marc-Andr=E9?= Lureau ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, qemu-ppc@nongnu.org, qemu-arm@nongnu.org","Date":"Mon, 27 Apr 2026 15:19:32 -0500","In-Reply-To":"<20260427-qom-tests-v1-30-c413f3605311@redhat.com>","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-30-c413f3605311@redhat.com>","Organization":"IBM","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.28.5 (3.28.5-27.el8_10) ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=CIIamxrD c=1 sm=1 tr=0 ts=69efc4d6 cx=c_pps\n a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8\n a=20KFwNOVAAAA:8 a=ecB0vJ_Esy-Zxr4yp7oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10","X-Proofpoint-ORIG-GUID":"lLPY4Lw42v2eNeebUD1K9lCXOZIivERd","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI3MDIxNiBTYWx0ZWRfXywvXteG69D02\n JR5OpZrvOWlnF30qgmEBUhobiXmk85oFOYhJg4PDoXnxN+8LXOrL2zZ1GSkSz3vorvpzW8qfuKv\n qS7gflueCx2FRtEU/umYxgVmGeoMmgJ/ijaGRYViuhLtbrU003Ul/EVE815EIllDXL7cu4OZDSd\n HOgat7vzOV4VsMrM14JXS6s6jpTbM/saz5Z/VpTpht27Q1YPlI6hISOVu6nzPeQknmiA+Wty8OT\n rKpTcdBiovELG5w+4kgdib0cW02EXaTtLVWulvuGu2Yz6VjnhPpgPq2XsWGaRDWZ/srtfPmL23+\n 3PgKB2bSUFpsaW7HjYXj+YWgcnnEqUumX7+51YCp0yARkldpdg0EgB+1Z09UKLVvvDWoFFUl2/4\n NbHCaqdoFg6Ho/epGMnUDtU3tRkam9lsYHxWx9529M7us++J8roW4ZOTUdSNqkGQOZczRgJR84Z\n 3+2CDw743sciXMqVXaA==","X-Proofpoint-GUID":"lLPY4Lw42v2eNeebUD1K9lCXOZIivERd","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-27_04,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0\n impostorscore=0 lowpriorityscore=0 clxscore=1011 bulkscore=0\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604270216","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=milesg@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"milesg@linux.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3682983,"web_url":"http://patchwork.ozlabs.org/comment/3682983/","msgid":"<85d9d9e9-445d-43f9-928d-dd4906ba716c@linaro.org>","list_archive_url":null,"date":"2026-04-27T20:46:16","subject":"Re: [PATCH 30/41] hw/gpio/pca9552: fix state_str leak in\n pca955x_set_led","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 27/4/26 21:42, Marc-André Lureau wrote:\n> visit_type_str() allocates state_str, but the function never frees it\n> on any code path. Use g_autofree to ensure it is freed on return.\n> \n> Fixes: a90d8f84674d (\"misc/pca9552: Add qom set and get\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/gpio/pca9552.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yMIixyz0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4FyT1SdTz1yHX\n\tfor ; Tue, 28 Apr 2026 06:48:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSri-0004NR-Iu; Mon, 27 Apr 2026 16:47:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHSqY-0004Gu-Ax\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:46:26 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHSqT-000731-6X\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:46:24 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-4891e5b9c1fso91374965e9.2\n for ; Mon, 27 Apr 2026 13:46:20 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a773f1fa0sm10961165e9.14.2026.04.27.13.46.17\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 27 Apr 2026 13:46:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777322779; x=1777927579; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=QTF7Yr6hK79y98oY3+YAgeilETvNKFOVBDJFrBUqMTM=;\n b=yMIixyz0i/Aw8rxXxRUI6r1Y9vO8BWTt2VfPeHEREWPXJIceolEh706HFrO3sjlS6w\n ZhIy0kDYPgLQ4kIgo/VWuMJF5Zk8IbzsJMIPLuhcvffRiLnKM1UQZO0QPrTC4rsqop7U\n N4sv4d7tQBUI9ssNH7pSwRTIdP0Itpuq33ey7Lvd9jOnLXiLfF+Yv/azZmPdOjSIhQxI\n 93UDdSYlORu86xnXCzIwL1jZ3wOL4SUfLanw4mjCg9oHdbYiwlO9tT+qzIY9ohXOsK/f\n pOSe/Cv3dsGT9tzKDZ6wu5x2W2vmpRghAkdqeVgtJ2Xm9BjDmbq7FKIJYF0ZHcLkBfUL\n nu6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777322779; x=1777927579;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=QTF7Yr6hK79y98oY3+YAgeilETvNKFOVBDJFrBUqMTM=;\n b=h+WMOoN3My5GvLwQ7FbQmXfIzFHXKxCo9TI3U0UHNm+9YtjgdAlY6YnnLx7c9sc1Qz\n rqqiD67fAlIO/iwoUdVzpz14/TnFLaKBSgNR0LrQ5Db5+gQ80v6+jk2cndOsOP+Kwa/H\n T+0I4xiO+DPzpH6lcZvdUXnwEk9ucoNV7OGFRX40L1Rd7oYGDSegALbqBbtxq8aqGjX/\n 8qOSIOo8b2jEKRBTnIsMx3fBj2FMIwsnHIyeaqHHKjRfl4ykgN23wlNdg4iX9b5RQ18V\n 9tPiMzfVAXZl1VAdmxy9+9T+VZ1Jqht/11lBs4PH1nna2NLd0T3I9eYvSShjPA88O37w\n WEHg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/W0Y5jxEBfT7NniQbSNR28W3gbDoCiF/Cr+l5fchVJT7t5rVajpnfxy5vdTmLDt/zqRNEA1YN8rs3x@nongnu.org","X-Gm-Message-State":"AOJu0YxS+bWUU6Ah8uHO9WLYPjMX1s2MeNZJrUiZ9VvIVewLz9ZB/Gkc\n RvCHQTuWk7g2PM+tlhT5pCl7uu09q8/CBGp9EeTESpqfA1VN47yqp+lhOgC7XyzjzNs=","X-Gm-Gg":"AeBDievWLNAG2dX34FsPb31Lvwblieg83xrHmr/vBld0VCK/Qz9hMTanw2llMywfh2a\n USaHgf6RxTaAfi8taTkjC0XweIzNrCNPEpGkqeau6zW9e3GqAkF80JznxCGDH2t++SHP26KbSh7\n EdJOSSNuMOYNBz0JGRtciwH4L/2m+KHHb5Wo2o9LvwbvG5hVDEVgtsFJ4BHo+II+QZrDklw6Lt3\n WvrgrAP2EnhZRuym0+yjiRkyzPxCXwb7QG+aj4QcrfYAG7Vz9PcWO9MMRyYgAQX3pQFYId2Hr+X\n c3xw4u4eiXt5qcP7Ge3EbDcZ3T+Fbu4stIkDqNnggji9L7wZGCQTXwrhlMjOZkbcHGOzCXv21l2\n aT8bD43HOjACUbRAQY2foBkyst6/wdTpwnPmTQW63hkzIaf+0vlW1l5cLNmmrlRrYatRP2EwMpt\n 1zG1ARO8Qj//Zdm2Z+S19behz0nDLFAxfN83pKNpvxNXS7nYnDOBloeR1AIh9ppUm9M3d8xQbpJ\n rqd","X-Received":"by 2002:a05:600c:3541:b0:48a:599a:3716 with SMTP id\n 5b1f17b1804b1-48a77b19ce1mr3149475e9.23.1777322779257;\n Mon, 27 Apr 2026 13:46:19 -0700 (PDT)","Message-ID":"<85d9d9e9-445d-43f9-928d-dd4906ba716c@linaro.org>","Date":"Mon, 27 Apr 2026 22:46:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 30/41] hw/gpio/pca9552: fix state_str leak in\n pca955x_set_led","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Glenn Miles ,\n qemu-ppc@nongnu.org, qemu-arm@nongnu.org","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-30-c413f3605311@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260427-qom-tests-v1-30-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]