[{"id":3682989,"web_url":"http://patchwork.ozlabs.org/comment/3682989/","msgid":"","list_archive_url":null,"date":"2026-04-27T20:50:42","subject":"Re: [PATCH 34/41] hw/arm/virt: free flash devices and OEM strings on\n finalization","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 27/4/26 21:42, Marc-André Lureau wrote:\n> Flash devices created in instance_init via qdev_new() hold an extra\n> reference that is only dropped on sysbus_realize_and_unref(). When the\n> machine is destroyed before realization, the flash objects leak. Also,\n> the oem_id and oem_table_id strings from g_strndup() are never freed.\n> \n> Fixes: 602b458201ff (\"acpi: Permit OEM ID and OEM table ID fields to be changed\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/arm/virt.c | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bA+XaqUd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4G2H34Rcz1xvV\n\tfor ; Tue, 28 Apr 2026 06:51:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSv7-0005pn-Gj; Mon, 27 Apr 2026 16:51:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHSul-0005nv-C8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:50:48 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHSuj-0000FK-2C\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:50:47 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so105066835e9.2\n for ; Mon, 27 Apr 2026 13:50:44 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a77aeb223sm4464845e9.3.2026.04.27.13.50.42\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 27 Apr 2026 13:50:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777323043; x=1777927843; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=nLBjKeevaWO4Kc5sT5HN7jwz2+BINbfgfm07ZBE+LZ4=;\n b=bA+XaqUdueLZkps1z3qDay1ITJ6c+FFnvSnau9NyyBeCJx/RBh7TJlfbWCVyEKMXt3\n IDu2qUm8WLK2uLlXOszLM9AHlj6sjhAO8P1o0+yZy8YAGepQelNfyXhvl47nLKNurUe/\n 9taqPQoZ0xltTE4S7SerCHs4XjAYgk8cq5Ena9yW/FgeKpWSSZyDlZbNYjBuJgAROe5E\n FQd9R3IC6zUJZo9j46xCEowzpY3Bsr/pMWvNIuACzjW2mbhiKcFM0947k24dQwVqOG0x\n 8oZl82tgmyvo482GrCNNw2YzVV4nTSJf0FvVBKeNkseATlAskJAH09qiJawGJuORiEc0\n Pibg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777323043; x=1777927843;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=nLBjKeevaWO4Kc5sT5HN7jwz2+BINbfgfm07ZBE+LZ4=;\n b=U2uWZA31oxT+gLsbYh43Mtqn3JokWkUg16QD4AhEjbUmI3slj+rl4B3HwGgl6vGxCc\n hPhZoAsF+SYgZTy2tAad9HLYLNrpQIHIwISctSAuyLHr4TgF0HRhG4lVONtG+fDVeNEt\n bu2ylYCjf3oviMXhM29HvHKQ/+zArteooFgDMdYJ9ElktCmAeZrwGxbRfJbuIZrUCWrV\n 5CYC+q6XEdjryBsJcFk/w7jCEnnJhEkSiCm7M/V+I91hWmcH+3+xrcUK6xPj4/IXHkIl\n kRNsM+hvsbe5yms9bD4cSfckZkfRhaL4LrGp5BnFckfaJsqE1EDhUiBiQq+osizckhBU\n lVjQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+qkhUXAptOyCboI9af1uH1uVozuA9QKIbooQH/r/7nCOg7b1D7mRezvb7bgjXysS4MHGxZ1/EE1Ky5@nongnu.org","X-Gm-Message-State":"AOJu0YxAN/KSdXRtrqJuN8cTDFOdfFITxVgWoJvfq9/93naMDCkkGbjg\n bjnaYOn8UWwh+wNfsTjUOY6FJM0Ten9qt8iusARAhj8ukHWKtFMjVy1mlFo1UtUQhxo=","X-Gm-Gg":"AeBDiesL9J8DiK5x8eG+fNU+s+voQ1yvI1n6J1uenrYl78nEuSFtv5jkk6d2A0B3Kfm\n CmPYcPbNqY7bOKpXDbIf+Ij/FR6nZhw/lGOKmObMa8Ledx8tNJ09JX5H5LBobbYxRLms+9O1yQT\n UpJDYFQvcIe1AgEFccWK8s2NgJZWZA+XqN9ySEmGXHuQADV8J2dvT68UpNbiTLrMNjbpXyneV7g\n 4RFk2IDzL+RUnpjnYCfVD60miCUCxQIXH3broA2IlJa0MX00i8RsyUiYKUl87NL5nN7RZ5zpzts\n xvFbLikh0Xz6JpqsmHIM+xqu9hnP80Zj4a8AQbAmS4WC6b3m2a5cTH7xC3nPFF4Fj115C6m0OXG\n SnIb368AZaN73G3Kid4PR9B6/kwg1cgT6u6sdtRgxrcUgSLoq/Q1qpj/CuizJdyOCCJzAODIU9p\n YvAV+uTd489nBcN5hP7uzojwamT97JhJtWbAggjUekXH4C4ea5+z61cZdO/PCGTSgoAU3dojdH2\n sLW","X-Received":"by 2002:a05:600c:4444:b0:488:aa33:dcbd with SMTP id\n 5b1f17b1804b1-48a77b22e4dmr3777915e9.26.1777323043529;\n Mon, 27 Apr 2026 13:50:43 -0700 (PDT)","Message-ID":"","Date":"Mon, 27 Apr 2026 22:50:42 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 34/41] hw/arm/virt: free flash devices and OEM strings on\n finalization","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Peter Maydell ,\n qemu-arm@nongnu.org","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-34-c413f3605311@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260427-qom-tests-v1-34-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]