[{"id":3682987,"web_url":"http://patchwork.ozlabs.org/comment/3682987/","msgid":"<2143ed51-4076-45f5-aea1-9e43fbb0ae77@linaro.org>","list_archive_url":null,"date":"2026-04-27T20:49:56","subject":"Re: [PATCH 33/41] hw/arm/sbsa-ref: free unrealized flash devices on\n finalization","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 27/4/26 21:42, Marc-André Lureau wrote:\n> Flash devices are created with qdev_new() in instance_init and added as\n> children, but the initial reference from qdev_new() is only dropped by\n> sysbus_realize_and_unref() during machine init. When the machine object\n> is destroyed before realization (e.g. during qtest device introspection),\n> the flash devices leak.\n\nHmm PFlashCFI01 is opaque, OK.\n\nReviewed-by: Philippe Mathieu-Daudé \n\n> Fixes: e9fdf453240e (\"hw/arm: Add arm SBSA reference machine, devices part\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/arm/sbsa-ref.c | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ljWI9TEb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4G0s1lMcz1xvV\n\tfor ; Tue, 28 Apr 2026 06:50:21 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSuE-0005Kt-T6; Mon, 27 Apr 2026 16:50:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHSu2-0005Gj-Gd\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:50:04 -0400","from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHSty-0008JC-UP\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:50:01 -0400","by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-488a8ca4aadso148609635e9.3\n for ; Mon, 27 Apr 2026 13:49:58 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a77449ce5sm6328845e9.0.2026.04.27.13.49.56\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 27 Apr 2026 13:49:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777322997; x=1777927797; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=K9LQMhbq3UafJT/gSRJmDPNRrwYwFOmC8pKvQuYGvac=;\n b=ljWI9TEbZr9FZwmBlGq4XmlzlsJ502CLphZI0jNiAl1M8cgz4W344QGxF5x33LdJpL\n gtYfUFvZX+10DuudIVv2FB9pDFyXFmXYiL0xPAL2ENW48tG5IN3YfkMPgNrPegzNzP7T\n 0J2Bpwqi6/Qb62HdXXsZVoVbhBWGmIj/7vFHFE5GZxpSoqc0SBMgSA3R/XOxDWLQBdDn\n VKkpOwYNbyc6ewDvjp48gU6R8CyZdcAjOwf9IUJYzGFE0Ocg6hMiTeTo63E+J28g16Qa\n k0imIqqia0UVRKUs5zLSP+abkVCAlN6PgfGSQuHeo5wzfQeuNMWkK2RbxQpg4LsKk3t6\n c9dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777322997; x=1777927797;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=K9LQMhbq3UafJT/gSRJmDPNRrwYwFOmC8pKvQuYGvac=;\n b=lwi0bUhEG9cMJJDGdQ2jOFpib/q8ce35tsFeGqDmBBvFPVmorKjZXRpg84F7Iw7fHh\n H5NP6thZmkrWk0kxqqvE9L5KXgy9pcxcq29H3uTd5Ng2JDCxmK13sx73Y38Jd5X1mmWs\n DZq55OG57/9m2TOBPOoFY4iBb1KKmKxE6Nd9h8wM6EpiQuX/olQn0lohqRVSLVK0NrFx\n A/VKXe907wGNX3xeXWArM4cv4C4J2rsY4U1QTAyE9wKGFcDUFQT+mLAzg+iVsrx4nkjK\n vIKl1xCM5ogzsKqXcYYTDD8U9wLofQaBryoyP38LCFx5pP0DkHvQFQhVBbIgWBui8csH\n /y3Q==","X-Forwarded-Encrypted":"i=1;\n AFNElJ94du/rj1wvpYYBHSS1eXPruggNw8AbORkwdxYbwJJmIHG7PmsdmxgbjRoAvrVye2pLRhdtLabErsN4@nongnu.org","X-Gm-Message-State":"AOJu0YxQEW937DrzEEnWoFdMJxexsSW2lszDG4GdKNIov+TriHMLfbgp\n IXR8cSiPY01Nay3vwLdaYCEI/TX0duS5uwd3sT7WpLkCj//KHMUiSe5Nt6t6tx+JoL8=","X-Gm-Gg":"AeBDieuH63PXWl/P1U/WDjKbneT6rHIJmVtR74JglL1P8X+btBT9mdY79gk2HdhccEW\n ZXKvenodslj+2laNk8moA3jetEPeFSnKtchk5SiLV3siNDDTta3xi4QrWf19L78HI1h+FHe+7PZ\n OB7H31vX9vdZDE/udAhPpUEy0AdyhKZS3yhVnDdpFvXVCIvaCKMNZifqKudVQ8paGLRKZqDwS6Z\n co9HOfrQXFdeO2PFd2Rvrax3ogI6TnihjTpGQxXTA9BIQ5pr43NSUKJ/xWAxXW4NIDArKl9Xg6I\n j4/yw9i6XUPMLYiyeqA03sQUpNFa6/OFQ4sU+E3aXSXb7eGp41gZcVm8U6RYw7/IBek3MlKtX7n\n +S2sXa71vzwVGKVfGCp9SPZ9gBE64JZQtcuC7XuJA3QV5oSLgd/aFhXcTLrMw+dSP47TMlK8rF7\n 7jTGZervfdWC+ClTG92pndYN4V0qF7phZjTNnb0rYBopp4/lpSiM/FtPCChr3eDUTqn+9ovE3AF\n bD7","X-Received":"by 2002:a05:600c:8b52:b0:488:a882:c7 with SMTP id\n 5b1f17b1804b1-48a77b1a4aemr3298595e9.25.1777322997325;\n Mon, 27 Apr 2026 13:49:57 -0700 (PDT)","Message-ID":"<2143ed51-4076-45f5-aea1-9e43fbb0ae77@linaro.org>","Date":"Mon, 27 Apr 2026 22:49:56 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 33/41] hw/arm/sbsa-ref: free unrealized flash devices on\n finalization","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-33-c413f3605311@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260427-qom-tests-v1-33-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]