[{"id":3683154,"web_url":"http://patchwork.ozlabs.org/comment/3683154/","msgid":"","list_archive_url":null,"date":"2026-04-28T06:55:57","subject":"Re: [PATCH 24/41] backends/igvm-cfg: free filename on finalization","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"On Mon, Apr 27, 2026 at 11:42:23PM +0400, Marc-André Lureau wrote:\n> set_igvm allocates filename via g_strdup, but igvm_cfg_finalize\n> did not free it.\n> \n> Fixes: c1d466d267cf (\"backends/igvm: Add IGVM loader and configuration\")\n> Signed-off-by: Marc-André Lureau \n\nReviewed-by: Gerd Hoffmann ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iGQRRFJd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4WSl094bz1xvV\n\tfor ; Tue, 28 Apr 2026 16:56:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHcMh-00058T-9C; Tue, 28 Apr 2026 02:56:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHcMc-000580-N4\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 02:56:10 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHcMa-0004uK-4R\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 02:56:10 -0400","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-QsNa_JzYNHyW1smsn5qN3w-1; Tue,\n 28 Apr 2026 02:56:01 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id D8C911956095\n for ; Tue, 28 Apr 2026 06:56:00 +0000 (UTC)","from dobby.home.kraxel.org (unknown [10.44.48.15])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 67251195608E; Tue, 28 Apr 2026 06:56:00 +0000 (UTC)","by dobby.home.kraxel.org (Postfix, from userid 1000)\n id 8C2E9751B9D; Tue, 28 Apr 2026 08:55:57 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777359365;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=lkI8N992PCShkGc4v+prXnaxjYnHT4U2KkfjeKSO6ZM=;\n b=iGQRRFJdekYeZ3Wr4FLn1ex/+zb1y0qe6duoycCJovnevAoxAjYg1Xpq4vdmsqTd8QzIBP\n Y9dIDmNQ30e5sBudKsLkl1hJ2WtmFsmNphSLbhvrlRMroSuqETX9cY4Hh3dW09WqetPQw7\n Fbq9Ca2Gb1jcb2RV8OQSsrBZ07P1Cjw=","X-MC-Unique":"QsNa_JzYNHyW1smsn5qN3w-1","X-Mimecast-MFC-AGG-ID":"QsNa_JzYNHyW1smsn5qN3w_1777359361","Date":"Tue, 28 Apr 2026 08:55:57 +0200","From":"Gerd Hoffmann ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","Cc":"qemu-devel@nongnu.org, armbru@redhat.com,\n Stefano Garzarella , Ani Sinha ","Subject":"Re: [PATCH 24/41] backends/igvm-cfg: free filename on finalization","Message-ID":"","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-24-c413f3605311@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260427-qom-tests-v1-24-c413f3605311@redhat.com>","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]