[{"id":3682977,"web_url":"http://patchwork.ozlabs.org/comment/3682977/","msgid":"","list_archive_url":null,"date":"2026-04-27T20:41:33","subject":"Re: [PATCH 15/41] hw/i386/x86: free oem_id and oem_table_id on\n finalization","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 27/4/26 21:42, Marc-André Lureau wrote:\n> x86_machine_initfn allocates oem_id and oem_table_id via g_strndup,\n> but no instance_finalize existed for x86_machine_info, so these\n> strings were never freed when the object was destroyed.\n> \n> Add x86_machine_finalize to release both fields.\n> \n> Fixes: d07b22863b8e (\"acpi: Move setters/getters of oem fields to X86MachineState\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> hw/i386/x86.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JSwRgaNa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Fqb1dZwz1yJX\n\tfor ; Tue, 28 Apr 2026 06:42:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHSm5-000241-Og; Mon, 27 Apr 2026 16:41:49 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHSlx-0001vc-Sj\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:41:41 -0400","from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wHSlt-0004qM-Si\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 16:41:41 -0400","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-4891f625344so96550515e9.0\n for ; Mon, 27 Apr 2026 13:41:35 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a77b29487sm3919015e9.13.2026.04.27.13.41.33\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 27 Apr 2026 13:41:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777322494; x=1777927294; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=REanicuq2dKImBx/Bu/a09lwhy+WZUiQ+xOmbwRpLsc=;\n b=JSwRgaNadHOzgwOxOyMk1eXGduvmdHnr6gKHWDONGaWfDw/Oz1JSW9C0jtBpS7lcwv\n dUTJ002md5kw9UlkTuabqhhuJGjtw66+k/6TQ6cnpvgLLmNBFyXxff1zvYtndTjvyenO\n /b2oBlCwaKfg1oO+aFFsu+QkM0PjXDOV9dS80Y8BaO8q0Av2xF02a38CqSAlHFsThKFq\n OZCfyJLVnVHAMuIlgr2wcsKLkxP2v91Ht6FVuFPD95v7kJ0HK4zVW0ReHt+O6Emp0iNZ\n EBtHa8Hpv7k+dbw6Y1/AosIqoaRq6zrlvndGBdMz2QfYJT0jAf4vsW2QAnnMuwbbtTBI\n jDVg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777322494; x=1777927294;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=REanicuq2dKImBx/Bu/a09lwhy+WZUiQ+xOmbwRpLsc=;\n b=dxDDfJKp9KhPrS6l62hqN9tK/8tA0jdB/Mo2pQzEPOWjyxiWZbwyybV8L1YE0WB5zq\n WMnhFWB4a06gsJVI0ddwdyOXEQ6e1yUB2lS9ClXaJXRvn0w7woWqMZkoSsIAS/VH4nKS\n lG/zh2KKnaF7pJ2fR42ruENlDDfU/uYOQmowZDkFuih5yATun1t9BMRpK+JooEI3NR7N\n m4z1TIDRSbW1usAaaGScVeZYVuJWXCsaxqSWwLjqXTL6c9rFDcllKMAAkQhCmWfBmOi5\n dIjUL/of+z5A++3VIU6+VY+S1PwTeegyKvDeqwqfotdsTSlkS1oqj0PRcTGakMcqk+Al\n RUVw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8OxZ/ttR+sOVpZ3TJgqcijmjcHCn9Q69p69/EbPK0MWDskBK9rmf9nhdIjtTkWcEe/sKiP1oNrM/Pt@nongnu.org","X-Gm-Message-State":"AOJu0YxPGcUXFuD6aLo/LL+rK6rlcgCAtCai2PYx/kTK941niTbEsVZS\n 1VcD4opgALkIFdcxhRZWad3JDqOZ76/ZEFBwsulteIEOgZJw+WVlS9xw1Zh4TNcIlxU=","X-Gm-Gg":"AeBDieuh9MMqQgATXI5eGFX0jyV448SmnkSGeuNEDpkZ3s2zVyeguIEBNDHFsleB6xK\n 9XjuSOBhWri/+rxhXT5OsIEk7OydAZtl/FeNfvwdqnWKueaH7sP+oKSGWY7UzoOFFcYkLvsoV/a\n QyUeearCbbQ9IHbTLu95SI2A1+jeqmiaDfyBKo34QvQ1mka217w2PTikhgCSF0QVI80IoGk5mXT\n uNxAEhu9mF1OhkD9qUSnoPYoaxHA8nfKaGuOJU9s+MN7s25eQbZ7vEm64NuzZrxuiacOC+C53AC\n E1c+b7DsoJIQUjwVlMS+UWoeveaFtQq6rRVnhzvC1PejfUHyxvQgciBcx98W8pbepKkP8/TC6D+\n lx/Z3IGH7/6ycQose+vP4beFjGcn9Mp4CAFMnY5oR9iL03YsLBRP4e9ab2RwBFri4tB1EkFzs2E\n 1X06mDhUB37AgUveGWMf2KLAajmfMoWO8LN0ppxRSMUgpTcwMMT8inhqsoWVoW3alOEHsp4jdtv\n NCx","X-Received":"by 2002:a05:600d:8451:b0:489:1abb:5559 with SMTP id\n 5b1f17b1804b1-48a77e4243dmr2565265e9.5.1777322494489;\n Mon, 27 Apr 2026 13:41:34 -0700 (PDT)","Message-ID":"","Date":"Mon, 27 Apr 2026 22:41:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 15/41] hw/i386/x86: free oem_id and oem_table_id on\n finalization","Content-Language":"en-US","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, Paolo Bonzini ,\n Richard Henderson ,\n \"Michael S. Tsirkin\" ","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-15-c413f3605311@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260427-qom-tests-v1-15-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32c;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]