[{"id":3683052,"web_url":"http://patchwork.ozlabs.org/comment/3683052/","msgid":"","list_archive_url":null,"date":"2026-04-28T00:05:32","subject":"Re: [PATCH 10/41] backends/cryptodev-lkcf: skip cleanup when not\n initialized","submitter":{"id":92260,"url":"http://patchwork.ozlabs.org/api/people/92260/","name":"zhenwei pi","email":"zhenwei.pi@linux.dev"},"content":"On 4/28/26 03:42, Marc-André Lureau wrote:\n> cryptodev_lkcf_cleanup() locks a mutex that is only initialized\n> during the init vfunc (called at realize time). When the backend\n> is destroyed without ever being realized, the mutex is uninitialized\n> and the lock aborts.\n> \n> Return early from cleanup when the backend was never started.\n> \n> Note: it looks like cryptodev init/cleanup callbacks should rather be\n> regular complete/finalize overrides (calling the parent method).\n> \n> Fixes: 39fff6f3e8b3 (\"cryptodev: Add a lkcf-backend for cryptodev\")\n> Signed-off-by: Marc-André Lureau \n> ---\n> backends/cryptodev-lkcf.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c\n> index 40c7bd3c5a0..74db03fe96b 100644\n> --- a/backends/cryptodev-lkcf.c\n> +++ b/backends/cryptodev-lkcf.c\n> @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *backend, Error **errp)\n> CryptoDevBackendClient *cc;\n> CryptoDevLKCFTask *task, *next;\n> \n> + if (!lkcf->running) {\n> + return;\n> + }\n> +\n> qemu_mutex_lock(&lkcf->mutex);\n> lkcf->running = false;\n> qemu_mutex_unlock(&lkcf->mutex);\n> \n\n'lkcf->running' is used for synchronization between main thread and LKCF \nworks, 'backend->ready' indicates the status of cryptodev, so I prefer \nthe following code instead:\n\nif (!cryptodev_backend_is_ready(backend)) {\n return;\n}","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=N8TuQwan;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4LMf4VPRz1yHX\n\tfor ; Tue, 28 Apr 2026 10:06:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHVxf-0006Gr-E1; Mon, 27 Apr 2026 20:05:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHVxd-0006GU-Hm\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 20:05:57 -0400","from out-181.mta0.migadu.com ([2001:41d0:1004:224b::b5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHVxb-0001BX-7m\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 20:05:57 -0400"],"Message-ID":"","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;\n t=1777334739;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=P7WQhkzQJOrWeev/cPEXm7+vLufk9ScMPC18T7PlSjg=;\n b=N8TuQwanG8KZntvBbetua5h1MMcJvdotJsMQvmI8jHFA5PMgjS2fyD20Rs6fJ3C9VQqmTk\n FPHTzNnHd45X2k/nc8RGyDBrklxGiHWX2oz8tBbxw+H1zOrdSJcGsQye0AMiNhEZ5u77W4\n Pc29TJlWHCUtLA4s5eS8OXp6deddm8A=","Date":"Tue, 28 Apr 2026 08:05:32 +0800","MIME-Version":"1.0","Subject":"Re: [PATCH 10/41] backends/cryptodev-lkcf: skip cleanup when not\n initialized","To":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n qemu-devel@nongnu.org","Cc":"armbru@redhat.com, \"Gonglei (Arei)\" ","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-10-c413f3605311@redhat.com>","Content-Language":"en-US","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"zhenwei pi ","In-Reply-To":"<20260427-qom-tests-v1-10-c413f3605311@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Migadu-Flow":"FLOW_OUT","Received-SPF":"pass client-ip=2001:41d0:1004:224b::b5;\n envelope-from=zhenwei.pi@linux.dev; helo=out-181.mta0.migadu.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]