[{"id":3683239,"web_url":"http://patchwork.ozlabs.org/comment/3683239/","msgid":"<202604281025.37014.pisa@fel.cvut.cz>","list_archive_url":null,"date":"2026-04-28T08:25:36","subject":"Re: [PATCH 23/41] net/can: free ifname on socketcan finalization","submitter":{"id":79714,"url":"http://patchwork.ozlabs.org/api/people/79714/","name":"Pavel Pisa","email":"pisa@fel.cvut.cz"},"content":"Hello Marc-André,\n\nthanks for the catch of the missing free\n\nOn Monday 27 of April 2026 21:42:22 Marc-André Lureau wrote:\n> can_host_socketcan_set_if allocates ifname via g_strdup, but no\n> instance_finalize existed to free it.\n>\n> Fixes: ea15ea8a7c67 (\"net/can: support for connecting to Linux host\n> SocketCAN interface.\") Signed-off-by: Marc-André Lureau\n> \n> ---\n> net/can/can_socketcan.c | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c\n> index 8a57ae07178..be67ed7f5a9 100644\n> --- a/net/can/can_socketcan.c\n> +++ b/net/can/can_socketcan.c\n> @@ -319,11 +319,19 @@ static void can_host_socketcan_class_init(ObjectClass\n> *klass, chc->disconnect = can_host_socketcan_disconnect;\n> }\n>\n> +static void can_host_socketcan_finalize(Object *obj)\n> +{\n> + CanHostSocketCAN *c = CAN_HOST_SOCKETCAN(obj);\n> +\n> + g_free(c->ifname);\n> +}\n> +\n> static const TypeInfo can_host_socketcan_info = {\n> .parent = TYPE_CAN_HOST,\n> .name = TYPE_CAN_HOST_SOCKETCAN,\n> .instance_size = sizeof(CanHostSocketCAN),\n> .instance_init = can_host_socketcan_instance_init,\n> + .instance_finalize = can_host_socketcan_finalize,\n> .class_init = can_host_socketcan_class_init,\n> };\n\nAcked-by: Pavel Pisa \n\nBest wishes,\n\n Pavel\n\n Pavel Pisa\n phone: +420 603531357\n e-mail: pisa@cmp.felk.cvut.cz\n Department of Control Engineering FEE CVUT\n Karlovo namesti 13, 121 35, Prague 2\n university: http://control.fel.cvut.cz/\n personal: http://cmp.felk.cvut.cz/~pisa\n social: https://social.kernel.org/ppisa\n projects: https://www.openhub.net/accounts/ppisa\n CAN related:http://canbus.pages.fel.cvut.cz/\n RISC-V education: https://comparch.edu.cvut.cz/\n Open Technologies Research Education and Exchange Services\n https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=fel.cvut.cz header.i=@fel.cvut.cz header.a=rsa-sha256\n header.s=felmail header.b=omApbhxx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4YS15Kx1z1xvV\n\tfor ; Tue, 28 Apr 2026 18:26:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHdlP-0005nu-F7; Tue, 28 Apr 2026 04:25:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wHdlM-0005nS-B6\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:25:49 -0400","from smtpx.feld.cvut.cz ([2001:718:2:1516::210:153]\n helo=smtpx.fel.cvut.cz)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_CHACHA20_POLY1305:256)\n (Exim 4.90_1) (envelope-from ) id 1wHdlJ-0001oU-TW\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:25:48 -0400","from localhost (unknown [192.168.200.27])\n by smtpx.fel.cvut.cz (Postfix) with ESMTP id C0C852F07A;\n Tue, 28 Apr 2026 10:25:39 +0200 (CEST)","from smtpx.fel.cvut.cz ([192.168.200.2])\n by localhost (cerokez-250.feld.cvut.cz [192.168.200.27]) (amavis, port 10060)\n with ESMTP id hHmkLup_7MoP; Tue, 28 Apr 2026 10:25:38 +0200 (CEST)","from baree.pikron.com (static-84-242-78-234.bb.vodafone.cz\n [84.242.78.234])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: pisa)\n by smtpx.fel.cvut.cz (Postfix) with ESMTPSA id ECFFE2F079;\n Tue, 28 Apr 2026 10:25:37 +0200 (CEST)"],"X-Virus-Scanned":"IMAP STYX AMAVIS","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=fel.cvut.cz;\n s=felmail; t=1777364738;\n bh=0jcRybkN6G5z/JK+FLZiqhP5P9CmBDxt/1E9pkxbQh0=;\n h=From:To:Subject:Date:Cc:References:In-Reply-To:From;\n b=omApbhxxx6dnf8H+X+d6NB25YqeCEeCxF1Pvt4q/C6c9vQHyNhbiM1TjpKEfYZZ7Z\n HdsI6JP6zE2Nwf7ettf55WEFAjL9mPBjS4/dJVR+qAdAsusnQ3z3Z1Y3vNhn6muunM\n Zumcxxzt4ckV+KJVHHNLwxuVdE38naZ2io9VjrYWW8J2O7Ejp++xXkuCTvWYJbGuGN\n iCp7e9j4mHxgORnwDQy1Yz6oQFcHXHg9PTAy11J21ieSjF55dIG6RPl1HGkOEaWxAS\n PlTOwVvCTe97EpsMDzrfwJMe0YfcbbFzhU/ZOUqQ69adkr52NrUA8bQUKDaMD3Uxe0\n xTGO7HD9TeHhA==","From":"Pavel Pisa ","To":"\" =?utf-8?q?Marc-Andr=C3=A9?= Lureau\" ","Subject":"Re: [PATCH 23/41] net/can: free ifname on socketcan finalization","Date":"Tue, 28 Apr 2026 10:25:36 +0200","User-Agent":"KMail/1.9.10","Cc":"qemu-devel@nongnu.org, armbru@redhat.com,\n Francisco Iglesias ,\n Vikram Garhwal ,\n Jason Wang ","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-23-c413f3605311@redhat.com>","In-Reply-To":"<20260427-qom-tests-v1-23-c413f3605311@redhat.com>","X-KMail-QuotePrefix":"> ","MIME-Version":"1.0","Content-Type":"Text/Plain;\n charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","Content-Disposition":"inline","Message-Id":"<202604281025.37014.pisa@fel.cvut.cz>","Received-SPF":"pass client-ip=2001:718:2:1516::210:153;\n envelope-from=pisa@fel.cvut.cz; helo=smtpx.fel.cvut.cz","X-Spam_score_int":"-33","X-Spam_score":"-3.4","X-Spam_bar":"---","X-Spam_report":"(-3.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.387,\n SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]