[{"id":3683166,"web_url":"http://patchwork.ozlabs.org/comment/3683166/","msgid":"","list_archive_url":null,"date":"2026-04-28T07:05:00","subject":"Re: [PATCH 11/41] RFC io/net-listener: move mutex init to\n instance_init","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Mon, Apr 27, 2026 at 11:42:10PM +0400, Marc-André Lureau wrote:\n> The QIONetListener mutex is initialized in the convenience\n> constructor qio_net_listener_new() rather than in an instance_init.\n> This means a bare object_new(TYPE_QIO_NET_LISTENER) produces an\n> object with an uninitialized mutex, but instance_finalize\n> unconditionally calls qemu_mutex_destroy() on it, which aborts.\n> \n> Move the mutex initialization to a proper instance_init so that init\n> and finalize are always paired regardless of how the object is\n> created.\n> \n> This patch is just added for completeness, but \"qio: Fix\n> qom-list-properties crash on net listener object\" from Peter Xu is\n> basically the same.\n> \n> Fixes: 9d86181874a (\"qio: Protect NetListener callback with mutex\")\n> Cc: peterx@redhat.com\n> Signed-off-by: Marc-André Lureau \n> ---\n> io/net-listener.c | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n\nReviewed-by: Daniel P. Berrangé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=f1u7pw+n;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=QBaGAeAi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Wfl4QlVz1yHX\n\tfor ; Tue, 28 Apr 2026 17:05:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHcVL-0007VT-Tk; Tue, 28 Apr 2026 03:05:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHcVJ-0007V5-Kz\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 03:05:09 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHcVI-00084m-1f\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 03:05:09 -0400","from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-260-b8YM6PdQMmCvVg1WADjnwA-1; Tue, 28 Apr 2026 03:05:04 -0400","by mail-qk1-f200.google.com with SMTP id\n af79cd13be357-8d3ea68b9cdso2122227285a.3\n for ; Tue, 28 Apr 2026 00:05:04 -0700 (PDT)","from redhat.com ([2a02:8012:f011:0:f1ce:ac56:d2cd:7c2e])\n by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8f7c49c0993sm142261485a.6.2026.04.28.00.05.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 00:05:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777359906;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=+wmsyHNiym4ZauabkM84A/vR/ijgjrBaGACcvxDnE3o=;\n b=f1u7pw+nthsqEwFAi5xeqH3J2IW4tx0sdMgelmvO8wf1HBuMseljNOCmbyesAg7dmW9/jT\n CBPzM1HUw1CgguDoTygXRmm0ku092s2i72RuS+Re2bPfJxpUp3Mca4rImSUi210l5TRXq+\n d5bdwQ5ewOlvVPSW+r6kgYYnptDkP1M=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777359904; x=1777964704; darn=nongnu.org;\n h=user-agent:in-reply-to:content-transfer-encoding\n :content-disposition:mime-version:references:reply-to:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=+wmsyHNiym4ZauabkM84A/vR/ijgjrBaGACcvxDnE3o=;\n b=QBaGAeAi33ndKw0zMdVOyOoiRoePE/4FXbefAohQDfMZbLXH20alf1t2iIpIUujGFj\n q2aHKRWJCKDQyKKxjfiMxLXEcIoGUJesbEJNRcJ/xuBjgUxzQumZOSzZVfa99ee8P0Ad\n EhpHW0QQt9lbq6pbltDKDvL8lYA4E2zfgBX/0vKP11gF7GBG2WebxAgsgYaRdhVo2UIo\n PpviQnireLZTqIsPSJZrLtZ4p20kMm/mt/YghDQhyn+grpIjWRLKc3Ut3YxeEsnuCo16\n 7/ShH0LIhm5gEhKw2jGbNlpCqc/4pnVPEidi1asB1ly2wmYl/Ss20mnNKeMF2ffmmOnL\n CJBw=="],"X-MC-Unique":"b8YM6PdQMmCvVg1WADjnwA-1","X-Mimecast-MFC-AGG-ID":"b8YM6PdQMmCvVg1WADjnwA_1777359904","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777359904; x=1777964704;\n h=user-agent:in-reply-to:content-transfer-encoding\n :content-disposition:mime-version:references:reply-to:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=+wmsyHNiym4ZauabkM84A/vR/ijgjrBaGACcvxDnE3o=;\n b=r4nxhczEyww+cykj1xM2HhKXtgyDIzoWllMc1bjneGXOZFfwYWEafFiWiX8fJxS3mJ\n TcQycr9PJXM8Pzrc7OBESbCf+LP8l4R6WN14k4YJ1XSQQHULahHdkaNMnJA+CMgjqJIW\n nCKLzcy5JeoGgk3dC7LVaqFhjGxAdhj+Uj9DAGqN8WF/J6nimRl987YIkJorrADm+sSL\n xpQOgZmHdJZYIM2GV64E9b7dYYxmPnXmZrTJ1pw8R6o38Qtk3KVQECbr0zoPBYDmV+Fb\n 6EMDl0a/t7AUpMTZrTaOQWsMrCITAMIEyfHSY+lAEojRRB6N+wlClllDphygQKL4QDJM\n 5ZqA==","X-Gm-Message-State":"AOJu0YxUmmXHGgkZ27QU5kX7Q90+muMxKESKd9Jm2Xt8N4fF9tnHp9Yc\n qt/mN1cB59hB6muh6m57jZtZtqqeF84xSmxkrdCReDLIxX+7qB2TUv+EFMI16gZkx6bPfMtL7Is\n yJZ3QJoRDMTztgnsWJg0WEyeuxDurfjZfMzfcX0MHTa5hAOetTP+GaUuV","X-Gm-Gg":"AeBDieuoZ3Nv4z6lT+Q03yj7BMgCsG67lWngkxZGeXwnlVCUABBHCYzIc/ZB7P5aCCD\n pt1Dd2vlUzBA2FBfROcSnNQrwdf3vbKcqcHWpJg9+ddB18ErwZzIZ9A0P/Oxhf2mLkfW8N4eUcJ\n BD56BY8eY+gBM0xil7kVWTZH8YeLRg48Bn1O9qdKH7rhicBQneF5fhR7rtQGN+iBr5y9Ym7DbII\n x/GTTYKU9EYkoHQKlEDwYx16BHtpp6RPWJpzT7urwrijiN2bcg02gZzb21LOGHa4pDJtF6mHMTy\n hbwqZXn6ST0JAGgKeS6CuNHJ1aOCqtBDru+/PwUiCKTf+fBGt/qa5bu6uQkgofoDkpRKfL2mdK8\n ptPODs9Kq/LhdlkUNCkm/WAG/4yu8uzg=","X-Received":["by 2002:a05:620a:404c:b0:8cd:8569:b957 with SMTP id\n af79cd13be357-8f7d99027d7mr229491985a.43.1777359903938;\n Tue, 28 Apr 2026 00:05:03 -0700 (PDT)","by 2002:a05:620a:404c:b0:8cd:8569:b957 with SMTP id\n af79cd13be357-8f7d99027d7mr229488285a.43.1777359903494;\n Tue, 28 Apr 2026 00:05:03 -0700 (PDT)"],"Date":"Tue, 28 Apr 2026 08:05:00 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","Cc":"qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com","Subject":"Re: [PATCH 11/41] RFC io/net-listener: move mutex init to\n instance_init","Message-ID":"","References":"<20260427-qom-tests-v1-0-c413f3605311@redhat.com>\n <20260427-qom-tests-v1-11-c413f3605311@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260427-qom-tests-v1-11-c413f3605311@redhat.com>","User-Agent":"Mutt/2.3.1 (2026-03-20)","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]