[{"id":3683158,"web_url":"http://patchwork.ozlabs.org/comment/3683158/","msgid":"<20260428-jumping-discerning-oarfish-d2caf1@quoll>","list_archive_url":null,"date":"2026-04-28T06:56:04","subject":"Re: [PATCH v2 7/8] ARM: dts: qcom: pm8921: Add USB ID extcon","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Mon, Apr 27, 2026 at 09:34:53PM +0200, Alexandre MINETTE wrote:\n> Add the PM8921 USB ID interrupt as a disabled extcon provider. Boards\n> can enable it when their USB controller consumes the PMIC USB ID state\n> for OTG role detection.\n> \n> The interrupt corresponds to PM8921 USB_ID_IN, block 6 bit 1.\n> \n> Signed-off-by: Alexandre MINETTE \n> ---\n> arch/arm/boot/dts/qcom/pm8921.dtsi | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/qcom/pm8921.dtsi b/arch/arm/boot/dts/qcom/pm8921.dtsi\n> index 535cb6a2543f..30366536f580 100644\n> --- a/arch/arm/boot/dts/qcom/pm8921.dtsi\n> +++ b/arch/arm/boot/dts/qcom/pm8921.dtsi\n> @@ -121,6 +121,13 @@ ref_muxoff: adc-channel@f {\n> \t\t\t\treg = <0x00 0x0f>;\n> \t\t\t};\n> \t\t};\n> +\n> +\t\tusb_id: usb-detect {\n\nYou should not mix non-addressable children with addressable. If you\nreally do not have address, but other children have, then probably this\nis part of the main device, so should be folded into the parent node.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qO7UJDjq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35645-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"qO7UJDjq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4WW00Jb3z1xvV\n\tfor ; Tue, 28 Apr 2026 16:58:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 660313058E15\n\tfor ; Tue, 28 Apr 2026 06:56:08 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6C1193624B0;\n\tTue, 28 Apr 2026 06:56:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C34433A014;\n\tTue, 28 Apr 2026 06:56:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 2DDF2C2BCAF;\n\tTue, 28 Apr 2026 06:56:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777359367; cv=none;\n b=c0sICjvcK8YOg48POwUSv+xhPk7Ss+ZfQGZKA2DkbY9fSS6KBK7jV2T9vRaArnTP0aHAXcgfh2eO0GE0s5juJGmQn0uh0K1x4Xq6ShXTTziNvM/zg6Dh7XC+id2VeciiKkmFQnb1QZj9ntWs62zLDtyxWv4biic/cjxUqMzJj38=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777359367; c=relaxed/simple;\n\tbh=QeaEkgB9qXRMZH4lw8BH9d5lPmwzC3VKrYrbh7I6zPc=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=BortLfNtc62GG1Xz1db78gncc5+NZGhm8kYFFYsSGNlXsGnlEfDcGwzzMQ3GW7iJDOVbM4uAnGTsltkUNwrx9T1S5dKREiWJMelYxZK1e6hhU5cTAvYNLADOJMBpAYguEKH1PAl2WqB/lC5hh+ncGajVCs5bPqtMjLENwfAiIA4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=qO7UJDjq; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777359366;\n\tbh=QeaEkgB9qXRMZH4lw8BH9d5lPmwzC3VKrYrbh7I6zPc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qO7UJDjq2gTtXyPBMPfAManjJj37VoTuam+lGTAPs6zG26slluqYJIM7cj7H5/RfA\n\t p/jUXJD+izV0k/s4wPDAuOD1YSRHhH+f3Xxac9QAmPvg7QTWZwgWlbBB3qCQzkUI00\n\t KqggtJ9J2JW6ck325ynAZhNZV9vQDY73ajvLUMvt7nLK+CFOsMlc4knY022AUeUt2N\n\t pQD1FSh9wV39isM935ZcmMnLDlVGXS21RlG8ciQOebvFJrs5JmVj3F6njsFtNEdcWi\n\t osHM5MxXGiY7WhJ3qQJq/ajhoDwMSDDt6/l87Fn5LB+HSTor2TnL+hGY7jJcK7gp0c\n\t HVtmn1oIswKdg==","Date":"Tue, 28 Apr 2026 08:56:04 +0200","From":"Krzysztof Kozlowski ","To":"Alexandre MINETTE ","Cc":"Bjorn Andersson ,\n\tKonrad Dybcio , Rob Herring ,\n\tKrzysztof Kozlowski , Conor Dooley ,\n\tMyungJoo Ham ,\n Chanwoo Choi ,\n\tGuru Das Srinagesh , Linus Walleij ,\n\tRob Clark , Joerg Roedel ,\n Will Deacon ,\n\tRobin Murphy , Kees Cook ,\n Tony Luck ,\n\t\"Guilherme G. Piccoli\" , linux-arm-msm@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n iommu@lists.linux.dev,\n\tphone-devel@vger.kernel.org","Subject":"Re: [PATCH v2 7/8] ARM: dts: qcom: pm8921: Add USB ID extcon","Message-ID":"<20260428-jumping-discerning-oarfish-d2caf1@quoll>","References":"<20260427-mainline-send-v1-sending-v2-0-dcaa9178007b@alex-min.fr>\n <20260427-mainline-send-v1-sending-v2-7-dcaa9178007b@alex-min.fr>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260427-mainline-send-v1-sending-v2-7-dcaa9178007b@alex-min.fr>"}}]