[{"id":3683275,"web_url":"http://patchwork.ozlabs.org/comment/3683275/","msgid":"<97969bf9-8eb2-4498-90bd-9973fb2bd638@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-28T08:57:07","subject":"Re: [PATCH v2 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","submitter":{"id":89450,"url":"http://patchwork.ozlabs.org/api/people/89450/","name":"Konrad Dybcio","email":"konrad.dybcio@oss.qualcomm.com"},"content":"On 4/27/26 9:34 PM, Alexandre MINETTE via B4 Relay wrote:\n> From: Alexandre MINETTE \n> \n> Add a device tree for the Samsung Galaxy S4, codenamed jflte.\n> \n> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support\n> covers UART, USB peripheral mode with USB networking, the front LED and\n> the physical buttons.\n> \n> Signed-off-by: Alexandre MINETTE \n> ---\n> arch/arm/boot/dts/qcom/Makefile | 1 +\n> .../boot/dts/qcom/qcom-apq8064-samsung-jflte.dts | 485 +++++++++++++++++++++\n> 2 files changed, 486 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile\n> index 32a44b02d2fa..c23c961f79e3 100644\n> --- a/arch/arm/boot/dts/qcom/Makefile\n> +++ b/arch/arm/boot/dts/qcom/Makefile\n> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \\\n> \tqcom-apq8064-ifc6410.dtb \\\n> \tqcom-apq8064-sony-xperia-lagan-yuga.dtb \\\n> \tqcom-apq8064-asus-nexus7-flo.dtb \\\n> +\tqcom-apq8064-samsung-jflte.dtb \\\n> \tqcom-apq8064-lg-nexus4-mako.dtb \\\n\n'l'g < 's'amsung\n\n[...]\n\n> +\ti2c-led {\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tsda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n> +\t\tscl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;\n\nHave you tried setting up the I2C-GPIO busses as GSBI devices, like\nI think I suggested the last time? This will potentially bring power\nand latency benefits, since there's an actual bus controller\nconnected to these pins\n\nKonrad","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=SnbT/UeZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=YVErJX6W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35661-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"SnbT/UeZ\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"YVErJX6W\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4ZWk4lYdz1xvV\n\tfor ; Tue, 28 Apr 2026 19:14:42 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 6E5F530D9E58\n\tfor ; Tue, 28 Apr 2026 08:57:59 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B18FE3D75D6;\n\tTue, 28 Apr 2026 08:57:15 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CF4F3C1F\n\tfor ; Tue, 28 Apr 2026 08:57:13 +0000 (UTC)","from pps.filterd (m0279872.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63S3P3bS662986\n\tfor ; Tue, 28 Apr 2026 08:57:13 GMT","from mail-qv1-f69.google.com (mail-qv1-f69.google.com\n [209.85.219.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtc5n345c-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Tue, 28 Apr 2026 08:57:13 +0000 (GMT)","by mail-qv1-f69.google.com with SMTP id\n 6a1803df08f44-8acb4b340f4so30233656d6.1\n for ;\n Tue, 28 Apr 2026 01:57:13 -0700 (PDT)","from [192.168.119.254] (078088045245.garwolin.vectranet.pl.\n [78.88.45.245])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-bb808a35e19sm70631966b.16.2026.04.28.01.57.08\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 28 Apr 2026 01:57:10 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777366635; cv=none;\n b=qY2eRy4YHOlKb6v84f8IqET004utvjS7dDdZAB+y0xySvwZJp3Yzr7N3I7vW5oSGzSrrCkB9kF9Wv5vNAnv4F1KeEO2aLH+OQDQdVPf8hP4ojNdFYkQIWBWRVuznFmS7L9q+cR4VZMO63tv03seoq7RUL7HnfijvwvO9ufQ1HAg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777366635; c=relaxed/simple;\n\tbh=6/kXOpIPrMyYeAZQVyerbvyBh4ZULLVmilh78gfeyXo=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=q8dVAOXYchuzm4My6sIEdnt36Sio6bUoWcmcVvWaaTQ6cuJ3JVQKsKn0oTnxSy/cp8K0PSqLYOvlZOTKWWH4+WAzfKTnL/NEx6CNZBoGbll2a/v4Twowmt7aKJrQsPfDZAdoPiKoahJbPBGI4B98wgxGtzZ6kvc6FKo2d5lrCaI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=SnbT/UeZ;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=YVErJX6W; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=; b=SnbT/UeZ9SYbGdo4\n\t0WzyD5jTFOmk3wtQ71JvXsSaDGkEc0WhrOO4rBTVFrbs2Yl7ChxzVnYs27d8rjla\n\t2TjFrPGnn5N1LoADoXEuDPOtk+9uipRVs+3UW00ztwBfY2kPIHgkz29//pU8JcQZ\n\tMXkwcdp+jr0K5CJWJcK6ujQRx3eIOb+2z+CSNHsgX/U+J48VsApo/HMylPnJC0G/\n\tAnbW5wQlEMYHWK6c2Mg2AtJrbCkMbaEPQyAI4UyBFqP7AxfpmUp52HhvcIVkr0rd\n\tSZg4gEsCY78pPaBtnklnmMkvBfuUcDmIxPHoWFIFPIRoKwcwB8fzQRgV6KJR6S/k\n\txpV12A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777366632; x=1777971432;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=ZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=;\n b=YVErJX6WuBg9HU1KVE6h7PaxTFMPUmZOqH7WWlUcw2lv/K72mXj8S+Aj7IPG9godH6\n 7RQFGNF+W/I7eW6CPMeDqg8n57jjUdFY3c5ql9KfL3jsvZbSIg39hTjsS1I+MxDUaIHQ\n iYP992ttS4iNYSqXrWpg28F2k2W66/YREZjud1BxOlgjlWjnGWTUrOyFr0g7bRDh9+60\n CmIbPKqoqLKqJ53AHzK3jPwu4nk/ZDJ5XtUhdcLODnOfxQpRYGTbKbap4akzB+t7F6NM\n lsZNN+TaTO9j2YJwYvbJPHx6854jdJoM6RYwrRnDAIIZfz3eLdxB/2n+UFh3nMzsDnBy\n 91aQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777366632; x=1777971432;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=;\n b=AwhBWAek5mUSNngjU6WRu2nanG8n1XsCiSZR7wk0qj7boQzptVkaXIPJ6shLEQ0BQs\n 0DtbGXNgCA0vPQyRh89OS2MAAXvsSkI8cLCYMtDQH55LO6ED2BkE+uJIYa4bzi/Aom3+\n 7LvWRYZKhyautccd7qqiZ76FC/RgivQxNZETubAlCC5HD0sNmQdljgxjsScnt+DGPkgb\n y6+pq/qNftVGzEnZ9IfRzGpt3ZH8jRfpaHFym5+sxiTQWlSAvIxFzNe4rx11ZFT1C2CT\n xuHPFoZeB4INeAD+jpDtx3ebTWUxej65PYhFM6ckZlme5eBeshcBFo8zSYQZu9hCJi7w\n zrvg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/YNc+MDxkEqk6SCmo2ndCYBExwe7OowMs8tK3yJI6hZ39SWlulLmoGTtJeXGMmZGVplbCRQ5Nvcw+X@vger.kernel.org","X-Gm-Message-State":"AOJu0YymVVSARuxPsMOLWax2+YMlhOGsRWRAkJqsHlxU1jumbd6EG16y\n\tYqiuIOfJLYYpmelmLxR2UY934F/+WusUu7xSQqNLZn2/U6NNHoKlPFaFgSGnq4rmIAey5C35p03\n\tIDRVjJ09Z65z4fYNn72Ov7htTTJgM0OrbDe0EGGy76MJlqYrsOWD7Tm6zfuRsWXwd","X-Gm-Gg":"AeBDietYD1+gLdVSnoSTqiEeHmXHF7pdQ10JgPmBL4LWolcezHLzcusLSXwDzNBT55q\n\tKKVGlYpbZ40bntvbDx5LrpGuwlVQCuqYFiEBXQweZRWbKqlIaiYukwtIfSOaY7/38gnz5DpdM8I\n\t0IX+RLZhl9GsZTSPXnX22IV92R40x/2M+OayOUOIKPl89WTsfirKwvS8CL9QhNeUtPTCD2lOUmS\n\taK28ZYuSKdGN3e+87/Pyo15rg0sai3B9EiuyPSUPse5D5A+Ip6ImRYamjyE4J9pFS40uaMdTUbu\n\t2+avSs8F/iIShqHbx8tesxJboNlxs+ivCQTadUp0LhQP8TFsxmIKv0MEjqPVi8kr3HXJTzNnN7O\n\tcdWcLdN7H9iOjf/6mK1xmu2rbC4gn1ldb7+9Yk9cHN8RcNVo7MqTk+9rseBvWb1jIOjN5ShMKCM\n\tscvpjWE7//AiEQ0Q==","X-Received":["by 2002:a05:6214:629:b0:89a:4741:2147 with SMTP id\n 6a1803df08f44-8b3e2a0dfa3mr27569006d6.8.1777366632369;\n Tue, 28 Apr 2026 01:57:12 -0700 (PDT)","by 2002:a05:6214:629:b0:89a:4741:2147 with SMTP id\n 6a1803df08f44-8b3e2a0dfa3mr27568606d6.8.1777366631761;\n Tue, 28 Apr 2026 01:57:11 -0700 (PDT)"],"Message-ID":"<97969bf9-8eb2-4498-90bd-9973fb2bd638@oss.qualcomm.com>","Date":"Tue, 28 Apr 2026 10:57:07 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 8/8] ARM: dts: qcom: Add Samsung Galaxy S4","To":"contact@alex-min.fr, Bjorn Andersson ,\n Konrad Dybcio , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley\n ,\n MyungJoo Ham ,\n Chanwoo Choi ,\n Guru Das Srinagesh\n ,\n Linus Walleij ,\n Rob Clark ,\n Joerg Roedel , Will Deacon ,\n Robin Murphy , Kees Cook ,\n Tony Luck ,\n \"Guilherme G. Piccoli\" ","Cc":"linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,\n iommu@lists.linux.dev, phone-devel@vger.kernel.org","References":"<20260427-mainline-send-v1-sending-v2-0-dcaa9178007b@alex-min.fr>\n <20260427-mainline-send-v1-sending-v2-8-dcaa9178007b@alex-min.fr>","Content-Language":"en-US","From":"Konrad Dybcio ","In-Reply-To":"<20260427-mainline-send-v1-sending-v2-8-dcaa9178007b@alex-min.fr>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI4MDA4MCBTYWx0ZWRfX+yjjhjSbCH5/\n /ncG6zkNR3sn4OrUu1TeaYZsa2VHdeIcYyFx7lDqQ62EqvJ4Pvq1OqmS+6ID+upt+1FPnBrQ0Vr\n 2+XjSnClA9NV3xwYAX5w+rHUeNAYQmN3e4E4EWyKYC9dRilK9VXhnsVt7LsIjuroXD+Mvy+ydBi\n NfQyyl0X+lPWq2TtdiW8Gfj6aMHvy/qm6l7rbVqn6BRmU1wy767nm0HrMQW4puULeIjazmw841F\n hYo564P7rKhDn5ox/6J2CkE+/5j8DEaSqw+l8L10C8jmGS4XU7dYOr8W6LqPMTC+6KjMMBOjU1I\n 0B4/eaWZAb5NxXaYf1oZGRryVjtyOzRlxFQ92nMo3qPcmIWcTfjAsj/5UCgAFFMVt2auH0xh7Js\n OYJRzWnfTt+EO3bimcBp1XoVqMociR1Sw3LejuyYM3VSMqUbyRd1qflOM3FUdgJYaKGkqEoTm/5\n o6bE85QsF6kR5+Lk+6A==","X-Proofpoint-GUID":"jViHavkBLoTq-con5CfvNd_2pInjOmB6","X-Proofpoint-ORIG-GUID":"jViHavkBLoTq-con5CfvNd_2pInjOmB6","X-Authority-Analysis":"v=2.4 cv=ZMfnX37b c=1 sm=1 tr=0 ts=69f07669 cx=c_pps\n a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22\n a=J1_VKfl4AAOAIIosoXcA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_02,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0\n malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 phishscore=0\n bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604280080"}}]