[{"id":3682838,"web_url":"http://patchwork.ozlabs.org/comment/3682838/","msgid":"<28B9184F-96D7-45AF-84AA-98EB2ECE713A@gmx.de>","list_archive_url":null,"date":"2026-04-27T17:04:49","subject":"Re: [PATCH] efi_loader: fix AllocatePages overlap status","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"Am 27. April 2026 17:48:21 MESZ schrieb Ilias Apalodimas :\n>Hi Harsiman,\n>\n>On Mon, 27 Apr 2026 at 18:05, Harsimran Singh Tungal\n> wrote:\n>>\n>> Return EFI_NOT_FOUND for EFI_ALLOCATE_ADDRESS overlap\n>>\n>> When efi_allocate_pages() is called with EFI_ALLOCATE_ADDRESS, UEFI\n>> expects EFI_NOT_FOUND if the requested address range is already\n>> allocated or unavailable.\n>> U-Boot currently returns\n>> EFI_OUT_OF_RESOURCES when efi_update_memory_map() detects an overlap\n>> after a successful lmb_alloc_mem(), which does not match\n>> EFI_ALLOCATE_ADDRESS semantics.\n>>\n>> Return EFI_NOT_FOUND for EFI_ALLOCATE_ADDRESS requests that fail due\n>> to an overlapping EFI memory descriptor, while keeping\n>> EFI_OUT_OF_RESOURCES for other allocation types.\n>>\n>> The UEFI specification [1] specifies that\n>> EFI_BOOT_SERVICES.AllocatePages must return EFI_NOT_FOUND when the\n>> requested address range is unavailable or already allocated;\n>> EFI_OUT_OF_RESOURCES applies to non‑address‑specific allocation\n>> failures.\n>\n>Where does the EFI spec say that? EDKII indeed returns EFI_NOT_FOUND\n>for AllocateAddress but looking at the function description, I can't\n>find anything specific.\n>\n>Thanks\n>/Ilias\n\nThank you Harsimran for investigating this difference to EDJ II.\n\nThe spec has:\n\nEFI_NOT_FOUND\nThe requested pages could not be found.\n\nand\n\nEFI_OUT_OF_RESOURCEST\nThe pages could not be allocated.\n\nLooking at the text one could assume that EFI_NOT_FOUND should be returned if the pages requested with AllocateAddress don't exist in the memory map.\n\nIf the pages exist and are already allocated EFI_NOT_FOUND does not look like the right return code according to the spec.\n\nIt is unclear if for AllocateMaxAddress a comparison to the memory bottom is required.\n\nThe specification should be clarified in the UEFI forum.\n\nBest regards\n\nHeinrich \n\n\n\n\n>\n>>\n>> [1] https://uefi.org/specs/UEFI/2.10_A/07_Services_Boot_Services.html\n>>\n>> Signed-off-by: Harsimran Singh Tungal \n>> ---\n>> lib/efi_loader/efi_memory.c | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n>> index b77c2f980cc..63cf1a7277f 100644\n>> --- a/lib/efi_loader/efi_memory.c\n>> +++ b/lib/efi_loader/efi_memory.c\n>> @@ -510,7 +510,9 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n>> /* Map would overlap, bail out */\n>> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n>> unmap_sysmem((void *)(uintptr_t)efi_addr);\n>> - return EFI_OUT_OF_RESOURCES;\n>> + if (type == EFI_ALLOCATE_ADDRESS)\n>> + return EFI_NOT_FOUND;\n>> + return EFI_OUT_OF_RESOURCES;\n>> }\n>>\n>> *memory = efi_addr;\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.a=rsa-sha256\n header.s=s31663417 header.b=Lw446C/M;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=gmx.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.b=\"Lw446C/M\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=gmx.de","phobos.denx.de;\n spf=pass smtp.mailfrom=xypron.glpk@gmx.de"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g490y0zG9z1xvV\n\tfor ; Tue, 28 Apr 2026 03:05:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EE7B68407D;\n\tMon, 27 Apr 2026 19:04:58 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 377C584178; Mon, 27 Apr 2026 19:04:57 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id BE9CB83BC4\n for ; Mon, 27 Apr 2026 19:04:53 +0200 (CEST)","from client.hidden.invalid by mail.gmx.net (mrgmx004\n [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2j2-1vd8g21csE-00fHbt; Mon, 27\n Apr 2026 19:04:52 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;\n s=s31663417; t=1777309492; x=1777914292; i=xypron.glpk@gmx.de;\n bh=VaN+fQv1YHJH1ZFFhYLzAfzMYSYnzcLqyXRE905vSVA=;\n h=X-UI-Sender-Class:Date:From:To:CC:Subject:In-Reply-To:References:\n Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc:\n content-transfer-encoding:content-type:date:from:message-id:\n mime-version:reply-to:subject:to;\n b=Lw446C/Mx6M9O9AsdkPlucM3I5bv2aK44pbUAPmGLcTIxiSkk0xjAK8xtzoxSBAz\n ViKvg6X0avUFOAYehStQPqfwZseRXeKJIuwqiw4lLyBJnsenAzeyFxo6h6uUfjZlW\n aAhlF5p/QqKOyUI5SNtht/olfkvLx+YlrW1hlZamkMoeL3N1u6lU9Pd16XdWmEtar\n EumPfaBKoCvqJQ4hxnCNsMQH5ftYgWc/i7XiJCuXyhTjdKRnTlTGbozFKikj2QOhr\n GY9bwdZT0SMRffiX0Kii0YOp2qAyiuboDhc5ihLJK/OvvWGmeqzGnMaHlTaiXtjuW\n cyJ30cr1q8csv0UAvg==","X-UI-Sender-Class":"724b4f7f-cbec-4199-ad4e-598c01a50d3a","Date":"Mon, 27 Apr 2026 19:04:49 +0200","From":"Heinrich Schuchardt ","To":"Ilias Apalodimas ,\n Harsimran Singh Tungal ","CC":"u-boot@lists.denx.de, trini@konsulko.com","Subject":"Re: [PATCH] efi_loader: fix AllocatePages overlap status","User-Agent":"Thunderbird for Android","In-Reply-To":"\n ","References":"<20260427150530.3156000-1-harsimransingh.tungal@arm.com>\n ","Message-ID":"<28B9184F-96D7-45AF-84AA-98EB2ECE713A@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:4BCkp7Ksj88fCydYW7f42GBRVnTP533JKUQyAnycYp64msy5z6r\n gVwYPUEy4mks1RWfiuGjRX5ZkBdqn6kS0rZ3R6FEsHXtCVwQ9olrt6VkCLxe1MyELxvmn6i\n Lx/unSa4lw3BXf04DX9/dQIIA6SJhBczNvDkEox3z+v4g8RRk3QHzMMqC2hqyJmDGjnnDgg\n Qhr7KQhh1Vql26oVrkrUA==","UI-OutboundReport":"notjunk:1;M01:P0:fk3SLMa4j7U=;yypFIS+JfJYl9lqHHAx/Kbyxoam\n Z+noIVyAPYwLCV16jSaXYMhi88A5sb8hJIjlWNdRYrtd2lHSC0MAj9F5A/FKQduKmOZPSLCW0\n pl8yt3jbFQPp0UyaJHJbyobX34IkAZlB9DvdYuiLMj2a+2OZL11aISHY1mN3SU3iPUWscsPYw\n UcYFL2wuJGy48eDj47u/jXdMYkihl98bXTvikBKXuptgd479//6xblDvklmv5MHujD6BVa3OM\n h7+3sTT0edYTylveGdfrjcreTWFQRLqxGLWFoVD7bQc0kufTfSKm/B0E0XX+g8b2gr1GX1hEZ\n YUVzoPf8XXkCbtIpamxq9M+8jV2+C99CJDpB8YKHl4fso43NJqCz9dTx4FLTVlPkCIy9R17NA\n 8LqHLVydoWKa1ds7tJcvkXDXvHzkC+bOkf6M1tgyzxj0B0HmXLsQN7iwJLHoUhh5rMgVHX40h\n WdBwcPyEBXXM8EeLg0/RKDdyzXwt1hGF8nOHF95MIO0by8BSvqTUWl+VWoYEQc2zhJyoztE2D\n ptqdjuS0o8Ou5FhsmnQ1asbZEuneSe0xKpsyFfmQBdxK/yH/6SyGhXkY31z8NeeONAn8W03Ix\n u9tVl21V8Ez9HphIZpME5DXxnfNZOR/l1qa8e4AjD14sxAVgGYODtm8gJWChrEDKtZq3brn10\n dwH6QiuDqYAl/+//vXP/tFukpxHYtGciVPCfd+KyTj2x5k5jkqBY0PNIGD2fSVHoD+oE77u3j\n 4834IFAIXRyzAHxR2QQdVcsA90HPVYx3MXVqAyBJnt77r4r7j+rjb/8FYGyEnucczfZB6IY3C\n 4IYsVwO544zb7kbHYKKJXvqRluhuOD1ueSyCd33xofIYzsMCxR/zIe1c2Y+0p1tV+z4CyC3zw\n krCcnY56k5IRKZKl59c2x+Se1MZ2ghSU9oWgRkfFB3TrWzuuMi7Twawg2FV0bEf8uuDE0upx3\n XtUqPbO4NhqVtSN54hxg7Oy5ZjIpB3s1mQXZqdiLSDEfPJtQMYdVwr2DnC/0NwtP62K8UTw4A\n +osN7tfPmqtYOOLczN1MvcvGzbzyoopo28mQUILo0vjXYqFHNScDDm5vB9gLIJbobN3bp4609\n H+HXKmj+ZUUyp7z49JfD3WG7b1RXZ9SaQXJcQsDR8vH6lBviHO/2okB9/hnZgX8D08+MZc+ZI\n xg03iXV5WwUpi2JXXD9fLYLWQguQ/2dUgnXQNnFJEIKXH5qXpkXRmUM37xXS51FjR0/CP353E\n r3gadBFlZ3RWJ/hN8ioo8a1B927Wpsb32Uje67gmFTK7xwRSSjNij72grjR8xIqbQCp/B5DFi\n IuW2EnpyzoTrnWoGXUgunbQQ7n3MdqTI1VGe/Six7D1n0ZwdCA3vnc+Vq2M+uTBAatSBq7GKm\n TQ7ZzdLnysTFiaie9jAwbGOZsE8GRrLmi/JOHKS6P/H16RBllgaSSBTCGHcuMUXXfDJ0xe0DN\n Tl79zSkZe705NeWTONGEJwFq28EhsP34RYgoAW/4k3HaMEv/3yZwP/NLRJ0mc22gn9JZylb0h\n 8wXfxdW1nuaUbHggGiGoWSe1pL8TxJxV4W30zG83LGgIauWclCbdXk8T2qWF9w7XTGAVz6Pt2\n FTyGxUtSDMRpEtEFPOgFptJywPiYDpiKjYAJbSXRsgbv3zc+odsj20Q5qrmgapiGrvadQ05FF\n +0Y+3t6KlBUW48Q1BdCqI9H3dajdvqh3F1WZ/DRTpceN9yCZWQ5mjHrh7R5XGSljXSJ23qBzL\n BudO6WL372WwX0wUp9jH3Hr/ZI5MRuI96qF/AgcWTwpC14cP+BDh86+V068EcwwLkgBZQJvxp\n JHmxjcdyYq1k4uvsyIw7s+COoM+KndOm2loqv6Mmj9PPYfVczlaE4K/o3ozr5yLsn04tASjPc\n /DAW/RzodHjMzH+igxtpWuwxcqYQ4vAD2r8ATFNRtMTj5xZPu70+rDU11vVuGyWQMH9eDP5Ic\n 34mbm1t6C9m4mds1s1cewhTuMgxenNcuYMtVTHXHPv7sBFSF18u2GtNrgsXt9lpBSc4Bwf7CL\n olOlj8JJeVQJfagpHh57Ej+pcb4luujbBzM7S9ipF1+6AnkC6KXq1aL5FIOEeKGOIt8AAkF0f\n 07jUx/5Uu5g1kCEJPmuC9cjnd0sbZ1cSk9VJw0YbsbsKEyhoZ9pLw6m0bLMIikzx2pH5xWyOI\n vTtUyKYiVfgfBw0dXtamgwTLcONVWgUXNTOgxHsWLq41MVrpVrNNj1bnZghGUfldl31GrR4K+\n jS/THHSAe0l6keLFQNXsBr0XFlAnx/wDWyW92FkBD6/ozeSJFjYZwweLQvr9rDPcu8DDxx999\n a6kuRitTX0lzUvOzX0Cd0BHM+I66LkshiZmeWPwlAXOAtBRI56ZOkuw97SilPJR1JCI9GZJj+\n NBTLKUsZtlktQ3LhM8WxeuC0bC+cu3k1z6SSrd2L+joBI/QB2D0IBqWC27M20zzVomRpCCOY6\n zIpyJamd6whBCkuuoC5LyG2Z+FN2qzt3Fe1kPG8NJPSsF5thrhs3hmubYQMFMSWRvvmPd660W\n UPFyxO8Agb+d0cXgn1HBbV+lhofUj7UaGiociu3ric3mcwSSACMtlngnsbbNrKnt3WKBMQpgR\n n+YyFfJnuC+oX0BWTTq3vGKercIYXX3YPonKOH0KM4hv0wO922emRHa84wA4hcZkHLCdyD53l\n q7rOhi1/boiS/VuCc64iqXNaq/u+eb9KrBPlWP9xOXkP5/LGc0MQTY7wTXYIv66M/85bKK5PE\n Sf88sLWMu+jHAGppwhp5LJIVVlkjZzrjLu8QlsD7XVZ3WguTNA+Ih2lMvxP8i0VPp2K0ijNFq\n ZjOkPBFM3TgsMFVrNwBLI2Pq/AQ/m09nFbsmW8f9DJUqpe1Yc1t2lhW260rgruN5HhUtXHggn\n gI46Br2zoEh22aL+H/Ew5Y9RYksfryKGWzOuq3QDAoyUbLWvetvduygBstQJZgraCmvYS0Lm3\n g9Qn3kYMvHlffbZ1FkHrmzUTEd2PUfEPVoasCiXk4FNbabEHidpCA26rZ3j9jP+03yXwPRPS/\n Ihkle1/jxj4qHlOaQAu+dI6fpBoIwnrpv0aHSgJCjoHYAT4y5UfbS8kpUesLSpgxz7bypjcP5\n Sb4jQudKlmiAfO9vLlufLdfpRLhWlyyVXcqaFqI45NiIHtMwvj6AK6a66Boe6Z38uWcbFOtd+\n K8gnxeceM2BOIDdS7froikSRlPhoYflYaupIeD1I3WtJrdjL7uYNTRXmliQEl0UC71uMocvpQ\n 6A3b6rUeA9OxYqicB7BdNG5r8+E2DrOhQNKrQyl1WIDI55BH1LoF6+7fZ0o1LfIzcNwnF7dyx\n 4/ta6BJYKwXJDEEZnrOgmxvbOLdwJAbqteDdxVcDK4vsU8FgmRAdGyohGFaejlB9mFFPJD4Ep\n zDc+oP6rfM7/FRvX5J6S48BqxeQ9lnAlq9p1EeGY1+zQdwehcn1W92Uw9ADWDxsO95t8CTgF+\n Z1WbxIf40y8FSQdWvosyach0oHKLKkEF4btSh+Ad40u6JhniVDz/1mZsGuGg5RH1u/aziJuzX\n hE5qUCfUasdji2BbL17mKF5SFEnhqWtdsW57QhwAeQg4w849keZgmbrVG9kSDtxCrwF6SORuh\n UCl1hN3o7fbSOu34aykFXd/jYhN/jBQFmaVhVWwM58bWpskj/Pnf708XGEs0MG3tSp+Q62wlu\n bFuTNA3ChGscz80MwIsp30ducNLJx+dEsTRjdv8KtN8TuOc5+cP00nDJ2O1q5fByEBnvk8i4M\n 7PHBokdqdRDzUQqh1WZkeWKeJVApGeAR0+HUlHMIX3yK/0HWcp0f1qWM5CTB7jceVRSxX7yP4\n k6IeAc4VguMK4WT3za6/wSszD5SnsS0cJ8qT40syAayvzRHGcwl+sIduscoYWVb+rqZa4IFpy\n +wleHb9g/14DVNJeuC1+BMRcY4yzHgmLm13vIs3VIDg7YmPeg9sqAbLwXLZTqYsgndSLDXpgp\n Kow0kgS9b1f5J1asctGw0A6/oakXCGufKISs1MEjW0c85tqqqMsr8jrPRxYqh7kUYiALzf1r1\n qT+FltOYBijyTo3goQYgnLfsJsec/Ilqslvxfthez8vdmS0m7TkilclzQMHDrlXZE4T9Eyrtw\n mi3t52XKOyv0cf98diXsXxZztt4paGVOBZWpwrrrFfrAtNt9nc/IRbMEYKZ9ORYwOUOFKV08D\n 65WOgJjBx4rykzWz2Nx2UMEZ3v5DZaxjz6n/mwK9kaPtNiiKMcxlojwhyIHBqGzcQFsszjYDc\n N/6qwQs/ju7TdeK8FAwsGUKfDKsE6rYKgPLz3+HskK1sEjctPpEN7STmDaK1KXlFlhK9qhUFX\n T0x4u+ldcuTmaOHpO8n7mL6RdmxlpZy4fPp/gTXtTa5mYBJEXAUD2TAARmLET6BHyRD0rKJHj\n WPFwoKLwxTXz5r6l3fyRauWTcxZaMWYSlG5f7WZA9y16Z1WNhy7Y/SI/BAMwDpE3E4I6YsxcZ\n 3GnvNMf2cKr2tZA7ssCSnJ0es2BtIZyX3du/kTPrCUuk3ut3ELkVukYFys3tJ4mnjxhzr7DZZ\n 4w3Wc+rkk4igKYMARStcQrebjmBZNJQUpj3XtOX3Bgg92y25eCXHyTBzYWKlVNQnIjBemBXfi\n fkopCecaT8g6YxAE4nVimyHd9UX1lUn1mUDvbt6mQ0D5xe5e2Dt8Mnej6oPJUQe6ua6iwE8uI\n koHVY/zPkuhU+vMCVXGgrHoyRvFLmN1KoakGVqqXAWeZzJpcADNeqTufWJdWHnmjAc7LGXGlf\n JavbsrfK1iJUBAmmSHZM5RnVooD7kfMi+bcm5gD31It9rOjv07Rd9q0mFWyKE6i5P9SCfem6E\n P8dsSNqKGuw4qATzL8hsv7fg0GvVA1piTqzhef/bJrFySUQ2Klzy4goPTo5dAoYFH9IDCZfQX\n nHImSDhFQwFwo/EQxqgqFaLAeZs2LOlMfL9rzEB/0lJ2vT1kQ9q/nw3OL59fLcF6AjVmhLm64\n /nDZl8/pJJK+pAIlbr0ROlSR5AOyBWTGFQJHRiSfeVNdOcaN+z2Mrxy3i6vaLN9L/rxLqPJFm\n lmNtPbfTE/K7TJA73lMq1GUFJLepnuGsADGBf6RV5rjgw11vcMCdeyT8MvVpRvPMpUxRiQBMZ\n nHnputiph9FBFcplnzHyTGl6X6QSgOXoNdUm1PRTuNnt88mf0TKU8nXA1FP80AssQTkwxtRbo\n KjCMJavgT0iL+i41QwiCwHNkOe5iGsZ2zfR+Amkk+5fZhG163Ka/sAbeE1m6Ry81QbnaiYAxJ\n KNArY0LTu6iA9Z8GFoDr6r/PF4qLD8GOyPxa1fklae24pjWbehBMII0LJtK0zNi3ft5pJrI2j\n 8a0ZTuQA+kDnwMzvgt6LIhiWxoOz4Dz7M66Qiw6gI3uqGWFKw8TBORa+i5JHv8iI84/WUiDkz\n WZ4C+OJ2iqlajoV/AE/+Mn0fkau0C0kyqMAVUCczCsy/MDk3/sAqFvVpXN40/xBX9bbyQZoRu\n 3YbY6ifOGw0llgSE3/358LMyt4AgMA5gUm20=","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]