[{"id":3682790,"web_url":"http://patchwork.ozlabs.org/comment/3682790/","msgid":"","list_archive_url":null,"date":"2026-04-27T15:43:33","subject":"Re: [PATCH] usb: udc: pxa: remove unused platform_data","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Mon, Apr 27, 2026 at 06:42:31PM +0300, Andy Shevchenko wrote:\n> On Mon, Apr 27, 2026 at 04:32:10PM +0200, Arnd Bergmann wrote:\n\n...\n\n> I even wouldn't mind this to be long single line\n> \n> \t\tdev_dbg(dev, \"can't get pullup GPIO: %ld\\n\", PTR_ERR(dev->pullup_gpio));\n> \n> (I dropped ' err' part in this variant, though).\n\nOr even\n\n\t\tdev_dbg(dev, \"can't get pullup GPIO: %pe\\n\", dev->pullup_gpio);\n\nwhich fits 80.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=G1zVc9Am;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35606-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"G1zVc9Am\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.7","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47LK2clhz1yHX\n\tfor ; Tue, 28 Apr 2026 01:50:01 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 39BD43049E07\n\tfor ; Mon, 27 Apr 2026 15:43:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2EE86344024;\n\tMon, 27 Apr 2026 15:43:40 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B1A10337B97;\n\tMon, 27 Apr 2026 15:43:38 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Apr 2026 08:43:38 -0700","from fpallare-mobl4.ger.corp.intel.com (HELO localhost)\n ([10.245.244.2])\n by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Apr 2026 08:43:35 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304620; cv=none;\n b=m9/m00xGw8fYDtomACvfn0R+PW2ccEdpSVc7G7F2T+nR+50jQ0xYxJDerhMTeL+K3g5/lUfgBhgR/VcobAa6Z6Ugno4B79UtNhhvUuvt4p2GY7JhILcOzUV9cFjSlqhrbrXXU0qfJHy7re/jsv9lfbxVEJcbxbMi5Vzgtfn77BY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304620; c=relaxed/simple;\n\tbh=6ISVTMtRX4NqFtLqj4qSZrtb1sJJjw46nVYpkNvtzzE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=qGf9jvaWjBKwv6QCs3/18vbUqepBaviGk1RzOPCSp6WuvVEe1goDvBuY7qnBUTyNd6vab53JhzpcYd9NAbKxiPdac1OKpExgGs67Bc4cEX34zp8oOb98/DrA3F2LsxE3k1hgwk6UFs5DaMa4CTx3/dpHHuNMFJ6LXTRe3zERluM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=G1zVc9Am; arc=none smtp.client-ip=192.198.163.7","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777304618; x=1808840618;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=6ISVTMtRX4NqFtLqj4qSZrtb1sJJjw46nVYpkNvtzzE=;\n b=G1zVc9Am0lg0OLEg0IaI2O93vquAA+1aB7uJwL2FFFUoHkoN1wWbMQGt\n 5vEjNa5dzQkTtpqQVVZmZLXCNeg7WPvUJ4gdh5cCh8OiN99ww4OjG8+7F\n bEzVFHJepQMpR24mq92heRJmi4hD0UE9cjybDfryspqclBIqxLAvdOiyC\n NXi82JGeJ5atAUruEA2A/yDhzJldBGqUYTFaBf3VeXr0cgq0az6qUUsSC\n uf8c/0/U0qo5dSl4VtAwVdrTkVyezQZu+qODHJ7Sl2Yu64eg0JRh8yN51\n ZnzqtFI7iJ2X+09mB4ubkdgp8+OeCZqTvSXFlESMI5blDcDb8XN+gvvFB\n A==;","X-CSE-ConnectionGUID":["pkfnsPSvSaqbuizfOlhiyg==","MSbhwIMpSU6XPZgGx/cnPg=="],"X-CSE-MsgGUID":["kqlQ3sM3ScmYFVbfEsrwtw==","VNR5LbqfS7Cae+5Twd97QQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"103656950\"","E=Sophos;i=\"6.23,202,1770624000\";\n d=\"scan'208\";a=\"103656950\"","E=Sophos;i=\"6.23,202,1770624000\";\n d=\"scan'208\";a=\"238660909\""],"X-ExtLoop1":"1","Date":"Mon, 27 Apr 2026 18:43:33 +0300","From":"Andy Shevchenko ","To":"Arnd Bergmann ","Cc":"Greg Kroah-Hartman ,\n\tArnd Bergmann , Daniel Mack ,\n\tHaojian Zhuang ,\n\tRobert Jarzmik ,\n\tLinus Walleij ,\n\tBartosz Golaszewski ,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-gpio@vger.kernel.org","Subject":"Re: [PATCH] usb: udc: pxa: remove unused platform_data","Message-ID":"","References":"<20260427143300.2887692-1-arnd@kernel.org>\n ","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Organization":"Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6\n krs, Bertel Jungin Aukio 5, 02600 Espoo"}},{"id":3682797,"web_url":"http://patchwork.ozlabs.org/comment/3682797/","msgid":"","list_archive_url":null,"date":"2026-04-27T15:42:25","subject":"Re: [PATCH] usb: udc: pxa: remove unused platform_data","submitter":{"id":8583,"url":"http://patchwork.ozlabs.org/api/people/8583/","name":"Andy Shevchenko","email":"andriy.shevchenko@linux.intel.com"},"content":"On Mon, Apr 27, 2026 at 04:32:10PM +0200, Arnd Bergmann wrote:\n\n> None of the remaining boards put useful data into the platform_data\n> structures, so effectively this only works with DT based probing.\n> \n> Remove all code that references this data, to stop using the legacy\n> gpiolib interfaces. The pxa27x version already supports gpio\n> descriptors, while the pxa25x version now does it the same way.\n\n...\n\n> +\tdev->pullup_gpio = devm_gpiod_get_index_optional(&pdev->dev, \"pullup\", 0,\n> +\t\t\t\t\t\t GPIOD_OUT_HIGH);\n\nWhile I gave a tag some time ago, I still wonder why we use _index variant here.\nWith\n\n\tstruct device *dev = &pdev->dev;\n\nit becomes just a single line (yes, 82 characters long).\n\n\tdev->pullup_gpio = devm_gpiod_get_optional(dev, \"pullup\", GPIOD_OUT_HIGH);\n\n> +\tif (IS_ERR(dev->pullup_gpio)) {\n> +\t\tdev_dbg(&pdev->dev,\n> +\t\t\t\"can't get pullup gpio err: %ld\\n\",\n> +\t\t\tPTR_ERR(dev->pullup_gpio));\n\nThis occupies more LOC than needed (also gpio --> GPIO).\n\n\t\tdev_dbg(dev, \"can't get pullup GPIO err: %ld\\n\",\n\t\t\tPTR_ERR(dev->pullup_gpio));\n\nI even wouldn't mind this to be long single line\n\n\t\tdev_dbg(dev, \"can't get pullup GPIO: %ld\\n\", PTR_ERR(dev->pullup_gpio));\n\n(I dropped ' err' part in this variant, though).\n\n> +\t\tretval = PTR_ERR(dev->pullup_gpio);\n> +\t\tgoto err;\n> \t}","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Umiet226;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35605-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"Umiet226\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.8","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47YL5rbfz1yHv\n\tfor ; Tue, 28 Apr 2026 01:59:34 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C2D993043D04\n\tfor ; Mon, 27 Apr 2026 15:42:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6CDB131E84F;\n\tMon, 27 Apr 2026 15:42:34 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B171A6822;\n\tMon, 27 Apr 2026 15:42:32 +0000 (UTC)","from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Apr 2026 08:42:31 -0700","from fpallare-mobl4.ger.corp.intel.com (HELO localhost)\n ([10.245.244.2])\n by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Apr 2026 08:42:28 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777304554; cv=none;\n b=mthT+D4enHRjtAIuDMVRym9tWS33/hGPh0zYIbV6EmudPcxwyQxwx0Wcv/7wMEy4QaWqf0Y02WzAy2XgR+2e/zNS20pqu6lxNEQc1jFqEFY3JqQjpBJOXZBMsYXsTq6cVeS4IUC/sVQTYSpSsmQAemw84vL2IWfVssbzeTXyU68=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777304554; c=relaxed/simple;\n\tbh=jpeqo3blo68qkWdVPmQrUuVlGinKzd6r+L8pS5ET8wc=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=mUom5wg236c6AlWSk9QkYoPUbOo8YOlJmJCmxXu1Uj/1rKC4yaWdrb7DH9kghJ16Sywb+lMrGaDc/FKiWgAQgPas3hGzS8AvvLgpJdgmnH6tdq/+YTEOXWdLrhvj14xtJ0v3T99pNAhVy+ziOnqDTLtj/9W0clyAx+e6GYaHUUo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=Umiet226; arc=none smtp.client-ip=192.198.163.8","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777304552; x=1808840552;\n h=date:from:to:cc:subject:message-id:references:\n mime-version:in-reply-to;\n bh=jpeqo3blo68qkWdVPmQrUuVlGinKzd6r+L8pS5ET8wc=;\n b=Umiet226sjN59+PO5ZFl9SfXMnsmLGb2b49uLAycdvGK2fkxMcfocAqB\n k2xghJ3pvIBg82pkwRFCykyU1DfBnZDJVcjRxSpeaM6wL8YV08mdSPpAe\n McJ4P38HlFTyHwWGPsL1s8a2L6RiKHfOFQUvDDmFxamadkuzMIpSiB4Tz\n COY1LUb0N26s1KvggAj5CzHDbcydEebVYpNKN9wn7oe9HUYuUfGk4mmVO\n hcA+hgDPNRLGQmqz+ohSb16EZGvIek62LltAuPkgweacjL3uHoqzyVFCM\n b9JzYgParHj4yfd4+M8Bv1rt4tyacBgO1AGExLXCcgOUBNkJ7ksoQyrZ8\n Q==;","X-CSE-ConnectionGUID":["GJmEHxCoREyHgAj0lo1fBA==","YGGLeOhSQYyz1BHpkVsziQ=="],"X-CSE-MsgGUID":["+wGkdRo1QeqfvF+OXOZ4iA==","aLLViqwXTyqs3NaMC227iQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11769\"; a=\"95758804\"","E=Sophos;i=\"6.23,202,1770624000\";\n d=\"scan'208\";a=\"95758804\"","E=Sophos;i=\"6.23,202,1770624000\";\n d=\"scan'208\";a=\"235425461\""],"X-ExtLoop1":"1","Date":"Mon, 27 Apr 2026 18:42:25 +0300","From":"Andy Shevchenko ","To":"Arnd Bergmann ","Cc":"Greg Kroah-Hartman ,\n\tArnd Bergmann , Daniel Mack ,\n\tHaojian Zhuang ,\n\tRobert Jarzmik ,\n\tLinus Walleij ,\n\tBartosz Golaszewski ,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-gpio@vger.kernel.org","Subject":"Re: [PATCH] usb: udc: pxa: remove unused platform_data","Message-ID":"","References":"<20260427143300.2887692-1-arnd@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260427143300.2887692-1-arnd@kernel.org>","Organization":"Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6\n krs, Bertel Jungin Aukio 5, 02600 Espoo"}}]