[{"id":3683074,"web_url":"http://patchwork.ozlabs.org/comment/3683074/","msgid":"","list_archive_url":null,"date":"2026-04-28T02:23:05","subject":"Re: [PATCH v4 17/32] monitor: Do not check TARGET_I386/RISCV to build\n 'info mem' command","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Mon, Apr 27, 2026 at 6:11 PM Philippe Mathieu-Daudé\n wrote:\n>\n> This command is filtered at build-time for i386/x86_64 and\n> riscv32/riscv64 binaries. By using the recently introduced\n> HMPCommand::arch_bitmask flag we can filter it at runtime,\n> making it possible to compile hmp-commands-info.hx once.\n>\n> Since the method depends on a pair of distinct targets,\n> define it in its own stub file.\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n> Reviewed-by: Richard Henderson \n\nAcked-by: Alistair Francis \n\nAlistair\n\n> ---\n> stubs/hmp-cmd-info_mem.c | 12 ++++++++++++\n> hmp-commands-info.hx | 3 +--\n> stubs/meson.build | 1 +\n> 3 files changed, 14 insertions(+), 2 deletions(-)\n> create mode 100644 stubs/hmp-cmd-info_mem.c\n>\n> diff --git a/stubs/hmp-cmd-info_mem.c b/stubs/hmp-cmd-info_mem.c\n> new file mode 100644\n> index 00000000000..8a53e367a9f\n> --- /dev/null\n> +++ b/stubs/hmp-cmd-info_mem.c\n> @@ -0,0 +1,12 @@\n> +/*\n> + * Human Monitor 'info mem' stub\n> + *\n> + * Copyright (c) Linaro\n> + *\n> + * SPDX-License-Identifier: GPL-2.0-or-later\n> + */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"monitor/hmp.h\"\n> +\n> +HMP_STUB(info_mem)\n> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx\n> index 336ab870a2c..2d0a8f7d48f 100644\n> --- a/hmp-commands-info.hx\n> +++ b/hmp-commands-info.hx\n> @@ -209,15 +209,14 @@ SRST\n> Show virtual to physical memory mappings.\n> ERST\n>\n> -#if defined(TARGET_I386) || defined(TARGET_RISCV)\n> {\n> .name = \"mem\",\n> .args_type = \"\",\n> .params = \"\",\n> .help = \"show the active virtual memory mappings\",\n> .cmd = hmp_info_mem,\n> + .arch_bitmask = QEMU_ARCH_I386 | QEMU_ARCH_RISCV,\n> },\n> -#endif\n>\n> SRST\n> ``info mem``\n> diff --git a/stubs/meson.build b/stubs/meson.build\n> index f086521cde4..33053d932c8 100644\n> --- a/stubs/meson.build\n> +++ b/stubs/meson.build\n> @@ -87,6 +87,7 @@ if have_system\n> stub_ss.add(files('qmp-cpu.c'))\n> stub_ss.add(files('qmp-cpu-s390x.c'))\n> stub_ss.add(files('qmp-cpu-s390x-kvm.c'))\n> + stub_ss.add(files('hmp-cmd-info_mem.c'))\n> stub_ss.add(files('hmp-cmd-info_sev.c'))\n> stub_ss.add(files('hmp-cmds-hw-s390x.c'))\n> stub_ss.add(files('hmp-cmds-target-i386.c'))\n> --\n> 2.53.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CupwUyz6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4PPr3tg3z1yHv\n\tfor ; Tue, 28 Apr 2026 12:24:00 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wHY6s-0001v7-7M; Mon, 27 Apr 2026 22:23:38 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wHY6r-0001us-4d\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 22:23:37 -0400","from mail-ej1-x636.google.com ([2a00:1450:4864:20::636])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wHY6o-0007Yj-9S\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 22:23:35 -0400","by mail-ej1-x636.google.com with SMTP id\n a640c23a62f3a-bb3c4d8cc29so262408566b.1\n for ; Mon, 27 Apr 2026 19:23:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1777343013; cv=none;\n d=google.com; s=arc-20240605;\n b=SeTolNt7clsZ1aqfeHRjf4ufdLYtmDmmE0kCo+J0onpq+SPQmsZI8ozRNMbex6QlcO\n BGB46iCt+GY6kmlYMzm4aGb6no0IJ3M+5rYTGyWMt24235EDg++cMr4afrgdnYd48xMX\n pVxU+xqHZAXN/pWnrdVL+Z0vpoxeSOgImJdGV6/bV4qFZ4UkJ2HnEgJ8gIhxNOU7TEp4\n mzQUi3YPE7Y6cC0FZJ5OJ5xfXVdTkTKfV7c/ZUhuTzjJ2P8jwy25bTK3fDGY1EP9ut0+\n 5EAPbsqVpX+fnRZ5FzyK6T3ET/V8BcZSpOmL6sNoW5+IQnOw+D0YEUdpFiS3ZpcW7M9J\n XOZQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=mr+G2hCk1Ov6y0E9/4Hwfj8a+5qO1RQNtC4Kr0hrqyg=;\n fh=q0OM5RabvX/sHt96dG4/MBbaZUOAEhdH4+aKddA+inE=;\n b=XZz0Tgdo/pbwlGq8p2ae/OiHIxTzOOkBqkpUC9RduJlPJ3WHfKtnUEjZ22it1cUdWu\n WjodHfTm1RCv4CooiasVsLDLcuayzIbazztbDnjZmFRaFn+xkJ2uVfRW3GmGchb+ToaV\n ClOIAq0e9ITKX9cmLPdZIvWNYFKvkQ0tQn3Ugbe/SP8+yGJyZ3IKbooRzzF+2NFb9qB+\n SlN7JfibUZJLG4Ux1ynhbJ12frCmqmBtVLO3AK6RbtZPNQxUqQ8OkA6NbFcDp74Xkdmj\n vOvUsjSSSZaUU94MSolyqUmUCTWBkvar0xpt0DffcgsIqyd6SsRZYhhYPZef7HlsDL+2\n +INA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777343013; x=1777947813; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mr+G2hCk1Ov6y0E9/4Hwfj8a+5qO1RQNtC4Kr0hrqyg=;\n b=CupwUyz6lFQvv+hCu9TkCofhTgeVz+IPFh1XZ+tXexqg68l4CRSQ0nR9h7YGajtK8t\n tbt5l0jcivg/kaWT3QWsVlsV9AIN11HnovnQbxdnhpxIavDH7e/waYnJ8S5sHTPsAqf+\n 3SU55NBIsWDGBO4/MOOsR18IGB96vofpKtgECofOb/RDk4RmZp7mxP2pt1wvbX+/+hBh\n Se3OuqhZZqIqpcvb44OVNyyw77vb6Y7xyeyBU6PS/v84iR54C3IAFVm6pot0MVKOVYEz\n uIS/TOd95v58/caDaL2PgLskWfR0J3tyLTTcbW4CJBJWORl8ymtiPDofhIZL+PipGqUp\n lG3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777343013; x=1777947813;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=mr+G2hCk1Ov6y0E9/4Hwfj8a+5qO1RQNtC4Kr0hrqyg=;\n b=sEVQzToBELwwR9vKFAHIZYxYT7GbqvAh4HSTSx6KmYVAEa+97siYdpyi+bS4zLqvc2\n GGQftfDQvLQLDFTZt7JUrzT+TpnFfrYkGY5VZfXSZQ7pmHdJMZIlG8E7CfHtqR76LGn7\n PsZEKMnEEuaT7rrVpdwyDqZzttukMMoVEIvshskz5Xbo4TEzMm20mNUSsENfcytP9Mca\n DkjKBRgTNbn7n6dmiflSk+TIbbQ4nYSMHlnat7k4Xi8LeMI3pOFn7EZFERymimIw8lOD\n r5t7Z1+xoLEt4qR99FD4CsNMKHaEMXNDHdQ4MtOKdoAdiKZSoV2DpFbOUClIfU6MVwYK\n A2Eg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8wSafNdomQNwZzXgoxgcIQPzuOL/CNa6BX0dHYziGWtMG3Z04HnSspZkgwU5NGVd7/h3xhiQ97sOyF@nongnu.org","X-Gm-Message-State":"AOJu0YysO1Y695zkFptWEwpY/hA1Egz3GLMSKcSTmeRgh7rxkrZcMJjz\n m6Q33/6fWF5werqRtjOKU4TFtfhGo0kJcBUcbJ1ZNwEplWSQoySjW9v0vv6zRAKQ5BAeO1j9g+n\n GGf3nytCq8402I1i7FrxWdQjcO0AwgB/nXQ==","X-Gm-Gg":"AeBDievd6s5T5kAJRoZGkcFsv0bkblE8iNhBlTax8J2A/e+lVywGD7s6sZ9SPLI77Yd\n DyQ7BWlfZcGNl7AHvBeHNi036BR5K68OUydDThIO5NV19NhWg7/zt0Gsm4q9Rmf9OS5/wbB85jO\n /tQZxKzGausez1Xj5e2r3ehaTVnpDyrXmk/bJCohyltpgJmjnbN0Gp7T8GztCd73w5emDOavCR+\n HJG26LiuRoV1vG27nDqFx2v1a7LDzVXcAQMFuwMy26dQCUaSPH4Y0D5lmestU3OMVseyIsSPYo5\n ogMjZ3lmM0m475MN6rXmlWvStkYWEIu2vr37IhCsGQSO6x+J","X-Received":"by 2002:a17:906:f588:b0:baa:1d9:66ff with SMTP id\n a640c23a62f3a-bb802da69dbmr69703166b.20.1777343012549; Mon, 27 Apr 2026\n 19:23:32 -0700 (PDT)","MIME-Version":"1.0","References":"<20260427080738.77138-1-philmd@linaro.org>\n <20260427080738.77138-18-philmd@linaro.org>","In-Reply-To":"<20260427080738.77138-18-philmd@linaro.org>","From":"Alistair Francis ","Date":"Tue, 28 Apr 2026 12:23:05 +1000","X-Gm-Features":"AVHnY4L5IgmFfU1GrvFcbEtRdC4bQA8uvVVVq0DbNVfoQUAR-Z4-6HLTCWy9tO4","Message-ID":"\n ","Subject":"Re: [PATCH v4 17/32] monitor: Do not check TARGET_I386/RISCV to build\n 'info mem' command","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"Markus Armbruster , qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::636;\n envelope-from=alistair23@gmail.com; helo=mail-ej1-x636.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]