[{"id":3683062,"web_url":"http://patchwork.ozlabs.org/comment/3683062/","msgid":"","list_archive_url":null,"date":"2026-04-28T01:52:48","subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> From: Ion Agorria \n> \n> The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> paired with pm_runtime_enable in the probe instead of being inside\n> gr*d_runtime_resume().\n> \n> Signed-off-by: Ion Agorria \n> Signed-off-by: Svyatoslav Ryhel \n> ---\n> drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> 2 files changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> index 21f4dd0fa6af..71f092d59d65 100644\n> --- a/drivers/gpu/drm/tegra/gr2d.c\n> +++ b/drivers/gpu/drm/tegra/gr2d.c\n> @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> \tfor (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> \t\tset_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> \n> +\tpm_runtime_enable(dev);\n> +\tpm_runtime_use_autosuspend(dev);\n> +\tpm_runtime_set_autosuspend_delay(dev, 500);\n> +\n> \treturn 0;\n> }\n> \n> @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> \t\tgoto disable_clk;\n> \t}\n> \n> -\tpm_runtime_enable(dev);\n> -\tpm_runtime_use_autosuspend(dev);\n> -\tpm_runtime_set_autosuspend_delay(dev, 500);\n> -\n> \treturn 0;\n> \n> disable_clk:\n> diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> index 42e9656ab80c..33e88ca4d4c5 100644\n> --- a/drivers/gpu/drm/tegra/gr3d.c\n> +++ b/drivers/gpu/drm/tegra/gr3d.c\n> @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> \tfor (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> \t\tset_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> \n> +\tpm_runtime_enable(&pdev->dev);\n> +\tpm_runtime_use_autosuspend(&pdev->dev);\n> +\tpm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> +\n> \treturn 0;\n> }\n> \n> @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> \t\tgoto disable_clk;\n> \t}\n> \n> -\tpm_runtime_enable(dev);\n> -\tpm_runtime_use_autosuspend(dev);\n> -\tpm_runtime_set_autosuspend_delay(dev, 500);\n> -\n> \treturn 0;\n> \n> disable_clk:\n> -- \n> 2.51.0\n> \n> \n\nOof, looks like I had managed to really bungle this with my earlier\npatch. Thanks for fixing it!\n\nFWIW, I've been working on adding some nightly testing for Host1x/\nTegraDRM, so hopefully we'll be able to catch such things easier\nin the future.\n\nFixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\nAcked-by: Mikko Perttunen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=mY3iPPFF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14015-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"mY3iPPFF\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.209.66","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4NkF3HBRz1yHX\n\tfor ; Tue, 28 Apr 2026 11:53:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id C7F3B30054D3\n\tfor ; Tue, 28 Apr 2026 01:53:05 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 463A02D5A01;\n\tTue, 28 Apr 2026 01:53:04 +0000 (UTC)","from PH8PR06CU001.outbound.protection.outlook.com\n (mail-westus3azon11012066.outbound.protection.outlook.com [40.107.209.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A241913C918;\n\tTue, 28 Apr 2026 01:53:02 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by IA0PR12MB8975.namprd12.prod.outlook.com (2603:10b6:208:48f::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr\n 2026 01:52:58 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026\n 01:52:56 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777341184; cv=fail;\n b=nqAVkPikrv5KCzaFvIFURPE/wa9uakap/29PqsXf9Qh/9Sij5DD5bKjO5PdOpjwPtzB8fSbKn+O/d81RsKYktQGQYQHvJE3HwLKtbGKLdbjYi9qmtFePJfgOjHMO+rcZHKW0p8Zk4ZX5CzqHvkwh4e6Y4RxAqjaZmy1UK5zowm0=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=TuM4G/uLhKXGplKnriqn/zlcv0RA2tQAjeJn7EmVeirZt9SBoygttGvbw2bETS+3kix4/TFl+EBqlDAJKcbXM4384XP7T8aEPNB6btF2/CLgFPJva0thrHg5BHBdR33FqpbgK75Hgh0Q6LK5yxz8wRR5U8FgChwcOgDwgEJHqsHMPh6Au6AxeOY+kblVBBd5loI88gSXuGS+e7qCBQBJCmBqNzzLfz41WA1vh25sTu8bmp6yHOHMIMF+bx2mLYS0NhRmhySX3/g5+UNtWh8BSsWSVPXiQIHZxK2frdWNAS6TlN5Oh7S+6VCws7Ebij9lTSDObX8eLy1V9e7+RbqnfQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777341184; c=relaxed/simple;\n\tbh=jh4EJqglHPv7t04WSbrCFkr7FEawYK2uMGa00jPOmCo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=qkGaZ6nnbxxoZf7mVvYHXiKFT3M7apzhlpGctdCG3+wE7v81r0W+ydmKP1jBFml1XDz6lyAv4dXU2exQFtXBb1oQm4Y/ICbXTcWaukWMp0xHIYnk3xW4d27u16b7shPDIwMHZNGzXWcg0XCidjoLzeQiqKN4WwNoAxWwOE2nhOA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ZgkZoFqiDNjFDSj2UNcIfDRN2J8Tuu7UePEifsUNWvY=;\n b=bkKA8MITW4enM8S2YUna+M6DqcKlCVo9tZi3TeEQW+zQjJJZ1FGpOyNEcsBBZp7e5U5LQ825HQiOsDJweO/PpoNDKakbrZ1m3U5p++kKDBZMx+kj85H4QOSyZJK3m6SaJcqFYExxH1oEKGAdjXL6iFsecLE4ZWoTre3aUD7MZJCU/oGGGq5/2l6oRAz2h9gN2ZiMxB3NRBrwAa08UFFZ66jDRDfBfc10lOUBwuUpV6WIw2oA0q16m8QFTLYjYp/xCfS9vqKOq4mhho57/c4YeG5LyZbM++axPhyb8ja/JNJXC9xdrEFF02GAK80eGAdEMWgNkJWRdjasxlqzl8yvyA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=mY3iPPFF; arc=fail smtp.client-ip=40.107.209.66","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZgkZoFqiDNjFDSj2UNcIfDRN2J8Tuu7UePEifsUNWvY=;\n b=mY3iPPFFtj2hpoENtG+Wtjjg8xGBUkyzczLE8iNAxlmnRGHwLUYG/swFsYOa3kg8Gl8WBEGiQ//pM0cr4sP2JMuZ3DsJGrDnGk3ZpEx0ayz8qbAMcXaWeP9TgKwAybLxBz/QUvFVF2uBg3pdPl3RgiXPA5GRBM6ZEb/NQc4HNtY1fgLygJd/NmiWfIXtdJTYJRkmbUNfidj2c2bayzDJUOsKZy4R1gdHh51liE1xNOvI3iJ+AYz2cshWg6wMknG4zRNrPcWOehH0UM5IAgGs7BOrIkzmCjrSDnPcVKb0VN1Yw4VdtxaEV5KZIdJQuo7VRF/UYFtWmL64TWOcPKZbtA==","From":"Mikko Perttunen ","To":"Thierry Reding ,\n David Airlie , Simona Vetter ,\n Jonathan Hunter , Ion Agorria ,\n Svyatoslav Ryhel , Svyatoslav Ryhel ","Cc":"dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","Subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","Date":"Tue, 28 Apr 2026 10:52:48 +0900","Message-ID":"","In-Reply-To":"<20260427075856.85208-2-clamor95@gmail.com>","References":"\n <20260427075856.85208-1-clamor95@gmail.com>\n <20260427075856.85208-2-clamor95@gmail.com>","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-ClientProxiedBy":"OSTP286CA0113.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:604:225::9) To SJ2PR12MB9161.namprd12.prod.outlook.com\n (2603:10b6:a03:566::20)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|IA0PR12MB8975:EE_","X-MS-Office365-Filtering-Correlation-Id":"c5d05e4a-5752-47e2-25b6-08dea4c8de6f","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|366016|1800799024|376014|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tLlQxTwOycVbuzsiJvpPj6gZd0pgJmdjNzBdE5vFG3VF7XSCVuI/VQpf4rTH2A6O5yAm2AxNVVnkgHVVpcKBYPmOD+cko2oWRE7jGaB2VgfepSx5XL0RpT4XFQKRkU1YN9G8OWyZ60OFN4Koj8L5WZQXT10rtpo0qO4zfZkFH+Mn35FqkvXhX7i+1Nj0EpEyTVhENPBKcDzsNcJ57SDxAgOt9zXbszIUQmXPKNr8r0L17xqw06LXSHhL/QxmuLvwrYEn5CtNMyFTAv3/IAQIH+y0hCog2V3xuO5/hk83jx4m3ljcuQyQ0dX6nPHgKP9fLbefKLWfixE1a4c6aldhs+6sXQwOulCpjvUAwL0nkD62zaLA94M/gY867X6p/pwsrvWObtVZ6kIrSPUWoXLAdIa1blqOsfESqdJ7gr/pZBLArbz8w4C8/Y0xglWjPgpMy+Cv+9dJpzKQJ4Cp/Yu0wUGAWefVAgMfwXCHXdZRgzLrBJ3i8bpf5+z8VE53cQX4Yqv71kr9eNSUWlA0lqmDDf88ri8nyKnSqGOTd7B86JSvZgClszLiDmJAGK5nvUdjYbSAu/0Cvd9ygbV7I1CA787fiQ0l1VmT1PDrBGOq5E4OhC+gvAlMS+SP3JpGckIW4JjKP7axjdL1g5uCDurrgnjYdT+aQm6o7D5nQ8rsDFILenhHZ85xLGUqDdE1k2vBLVKkP9UgPLB7p9wbt+AMPFq0cpHA9S73a5YkEXOTPVKc=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?RSSNj4rwCR1qhmJVR5Rt8e118UYE?=\n\t=?utf-8?q?gdda9s8LnbcbhrxkM0PpZm9kSIuy4/ureQ6CnsyReR1g86GIOit8KKNhTg4M4kneb?=\n\t=?utf-8?q?UkCm3zxT5qQ02LF5FyRsMS1TQFNn+srdfdzSw47e6+xr5D8+XN3IJpz8wnP6818BR?=\n\t=?utf-8?q?/iqpp1WrfbStwlGWJkzdWsMv5jf83BJVqeqDcDAsRfwb9ZFTEtkdQQ8szqFwBsIjX?=\n\t=?utf-8?q?bYWmpdqfum8abyflxbJB0uK2ZCzLOSXGeLPPblwP1Bg3Ff7OyNQmYTE/7lG6JRBvd?=\n\t=?utf-8?q?4T1Hz9Xgi29Swf4/HWNmDFbKh/TSR2Iqki8FVzb2aYt6ZnarhqK65nRC4jh5BRcsq?=\n\t=?utf-8?q?Pj+LMcqhlqSbXS3pY4ERuxiGjdesoatAbWz7VxoRf2tCc417FyzFR2K1G7dgvuYt4?=\n\t=?utf-8?q?23RgXT+bgenbB9mZ2Q0ZVF+Vo/ZU8pzfx6snZ7U/NrAv2ZSTBaUGdw8B72yk9B8p8?=\n\t=?utf-8?q?GZWZ7MtSsJAMhzMeVADe6OwGtcKQFmhnqTMlQSH2FgcRHkM7AX0OQmG0sIkex2aLg?=\n\t=?utf-8?q?iSRXDsxsGPAT9BQyS3zQUKyWGMy1jDVpCXVUpcFMoB8THpJzA+M3+Vwem9e+6tyYA?=\n\t=?utf-8?q?2uSd3uQUtw5dYJfydIOKd4j+fjBK+UfnZNELKfyE4LHCIiGAliCwfOvV8xlhqF+4E?=\n\t=?utf-8?q?nIR5DTJtKPsFxveNwKlEWav3MflxMHaBjBDT3uXg7ouU1/BRYP6HWs6s+Ic9EfLrF?=\n\t=?utf-8?q?XRJV9KUEQWVjxjkOVzpS+pprktQycSRFlu32tGI5LKMZI/admEPFxzi1c6J0FwT8A?=\n\t=?utf-8?q?oBhrEr2pmM0vSSttk6V1K+85sQTOVnxd4Z/dvBiC67HUTEz3Mm46GJ4RS5Zt7E5hM?=\n\t=?utf-8?q?0cXC/kLHyuwe59mndfgr32FCOTAj3Zn+mpFdjKCPEpp/dVQmuxR2cy4x2zkburGdE?=\n\t=?utf-8?q?TqH+82xpu+lbO6NhHaiOBfQVtZP/J86lsssopvOWVi2ey4cLlCuymnCP3CMUG8edL?=\n\t=?utf-8?q?6kN8XkWlgI+wBPGNldz4cZQh37bb8QlFj3SdJjqHRR4IkIZBxxVTdFqaFzTpuA3aH?=\n\t=?utf-8?q?xzo68WvWI5+xEL+t3ipN8luRgX7y5v/emza8wvUWztndQ8pPVRNO/2UcLjk+6t1vh?=\n\t=?utf-8?q?Cv3hW8wrORnNF9lrqkIwjvftgflAXHE1/yb5n5jiddZxTeFAm5r0BO+PmT5BUpqp1?=\n\t=?utf-8?q?chJNEAMaMjFQebc69QdmAEp3eraTTjI0eca6p55Hj7P0Y6HP/0AGKHgJCA5n7ncgT?=\n\t=?utf-8?q?4pS3WbP/ul+LlS9tDAtV5qgWtLygPMmQBiftu8EHvsqzLkyWcNRx9AFUm9tzbcg37?=\n\t=?utf-8?q?BHocvt5aBPxHgJ1tZhjGzFds2QZ9qtlavSgzdqk7KydR9gz7QrBMHDQpQZY7pjmIm?=\n\t=?utf-8?q?Jn+wtwM9YV5d7wmtAw77PLQulNuDDGBgS/E03tSP3qHEfL878NLLDhD5bCWHv9sDV?=\n\t=?utf-8?q?Q8Bqmfdazav3NF9csmZKcv1LLss5hinN9M7AFEM5zazHmmsy66szMNh3SLtGfjHkq?=\n\t=?utf-8?q?uvTkkpqGjJMOcX4sXCd8+PSxQWqqp9r21Uh+T8J09jpQej8d7JDxcw4yg4gXMopIx?=\n\t=?utf-8?q?UpgOQlG6Cewz8O1+4BnF2Qc6SwTTP8JYFp9OXzBvS1pfpk2omOMFnwccE9aENrmOt?=\n\t=?utf-8?q?WcY/IcbFmHV6tPq1clYu4BMzN0BrXh3dUzTjFzgu/GPdfK63yAynofTF2/cIdvoTq?=\n\t=?utf-8?q?IqjSdWvIgkqtRhli3np494s8klRsxbZg=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n c5d05e4a-5752-47e2-25b6-08dea4c8de6f","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB9161.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"28 Apr 2026 01:52:56.7268\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n Bmui3ak1oK/hU9PfzASoB1BDSmN/N+l0wRP8XnyzQZ9+qzG3Ylv1UR+s8Xati0lB53dp7W4zpc9ts79S6ScSiw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"IA0PR12MB8975"}},{"id":3683110,"web_url":"http://patchwork.ozlabs.org/comment/3683110/","msgid":"","list_archive_url":null,"date":"2026-04-28T04:57:09","subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","submitter":{"id":84146,"url":"http://patchwork.ozlabs.org/api/people/84146/","name":"Svyatoslav Ryhel","email":"clamor95@gmail.com"},"content":"вт, 28 квіт. 2026 р. о 04:53 Mikko Perttunen пише:\n>\n> On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> > From: Ion Agorria \n> >\n> > The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> > paired with pm_runtime_enable in the probe instead of being inside\n> > gr*d_runtime_resume().\n> >\n> > Signed-off-by: Ion Agorria \n> > Signed-off-by: Svyatoslav Ryhel \n> > ---\n> > drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> > drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> > 2 files changed, 8 insertions(+), 8 deletions(-)\n> >\n> > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> > index 21f4dd0fa6af..71f092d59d65 100644\n> > --- a/drivers/gpu/drm/tegra/gr2d.c\n> > +++ b/drivers/gpu/drm/tegra/gr2d.c\n> > @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> > for (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> > set_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> >\n> > + pm_runtime_enable(dev);\n> > + pm_runtime_use_autosuspend(dev);\n> > + pm_runtime_set_autosuspend_delay(dev, 500);\n> > +\n> > return 0;\n> > }\n> >\n> > @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> > goto disable_clk;\n> > }\n> >\n> > - pm_runtime_enable(dev);\n> > - pm_runtime_use_autosuspend(dev);\n> > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > -\n> > return 0;\n> >\n> > disable_clk:\n> > diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> > index 42e9656ab80c..33e88ca4d4c5 100644\n> > --- a/drivers/gpu/drm/tegra/gr3d.c\n> > +++ b/drivers/gpu/drm/tegra/gr3d.c\n> > @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> > for (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> > set_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> >\n> > + pm_runtime_enable(&pdev->dev);\n> > + pm_runtime_use_autosuspend(&pdev->dev);\n> > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> > +\n> > return 0;\n> > }\n> >\n> > @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> > goto disable_clk;\n> > }\n> >\n> > - pm_runtime_enable(dev);\n> > - pm_runtime_use_autosuspend(dev);\n> > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > -\n> > return 0;\n> >\n> > disable_clk:\n> > --\n> > 2.51.0\n> >\n> >\n>\n> Oof, looks like I had managed to really bungle this with my earlier\n> patch. Thanks for fixing it!\n>\n\nHello Mikko!\n\nThank you for taking time and looking into this patch. Don't be so\nharsh to yourself, PM is easy to mess and hard to set properly. This\npatch does fix gr*d access but it does not resolve the issue itself.\nPM should be set in the init/exit rather then probe/remove. I have v2\nwhich fixes this and one more minor issue and I will send them later\non.\n\nSo for now this patch should not be picked.\n\nBest regards,\nSvyatoslav R.\n\n> FWIW, I've been working on adding some nightly testing for Host1x/\n> TegraDRM, so hopefully we'll be able to catch such things easier\n> in the future.\n>\n> Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> Acked-by: Mikko Perttunen \n>\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=SaHglJh/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14016-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"SaHglJh/\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.221.43","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Spx32h6z1xvV\n\tfor ; Tue, 28 Apr 2026 14:57:29 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 0E01C3006826\n\tfor ; Tue, 28 Apr 2026 04:57:26 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 4DEB91EEA54;\n\tTue, 28 Apr 2026 04:57:25 +0000 (UTC)","from mail-wr1-f43.google.com (mail-wr1-f43.google.com\n [209.85.221.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E05464\n\tfor ; Tue, 28 Apr 2026 04:57:23 +0000 (UTC)","by mail-wr1-f43.google.com with SMTP id\n ffacd0b85a97d-43fe608cb92so7390635f8f.2\n for ;\n Mon, 27 Apr 2026 21:57:23 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777352245; cv=pass;\n b=NueWN4W/c1CP2G+ZMsMGjsSGPpXD1DXJj9oIGVJF795rcP7ig4dNd7fSzj096Ox1aGi+xdWSHFmUJSzc6ga9uofVaS9PGNRqbS1njD3Cv4YyqnhhrubYSbSmI2Ax0fyhfsCfUfAQJgLHY1jx8oJNtsiTgx9ojoXpzy8VzHfdnsk=","i=1; a=rsa-sha256; t=1777352242; cv=none;\n d=google.com; s=arc-20240605;\n b=iIw4B0OiocYgM/okKrXIl5ylJtxJqi84xiuqdaRtX1N0h1GppauEZrzfmMOc7ay5qF\n X7KXgim+SJHACyqGDIqsrNJHiBBiZTp6AeQAUVEKY84vR86/hxWrdnAVZlXR5HduK1JD\n uSnQ3WMjCZGc8H1pJgnpB7OT9q5snaiWRSkeCV5BCXeucfmzbKLMwQZRtUI2JapcXo/Q\n 5APEBLM3Az/kbFdRleZDqnHwYMxWwR3+/XpHjhshav/iVGV8ef1XYE9e/5B4wxe62T2q\n ZcGZ2hnuddeX3jklJyKwEzCdVRYq9AvPyKKguApASfe81D3USCEjBehdCQH2g9WClWzQ\n 6coA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777352245; c=relaxed/simple;\n\tbh=ncWWGMcEzmJUe2TRqBfOnes/WYshovyl3IhN3Cy8Ooo=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=n0PsMWUdxFjO12IsV6Ir4qeIOQy9r9EmwT5iH2/XGT8bK8ST5qZ3atvzNtn5MIDvRMgcIj72h20X3mbQmsZHJf6vHrgah9ek9VZq/yiGS/+syeJX5r6rhrwgjvQrMko9sr0Ue7mLqX/wRT8YWxsUwReEcATPEOvsDx9gqnRo17I=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=nd1/QqzjArDnTXh+sjQgJCmnUECsah1/qdKQYQu4dDg=;\n fh=A/D06L+fRp7ycI74gkLAPlyPxl+Jx37zhEN/0cABjuc=;\n b=JixpTwUtJLqT3IctrZX/37mwIA91yw4Lzv2tXClflfWmtcGYdTX2galCzjjQC7kPY4\n WG6ViAphh4DRljs2HTOYB8xuUENOq0ShuGFTcIguVcoEkcbB1X+Kv3i5fH9rIkjcQKLE\n DSVv9JaMPmKFtqug0dnZSydkgfEVnViuESWD3DCY5W6l/zqMmjZeKAENSLoOJxq6nA6H\n Y0Kpd5SImUOsSv1zez7yx6cG140mj00OtWg4+hWA+GYlos3SAs0mjcNeMkccJws8RXBy\n o3voooPHJM92y3+VlI/yAaQROTILwQEuIrjG3BV0mWzlrEOdAOiY7pQrqfmqBaQ10lCs\n NVqQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=SaHglJh/; arc=pass smtp.client-ip=209.85.221.43","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777352242; x=1777957042;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nd1/QqzjArDnTXh+sjQgJCmnUECsah1/qdKQYQu4dDg=;\n b=SaHglJh/rhs7rOR8MXEmRoG8PYoawiP0fzPknR30jnet36r3rfnrWg/p9Cz81o7Bcx\n yn1FwjqVIgr762mjrWoctL1xcSpZXFHSHikcvy3+e0YFzqsaPYXc/P1FXRSzXcRc3cx+\n ye1SAEvhoSQQzbTONbkg7jf4gZKrTmC+8VrarL2/sumZ11sneTCW5lmfWZOIhjVzpOHw\n 6d0Exv26mTU2AU+My1cq7JyeWFhdccc1BW0dII6sH96k9/7KO894d/s3NCpVvYMIpcyc\n +98lLZdVwsfNs6I1/PTCJpgKwl9x6WGgPjmDkGsuaEiGKJE/xdm97LYyX4Bv0XAVAo0b\n AnAg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777352242; x=1777957042;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=nd1/QqzjArDnTXh+sjQgJCmnUECsah1/qdKQYQu4dDg=;\n b=n+fIEo46iXfoA72oF9wgQboXqg1r0R1sMhkIlmt5xvqurAvNzXHGraQAH25Qc0kXM3\n iv9nr8q878wfdlfGJZ4DNrMfdgXyFIXHDKVCPcVGv9JzVL2z3vKpnBDU87iVCKGx9tQs\n 0fvlsaxzZpMVSWaCNFnz22wDXzuugAsTTfEIw/kzrh/aP6j6UKiTF2N8jSJ065bO2I6l\n oCHpVHkC338N9zYtLbZUCMYUwXdP1EhyKs8epCXHZc/fTlythjSfts6OC5qdgi45ap6P\n ibsuHYEzG3DSFmGR4nCLIg3fm4ks6gqthOFc5vVXN78+uhCCONbaKN9y6d/a9YAgrF/+\n KfTA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+KRojYfc7Ipe/sA6DOGHQbflOylYC2H3vmW//1QNImERx/vpCVkW25zOnCFfaNyTCNdCfInvn2rd3SRA==@vger.kernel.org","X-Gm-Message-State":"AOJu0YxqKU0JfDj08PglmZNwAxrU0Ec7kOAZ9QiSZJ3AnVKVTNrJNmyA\n\tBnXm3hdh4rNDbgXzm/0am85JgtKpH2nHrO0tdYloic6pHNDHLjN7BfHen13AOyKIi6TzUfp1QV5\n\tqxIudid3echMj6pqjNoa52GlS/5GKseE=","X-Gm-Gg":"AeBDietc/VWI+/kBu+WB+GTUtZXRI8ZWsgKY+IH55y1a3GuhAKYuX+0Wi+V8G3Rlmr/\n\tk32Ta0hg+KifFk1ZwHG1p5MYaxuiXY5M2ddWz7cybEv010RTTmm6EMGXFRQRpCca2udaIL+3+Yp\n\ts3uyQrNbckpJdWpm8AH8GOGyklbEd78UAoUMDoWNRHrpgStJtYZqn0ezT4ONv4IyjYFDTf+eY7O\n\tDlvph1pSHD9+xG8d78/EEJPAnytF7OPlug971T2OyYL5GHmK0LdNQPJbXnlDz4T/TzxZzFCog4a\n\tPQ7oov//YZAMSyAWs4E=","X-Received":"by 2002:a05:6000:240e:b0:43b:4136:1e6f with SMTP id\n ffacd0b85a97d-44649c9973emr2630806f8f.38.1777352241852; Mon, 27 Apr 2026\n 21:57:21 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260427075856.85208-1-clamor95@gmail.com>\n <20260427075856.85208-2-clamor95@gmail.com>\n ","In-Reply-To":"","From":"Svyatoslav Ryhel ","Date":"Tue, 28 Apr 2026 07:57:09 +0300","X-Gm-Features":"AVHnY4LI76aCvDtWfafVdfCQxyDNR500_itc7PsbVg4RhSzhSUX-qsfcx-3dp4A","Message-ID":"\n ","Subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","To":"Mikko Perttunen ","Cc":"Thierry Reding ,\n David Airlie ,\n\tSimona Vetter , Jonathan Hunter ,\n Ion Agorria ,\n\tdri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3684464,"web_url":"http://patchwork.ozlabs.org/comment/3684464/","msgid":"","list_archive_url":null,"date":"2026-04-30T06:23:14","subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Tuesday, April 28, 2026 1:57 PM Svyatoslav Ryhel wrote:\n> вт, 28 квіт. 2026 р. о 04:53 Mikko Perttunen пише:\n> >\n> > On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> > > From: Ion Agorria \n> > >\n> > > The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> > > paired with pm_runtime_enable in the probe instead of being inside\n> > > gr*d_runtime_resume().\n> > >\n> > > Signed-off-by: Ion Agorria \n> > > Signed-off-by: Svyatoslav Ryhel \n> > > ---\n> > > drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> > > drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> > > 2 files changed, 8 insertions(+), 8 deletions(-)\n> > >\n> > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> > > index 21f4dd0fa6af..71f092d59d65 100644\n> > > --- a/drivers/gpu/drm/tegra/gr2d.c\n> > > +++ b/drivers/gpu/drm/tegra/gr2d.c\n> > > @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> > > for (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> > > set_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> > >\n> > > + pm_runtime_enable(dev);\n> > > + pm_runtime_use_autosuspend(dev);\n> > > + pm_runtime_set_autosuspend_delay(dev, 500);\n> > > +\n> > > return 0;\n> > > }\n> > >\n> > > @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> > > goto disable_clk;\n> > > }\n> > >\n> > > - pm_runtime_enable(dev);\n> > > - pm_runtime_use_autosuspend(dev);\n> > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > -\n> > > return 0;\n> > >\n> > > disable_clk:\n> > > diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> > > index 42e9656ab80c..33e88ca4d4c5 100644\n> > > --- a/drivers/gpu/drm/tegra/gr3d.c\n> > > +++ b/drivers/gpu/drm/tegra/gr3d.c\n> > > @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> > > for (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> > > set_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> > >\n> > > + pm_runtime_enable(&pdev->dev);\n> > > + pm_runtime_use_autosuspend(&pdev->dev);\n> > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> > > +\n> > > return 0;\n> > > }\n> > >\n> > > @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> > > goto disable_clk;\n> > > }\n> > >\n> > > - pm_runtime_enable(dev);\n> > > - pm_runtime_use_autosuspend(dev);\n> > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > -\n> > > return 0;\n> > >\n> > > disable_clk:\n> > > --\n> > > 2.51.0\n> > >\n> > >\n> >\n> > Oof, looks like I had managed to really bungle this with my earlier\n> > patch. Thanks for fixing it!\n> >\n> \n> Hello Mikko!\n> \n> Thank you for taking time and looking into this patch. Don't be so\n> harsh to yourself, PM is easy to mess and hard to set properly. This\n> patch does fix gr*d access but it does not resolve the issue itself.\n> PM should be set in the init/exit rather then probe/remove. I have v2\n> which fixes this and one more minor issue and I will send them later\n> on.\n\nThanks! Why do you think it's necessary to enable runtime PM in init?\nIf you look at the commit I referenced below (in 'Fixes'), we've had\nsome issues in the past with doing pm_runtime_enable outside of probe,\nwhere the engine's power domain would be left enabled even when it is\nidle.\n\ngr2d/gr3d I suppose wouldn't be in practice affected by that issue\nthough given they aren't in their own power domains.\n\nCheers\nMikko\n\n> \n> So for now this patch should not be picked.\n> \n> Best regards,\n> Svyatoslav R.\n> \n> > FWIW, I've been working on adding some nightly testing for Host1x/\n> > TegraDRM, so hopefully we'll be able to catch such things easier\n> > in the future.\n> >\n> > Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> > Acked-by: Mikko Perttunen \n> >\n> >\n> >","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=I7QJZ7xW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14067-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"I7QJZ7xW\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.193.50","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5kdG4GY1z1yHv\n\tfor ; Thu, 30 Apr 2026 16:23:30 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 2339A300BB97\n\tfor ; Thu, 30 Apr 2026 06:23:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6588E3559DF;\n\tThu, 30 Apr 2026 06:23:26 +0000 (UTC)","from CH1PR05CU001.outbound.protection.outlook.com\n (mail-northcentralusazon11010050.outbound.protection.outlook.com\n [52.101.193.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BF1F740DFB4;\n\tThu, 30 Apr 2026 06:23:24 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by PH0PR12MB5677.namprd12.prod.outlook.com (2603:10b6:510:14d::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.20; Thu, 30 Apr\n 2026 06:23:20 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 06:23:20 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777530206; cv=fail;\n b=tD+BFEW25QMFYnyW0+LbdB64kJ4DAjsja1MvqGVFkClgyi3xSp3uNGzhMfTT22zct2ylFz1HTbfY4lnhx7rV+K/JHO7OHhWPykkM5KxZtHZjTX400LCKpbP2LutOCAA0sgWEpiw2j8MURhkIPoFT/2RiPxVWPMRz1VGUwofSygw=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=It5mWtgBqZ86uRaMbv0kNalOSlZxgoS9XXYSwpzl2RJBMCoFwApAFAmz0rjbjanogjZ3LLpUuYe6k5RoW7PIh7v8yKm4goGXftz71niSKK86lRw+uk8kBbXyMpzg5K8bsoRTDuwYxc3zEkIPO4RhaGEUJ7WHPLx43rZKL06wp42V7UxZNBw5/E8965Fz/mb3RmITrXxgMf4qY/2iMB0sqrTOOM0vzC0+OKV2Mq8EMj4jONSVSQ64Yu8dqAcJHr0mkdtch3WFkf9jzUbGxCDAQA3hW4ZHB1++YNX4D/MjJwBAGZd0bpvxP9p6Ypnqqi+A6yaosPQ8yLB3W2fF2eIvxg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777530206; c=relaxed/simple;\n\tbh=LjGGISeCzHDi+GGEhBqhCGGZlbCtX8WHh4UMMX4Pams=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=MDlHUUnT8FpZ8tKqF2ANg0ezI3Tv07nc9Vg+XEQ4cbMe9iLTef57dwdTmTusN/bm/op5luXH3LaNCWDi8zYwqzrFyG7GpZql5URqD9R1OUsZlXaiqPubwpUmRZi1SkUPSXgDFnYPtPrX1tLeKeOh9Bw7Eurgg/Qvh1V8GHMdWCs=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=aFsCPe6jAWYAsqP+wBYhlmoBNppSZ6W88RoeSy9J0Fw=;\n b=GCT4jrSMedeH5D9smXrvEO5GtBKl4Wp2KHCsv8yFiN7e9zjxWYEx8/Vlf22raafEpOgU/Th4py3hPygZ8N+8X1sP2rv1HiVka5o8T3PtEqjTh+CyGBvBls3zKzrJ8pMzIRwM+KORcsR6/l7D63OubCHe81EAhB9RxaWxAglk/Rg13uTSegquFc6Wtz+Oi0yH9jADc971xevBkzBxa+blFTQd3vwn87aame5HNybHRTa+fia7bDENnWXUbbQ3csML3bZVARAqXaGTzZ9Gww6K2JjnZVGZVWfZ68PY+BUEpqA0UTRfpSA/L0MIAUco1/E8LgX5SOlbUFfc+hvbbTieLg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=I7QJZ7xW; arc=fail smtp.client-ip=52.101.193.50","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=aFsCPe6jAWYAsqP+wBYhlmoBNppSZ6W88RoeSy9J0Fw=;\n b=I7QJZ7xWPkbs1KtNi1a6pI0/Ldx1FoyRoIEQZAvUDEtewp516pC4iYfGiVlE5iKwJLNnAMVZyfnHM6j4TRQxzP6WK/yH6Fnc6qeN+auVFtMep7nQ7PAnBRBwammNsMfld2W/ICbpUy9T9Q33FjZFp1yu7BHMk63rrU0K4YHdaiT9OEPMzHE7dmm9GRvs0z6p2Qnx5L+gE3H0X1lkJ2vkhjl4egYku1GiowPGq203CSy8FKo3wNlpDM6mr/UNQv0sGwVxOaSiAyNzRGMJ9ZDET3IVRUiub8IRA5ZDLc8oOmfthCk4HWQpo/UV/ZfD9RyWN9C9ZfE8OyYNuwIXa8fbJA==","From":"Mikko Perttunen ","To":"Svyatoslav Ryhel ","Cc":"Thierry Reding ,\n David Airlie , Simona Vetter ,\n Jonathan Hunter , Ion Agorria ,\n dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","Subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","Date":"Thu, 30 Apr 2026 15:23:14 +0900","Message-ID":"","In-Reply-To":"\n ","References":"\n <20260427075856.85208-1-clamor95@gmail.com>\n \n ","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-ClientProxiedBy":"OS0PR01CA0148.jpnprd01.prod.outlook.com\n (2603:1096:604:27::23) To SJ2PR12MB9161.namprd12.prod.outlook.com\n (2603:10b6:a03:566::20)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|PH0PR12MB5677:EE_","X-MS-Office365-Filtering-Correlation-Id":"a0113f5e-7373-49d2-9727-08dea680f93f","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|10070799003|376014|1800799024|366016|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\tejpbwU9lyfqXsfYgKn91RKXJP1hySOT1zL/1ySE2UCeK0oAh7qtHMEOF+7jxXsDbH1CV6nG1bUXSBpSqcM0PwKsHGxe8pbkpw55mCyG9Db0B5Mq+jXQ3UAIsxCohceJNmwkIC7DdHT1kA+0jMTzLErBzzQaEl5GRqCjP0vuLicqoB9X6wtTtiXEb25aAy780fWnpIdp5jJl5yB079/FjM6DnAODOzIMlszY8IMEO1E/9H0osdecExi1RrNIwaNYS6VryhnYGCWXo4AbOLrcOi649AE/3vA6Q41e9oJ64mTZSgXnvljL58MjwjAUV7zsx/fXJeXRho21/RC6MbWqmBOFglhhAEtiXgNQAmXU10LrF9DfZ6As4sMeAzb52+RLUyxxa13pc+BWzZz4f4KABWCQ2MR+eVjHtKkem4cyGI6zwLUBTeVoGvREvdAI1VU451q81oatUcfkponvZ+dw20s7RWNcKjGOKE1jiOk9vnEUiuaXcnquOakInGEWDJctE0uTu5xONuQrHPB/pSg1H9ixh8eXd+6T4GmUgsco+Uo7eiWzl/drMEjJz6PhChCpMYnfREaCdYSgjidf10Kn20UhlkZVrPSfxDrZ/yPAAcCUjLhOR6eun6QV2xwo0GSP5ZOUC9Ve32Cgjs2H5NxbweeUBAm1NiTBKYIT3eETG71JcW4wp6kUWKFmusem/Uky8GHkrGY8IK5/eMlBqS2hw1TEy7GBpVtfGsBObuVTlY24=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(376014)(1800799024)(366016)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?qAtv3iFHfTLBAV/TCbSYqmLk39Kj?=\n\t=?utf-8?q?PgSroYXX6D0h65pm2YR5fOr9BC4ZSoPioSm6Ka70S7PqegLNjU6mFzLsNSUssrBzW?=\n\t=?utf-8?q?zlfYx0qZZw3yZQoi27PAvgQm84FGLphEwhPmEsqNLkQ/TAqeCnXGLGnXwNAjEqJwr?=\n\t=?utf-8?q?m8Ud8aWy/n/hY30snCWQJAesUwAid9tqPdHmAlLA/jPkR+9lJKncuezgwbaaXobnj?=\n\t=?utf-8?q?JB5EZEGincS36B0021UpnR/np0k8c4Td9lnVYGodESqqj1JeP6kM+kUQ5BFhENzCG?=\n\t=?utf-8?q?IOfH0AOzKkiRP7AB9HOTXpmp+TGbs2jIj5xvn8e8ifixAYCtGIRWABvnb/H5o+Rlb?=\n\t=?utf-8?q?L8mnHY1OgJRly6uMLYHG8P3g4oVGPDc86IsyNHNcvicqhEB0eQRPxeGa4uavqV/KA?=\n\t=?utf-8?q?Wm6mZ6BH4qoom3VMtE5xV5/nZ9bvd6iB502Sh0tru4uGZXBudJJmpEUQL1ZcdTcYA?=\n\t=?utf-8?q?UOC4QcUXy/Rs9X5zzTStNg7aot9cMJhdqW0p5HojTwD428UG309but7wyBkUtWWPh?=\n\t=?utf-8?q?k0QeBNrYVzBW0z1ig0Fwq7y6ksSHjEpfCjUnT/47nGUXEbvuN9LID0Az545VS5qML?=\n\t=?utf-8?q?4gEqXEvWUYrLg95KEty2vytxquuTFvllU2gPFPYwIoBthPEPHZP+2XhF5Cc8l+/bQ?=\n\t=?utf-8?q?ra1r2epAmcjlExQGvz8Z3+E3q5YJpibk3Mk1EyCWQXYPu8QN3fsuBMKuqRZUHXhe7?=\n\t=?utf-8?q?69rDvhL2yNBjHQ6SztoolQWp5+WgHO1OxJ1tRC6W2+Zn9huYyils9Qi5URndDErU2?=\n\t=?utf-8?q?oVMG2G8vZeHaxXCGBGqhAGPCL2zDvh6icqqP4650w1bP7OWpYBTFwgNPG5VEEstOu?=\n\t=?utf-8?q?sILgEDk9puzIOn90KUArhxRpPiwr6/UNUxH8onOZiK2RtXX44Wy9/724BHxPJsTVw?=\n\t=?utf-8?q?4g0acWXxWcrwo3Gm/0mmJgYNXIwqWkYginbv5JyDCTldDORCuHxUNPOFlR5RGvoD0?=\n\t=?utf-8?q?lp0+Ent6yid9ZPC/XciDkOFWpYkETKp9bzBv8msgC9//npsoubv7r2blRFN0PGVgP?=\n\t=?utf-8?q?dOsQScKKUrBWkH2MhPeFKE9X+pMDq6rd6EDzdpDulClazqafjb31frDcCvBcxhRaX?=\n\t=?utf-8?q?rWUpE1LtCTWF3er8T2NVRLd2mo8CooghL9OS//+xUKCO33rRG8CaeE9FmGrTc0NeD?=\n\t=?utf-8?q?JMd7GAxC6BsuVE+DiymSwpcPsQy7s4mCJMOENTqpZL3tZ7H0sa/H5AZIHpyqFai7v?=\n\t=?utf-8?q?3pyqv9Qh6MyVyOQjCC8DZHAPX0yQ17SfMlb21WwWOhIxzR48/W2ugW3wjMqhRi0km?=\n\t=?utf-8?q?KKCkS3nQDPSyqFpY67rHnAS7NiNzPkTC5R7gY8XeIw+leOitFODlQo+GOdSCah25b?=\n\t=?utf-8?q?8yXK9VPTM1XrwrPHPEaDgaHOAQwxy8udFtCIYblcrwabJ0ieq1eX+hDYMbXpvNB89?=\n\t=?utf-8?q?kPscfYQrOZf/nWhWfwXS3oFxTNVI7AHmWKQejhKevaFevYOZYROG5reaLeo12lehF?=\n\t=?utf-8?q?1pEaI/nClv+7/vmdUNjYNqGlHMIdxeyhmPIWcZEWLbY+XOJvOYcvBDCLpJjcNI5f/?=\n\t=?utf-8?q?aRZZajjDYnJaO5bxuY3bXvjb3eJHbZXdoqOggk2LZTwFWNAybc3pKQ9ublDNAGitJ?=\n\t=?utf-8?q?S5J/8jD6UREbztICT7noKqGyGkt1gS/bdxlA5KW3+fRyMXshlpquiuwqaifSJfC2n?=\n\t=?utf-8?q?zpFRmpoUB55SzMJPWUDWZEvDd74PaQ+djZz37NCCfqVwYO2o11J1KSEgtroo4cdMm?=\n\t=?utf-8?q?IwXGEIGcSSbZZ8d6L?=","X-MS-Exchange-AntiSpam-MessageData-1":"hhykhcMfuSB1jw==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n a0113f5e-7373-49d2-9727-08dea680f93f","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB9161.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 06:23:20.3640\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ieNF4xsjS8CFh9zb69aufL7dGt2/PLApHKpurgheBOXRGEG+nzZ+9KeMB+IraDM0CnezuE2zpAZWLsZ/HRX+3w==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH0PR12MB5677"}},{"id":3684516,"web_url":"http://patchwork.ozlabs.org/comment/3684516/","msgid":"","list_archive_url":null,"date":"2026-04-30T08:04:32","subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","submitter":{"id":84146,"url":"http://patchwork.ozlabs.org/api/people/84146/","name":"Svyatoslav Ryhel","email":"clamor95@gmail.com"},"content":"чт, 30 квіт. 2026 р. о 09:23 Mikko Perttunen пише:\n>\n> On Tuesday, April 28, 2026 1:57 PM Svyatoslav Ryhel wrote:\n> > вт, 28 квіт. 2026 р. о 04:53 Mikko Perttunen пише:\n> > >\n> > > On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> > > > From: Ion Agorria \n> > > >\n> > > > The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> > > > paired with pm_runtime_enable in the probe instead of being inside\n> > > > gr*d_runtime_resume().\n> > > >\n> > > > Signed-off-by: Ion Agorria \n> > > > Signed-off-by: Svyatoslav Ryhel \n> > > > ---\n> > > > drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> > > > drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> > > > 2 files changed, 8 insertions(+), 8 deletions(-)\n> > > >\n> > > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> > > > index 21f4dd0fa6af..71f092d59d65 100644\n> > > > --- a/drivers/gpu/drm/tegra/gr2d.c\n> > > > +++ b/drivers/gpu/drm/tegra/gr2d.c\n> > > > @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> > > > for (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> > > > set_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> > > >\n> > > > + pm_runtime_enable(dev);\n> > > > + pm_runtime_use_autosuspend(dev);\n> > > > + pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > +\n> > > > return 0;\n> > > > }\n> > > >\n> > > > @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> > > > goto disable_clk;\n> > > > }\n> > > >\n> > > > - pm_runtime_enable(dev);\n> > > > - pm_runtime_use_autosuspend(dev);\n> > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > -\n> > > > return 0;\n> > > >\n> > > > disable_clk:\n> > > > diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> > > > index 42e9656ab80c..33e88ca4d4c5 100644\n> > > > --- a/drivers/gpu/drm/tegra/gr3d.c\n> > > > +++ b/drivers/gpu/drm/tegra/gr3d.c\n> > > > @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> > > > for (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> > > > set_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> > > >\n> > > > + pm_runtime_enable(&pdev->dev);\n> > > > + pm_runtime_use_autosuspend(&pdev->dev);\n> > > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> > > > +\n> > > > return 0;\n> > > > }\n> > > >\n> > > > @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> > > > goto disable_clk;\n> > > > }\n> > > >\n> > > > - pm_runtime_enable(dev);\n> > > > - pm_runtime_use_autosuspend(dev);\n> > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > -\n> > > > return 0;\n> > > >\n> > > > disable_clk:\n> > > > --\n> > > > 2.51.0\n> > > >\n> > > >\n> > >\n> > > Oof, looks like I had managed to really bungle this with my earlier\n> > > patch. Thanks for fixing it!\n> > >\n> >\n> > Hello Mikko!\n> >\n> > Thank you for taking time and looking into this patch. Don't be so\n> > harsh to yourself, PM is easy to mess and hard to set properly. This\n> > patch does fix gr*d access but it does not resolve the issue itself.\n> > PM should be set in the init/exit rather then probe/remove. I have v2\n> > which fixes this and one more minor issue and I will send them later\n> > on.\n>\n> Thanks! Why do you think it's necessary to enable runtime PM in init?\n> If you look at the commit I referenced below (in 'Fixes'), we've had\n> some issues in the past with doing pm_runtime_enable outside of probe,\n> where the engine's power domain would be left enabled even when it is\n> idle.\n>\n> gr2d/gr3d I suppose wouldn't be in practice affected by that issue\n> though given they aren't in their own power domains.\n\nWDYM, gr2d and gr3d have their own power domains.\n\nIf the master device is unbound and rebound, gr2d_init() will run again, but\npm configuration is only located in this probe function which will not\nrun again, while pm disable are both in exit and remove. This results\nin pm issue we are observing.\n\nSolution would be either do everyting in probe/remove, or init/exit.\nProbe/remove will lead to domain being turned on even if engines are\nidle. Init/exit seems to me more suitable and we have tasted this\nconfiguration for a quite while in the grate DRM version.\n\nBest regards,\nSvyatoslav R.\n\n>\n> Cheers\n> Mikko\n>\n> >\n> > So for now this patch should not be picked.\n> >\n> > Best regards,\n> > Svyatoslav R.\n> >\n> > > FWIW, I've been working on adding some nightly testing for Host1x/\n> > > TegraDRM, so hopefully we'll be able to catch such things easier\n> > > in the future.\n> > >\n> > > Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> > > Acked-by: Mikko Perttunen \n> > >\n> > >\n> > >\n>\n>\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gSHZwcPT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14073-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"gSHZwcPT\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.128.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5mtF3t76z1yHZ\n\tfor ; Thu, 30 Apr 2026 18:04:53 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C001B3006B0F\n\tfor ; Thu, 30 Apr 2026 08:04:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9478638D688;\n\tThu, 30 Apr 2026 08:04:49 +0000 (UTC)","from mail-wm1-f52.google.com (mail-wm1-f52.google.com\n [209.85.128.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DFFD21E1DE5\n\tfor ; Thu, 30 Apr 2026 08:04:47 +0000 (UTC)","by mail-wm1-f52.google.com with SMTP id\n 5b1f17b1804b1-4891e5b9c1fso5562325e9.2\n for ;\n Thu, 30 Apr 2026 01:04:47 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777536289; cv=pass;\n b=LkD3sN9sVJGG54VeLoEX2e9fuBT4WUO/Jr6p8C7xxl8Udxn2TVl2IxpCMiyWKxcXyL/14ehKyhgfiNfSE4B8+5oiaSM3nh88K4VQzvmuhNpkw4DgXeKx9qWo3MZ0lLX4aR7jY0+/9GjIMIDyeR0R/YJi2J5O9fns0fdq+jcMHUQ=","i=1; a=rsa-sha256; t=1777536286; cv=none;\n d=google.com; s=arc-20240605;\n b=ZYD1xTDPKceeC7mW2iPYNzbTngOlkjwSvZmc1bxWLulYFzXcivBZvf796YOCFCNM5s\n CMEKUz6iTCW+Sc5PGgcuds5CAy0Z+CklAn/3nhSoQN8DvsCMFLyPyLE+DPTmecPSI6SC\n MO8o28pPX/NRFSO7P3jVsVMz1G55usExVUccE/IZflmYEAjulk0qHWrhXQ0tT2WiDjnb\n PBudZ+QVFZHuLnilwrAlu7XtDb8t5fxbvnwn8/oJMcivQqCQnx+2xEwUBWlqwrleAsXr\n mmgAQ9wFbqneLVuJ4DudPj2tO1AngeVRjh4JX+GkQr6fGxsZOxiTNj5t8Sa58qIQO8Zb\n WFEQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777536289; c=relaxed/simple;\n\tbh=INJcuWEXGOjWHDT+RH1pIaFwUniIVXtLPsYxOQAyTWw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=tSsIffKHzNcTzrN4w2Xb1nASQG3xh9tlCaWeoRz7fwXLpGJ0MRfTnK9jbWNeERI6D5bjaDUygRtZ7gGnmXBXkksj+jmJFaImma70okJdAh8WHYI+Y2vdwhVjmsQGavRlwiUic4bGt+xcT1Qd2urWwnj8qH0Z6W9v6zfdguzG7hA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=aZrGBqXYPdLgNn5aQC9hh+9jzHstDAbAkt2IwwGF1kY=;\n fh=cAloTEfeMUQgg4JAtruTrqBM8HQcKQXuzprS/3xdRMk=;\n b=elsyUALEjkoAbT0QVo0aaWD46MYeVXlia3RKZEEvGVLXfhkPHZdC8oPIC+fjVYleaL\n 7dVfM7MGEIqS8rmFOZlLaksKPIDjes9Ryju3jH+kas4seveONN+ypV7qCEDtCjeoRhMp\n XNY2jnTL8tTroiUfto+G9gHfdmf68SvKQIfyEUZeSZgo9De4VQShmeF+x4mt6go8tk93\n eM0qgFekEXFq6tEJf7sOoExC2m9jhOs2AG1VlpEMAflYH0HIZPmLHZbt9x8GIN0UyeHa\n GHL5XcWZecw4FYfm4ufC52Zh09YIpVhflECqJi8UEWqiPeErAcdJdDfVtPckOUmWovnY\n ZUwQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=gSHZwcPT; arc=pass smtp.client-ip=209.85.128.52","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777536286; x=1778141086;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aZrGBqXYPdLgNn5aQC9hh+9jzHstDAbAkt2IwwGF1kY=;\n b=gSHZwcPTu3WGNmWP1hGARLxzEtIUL0qlKCg6t2DvCa5oajoLKzMZuehT8AxnCUEjDX\n Zab1NjGCFpoP6Oeht6AfBK0QVW0wY7C2fAuOosgSpYgX2UZ7OoLmuE+j2iRI6Fq+Ztye\n bnwLGAx/rtcfBLY928/la4+ZQJDX6jnmt4NFmWpL8qeMCMmU1OSJ/uhHDcqXxxCuqO5A\n jKKXfxerPIU0LyuP2D2jj2mSH7HCMh5ENsPYOQDVYWEMI4zd8zh5oP3mnpTTvuLAWjFq\n 8EaZvtXw6es58+5b0V1D8ltinedaYf9sdW+eYjmU5v+hk/krw/gIW1FOA53Uqg8MZtoA\n rVJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777536286; x=1778141086;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=aZrGBqXYPdLgNn5aQC9hh+9jzHstDAbAkt2IwwGF1kY=;\n b=GpkXtHefBk+oxP96c7CHSheoDzw8LP4XJ3ETSq9pr8gX+dpYGvJuQnN3v7sitBcR6E\n p66j8vV+iq09eW8OoY5R+B9iNgxGaq1FgOgnS1RKflsIy6+Xqraov9lwOkd4nx37ZOmA\n mw+/zJbZRMlinaJ+fIbB9LY0oIixgCzzm/VhRWwScVOsGbAbJtXTnozfm+JXurqIejvu\n q+ZFF8AERGXbjBmV209z0X4/BKJhiOdyZXd7bs+ow7ltIrfSP+/IiaR57OXrUwCUdIL7\n Dan2PYFw7DqDluZB7NF0yJzWpCR0X7eLmkXI7B0tK9xVjyMnIYNL4XkcVMPj5iKkRRjD\n KFqg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/RXEBgdaeLBop+Kv8EA8Yce63lAw+Nh3lg54jI2uEaKY9MejeD7ZAb/lb92zyC3DHTWsXiFio2lWrwvQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YzVQUFvsA3G4lYz5zc19wTuHa2ycRePjZotxjHqVs3rtpnZaVDC\n\t0OYiymjqUFVe6ZC6fZMAfa5wiKnku7wv5ozUnZgqPSCjKYT5gpfbgAI6RvDA2j18rfUhh12cF/R\n\tI2Lm8ytATv7HIiLGB9QtXZCUztzLE7uoLGIEFyK0=","X-Gm-Gg":"AeBDieur14LXX3P5Gue4NTqIxxqe0F93+yLjb3bHqmLj0VAD8gNonJSuza3BCOu5ZKr\n\tDUKHje1FxN1EpAkRh0IXNTfQHfEREzNwm5Eb2kARRGvLZoqeI5l/SU/1quI0F3kHXWLDiisE5pC\n\tOgb2+ma7IXsRELHKa2pyaTnebVAyQ4mGuR8r0WJuF3wQwEnd1AHBRE4D0RJ61ABlzSVfwkg2V6H\n\tKF3yDvch3zts2gBpFsPu/61O6t0rXmfxXO1oO2EAx/4Szp6ZH0LhhFsp/ooDV8d5Oqurs8+xVdE\n\tbFWh24e4OgBNWUu187Q=","X-Received":"by 2002:a05:600c:6285:b0:488:a797:f0ac with SMTP id\n 5b1f17b1804b1-48a84485623mr32551075e9.28.1777536286057; Thu, 30 Apr 2026\n 01:04:46 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260427075856.85208-1-clamor95@gmail.com>\n \n \n ","In-Reply-To":"","From":"Svyatoslav Ryhel ","Date":"Thu, 30 Apr 2026 11:04:32 +0300","X-Gm-Features":"AVHnY4J3f47Ssn3vff5AA01Azy11Bi0ZSOBuJyaaCs1Zt8ajGgiFrXmKZX1YrmQ","Message-ID":"\n ","Subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","To":"Mikko Perttunen ","Cc":"Thierry Reding ,\n David Airlie ,\n\tSimona Vetter , Jonathan Hunter ,\n Ion Agorria ,\n\tdri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3684536,"web_url":"http://patchwork.ozlabs.org/comment/3684536/","msgid":"","list_archive_url":null,"date":"2026-04-30T08:38:28","subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","submitter":{"id":26499,"url":"http://patchwork.ozlabs.org/api/people/26499/","name":"Mikko Perttunen","email":"mperttunen@nvidia.com"},"content":"On Thursday, April 30, 2026 5:04 PM Svyatoslav Ryhel wrote:\n> чт, 30 квіт. 2026 р. о 09:23 Mikko Perttunen пише:\n> >\n> > On Tuesday, April 28, 2026 1:57 PM Svyatoslav Ryhel wrote:\n> > > вт, 28 квіт. 2026 р. о 04:53 Mikko Perttunen пише:\n> > > >\n> > > > On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> > > > > From: Ion Agorria \n> > > > >\n> > > > > The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> > > > > paired with pm_runtime_enable in the probe instead of being inside\n> > > > > gr*d_runtime_resume().\n> > > > >\n> > > > > Signed-off-by: Ion Agorria \n> > > > > Signed-off-by: Svyatoslav Ryhel \n> > > > > ---\n> > > > > drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> > > > > drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> > > > > 2 files changed, 8 insertions(+), 8 deletions(-)\n> > > > >\n> > > > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> > > > > index 21f4dd0fa6af..71f092d59d65 100644\n> > > > > --- a/drivers/gpu/drm/tegra/gr2d.c\n> > > > > +++ b/drivers/gpu/drm/tegra/gr2d.c\n> > > > > @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> > > > > for (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> > > > > set_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> > > > >\n> > > > > + pm_runtime_enable(dev);\n> > > > > + pm_runtime_use_autosuspend(dev);\n> > > > > + pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > +\n> > > > > return 0;\n> > > > > }\n> > > > >\n> > > > > @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> > > > > goto disable_clk;\n> > > > > }\n> > > > >\n> > > > > - pm_runtime_enable(dev);\n> > > > > - pm_runtime_use_autosuspend(dev);\n> > > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > -\n> > > > > return 0;\n> > > > >\n> > > > > disable_clk:\n> > > > > diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> > > > > index 42e9656ab80c..33e88ca4d4c5 100644\n> > > > > --- a/drivers/gpu/drm/tegra/gr3d.c\n> > > > > +++ b/drivers/gpu/drm/tegra/gr3d.c\n> > > > > @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> > > > > for (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> > > > > set_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> > > > >\n> > > > > + pm_runtime_enable(&pdev->dev);\n> > > > > + pm_runtime_use_autosuspend(&pdev->dev);\n> > > > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> > > > > +\n> > > > > return 0;\n> > > > > }\n> > > > >\n> > > > > @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> > > > > goto disable_clk;\n> > > > > }\n> > > > >\n> > > > > - pm_runtime_enable(dev);\n> > > > > - pm_runtime_use_autosuspend(dev);\n> > > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > -\n> > > > > return 0;\n> > > > >\n> > > > > disable_clk:\n> > > > > --\n> > > > > 2.51.0\n> > > > >\n> > > > >\n> > > >\n> > > > Oof, looks like I had managed to really bungle this with my earlier\n> > > > patch. Thanks for fixing it!\n> > > >\n> > >\n> > > Hello Mikko!\n> > >\n> > > Thank you for taking time and looking into this patch. Don't be so\n> > > harsh to yourself, PM is easy to mess and hard to set properly. This\n> > > patch does fix gr*d access but it does not resolve the issue itself.\n> > > PM should be set in the init/exit rather then probe/remove. I have v2\n> > > which fixes this and one more minor issue and I will send them later\n> > > on.\n> >\n> > Thanks! Why do you think it's necessary to enable runtime PM in init?\n> > If you look at the commit I referenced below (in 'Fixes'), we've had\n> > some issues in the past with doing pm_runtime_enable outside of probe,\n> > where the engine's power domain would be left enabled even when it is\n> > idle.\n> >\n> > gr2d/gr3d I suppose wouldn't be in practice affected by that issue\n> > though given they aren't in their own power domains.\n> \n> WDYM, gr2d and gr3d have their own power domains.\n\nAh, my bad, didn't look far enough in the device tree.\n\n> \n> If the master device is unbound and rebound, gr2d_init() will run again, but\n> pm configuration is only located in this probe function which will not\n> run again, while pm disable are both in exit and remove. This results\n> in pm issue we are observing.\n> \n> Solution would be either do everyting in probe/remove, or init/exit.\n> Probe/remove will lead to domain being turned on even if engines are\n> idle. Init/exit seems to me more suitable and we have tasted this\n> configuration for a quite while in the grate DRM version.\n\nYes, we should only do it in one place. Where are you observing the\ndomain being turned on when idle?\n\nGenpd turns on the domain before probe is called, and it should turn\nit off again after probe if probe had enabled runtime PM and the usage\ncount is zero. That's what we have currently for the newer engines like\nVIC and it's working.\n\nWe used to have it in init/exit, but then we were seeing the domain\nsometimes being left on at boot, which makes some sense since as probe\ndidn't enable runtime PM, genpd would leave the domain powered after\nprobe. The domain would then also never get powered off when init\nenabled runtime PM. I assume the reason this only happened sometimes\nwas that it was dependent on if the init function or the genpd\npost-probe code ran first.\n\nBased on that we should have the runtime PM handling in probe/remove,\nto ensure genpd turns off the domain after probe when there are no\nusers.\n\nMikko\n\n> \n> Best regards,\n> Svyatoslav R.\n> \n> >\n> > Cheers\n> > Mikko\n> >\n> > >\n> > > So for now this patch should not be picked.\n> > >\n> > > Best regards,\n> > > Svyatoslav R.\n> > >\n> > > > FWIW, I've been working on adding some nightly testing for Host1x/\n> > > > TegraDRM, so hopefully we'll be able to catch such things easier\n> > > > in the future.\n> > > >\n> > > > Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> > > > Acked-by: Mikko Perttunen \n> > > >\n> > > >\n> > > >\n> >\n> >\n> >\n> >","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=tG/Zh8Ez;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14075-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"tG/Zh8Ez\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.52.42","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5ndH39Gnz1yGq\n\tfor ; Thu, 30 Apr 2026 18:38:43 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id C705C30065C0\n\tfor ; Thu, 30 Apr 2026 08:38:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2670E3FE350;\n\tThu, 30 Apr 2026 08:38:40 +0000 (UTC)","from BL2PR02CU003.outbound.protection.outlook.com\n (mail-eastusazon11011042.outbound.protection.outlook.com [52.101.52.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4435138E106;\n\tThu, 30 Apr 2026 08:38:38 +0000 (UTC)","from SJ2PR12MB9161.namprd12.prod.outlook.com (2603:10b6:a03:566::20)\n by CY5PR12MB6228.namprd12.prod.outlook.com (2603:10b6:930:20::6) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.16; Thu, 30 Apr\n 2026 08:38:32 +0000","from SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017]) by SJ2PR12MB9161.namprd12.prod.outlook.com\n ([fe80::d9d1:8c49:a703:b017%4]) with mapi id 15.20.9870.020; Thu, 30 Apr 2026\n 08:38:32 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777538319; cv=fail;\n b=YbFIvoaQcOoQtbjaMj5xbFlc99rCggBUq/6rT4Cz9QciEXOqdgVHoYP/9mmQFCjA5KkPZzgnJMsnx2nKRQO9Ls1ju4zd/hl0qj3c0RJ6thNqb4NDpbRsuXsAow1ZFOuGl+wT089R9HntBHq/6BHG6gIkalopXYp6kCeCBtg93ws=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=rXxS3hq5DeWzOe9LMDlWv717tgRd5Ge39Mvp+9gtH1X3jRnfoJndC6EwrlJ0hW4s0SvWS5SCyvRd/BBRKD0RTuxkj9SWO3NiHHgY/PoFcII9343lDjhuba4aPsWrcZP7MXZNca2MatrKKgMGXiE4vphGPvD4RxC+CDQwUBf/nRQyfGaMzJIoVIOXOyUbe5DAWGK/Plc3d+0rFUuWQgzifVoqFDggW/3y5P2xSynrjRdxIUM7CjMVIdsOuWE/E0kFLfxOTGiRYKhX1nOHK4qZhU/yoY4hNF3FSH3Neb0hbYmUgeh03kc8kaghCX4mcHzL8hn0N12GZT+YLceCMLIIJA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777538319; c=relaxed/simple;\n\tbh=XJVzrUb9HkiJAAjYbUo6AgKt/n6H1dA0+l7EcnydrN4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=A/TNffpe7GOBH4hl5GRHu2766fSjpILK5qM0CsafFCSpkLYsoNxTszzKoyRrxsC34M9mJIFqNo0sgIbTcjHg+ngYy2w/1NjBpLy0PDR+20JgU37+k94+T8WJzhb7jeGZpDpEI2P7ja0s4W5W/o4VtKLejVojdy+r/ATWDjshoSg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AbZArEKi2F+Ir6HbtZqOUx/DtAWM/rMSCUdRr5LwQH0=;\n b=ad8MBKY+6tu5YiHku0V3MyzhJOcrNkoro/JYVaprKisGUndDtBuWMYRNoUYhPlKpYeak6dyyCNW+VCjsj9yTISXya++CVkOU+RTFhEFMegVFF/R02mKvbhRK/HDB47BMvOqqWviVb+aYEuTmrX5woZmoUJgMT4pxLE6Uj+vdnOJZAz+f5jNghDwHgRX8ytl5tTSbYxTDtkXjivmK/YX1WzYqXzmkGquapbNv/QlxFFDB7npWoGBj3eIl6RbRDC+ExSo2eaZPjus+lMl5pwjHSLhIPLYKpDMdXUh8mzRNsVNUN+pm4VASuZeKdSNscuytlaZuMiQRAm/VBbnj6lo7OQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=tG/Zh8Ez; arc=fail smtp.client-ip=52.101.52.42","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AbZArEKi2F+Ir6HbtZqOUx/DtAWM/rMSCUdRr5LwQH0=;\n b=tG/Zh8EzT+5Stod4I1RMDS4tOSsK2qtPAdO6Otw4o2zpGSimGpq16Z3NJbks9UQtZhokClPdUHjU71SE/ArEFU22ONvU28Zc2C9AQEk6qcaTcQv3ZsaRn/HyQB+D5Tcco+I49fdXpl6HbELYQJMPp6KReXXFiHbQ9+FgGHIc4Dn4KeyvpvNcYwVC+lwy5CednuuRO55WhzZGfZh50GlEPsqrhckpm9P6Fgp0GcMwQWRPKxeW9rPDvUnEjGkyN6aTWxKVXOZZEksO/wFr9gdbPVfufFc4Jn9SJqUsyLGRocsdPmejKqdShbKr9lNE3o6ZMITeh6MWZKzoYWS6eWAJmQ==","From":"Mikko Perttunen ","To":"Svyatoslav Ryhel ","Cc":"Thierry Reding ,\n David Airlie , Simona Vetter ,\n Jonathan Hunter , Ion Agorria ,\n dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","Subject":"\n Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe","Date":"Thu, 30 Apr 2026 17:38:28 +0900","Message-ID":"","In-Reply-To":"\n ","References":"\n <20260427075856.85208-1-clamor95@gmail.com>\n \n ","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-ClientProxiedBy":"TY4P301CA0039.JPNP301.PROD.OUTLOOK.COM\n (2603:1096:405:2be::14) To SJ2PR12MB9161.namprd12.prod.outlook.com\n (2603:10b6:a03:566::20)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ2PR12MB9161:EE_|CY5PR12MB6228:EE_","X-MS-Office365-Filtering-Correlation-Id":"4f018fd1-77c3-4854-0a45-08dea693dc4c","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|10070799003|1800799024|376014|366016|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tqMSNv/Mo/+x1nE0nvAfKe+ZAi8P0LfYcmvzFp+4QcwRllePYbqA8WShoXzCA+ZKG9ApI4tw2FauLntkNfIYjqzLYOti9LUtbtuY6Eqh5RA3GVHu496fz1/cVBDsLbTfQ8+Ear3i7tqw6YfG/xYYLYN0/r9XuTlwNLKXubOlctA+3+pNHXqidOhS2UPN6f2Y47ZhGI6Yzi2ZpuBSWfsknyVMTqRuNL+29DhQrox2jZqaR4TDdZ7CxKj+k72eX+vaToYZYMbSahFQsQN0f7SVoQlqpa9ZTZ50Ki/L200Xu8/oQvswLE6O0uH5n65dv0zUli3rUjBZjT6HtOQRzVG/WkbuQeOKkIuDVd3uRB2PGcobuyRGoeTaXL0H5bq/UAhj93nl9xgbA+PBMRX3j41xtb0DzCrdWF52QyupDzXs/ipew/E7oTMg2Wm7Ui2Vo7KRGYXU16MmUs2IA1YJ5cfrz+wBzZN5jHCgk7ACrhl16RFecq/60tNx2dm8a7elXOwgy2/EJHy9slptOgXbftwyvtWD8RmVACeVDzaMd7sqWApoRXutiCuK/hI7DlwdWmZpkvGh6LZuZoXQ294T2sRw5b/k53flWOtE7/Sw1Pb3VD311lRxpBSAK4iBd9rA409+GsEUbisMtPnYi0tZXTCZ/iPe85iKnmrz3Ib8dwlYoyNB03d2NU20Ltgy+f6o5Wx3Yq3Z9It3tEDBrON8KG0dEUAzaCogkPDccX1s5CA0SdKk=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR12MB9161.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(376014)(366016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?lrvxuivW2F2preCpqp7uIvQ8E+6W?=\n\t=?utf-8?q?MzFfuvsWoFWaTY9eEgMaL4xeA9cNXRfMljPNXCAAxCJc+pqQXRnNdGB3SBaOjL7+Q?=\n\t=?utf-8?q?8aJ5FFHsy8U9WppOgMZyatFF/6J9peAYISS7aURClxqK15oFwxyJetIjuF/eTk/Qp?=\n\t=?utf-8?q?BSHZFUVUbkF0x1VEEXkqahq01I+qOmlJ4y8h49inUlTjF1Cz7oxGRxzJn5clRqAbi?=\n\t=?utf-8?q?45nUQMAxqmvzN6397Oo8In4jgMNmXk/uKfAbajN79NrLwn3O+Wrz7BM2NbZW1ChIe?=\n\t=?utf-8?q?X8ZFLq3na2KM87QJbzfhdtrWESsKexEnsu8DGJYaOaobXlJoySrs4eL2chY9YM4rd?=\n\t=?utf-8?q?QBScWlePPgO8/qealcjLLSPGiZsZ4flQpTtf2RMwy03mb0ySiQzWe+XgRg+CTy2D+?=\n\t=?utf-8?q?OmjgjL3yntUrJ7PwHMIQBpk339tpsS0awrKn9R0tO6BOWytjAWxhN3BcanwsECnei?=\n\t=?utf-8?q?qPi9J46qz5vrIp2849dioNu6XyBW9fAkk9fEv9vm98XpG9nx7mQ1KRaXufyOFUm1J?=\n\t=?utf-8?q?2ADHBnytcen/7gRtY4MaGY9uIyO3D23qCYFi1Ioo9KpcLahYflnHnCe0GRK8pi5od?=\n\t=?utf-8?q?CLsqYk+nTffWgrSho9jWByatr/CiGilxwXiw1mchHU3igIYguUEXxax5bp/NeG/vN?=\n\t=?utf-8?q?Px1YRaZ3L7rb6P5YyAKhoXLzIaTbwzHRjuWPSmL/5RViCskKI+d8beW1PO395hnXX?=\n\t=?utf-8?q?Y+pTFvV2DMU9Kef3FxrW1YNPgUry5avmNS7wed14vXldMufbzc/yK+KgvjYVwPUnx?=\n\t=?utf-8?q?eENO54t6cfPV7i8MnuvMjNI3gYpAtGp9zOk5x3AHStzLid8IVpl0HKFaApVeXTHZo?=\n\t=?utf-8?q?ltMYZHmyTFSmEj3Sq3FNbpz23RYlNsd+o/0D+bYAc3Ks1fY+wkvC2xbsTyNmf/puA?=\n\t=?utf-8?q?rl4Z9vabmT0iEkRRYmN2Ih3jmXCs5EJCczmRnzkeVeTidP4Rd/6iaEu/9KNxSX00M?=\n\t=?utf-8?q?SIqRB+TB7QiiBw3WCyvCHx2hjlDddnVjF4t19+1UOUCTSneDd+LtA1+6GjBsshBKL?=\n\t=?utf-8?q?uqHUij00G4Yd6RBNrjFBlOKYGjdNNCpQ9XiM6G5TVGMdqD3qCEONUk313k5y2k8Ha?=\n\t=?utf-8?q?lGGI77g1qwdOkhRBKkS1O/t+RSXh1gY6s5sOr3bpJ1T+PhuqYV5IXW2zSKoqTUESq?=\n\t=?utf-8?q?GwrBYSf9lSE6XNq7JYYeuzczOOdmQ0Dfb5d26/9fvpiUGqgpi2hs0bSj7aNjetk2t?=\n\t=?utf-8?q?NIN15BS5KsTCV08EHWqq8tdJYqwix0pEz3QDkrJ2HIf0FY4SAUbNaq3Ke8cWEbZPO?=\n\t=?utf-8?q?XLsFKEtTEKomzQ15E16QRMcIoEkw32jlLtG69XLXQqsSk1VdLCN7/XiEod8MfM1xz?=\n\t=?utf-8?q?N+oed7vgpsKF6uliaQVUwxc9n9jU1jcwj3kfOhrupNAqYuXMedi8bohjlThQFB7/3?=\n\t=?utf-8?q?hia8RjhFgGFa6UW4LCS/wEY+zk3e9jt+aSsDbp62it3eWejWfo7fkmrSFFPDn7/th?=\n\t=?utf-8?q?PHBCt/Hsw7d6qoQei/knhdGlNqLtmFUI3gi73BAefQ9SV7qEjy6cN+2AH7+I7DhC4?=\n\t=?utf-8?q?FXq8ZAE5zWI14h0H9YKM5knHJug6k5Y/ALDJSIgXMW72aHhgV1jZb7JLjppT9u90W?=\n\t=?utf-8?q?Eh0k0mb4EjQ71E5+egdLtJryTsR/W0uxnv0DS5Edyw6EsoQYwhvwSNbMjFKH9nl08?=\n\t=?utf-8?q?QYSKgwAW1OqwsTs89cSAWg+sUsGH2I8ePEMfu+fEG9SdrPFTIVsjUoOk5iPw4bc+m?=\n\t=?utf-8?q?XPLgBhnycnfEaq7EC?=","X-MS-Exchange-AntiSpam-MessageData-1":"StqUAF3oVsq8Ag==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 4f018fd1-77c3-4854-0a45-08dea693dc4c","X-MS-Exchange-CrossTenant-AuthSource":"SJ2PR12MB9161.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"30 Apr 2026 08:38:32.1847\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n xZ/e1bs0Keyp3+Bqy0JDMp/IoeeDVdjolCrehfkLvHaT6JNMRVTgLQM4D06D9XIKVUjezlRjoTcQ6sNsj7RbbA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY5PR12MB6228"}},{"id":3684553,"web_url":"http://patchwork.ozlabs.org/comment/3684553/","msgid":"","list_archive_url":null,"date":"2026-04-30T09:09:57","subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","submitter":{"id":84146,"url":"http://patchwork.ozlabs.org/api/people/84146/","name":"Svyatoslav Ryhel","email":"clamor95@gmail.com"},"content":"чт, 30 квіт. 2026 р. о 11:38 Mikko Perttunen пише:\n>\n> On Thursday, April 30, 2026 5:04 PM Svyatoslav Ryhel wrote:\n> > чт, 30 квіт. 2026 р. о 09:23 Mikko Perttunen пише:\n> > >\n> > > On Tuesday, April 28, 2026 1:57 PM Svyatoslav Ryhel wrote:\n> > > > вт, 28 квіт. 2026 р. о 04:53 Mikko Perttunen пише:\n> > > > >\n> > > > > On Monday, April 27, 2026 4:58 PM Svyatoslav Ryhel wrote:\n> > > > > > From: Ion Agorria \n> > > > > >\n> > > > > > The gr*d_remove() has pm_runtime_disable, this indicates it should be\n> > > > > > paired with pm_runtime_enable in the probe instead of being inside\n> > > > > > gr*d_runtime_resume().\n> > > > > >\n> > > > > > Signed-off-by: Ion Agorria \n> > > > > > Signed-off-by: Svyatoslav Ryhel \n> > > > > > ---\n> > > > > > drivers/gpu/drm/tegra/gr2d.c | 8 ++++----\n> > > > > > drivers/gpu/drm/tegra/gr3d.c | 8 ++++----\n> > > > > > 2 files changed, 8 insertions(+), 8 deletions(-)\n> > > > > >\n> > > > > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c\n> > > > > > index 21f4dd0fa6af..71f092d59d65 100644\n> > > > > > --- a/drivers/gpu/drm/tegra/gr2d.c\n> > > > > > +++ b/drivers/gpu/drm/tegra/gr2d.c\n> > > > > > @@ -286,6 +286,10 @@ static int gr2d_probe(struct platform_device *pdev)\n> > > > > > for (i = 0; i < ARRAY_SIZE(gr2d_addr_regs); i++)\n> > > > > > set_bit(gr2d_addr_regs[i], gr2d->addr_regs);\n> > > > > >\n> > > > > > + pm_runtime_enable(dev);\n> > > > > > + pm_runtime_use_autosuspend(dev);\n> > > > > > + pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > > +\n> > > > > > return 0;\n> > > > > > }\n> > > > > >\n> > > > > > @@ -367,10 +371,6 @@ static int __maybe_unused gr2d_runtime_resume(struct device *dev)\n> > > > > > goto disable_clk;\n> > > > > > }\n> > > > > >\n> > > > > > - pm_runtime_enable(dev);\n> > > > > > - pm_runtime_use_autosuspend(dev);\n> > > > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > > -\n> > > > > > return 0;\n> > > > > >\n> > > > > > disable_clk:\n> > > > > > diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c\n> > > > > > index 42e9656ab80c..33e88ca4d4c5 100644\n> > > > > > --- a/drivers/gpu/drm/tegra/gr3d.c\n> > > > > > +++ b/drivers/gpu/drm/tegra/gr3d.c\n> > > > > > @@ -517,6 +517,10 @@ static int gr3d_probe(struct platform_device *pdev)\n> > > > > > for (i = 0; i < ARRAY_SIZE(gr3d_addr_regs); i++)\n> > > > > > set_bit(gr3d_addr_regs[i], gr3d->addr_regs);\n> > > > > >\n> > > > > > + pm_runtime_enable(&pdev->dev);\n> > > > > > + pm_runtime_use_autosuspend(&pdev->dev);\n> > > > > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500);\n> > > > > > +\n> > > > > > return 0;\n> > > > > > }\n> > > > > >\n> > > > > > @@ -578,10 +582,6 @@ static int __maybe_unused gr3d_runtime_resume(struct device *dev)\n> > > > > > goto disable_clk;\n> > > > > > }\n> > > > > >\n> > > > > > - pm_runtime_enable(dev);\n> > > > > > - pm_runtime_use_autosuspend(dev);\n> > > > > > - pm_runtime_set_autosuspend_delay(dev, 500);\n> > > > > > -\n> > > > > > return 0;\n> > > > > >\n> > > > > > disable_clk:\n> > > > > > --\n> > > > > > 2.51.0\n> > > > > >\n> > > > > >\n> > > > >\n> > > > > Oof, looks like I had managed to really bungle this with my earlier\n> > > > > patch. Thanks for fixing it!\n> > > > >\n> > > >\n> > > > Hello Mikko!\n> > > >\n> > > > Thank you for taking time and looking into this patch. Don't be so\n> > > > harsh to yourself, PM is easy to mess and hard to set properly. This\n> > > > patch does fix gr*d access but it does not resolve the issue itself.\n> > > > PM should be set in the init/exit rather then probe/remove. I have v2\n> > > > which fixes this and one more minor issue and I will send them later\n> > > > on.\n> > >\n> > > Thanks! Why do you think it's necessary to enable runtime PM in init?\n> > > If you look at the commit I referenced below (in 'Fixes'), we've had\n> > > some issues in the past with doing pm_runtime_enable outside of probe,\n> > > where the engine's power domain would be left enabled even when it is\n> > > idle.\n> > >\n> > > gr2d/gr3d I suppose wouldn't be in practice affected by that issue\n> > > though given they aren't in their own power domains.\n> >\n> > WDYM, gr2d and gr3d have their own power domains.\n>\n> Ah, my bad, didn't look far enough in the device tree.\n>\n> >\n> > If the master device is unbound and rebound, gr2d_init() will run again, but\n> > pm configuration is only located in this probe function which will not\n> > run again, while pm disable are both in exit and remove. This results\n> > in pm issue we are observing.\n> >\n> > Solution would be either do everyting in probe/remove, or init/exit.\n> > Probe/remove will lead to domain being turned on even if engines are\n> > idle. Init/exit seems to me more suitable and we have tasted this\n> > configuration for a quite while in the grate DRM version.\n>\n> Yes, we should only do it in one place. Where are you observing the\n> domain being turned on when idle?\n>\n> Genpd turns on the domain before probe is called, and it should turn\n> it off again after probe if probe had enabled runtime PM and the usage\n> count is zero. That's what we have currently for the newer engines like\n> VIC and it's working.\n>\n> We used to have it in init/exit, but then we were seeing the domain\n> sometimes being left on at boot, which makes some sense since as probe\n> didn't enable runtime PM, genpd would leave the domain powered after\n> probe. The domain would then also never get powered off when init\n> enabled runtime PM. I assume the reason this only happened sometimes\n> was that it was dependent on if the init function or the genpd\n> post-probe code ran first.\n>\n> Based on that we should have the runtime PM handling in probe/remove,\n> to ensure genpd turns off the domain after probe when there are no\n> users.\n>\n> Mikko\n>\n\nThank you for an explanation, I will adjust v2 accordingly (configure\nPM in probe/remove).\n\n> >\n> > Best regards,\n> > Svyatoslav R.\n> >\n> > >\n> > > Cheers\n> > > Mikko\n> > >\n> > > >\n> > > > So for now this patch should not be picked.\n> > > >\n> > > > Best regards,\n> > > > Svyatoslav R.\n> > > >\n> > > > > FWIW, I've been working on adding some nightly testing for Host1x/\n> > > > > TegraDRM, so hopefully we'll be able to catch such things easier\n> > > > > in the future.\n> > > > >\n> > > > > Fixes: 62fa0a985e2c (\"drm/tegra: Enable runtime PM during probe\")\n> > > > > Acked-by: Mikko Perttunen \n> > > > >\n> > > > >\n> > > > >\n> > >\n> > >\n> > >\n> > >\n>\n>\n>\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=jD7PJ5c0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-14077-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"jD7PJ5c0\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.221.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g5pM43Zk2z1xqf\n\tfor ; Thu, 30 Apr 2026 19:11:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 024123002757\n\tfor ; Thu, 30 Apr 2026 09:10:13 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A26AE369211;\n\tThu, 30 Apr 2026 09:10:12 +0000 (UTC)","from mail-wr1-f47.google.com (mail-wr1-f47.google.com\n [209.85.221.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C0AFC346AC3\n\tfor ; Thu, 30 Apr 2026 09:10:10 +0000 (UTC)","by mail-wr1-f47.google.com with SMTP id\n ffacd0b85a97d-43d75312379so1091469f8f.1\n for ;\n Thu, 30 Apr 2026 02:10:10 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777540212; cv=pass;\n b=sDnxujO/O/d0LvVDwAIfB1BAMl/lUk5VZqPk4YCHTSt/iIgtmUT72lofSQHI2PKkC0+R6EY6CPuSvLnbYuz6Jtg0h7Rnha5XWizoRZH10PGObOFQ8DkXNq8EofNKeCtlEBCNS1i06ZnvAJ9UyiWJEE7ZKfEIsseAz0ztUVOJlqU=","i=1; a=rsa-sha256; t=1777540209; cv=none;\n d=google.com; s=arc-20240605;\n b=BILtrZahf2Ia5n5ANdkwayyZwZaxHu9UE8hJ8+vbnMYtpfOy5SlaVdt93wHzq3HSUs\n Tgixu58E7F/boPtXDotff4f2x5751RNjldkIIG1Im8tZ6iiBmRz+J2aQGtgar6Hf+eVp\n kmGNdvPz9J2jxKVNlHdL3eu5R3KZGtkeRinQG5UglUa4npxbIjGYeOzvmGH8Ufm7F1Um\n AMa4lDbVdaDYjOONv6CknyILSR0etbhW2zXZBYt/2CC5r2QhHW7WYM2Yv6YWXkz68nAC\n mVf313TGuML5wtZ8SI89FVQENDq/fxmFfC9JDIE0OE/hOBZe9Z3z6OZ8EeZKiDlnj51M\n +8rg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777540212; c=relaxed/simple;\n\tbh=YAIuhcF+H7kfNG3j2tbQ/OMQAUa1gSJ4rfyK6EkXFKI=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=MNT/ZuEjfJeXl5LvPre9n1QJiE/igWocmXhTX1lRB3pw1inVOkA37An19jOqaHAkyXEa2q2bGN+/EtB5r/iX9Ey/6opseD+NeroBiUQG0lxKm56zra3CiUGxVia3c9faTsTmzdM3jFAWENcX+BrEGbSGH+tilAqv2U3EFypTQQc=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=uNayLLCXFFg34wv8nX5d4Vm4GrWa+HjlsC1+5DIJvb4=;\n fh=/4wm6AT5e/COE7QcsDZsIS8dzQExXSPgoQZlxmQ/GjM=;\n b=CzZq9ebWl/KJzi4WZAqmbFqU0chTiqV4VvTye6T8VFmLTXvUV/ucj7VOmZblHCSC7o\n rJ2piS8c1rumYmqYum1Rbcalvw+e8vfw0SuvK2mxxGcKB9mc+zGo5m1EUFqvf3QiywNq\n 1ldey+3YZyjsyEH4eqFPxrkTTz58djp68zLO5bfLLZtVCyk+r4qwbBEgo33rTDTM8PzW\n paF+sE51j5/v+o3F6OTjTFSQ4Zz5jpqukgAB8B8Lgpt5EYVdPhRVIT9ZcOiXXvpqBc1r\n 2Yg/Qujq5z6/2ZDzAoBYQ8mafVkb1oomKmj+83mWwU07GUKbmBh/XvPEreZ8dUJGVBoe\n uRig==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=jD7PJ5c0; arc=pass smtp.client-ip=209.85.221.47","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777540209; x=1778145009;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uNayLLCXFFg34wv8nX5d4Vm4GrWa+HjlsC1+5DIJvb4=;\n b=jD7PJ5c0WjV4M+BZy6d4iEHsFG7QdpJ+zeTIInx4bLsxuyI1ZcA3UA+jVrs+voDyxo\n +Wk8hQUE1sfhZg6P4CSZJQ7FGjoGTsiz/6q0QgPMG3Ze1xi8ybnm4aVjJc6mcOfYVBz1\n NXZBTk6eSUlrYucrx5RWw3aswDQPiy22a+dokBfxFUP4t4QUNsCciz3cMAdZqMpO5bte\n meNY2Psx8NIhISne5yU1Fu3JfyREHKrlzZc9bEoeelbnnft+NwEbBgC3I5DnbQ1bXdqH\n 41UphdcYx/Lx4vhuosZg/EMdA26qc4ryQeLPkUgMWqlyUomPxai5KYisvrJwhpQ/KjQ3\n jZ3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777540209; x=1778145009;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=uNayLLCXFFg34wv8nX5d4Vm4GrWa+HjlsC1+5DIJvb4=;\n b=mkKeTy2c+4TzbH6VLR2quGIny6LzuPGUIMgEobpKrYiMKuMPzTIWN+Qo1P+zq2N27V\n mfK0A8GmyozcUKXMyrF0XOqAZBnjvxwvQ/fS4hhprSb6NH5Zhd0oJnVRZoXqUtsLYPwI\n 2/RXRmd4Q/TDjCG49ElM9tOsXJ/p2Wqv2UKSkdP0h/EmU4A4s+FbMcAcZa0IfBmoqwyU\n nGTXymoZAomjkihVNLc+aJye7ulhWhHxIOAJZx/3MamuzhBc/RKLGG6V+8InL/xZzKUZ\n A+oZhhqO+mK2a4aYmFMlvUlB4SeAKgONVl7ZwRKDVJvlQYkpKEL57dMuK8Y5Z6X0d83t\n Y6ug==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/e1gK61tTgVy9czVb9PrtBKEMCpTg90ye6/IZ8u6SMEmyPz1t8SxOvO8l6V/VbQNw9uDBazb3os563mQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YzohzN5cIA3U9a4IfKceHzNEd3yr8XH3M2jD5xiiV3LWQEVNDDI\n\t6DqpXe+oOe8XtO/FDfbhPG7Ql7VZNcXpdb2hk8iInBzjEN1sH3Dmsogdy2MQ0x75xPw7XRfKd9Q\n\tJu0NaxTqxlgtkIf59pB8bR4cSbxaVAR8=","X-Gm-Gg":"AeBDies08lzfHfI4J5iQMOf/N4QEns568edTDGt/6Ntd+eZixdKMB9EBPyFQoteKLsb\n\tDBRI6YSYeFtVKASdhrySjgN9dLuZ+WQY9B1MBptVs03j2BBMbaoZhx0+0uk9zRY+uARzKZyl+DS\n\tr4Vt6hQcZ4cmXdTUyZVSNik+RrBT5AYUpiXt+TFvZPsdK+gfx2qD1C7yBYHvm1jmCusUR+Elfl1\n\tdTocfsp5U9CwrCe2S/aRREeM7pKeK7ntgVNSXIWx+eD7ST1vPr1nz5LWgVyh/z4iwDIIhpQS8H2\n\t+HpCdTX23yYTY2NRIc4=","X-Received":"by 2002:a05:600c:a412:b0:48a:65ab:8059 with SMTP id\n 5b1f17b1804b1-48a8607972amr22587615e9.13.1777540208950; Thu, 30 Apr 2026\n 02:10:08 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260427075856.85208-1-clamor95@gmail.com>\n \n \n ","In-Reply-To":"","From":"Svyatoslav Ryhel ","Date":"Thu, 30 Apr 2026 12:09:57 +0300","X-Gm-Features":"AVHnY4Je3sxCo-rN1StvJwz9cYuHqAYEyt3eRd6sgOWUegGJDGG9BA1xaOhYGlA","Message-ID":"\n ","Subject":"Re: [PATCH v1 1/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to\n gr*d_probe","To":"Mikko Perttunen ","Cc":"Thierry Reding ,\n David Airlie ,\n\tSimona Vetter , Jonathan Hunter ,\n Ion Agorria ,\n\tdri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]