[{"id":3682897,"web_url":"http://patchwork.ozlabs.org/comment/3682897/","msgid":"","list_archive_url":null,"date":"2026-04-27T19:08:30","subject":"Re: [Buildroot] [PATCH v2 1/1] support: kconfig: Fix compiler\n warnings","submitter":{"id":65908,"url":"http://patchwork.ozlabs.org/api/people/65908/","name":"Petr Vorel","email":"petr.vorel@gmail.com"},"content":"On Mon, 27 Apr 2026 at 09:49, Kanak Shilledar wrote:\n>\n> On Ubuntu 24.04.4, the compiler gives the warning of\n> `-Wformat-overflow=`.\n>\n> ```\n> ./util.c: In function ‘file_write_dep’:\n> ./util.c:86:26: warning: ‘%s’ directive writing 10 or more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]\n> 86 | sprintf(buf2, \"%s%s\", dir, name);\n> | ^~\n> ./util.c:86:9: note: ‘sprintf’ output 11 or more bytes (assuming 4107) into a destination of size 4097\n> 86 | sprintf(buf2, \"%s%s\", dir, name);\n> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> ```\n>\n> Update `buf2` to `PATH_MAX+20` similar to `buf`, thus giving enough\n> headroom for the filename suffix.\n>\n> --\n> Changes in v2:\n> * Changed from direct file fix to patch based fix.\n>\n> Signed-off-by: Kanak Shilledar \n> ---\n> .../24-support-kconfig-fix-compiler-warnings.patch | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\nIt requires to add this patch to support/kconfig/patches/series.\n\n> create mode 100644 support/kconfig/patches/24-support-kconfig-fix-compiler-warnings.patch\n>\n> diff --git a/support/kconfig/patches/24-support-kconfig-fix-compiler-warnings.patch b/support/kconfig/patches/24-support-kconfig-fix-compiler-warnings.patch\n> new file mode 100644\n> index 0000000000..daef13bcf6\n> --- /dev/null\n> +++ b/support/kconfig/patches/24-support-kconfig-fix-compiler-warnings.patch\n> @@ -0,0 +1,14 @@\n> +Index: kconfig/util.c\n> +===================================================================\n\nMaybe use git patch (used in 22-kconfig-lxdialog-fix-check-with-GCC14.patch\nor 23-kconfig-mn-conf-handle-backspace-H-key.patch) to have the reason\ndocumented in the patch itself?\n\nKind regards,\nPetr\n\n> +--- kconfig.orig/util.c\n> ++++ kconfig/util.c\n> +@@ -35,7 +35,7 @@ struct file *file_lookup(const char *name)\n> + int file_write_dep(const char *name)\n> + {\n> + char *str;\n> +- char buf[PATH_MAX+20], buf2[PATH_MAX+1], dir[PATH_MAX+1];\n> ++ char buf[PATH_MAX+20], buf2[PATH_MAX+20], dir[PATH_MAX+1];\n> + struct symbol *sym, *env_sym;\n> + struct expr *e;\n> + struct file *file;\n> +\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming-buildroot@patchwork.ozlabs.org","buildroot@buildroot.org"],"Delivered-To":["patchwork-incoming-buildroot@legolas.ozlabs.org","buildroot@buildroot.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=UKNeAn80;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Clr0145z1yJX\n\tfor ;\n Tue, 28 Apr 2026 05:08:55 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 85C8E810C6;\n\tMon, 27 Apr 2026 19:08:53 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1fqAnkRuPYn4; Mon, 27 Apr 2026 19:08:52 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id AADD3812DD;\n\tMon, 27 Apr 2026 19:08:52 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 669102DF\n for ; Mon, 27 Apr 2026 19:08:51 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 441A3812DD\n for ; Mon, 27 Apr 2026 19:08:51 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hvCsLPGZn3tE for ;\n Mon, 27 Apr 2026 19:08:50 +0000 (UTC)","from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com\n [IPv6:2607:f8b0:4864:20::e36])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 6D32A810C6\n for ; Mon, 27 Apr 2026 19:08:50 +0000 (UTC)","by mail-vs1-xe36.google.com with SMTP id\n ada2fe7eead31-6221c7251d1so1460875137.2\n for ; Mon, 27 Apr 2026 12:08:50 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org AADD3812DD","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6D32A810C6"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1777316932;\n\tbh=zxS/pDToxvde4IrvKauAlWJ4sPdh4ltsC2X2OjcAjoI=;\n\th=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=UKNeAn80s9UwDniaaEbUkBvlKRSuSwYGyLKVgMRDI4jSdWFRmcrGA8cAi6cJTBK8H\n\t Ugak7eOdXW44EtpN/DzK6MKgxxpqpoRdKRgjtYWzqcH95ilZw0w/EQAHSaIAvT+aik\n\t IHHzndFlbxmoYRF9KzcZ37DFL/V46AgY7/Lqdcl/U5tpBjqFGbVJyCczNABVMHH4VH\n\t 11Oxy6q/H7PmbV0Kv/PqyqQsJ6Pov/8TLUnbTOQ3N2DC9BCQoAywCW8eDg42OnSBSE\n\t dpgXnQrGuMq7yZEk0HcPYB8zZJHhwe5Dqdvf9Z8SHIZkaAAxp40ySsxlykPKdOrZ3v\n\t WbEnyqZKrYRjg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::e36; helo=mail-vs1-xe36.google.com;\n envelope-from=petr.vorel@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6D32A810C6","ARC-Seal":"i=1; a=rsa-sha256; t=1777316929; cv=none;\n d=google.com; s=arc-20240605;\n b=Tr8or0nIv7o1KhtBVNfl5jJV/cRsENA9J8UgthiZ9fCR4OA6Q1E6qghD6B4/OY69ey\n ZQzYCNU6v5+tZ/WwxzbMNOfN7bUBHtKpEft2XQ7ss9VgFvbyF9+cal+JbBYh6Xt4ZU4F\n ajNTQvtnenNyKmVavzO7Wzdyxn6Fo61697X5DPAZh+xzOiMow2C5adP3nRLEiC4M0RV7\n hNbOUknke1l3c2QNlX4B4Q1CIYZkqA9OWtjys4rd5uC7+B7pmtgugbQutT0ukd9qvPNI\n X5WtztYX5rUITXTzPmB9ymT3hV8yfk2LBqsLk8V8zAFw69tWt75BLAq5B45tU3gKqdqE\n VC6Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=ZNVKG+yLyfWmsjuD2N9H51vb9/sljC514RZArGkuVtQ=;\n fh=wNV1UCbQGYGCz0sC5IqfB8QPEFwbSWqpmmTuU0y8Ke4=;\n b=VPDR6TjMESIwKN+G0QKXr4t+MKwHrPTx0zKuBs9S9OoyBMc2G5LGM8Bca3nuPtEiRj\n K6nEDlcGF42R5PoWGsrl44sOlqDRhvWom4DWUxUo7WujFX8FlalN9ac2vdBinnpvEzdq\n VhUIoERxXyWDS6GT05tW6WHNqMH09+I0mIHFZaDOeyrvt4UDvCWGoGZzYYdOmBkWztHD\n wj3FLTobQTaFDQvfXSYm8wPacCm9pP/hMYnGRw6ovkCVuiz8JCbppGsnHWcSu84sOkyF\n oDgM4Hh29lTzV8KcW7UaQC7JU/1tdRXpxMmWU0OeyJhxm/go4lcMpQTUR6+XyrUtTETl\n Kx9A==; darn=buildroot.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777316929; x=1777921729;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZNVKG+yLyfWmsjuD2N9H51vb9/sljC514RZArGkuVtQ=;\n b=Zx9S/TI1nyvHHofp9dCFQDv0jD3UmGLOgGaEO20gOIBZIg37aXGU50fompZAkOf8W0\n GcvD6+wMp5Hvo4rqXa2TSZZrcIGbvkDcxYzPant7YDn3j+17XcJeRZVoBb3POIpN+/vt\n REIY2LmhJz+cJbjYZpjFovvfckqfM6Mg/tB8Vo9P3BdRn5fq+svfekAhZ19X8j5/9GbP\n hLrHco6eKcW+fjNZzIkcppQo+FxjgFsQMbd9doTDy+aJZScr8Z6gRHpnJfPFlv39WhCp\n NOhZ3UQUbzpIPkIToe/SOsyLyputdjJBiSmMPXoZA5DzIlSLJJhU6uckJW7eOs5dQaTm\n uGGQ==","X-Gm-Message-State":"AOJu0Yx6sPPmCpMwgbdN4GpeJYwRHKxphmU262J5OLsXVQYGGrDKt1uI\n 0FJOuWsIxIqx9xwF6A7uHNQcu7sqshINAxXPygyejUuP33EsFg5dWxR0giGLEwW5Qsy4J7xjZwt\n Vke4Ov+grnmT5nryXhTL7otg+GEWlK1U=","X-Gm-Gg":"AeBDietAqPysNFxKmoqy99gZT3Agyj8Hw6k3xDxEte0IrSRfTygRja/h/U44H+H3yAA\n u0SwYjBKPiZbAw+H8SQ3R+0WeTA4DItklOmzcwOVME9gxcDk6Bt4w4uyarbpspFY/xtPMmfFL71\n Wgel3cV4IPBN4OB/HQKQUo0VI6Qsa5iuOYJKtoTWRE06fcyA8OIsKU3iIfcNFal3aEHvV5Wduwv\n BCycu82ubWagcodvd4KRPjtPyYa4UTCqHmZzqMoDra3KxmW30OdaON+tYGNZcezmWsYSp0iGmw+\n szbT9JwH9g0Xr9tKm5lojISONHEjWok629OAMJMrjG6EC6M691E=","X-Received":"by 2002:a05:6102:162c:b0:605:8143:cb67 with SMTP id\n ada2fe7eead31-627d54bc5d2mr427511137.20.1777316928709; Mon, 27 Apr 2026\n 12:08:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20260427074835.1452504-2-kanak.shilledar@axis.com>\n <20260427074835.1452504-4-kanak.shilledar@axis.com>","In-Reply-To":"<20260427074835.1452504-4-kanak.shilledar@axis.com>","From":"Petr Vorel ","Date":"Mon, 27 Apr 2026 21:08:30 +0200","X-Gm-Features":"AVHnY4Kk12kwFUknYaw889-tfpyCVK_CtzcmQypBQG-fim68qIwLkgqIhUwZwII","Message-ID":"\n ","To":"Kanak Shilledar ","Cc":"buildroot@buildroot.org","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777316929; x=1777921729; darn=buildroot.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZNVKG+yLyfWmsjuD2N9H51vb9/sljC514RZArGkuVtQ=;\n b=celhNDq5RhV201u8pCUteZI0G+h32BMKjXNsgVJrTFJw9wpAVJOoJVYT0VumFqs3XK\n in6qwvmwPAQPH8H5K6Sv701OWLcSgej/yY9xB/vsIxKLNw0E/rwcfz88K/VsUQc1QWze\n FZCIP0e0/tnxwh7rJ8+ypU0VDN/8oVq+pPt64iOBmXR1g51bih/JfK81wPAOFs+iQ3LE\n 3+7F2hhG1qcm1+CJcm1krotSLkY3HjrARCohZ8ASJJ2xH+Pmxi9tjQaJXffiMVKezZo7\n jKK9Xn3aoaYXAZkfLJCa8OFMfoUhmNEDYUKyp6G9YJrx8Vwaikglt6cHv+I3Qg8rSfAi\n bT5w==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=celhNDq5"],"Subject":"Re: [Buildroot] [PATCH v2 1/1] support: kconfig: Fix compiler\n warnings","X-BeenThere":"buildroot@buildroot.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@buildroot.org","Sender":"\"buildroot\" "}}]