[{"id":3682451,"web_url":"http://patchwork.ozlabs.org/comment/3682451/","msgid":"","list_archive_url":null,"date":"2026-04-26T23:37:20","subject":"Re: [PATCH v3 6/7] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN\n ATAPI device quirk","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 4/27/26 4:09 AM, Phil Pemberton wrote:\n> The COMPAQ PD-1 (OEM Panasonic/Matsushita LF-1195C) is a PD/CD combo\n> drive that exposes two ATAPI LUNs: LUN 0 is a CD-ROM (TYPE_ROM),\n> LUN 1 is a 650 MB PD (TYPE_DISK).\n> \n> Add it to the SCSI device list with:\n> - BLIST_FORCELUN: tells the SCSI layer to scan past LUN 0\n> - BLIST_SINGLELUN: serialises commands across the two LUNs, since\n> the drive has a single transport and cannot handle concurrent\n> operations on both\n> - BLIST_NO_LUN_1F: the drive returns PQ=0/PDT=0x1f for unpopulated\n> LUNs instead of PQ=3; this flag tells scsi_probe_and_add_lun()\n> to silently skip them\n> \n> The INQUIRY strings as reported by the device are:\n> Vendor: \"COMPAQ \" (T10 format, space-padded)\n> Product: \"PD-1\"\n> \n> Signed-off-by: Phil Pemberton \n\nReviewed-by: Damien Le Moal ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fCi2qJu8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ide+bounces-5547-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fCi2qJu8\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3jmF4wYmz1xvV\n\tfor ; Mon, 27 Apr 2026 09:37:33 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id AE5983001876\n\tfor ; Sun, 26 Apr 2026 23:37:30 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E3C08283C9D;\n\tSun, 26 Apr 2026 23:37:28 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C0436197A7D;\n\tSun, 26 Apr 2026 23:37:28 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 76688C2BCAF;\n\tSun, 26 Apr 2026 23:37:27 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777246648; cv=none;\n b=ZlSqBU0x7NTgp9QvjeNIHBXAdGUSBajvNY657JDx5X2KAcouKm+z0/+bMGTMlRxZNhTe3RdiDUJEvt1IN4Z/L4eXtG0ikTZbf5aKDiO9DQ8QYKuCYGQpRbOF9DkPIxZ+7Pu61ZbtobGXQMEKm436V4kvlKtOgkTCh1+nnoBK038=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777246648; c=relaxed/simple;\n\tbh=sMDyinNuAsv12Ena7vNmBzeiWqr1LDKhrZyHoDLKWko=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=NZLc6p74ZIXWU9mFIlx66r4Jnx6ATH1ROC6yBOa9uJol39bjCH28WdRZPU5d4NVKpsOsQziDneyazhD+FTcrGvrqYtuKmLinLSGY/jh/UUnzgSyScc47KzLC+5HXvEiTKUIDNl0C/yb1GPqn970IoJ7pXUaD1Dlj0UbpCPglFQY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fCi2qJu8; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777246648;\n\tbh=sMDyinNuAsv12Ena7vNmBzeiWqr1LDKhrZyHoDLKWko=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=fCi2qJu8R30u7fRMNg4NM6h2T3nsxrc98gRXW1hPLdDTKUXMcve7Yof7NtrgV2m6j\n\t DGhdxPRVDlirpU/FSbSeW5+w/DCUFeJLkWDJcvwMaVagLE2JSnmgE9GsVbRqie0x8K\n\t f1Nr5Mx1JygqCmPcVXC2P0uHg6dFyf0B15my5LP33wS6FU7/4NiYOW0zbqXfyHc5Bi\n\t uJPeYdcLAAYE19ifV3xsRjgdNvYI9fobYmWVU7N/cpe8oBbOl7W852yxYYNDJObs0c\n\t XxihEXToJyNS6Oitv/e7mNrSNQYRP61ujBXCInuLITvHeE9Ise9B6Sc9Am0n3hyVms\n\t 1cd7QjCpNTyiA==","Message-ID":"","Date":"Mon, 27 Apr 2026 08:37:20 +0900","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 6/7] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN\n ATAPI device quirk","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ,\n Hannes Reinecke ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-7-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260426190920.2051289-7-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3682663,"web_url":"http://patchwork.ozlabs.org/comment/3682663/","msgid":"","list_archive_url":null,"date":"2026-04-27T11:55:31","subject":"Re: [PATCH v3 6/7] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN\n ATAPI device quirk","submitter":{"id":992,"url":"http://patchwork.ozlabs.org/api/people/992/","name":"Hannes Reinecke","email":"hare@suse.de"},"content":"On 4/26/26 21:09, Phil Pemberton wrote:\n> The COMPAQ PD-1 (OEM Panasonic/Matsushita LF-1195C) is a PD/CD combo\n> drive that exposes two ATAPI LUNs: LUN 0 is a CD-ROM (TYPE_ROM),\n> LUN 1 is a 650 MB PD (TYPE_DISK).\n> \n> Add it to the SCSI device list with:\n> - BLIST_FORCELUN: tells the SCSI layer to scan past LUN 0\n> - BLIST_SINGLELUN: serialises commands across the two LUNs, since\n> the drive has a single transport and cannot handle concurrent\n> operations on both\n> - BLIST_NO_LUN_1F: the drive returns PQ=0/PDT=0x1f for unpopulated\n> LUNs instead of PQ=3; this flag tells scsi_probe_and_add_lun()\n> to silently skip them\n> \n> The INQUIRY strings as reported by the device are:\n> Vendor: \"COMPAQ \" (T10 format, space-padded)\n> Product: \"PD-1\"\n> \n> Signed-off-by: Phil Pemberton \n> ---\n> drivers/scsi/scsi_devinfo.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c\n> index 68a992494b12..bfc2cbd43897 100644\n> --- a/drivers/scsi/scsi_devinfo.c\n> +++ b/drivers/scsi/scsi_devinfo.c\n> @@ -150,6 +150,8 @@ static struct {\n> \t{\"COMPAQ\", \"MSA1000\", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},\n> \t{\"COMPAQ\", \"MSA1000 VOLUME\", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},\n> \t{\"COMPAQ\", \"HSV110\", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},\n> +\t{\"COMPAQ\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |\n> +\t\t\t\t BLIST_NO_LUN_1F},\n> \t{\"DDN\", \"SAN DataDirector\", \"*\", BLIST_SPARSELUN},\n> \t{\"DEC\", \"HSG80\", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},\n> \t{\"DELL\", \"PV660F\", NULL, BLIST_SPARSELUN},\nReviewed-by: Hannes Reinecke \n\nCheers,\n\nHannes","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=oWSX+b78;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Z5Zzr6DW;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=P7S/VOVi;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=VfeGtbjJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5561-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"oWSX+b78\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"Z5Zzr6DW\";\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"P7S/VOVi\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"VfeGtbjJ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.131","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de","smtp-out2.suse.de;\n\tnone"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g42HL0S1kz1yHX\n\tfor ; Mon, 27 Apr 2026 22:02:05 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C6ED83036EBB\n\tfor ; Mon, 27 Apr 2026 11:55:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A1F95388E72;\n\tMon, 27 Apr 2026 11:55:37 +0000 (UTC)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC463803C5\n\tfor ; Mon, 27 Apr 2026 11:55:35 +0000 (UTC)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id 5FE255BCCD;\n\tMon, 27 Apr 2026 11:55:32 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4768E593B0;\n\tMon, 27 Apr 2026 11:55:32 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid BCe5ELRO72nedQAAD6G6ig\n\t(envelope-from ); Mon, 27 Apr 2026 11:55:32 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777290937; cv=none;\n b=riwUVb99qMbVr37OCAwobz5eC3jY45Z9Oist/LUndANXQtkj3gfCI1VdeP/IflRM/BtlKCNRosQAxzO7cdhUcCFj7c9SL73a99KIYGGHPic9BxgqZh3J9yHA9yJsvszpnQP3z6a9csgwYKNf5K1XQhNhhh3ZOYq8B1RPU56E3Ks=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777290937; c=relaxed/simple;\n\tbh=ZP1c4ky3bJXIySKuxipX8ApHDQjQJNDazRF+acMyh4E=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=VOiy3SqHc99mY3/XbazJpgav1kiVWoHScFj8Ji3d15zpAluFgphDdTOf54eLI3FooTz4Xy+7K58IUDURdhWA7N5NUvu6Bh82/0A3s/hEjcF8UkrCZTZ/P4vn9MfhZYm2Oxw9R9cUJH9EFYSWyekjpaAOf6shmQc9M3cG/xxfBwo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=oWSX+b78;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=Z5Zzr6DW;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=P7S/VOVi;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=VfeGtbjJ; arc=none smtp.client-ip=195.135.223.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777290933;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=swr+kJLdakYoARhnjNVMQ6vKSx0E0Hlgsx2lgeP1Otc=;\n\tb=oWSX+b78+HEIpN6yCZye893zAB9kg7JV5hrze71qgcP6vju/yNrU1c45pdQhVrdT+CyYKb\n\ttviy/2iXsDU8JCOdSYMQVrzzIFvV10ltQ8oTnH0JRvXjtSC7HCvNUnRrX+eUafMiUlG8ir\n\txyM/YQo0YD3sT0mTTjtUzdrz3r/qEhY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777290933;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=swr+kJLdakYoARhnjNVMQ6vKSx0E0Hlgsx2lgeP1Otc=;\n\tb=Z5Zzr6DWpOCc5MtaDCGh39Kv92c2lTxzi12MoqIpm08SzwElDiLCbQE9aY9eHqO4a4wgig\n\tjK4BjuAKll9hfwDg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777290932;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=swr+kJLdakYoARhnjNVMQ6vKSx0E0Hlgsx2lgeP1Otc=;\n\tb=P7S/VOViO8pKDSQUDThC5S/zA6VgIlxpQsgIJxI43XCvoFcI0FWvVrrplIMhEkAjxRy+wH\n\t1E5mpv6ceFeqff1sUpeVG51xuSlR7BKrkQ+/30mgsqrJ6ysTcsXEsRViT6viaQ0qytER3+\n\tBxpCp0lcu0KV13lLnNYCNTceScshhsc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777290932;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=swr+kJLdakYoARhnjNVMQ6vKSx0E0Hlgsx2lgeP1Otc=;\n\tb=VfeGtbjJ1hXtZoFZ1I85gIvtRtIiifVH0UyMTKjphfRRgS9oMB0hpK9/assKJfzsWVKTur\n\tNLY+B8xWiJmMcdCw=="],"Message-ID":"","Date":"Mon, 27 Apr 2026 13:55:31 +0200","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 6/7] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN\n ATAPI device quirk","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Damien Le Moal ,\n Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-7-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Hannes Reinecke ","In-Reply-To":"<20260426190920.2051289-7-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-4.30 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tNEURAL_HAM_SHORT(-0.20)[-0.996];\n\tMIME_GOOD(-0.10)[text/plain];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tARC_NA(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tRCPT_COUNT_SEVEN(0.00)[8];\n\tMID_RHS_MATCH_FROM(0.00)[];\n\tRCVD_TLS_ALL(0.00)[];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tFROM_HAS_DN(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email,philpem.me.uk:email]","X-Spam-Flag":"NO","X-Spam-Score":"-4.30","X-Spam-Level":""}}]