[{"id":3682452,"web_url":"http://patchwork.ozlabs.org/comment/3682452/","msgid":"","list_archive_url":null,"date":"2026-04-26T23:37:35","subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 4/27/26 4:09 AM, Phil Pemberton wrote:\n> The Panasonic LF-1095/LF-1195 PD/CD combo drive was sold under three\n> OEM identities: COMPAQ \"PD-1\", MATSHITA \"PD-1\", and NEC \"PD-1 ODX654P\".\n> All three are the same drive mechanism with the same firmware family,\n> so they should share the BLIST_NO_LUN_1F quirk that was applied to the\n> COMPAQ variant: PDT 0x1f / PQ 0 INQUIRY responses on non-existent LUNs\n> are treated as \"LUN not present\" rather than as a phantom sdev.\n> \n> This patch is offered for completeness. It has not been tested on the\n> MATSHITA or NEC variants -- the author only has access to the COMPAQ\n> unit -- but the drives are functionally identical and the flag is a\n> no-op on devices that do not exhibit the PDT 0x1f response. Drop or\n> hold this patch if confirmation on real hardware is preferred before\n> extending the quirk.\n> \n> Signed-off-by: Phil Pemberton \n\nReviewed-by: Damien Le Moal ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=enQEKt28;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5548-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"enQEKt28\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3jmr3QBZz1xvV\n\tfor ; Mon, 27 Apr 2026 09:38:04 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 18130300D470\n\tfor ; Sun, 26 Apr 2026 23:37:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5A7612DF13A;\n\tSun, 26 Apr 2026 23:37:44 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 372051FFC48;\n\tSun, 26 Apr 2026 23:37:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CAA21C2BCAF;\n\tSun, 26 Apr 2026 23:37:42 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777246664; cv=none;\n b=Va0pk+INmqIjPdslnjyogFi9HAr3IW1gCoxtA4PAC0P1WYHXswMVaLTP6FgAgSVKLUfdGeBhxCiKGLvqm0WoGlbafND/DJY6HhtAts20zESzU/GtyCmDHCLHSfS1ZeET6utl67z5oB314AVSl22OakLcWoajSBtntK8KFyp9NWA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777246664; c=relaxed/simple;\n\tbh=jjLQOeEeaq4SWWERvSWhTQEcbsEiBXOnn6zgvp+NZSg=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=AY0APNIRt1aaWvU3WVf8Jv5LJFMxFWWgRnZzuZOaiLvLBWED8jdfdmA88cBVe88w0kWbiPJgyPPXHoY92KfT2IUxx736X8aZAXvVI9njvzAeAFI+6rByi4DaF5dpPCX9j/O713Vqh5Ws+09vemH8Bxvn+ycNL/TcCqGC1UFE4Pw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=enQEKt28; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777246663;\n\tbh=jjLQOeEeaq4SWWERvSWhTQEcbsEiBXOnn6zgvp+NZSg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=enQEKt289jmHom4noRQUiPZGr+/woZI0bENttK/Zh4YT0HHmRVPG2aN/5dwOtZvHK\n\t 6Cq8YyXlgM3IWEjw7wo4doOzcAZNds7CqCWiu7Xgzyl1EOPJVRK5bEbxOPEAUDjt8A\n\t ZO5vPEV1oCvEPMJPNRvtxeadNeNDJ1a0mcFMiPpxLlrZh2qy5suzAM064AlL4rw0SC\n\t DshnPKD5s8aIjbCfYeD9nviNTHmOKv8qDNFdLle+zvE2OqndveW04BRjqCZ+KGnHny\n\t 8L8aC4hPIDTGWoui/HdbwCM7yNS4ZWWt3fWgkwe2Ki0hXQFmdai3RMvXdaGOgoVefU\n\t eQGemo+4OMUew==","Message-ID":"","Date":"Mon, 27 Apr 2026 08:37:35 +0900","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ,\n Hannes Reinecke ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-8-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260426190920.2051289-8-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3682664,"web_url":"http://patchwork.ozlabs.org/comment/3682664/","msgid":"","list_archive_url":null,"date":"2026-04-27T11:56:50","subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","submitter":{"id":992,"url":"http://patchwork.ozlabs.org/api/people/992/","name":"Hannes Reinecke","email":"hare@suse.de"},"content":"On 4/26/26 21:09, Phil Pemberton wrote:\n> The Panasonic LF-1095/LF-1195 PD/CD combo drive was sold under three\n> OEM identities: COMPAQ \"PD-1\", MATSHITA \"PD-1\", and NEC \"PD-1 ODX654P\".\n> All three are the same drive mechanism with the same firmware family,\n> so they should share the BLIST_NO_LUN_1F quirk that was applied to the\n> COMPAQ variant: PDT 0x1f / PQ 0 INQUIRY responses on non-existent LUNs\n> are treated as \"LUN not present\" rather than as a phantom sdev.\n> \n> This patch is offered for completeness. It has not been tested on the\n> MATSHITA or NEC variants -- the author only has access to the COMPAQ\n> unit -- but the drives are functionally identical and the flag is a\n> no-op on devices that do not exhibit the PDT 0x1f response. Drop or\n> hold this patch if confirmation on real hardware is preferred before\n> extending the quirk.\n> \n> Signed-off-by: Phil Pemberton \n> ---\n> drivers/scsi/scsi_devinfo.c | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c\n> index bfc2cbd43897..ab1ffa9433b7 100644\n> --- a/drivers/scsi/scsi_devinfo.c\n> +++ b/drivers/scsi/scsi_devinfo.c\n> @@ -201,7 +201,8 @@ static struct {\n> \t{\"LASOUND\", \"CDX7405\", \"3.10\", BLIST_MAX5LUN | BLIST_SINGLELUN},\n> \t{\"Marvell\", \"Console\", NULL, BLIST_SKIP_VPD_PAGES},\n> \t{\"Marvell\", \"91xx Config\", \"1.01\", BLIST_SKIP_VPD_PAGES},\n> -\t{\"MATSHITA\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> +\t{\"MATSHITA\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |\n> +\t\t\t\t BLIST_NO_LUN_1F},\n> \t{\"MATSHITA\", \"DMC-LC5\", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36},\n> \t{\"MATSHITA\", \"DMC-LC40\", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36},\n> \t{\"Medion\", \"Flash XL MMC/SD\", \"2.6D\", BLIST_FORCELUN},\n> @@ -212,7 +213,8 @@ static struct {\n> \t{\"nCipher\", \"Fastness Crypto\", NULL, BLIST_FORCELUN},\n> \t{\"NAKAMICH\", \"MJ-4.8S\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> \t{\"NAKAMICH\", \"MJ-5.16S\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> -\t{\"NEC\", \"PD-1 ODX654P\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> +\t{\"NEC\", \"PD-1 ODX654P\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |\n> +\t\t\t\t BLIST_NO_LUN_1F},\n> \t{\"NEC\", \"iStorage\", NULL, BLIST_REPORTLUN2},\n> \t{\"NRC\", \"MBR-7\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> \t{\"NRC\", \"MBR-7.4\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n\nAny specific reason why this patch is not merged with the previous one?\nOtherwise:\n\nReviewed-by: Hannes Reinecke \n\nCheers,\n\nHannes","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=o2PuXEyB;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6Of40lE6;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=o2PuXEyB;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6Of40lE6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5562-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"o2PuXEyB\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"6Of40lE6\";\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"o2PuXEyB\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"6Of40lE6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.131","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de","smtp-out2.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=o2PuXEyB;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6Of40lE6"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g42JM0N4zz1yHX\n\tfor ; Mon, 27 Apr 2026 22:02:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 18838303F46E\n\tfor ; Mon, 27 Apr 2026 11:56:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 53ECD39023A;\n\tMon, 27 Apr 2026 11:56:54 +0000 (UTC)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id DB41330DD3C\n\tfor ; Mon, 27 Apr 2026 11:56:52 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id 3649A5BCCD;\n\tMon, 27 Apr 2026 11:56:51 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 001E2593B0;\n\tMon, 27 Apr 2026 11:56:50 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid bq5tOgJP72lmdwAAD6G6ig\n\t(envelope-from ); Mon, 27 Apr 2026 11:56:50 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777291014; cv=none;\n b=c+acfASuM9epYU4VC1haHZ6nIOJ4FIknzyKpX56mWnjXzrZ0zPGPryxjuRpm/tCkQxkHeuWEWIPu5HE0d6CvSRpFMZVejUZx/hUEVe21JvUj5q+ViWDWcTDlc/dWgYPSwz60N1Ww/5TQnZFmEdmLJ3BKeM657idVbXr0cg3GqCo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777291014; c=relaxed/simple;\n\tbh=jMmdI5PjkkOv2fb/0b6eRHygdHRBUOV+ov32MF77QX0=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=k15zrELH7NFCrjFDM/BraOKu4YPNYMy/+L6kEYAJL2JZAJmNk2UUhGw0aNzlUEJ7bojZ68A5fTHqNXD6WYkTOpWlEwkOOP7h6zBl8dmMXrMzEhXWYKieuy8PeGcVtZ9YrkMWBYr5B/N6fJfxHuzPFiMfwyDJQJk2J5ghd9aO6Jw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=o2PuXEyB;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=6Of40lE6;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=o2PuXEyB;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=6Of40lE6; arc=none smtp.client-ip=195.135.223.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777291011;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=;\n\tb=o2PuXEyBkW3XsqwpYWNp8Z0sxW45qskODJTL3uaKKmlaNSmljc8VBbuEUqaKF7ALi7h6VA\n\tywXiGEx54BJwj4zOzt7L12um84pN93D8SWCC42MT666sxCwuEDqzP5/VsRFj5+lZmXBpRx\n\tNM5jxljienGUzSy5jbZbNjC3iGw1siY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777291011;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=;\n\tb=6Of40lE6XJX2/NnANAwnlHHP9e8oDBho6+uj4ueHgPUPDAv3zR1jCOTwTp7UqObc04n1fA\n\t8rbAaFkRubbsHPDg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777291011;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=;\n\tb=o2PuXEyBkW3XsqwpYWNp8Z0sxW45qskODJTL3uaKKmlaNSmljc8VBbuEUqaKF7ALi7h6VA\n\tywXiGEx54BJwj4zOzt7L12um84pN93D8SWCC42MT666sxCwuEDqzP5/VsRFj5+lZmXBpRx\n\tNM5jxljienGUzSy5jbZbNjC3iGw1siY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777291011;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=;\n\tb=6Of40lE6XJX2/NnANAwnlHHP9e8oDBho6+uj4ueHgPUPDAv3zR1jCOTwTp7UqObc04n1fA\n\t8rbAaFkRubbsHPDg=="],"Message-ID":"","Date":"Mon, 27 Apr 2026 13:56:50 +0200","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Damien Le Moal ,\n Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-8-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Hannes Reinecke ","In-Reply-To":"<20260426190920.2051289-8-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Spamd-Result":"default: False [-4.51 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tRCVD_TLS_ALL(0.00)[];\n\tARC_NA(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tTO_DN_SOME(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tMID_RHS_MATCH_FROM(0.00)[];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tRCPT_COUNT_SEVEN(0.00)[8];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email,philpem.me.uk:email];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tDKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Action":"no action","X-Spam-Flag":"NO","X-Spam-Score":"-4.51","X-Spam-Level":"","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"3649A5BCCD"}},{"id":3682670,"web_url":"http://patchwork.ozlabs.org/comment/3682670/","msgid":"<583f5450-38cb-4240-9518-785ba10bf306@philpem.me.uk>","list_archive_url":null,"date":"2026-04-27T12:12:40","subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","submitter":{"id":93108,"url":"http://patchwork.ozlabs.org/api/people/93108/","name":"Phil Pemberton","email":"philpem@philpem.me.uk"},"content":"On 27/04/2026 12:56, Hannes Reinecke wrote:\n> On 4/26/26 21:09, Phil Pemberton wrote:\n>> The Panasonic LF-1095/LF-1195 PD/CD combo drive was sold under three\n>> OEM identities: COMPAQ \"PD-1\", MATSHITA \"PD-1\", and NEC \"PD-1 ODX654P\".\n>> All three are the same drive mechanism with the same firmware family,\n>> so they should share the BLIST_NO_LUN_1F quirk that was applied to the\n>> COMPAQ variant: PDT 0x1f / PQ 0 INQUIRY responses on non-existent LUNs\n>> are treated as \"LUN not present\" rather than as a phantom sdev.\n>>\n>> This patch is offered for completeness.  It has not been tested on the\n>> MATSHITA or NEC variants -- the author only has access to the COMPAQ\n>> unit -- but the drives are functionally identical and the flag is a\n>> no-op on devices that do not exhibit the PDT 0x1f response.  Drop or\n>> hold this patch if confirmation on real hardware is preferred before\n>> extending the quirk.\n>>\n>> Signed-off-by: Phil Pemberton \n>> ---\n>>   drivers/scsi/scsi_devinfo.c | 6 ++++--\n>>   1 file changed, 4 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c\n>> index bfc2cbd43897..ab1ffa9433b7 100644\n>> --- a/drivers/scsi/scsi_devinfo.c\n>> +++ b/drivers/scsi/scsi_devinfo.c\n>> @@ -201,7 +201,8 @@ static struct {\n>>       {\"LASOUND\", \"CDX7405\", \"3.10\", BLIST_MAX5LUN | BLIST_SINGLELUN},\n>>       {\"Marvell\", \"Console\", NULL, BLIST_SKIP_VPD_PAGES},\n>>       {\"Marvell\", \"91xx Config\", \"1.01\", BLIST_SKIP_VPD_PAGES},\n>> -    {\"MATSHITA\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n>> +    {\"MATSHITA\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |\n>> +                   BLIST_NO_LUN_1F},\n>>       {\"MATSHITA\", \"DMC-LC5\", NULL, BLIST_NOT_LOCKABLE | \n>> BLIST_INQUIRY_36},\n>>       {\"MATSHITA\", \"DMC-LC40\", NULL, BLIST_NOT_LOCKABLE | \n>> BLIST_INQUIRY_36},\n>>       {\"Medion\", \"Flash XL  MMC/SD\", \"2.6D\", BLIST_FORCELUN},\n>> @@ -212,7 +213,8 @@ static struct {\n>>       {\"nCipher\", \"Fastness Crypto\", NULL, BLIST_FORCELUN},\n>>       {\"NAKAMICH\", \"MJ-4.8S\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n>>       {\"NAKAMICH\", \"MJ-5.16S\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n>> -    {\"NEC\", \"PD-1 ODX654P\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n>> +    {\"NEC\", \"PD-1 ODX654P\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN |\n>> +                      BLIST_NO_LUN_1F},\n>>       {\"NEC\", \"iStorage\", NULL, BLIST_REPORTLUN2},\n>>       {\"NRC\", \"MBR-7\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n>>       {\"NRC\", \"MBR-7.4\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> \n> Any specific reason why this patch is not merged with the previous one?\n> Otherwise:\n> \n> Reviewed-by: Hannes Reinecke \n> \n> Cheers,\n> \n> Hannes\n\nHi Hannes,\n\nThe short answer is because I don't have those two drives to test with. \nThey're based on the same hardware platform but I'm assuming they have \nthe same behaviour.\n\nThe idea of the separate patch is that if the lack of testing was an \nissue, it could be separated from the known-working parts in the first 6 \nsections.\n\nThanks,","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.a=rsa-sha256 header.s=mail header.b=xkMJ2dfw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ide+bounces-5563-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.b=\"xkMJ2dfw\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=178.62.38.78","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=philpem.me.uk","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=philpem.me.uk"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g42XB0g6Kz1yHv\n\tfor ; Mon, 27 Apr 2026 22:13:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 75AB53035D41\n\tfor ; Mon, 27 Apr 2026 12:12:45 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 28DC73B5850;\n\tMon, 27 Apr 2026 12:12:45 +0000 (UTC)","from nick.sneptech.io (nick.sneptech.io [178.62.38.78])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DE23B6BFA;\n\tMon, 27 Apr 2026 12:12:43 +0000 (UTC)","from wolf.philpem.me.uk (81-187-163-148.ip4.reverse-dns.uk\n [81.187.163.148])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\t(Authenticated sender: mailrelay_wolf@philpem.me.uk)\n\tby nick.sneptech.io (Postfix) with ESMTPSA id ADE46BD366;\n\tMon, 27 Apr 2026 12:12:41 +0000 (UTC)","from [10.0.0.32] (cheetah.homenet.philpem.me.uk [10.0.0.32])\n\tby wolf.philpem.me.uk (Postfix) with ESMTPSA id F1A905FBA6;\n\tMon, 27 Apr 2026 13:12:40 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777291965; cv=none;\n b=jGmIIaZTlp8MkCT5C8dLYP1NeGpyDxVvefjUOwH9ps+aYIxfQ2YTfUWXf0V6bgsu8huF1SorGEuDW5XwApHVFUx1swYEuOt39mxHvyH21qOIXYVwxq8S9AlYnnchYGMIDD8sE8reU0quy7x/pHTenhq72Zfs1iqC+H7ceuWQGVs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777291965; c=relaxed/simple;\n\tbh=giHwGTFD6wbmZRTrdyUEVWmsDYWotLmNnR/Uf5m1WPM=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=SWR8eK4turUbKamD3BNQkHcwl6FW/Hfc+6JPC9KVPynziQEYEfE1lT+BU+p5KvvN9GUnesQOwBOfMhYldaIJJHijwDX9YFKFLULy8txRUPghtF0Bgx7xHzh6J3eAwhEUr2BrrQ31kpcPQzllVThQ5HYcBabbdyDFMRBO5JxwPrw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=philpem.me.uk;\n spf=pass smtp.mailfrom=philpem.me.uk;\n dkim=pass (1024-bit key) header.d=philpem.me.uk header.i=@philpem.me.uk\n header.b=xkMJ2dfw; arc=none smtp.client-ip=178.62.38.78","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=philpem.me.uk;\n\ts=mail; t=1777291961;\n\tbh=giHwGTFD6wbmZRTrdyUEVWmsDYWotLmNnR/Uf5m1WPM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=xkMJ2dfwgvqUJ6FdfMRNgrFGImw/JAtEWny/p4MOb7C7WzoWl/DNjhX0f3IhVZ0hS\n\t wvvjC6J6uYbmPPavQK20nwc0cc+JcMoIAO/deBCO47p8dxpUXltarNCRt5pZl/oulS\n\t 7TJovViC/KqZ69795bR/TyEUfKXC8DnPSPWkPJzw=","Message-ID":"<583f5450-38cb-4240-9518-785ba10bf306@philpem.me.uk>","Date":"Mon, 27 Apr 2026 13:12:40 +0100","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to\n MATSHITA and NEC PD-1 variants","To":"Hannes Reinecke , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Damien Le Moal ,\n Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-8-philpem@philpem.me.uk>\n ","Content-Language":"en-GB","From":"Phil Pemberton ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit"}}]