[{"id":3682448,"web_url":"http://patchwork.ozlabs.org/comment/3682448/","msgid":"<19b6da9d-5954-457c-be17-877a5c3fd9cf@kernel.org>","list_archive_url":null,"date":"2026-04-26T23:29:39","subject":"Re: [PATCH v3 3/7] ata: libata-scsi: route non-zero LUN commands for\n multi-LUN ATAPI","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 4/27/26 4:09 AM, Phil Pemberton wrote:\n> Two changes are required to route commands to ATAPI LUNs other than 0:\n> \n> 1. __ata_scsi_find_dev(): The existing code rejects any scsi_device\n> with a non-zero LUN, returning NULL and dropping the command on\n> the floor. Relax both the PMP and non-PMP branches to allow\n> non-zero LUNs through when the underlying ata_device is ATAPI\n> class, since ATAPI devices can legitimately expose multiple LUNs.\n> \n> 2. atapi_xlat(): Older ATAPI devices (SCSI-2 era) expect the LUN in\n> CDB byte 1 bits 7:5 rather than relying on transport-level LUN\n> addressing. Encode scmd->device->lun into those bits, preserving\n> the existing command-specific bits in 4:0. This is required by\n> both the Panasonic PD/CD combos and Nakamichi CD changers. LUNs\n> beyond 7 cannot be encoded in the 3-bit CDB field; reject them\n> with AC_ERR_INVALID.\n> \n> Signed-off-by: Phil Pemberton \n> ---\n> drivers/ata/libata-scsi.c | 17 +++++++++++++++--\n> 1 file changed, 15 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\n> index 317883bac25f..48c7d323d6f9 100644\n> --- a/drivers/ata/libata-scsi.c\n> +++ b/drivers/ata/libata-scsi.c\n> @@ -2951,6 +2951,11 @@ static unsigned int atapi_xlat(struct ata_queued_cmd *qc)\n> \tmemset(qc->cdb, 0, dev->cdb_len);\n> \tmemcpy(qc->cdb, scmd->cmnd, scmd->cmd_len);\n> \n> +\t/* SCSI-2 CDB LUN encoding: bits 7:5 of byte 1 (3-bit field) */\n> +\tif (scmd->device->lun >= 8)\n\nInstead of 8, please use ATAPI_MAX_LUN.\nSince this should never happen, this also warrants the use of WARN_ON_ONCE()\nfor the if condition.\n\n> +\t\treturn AC_ERR_INVALID;\n> +\tqc->cdb[1] = (qc->cdb[1] & 0x1f) | ((u8)scmd->device->lun << 5);\n> +\n> \tqc->complete_fn = atapi_qc_complete;\n> \n> \tqc->tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;\n> @@ -3059,19 +3064,27 @@ static struct ata_device *ata_find_dev(struct ata_port *ap, unsigned int devno)\n> static struct ata_device *__ata_scsi_find_dev(struct ata_port *ap,\n> \t\t\t\t\t const struct scsi_device *scsidev)\n> {\n> +\tstruct ata_device *dev;\n> \tint devno;\n> \n> \t/* skip commands not addressed to targets we simulate */\n> \tif (!sata_pmp_attached(ap)) {\n> -\t\tif (unlikely(scsidev->channel || scsidev->lun))\n> +\t\tif (unlikely(scsidev->channel))\n> \t\t\treturn NULL;\n> \t\tdevno = scsidev->id;\n> \t} else {\n> -\t\tif (unlikely(scsidev->id || scsidev->lun))\n> +\t\tif (unlikely(scsidev->id))\n> \t\t\treturn NULL;\n> \t\tdevno = scsidev->channel;\n> \t}\n> \n> +\tif (unlikely(scsidev->lun)) {\n> +\t\tdev = ata_find_dev(ap, devno);\n> +\t\tif (!dev || dev->class != ATA_DEV_ATAPI)\n> +\t\t\treturn NULL;\n> +\t\treturn dev;\n> +\t}\n\nThis really should come first in the function. Otherwise, you are radically\nchanging the function since you removed the scsidev->lun checks for the\npreceding checks.\n\n> +\n> \treturn ata_find_dev(ap, devno);\n> }\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qAMDRzY0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-ide+bounces-5544-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"qAMDRzY0\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3jbQ1GyTz1yJX\n\tfor ; Mon, 27 Apr 2026 09:29:54 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 6C9DE30068E9\n\tfor ; Sun, 26 Apr 2026 23:29:51 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 816633161AD;\n\tSun, 26 Apr 2026 23:29:48 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD3426A08A;\n\tSun, 26 Apr 2026 23:29:48 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E7AB2C2BCAF;\n\tSun, 26 Apr 2026 23:29:46 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777246188; cv=none;\n b=Ka5dOp8sb+7RC8yiuy/6Ad46nrFcqu73bjgl+Zs28OZgP87U44WhBPQt7PIKsAYUfSxG6y1t7KjhadlSAZwyKf253nwMIMXwX6IGRfY5OnNVWEke7+mZs9TvDFEjgWKrFjmKAUkvdM7c4adUg0QONVgE9l8zoxlhYcnQ9g9etjQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777246188; c=relaxed/simple;\n\tbh=VTAyJZN46pmlO+UYowyBkIP0LLnz4XwEHRG3EdYJSHY=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=uSLLaAv3yRQz1KAAf9nrKHeGHn65QL3MmqGpKPNegQNgvf2sVIuyxLaNzfAVpRychqeXNJ91f7rhr3zvhzP6I2+tMG81qGXPXhNu5Qeuc28B+qGbjxRrpN93gXks2vH9iXEjX3S5H9DgofDBHRalds7JA9dfO8s7a3Xp+sRkHOw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=qAMDRzY0; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777246188;\n\tbh=VTAyJZN46pmlO+UYowyBkIP0LLnz4XwEHRG3EdYJSHY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qAMDRzY0bcyUbrgAdr+Y9nSlkyJxYuNXMCsZP4QEnEvUdDSam7KXyYu5dtBbSe3sY\n\t qdlsMh0WNj46iEvOaafatalUpVkEbiWtWDZLsDXKxDFsKm7p98/2jsvaigsK6hKZkp\n\t 6xbNsNx129Fbluv9RdAS+nNBejvBg8pPG+ZXbEVknECHZEI60YfCvsKhJEKoS5D9xo\n\t EnLEAVpjBKpEN+K8OWLPxwDUhjs6mcX52yqd61dn8ssJIZ2ndtygpljOjNJ7D99A8Q\n\t 4j/fr+4HCJk+nMAUC0lLzUTXn0MiKnrpYlz1fUVrDP6+Kj6JhrFtf8DzM6BrGzW9lS\n\t KhR1iAabQGRNw==","Message-ID":"<19b6da9d-5954-457c-be17-877a5c3fd9cf@kernel.org>","Date":"Mon, 27 Apr 2026 08:29:39 +0900","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/7] ata: libata-scsi: route non-zero LUN commands for\n multi-LUN ATAPI","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ,\n Hannes Reinecke ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-4-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260426190920.2051289-4-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3682660,"web_url":"http://patchwork.ozlabs.org/comment/3682660/","msgid":"","list_archive_url":null,"date":"2026-04-27T11:53:08","subject":"Re: [PATCH v3 3/7] ata: libata-scsi: route non-zero LUN commands for\n multi-LUN ATAPI","submitter":{"id":992,"url":"http://patchwork.ozlabs.org/api/people/992/","name":"Hannes Reinecke","email":"hare@suse.de"},"content":"On 4/26/26 21:09, Phil Pemberton wrote:\n> Two changes are required to route commands to ATAPI LUNs other than 0:\n> \n> 1. __ata_scsi_find_dev(): The existing code rejects any scsi_device\n> with a non-zero LUN, returning NULL and dropping the command on\n> the floor. Relax both the PMP and non-PMP branches to allow\n> non-zero LUNs through when the underlying ata_device is ATAPI\n> class, since ATAPI devices can legitimately expose multiple LUNs.\n> \n> 2. atapi_xlat(): Older ATAPI devices (SCSI-2 era) expect the LUN in\n> CDB byte 1 bits 7:5 rather than relying on transport-level LUN\n> addressing. Encode scmd->device->lun into those bits, preserving\n> the existing command-specific bits in 4:0. This is required by\n> both the Panasonic PD/CD combos and Nakamichi CD changers. LUNs\n> beyond 7 cannot be encoded in the 3-bit CDB field; reject them\n> with AC_ERR_INVALID.\n> \n> Signed-off-by: Phil Pemberton \n> ---\n> drivers/ata/libata-scsi.c | 17 +++++++++++++++--\n> 1 file changed, 15 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c\n> index 317883bac25f..48c7d323d6f9 100644\n> --- a/drivers/ata/libata-scsi.c\n> +++ b/drivers/ata/libata-scsi.c\n> @@ -2951,6 +2951,11 @@ static unsigned int atapi_xlat(struct ata_queued_cmd *qc)\n> \tmemset(qc->cdb, 0, dev->cdb_len);\n> \tmemcpy(qc->cdb, scmd->cmnd, scmd->cmd_len);\n> \n> +\t/* SCSI-2 CDB LUN encoding: bits 7:5 of byte 1 (3-bit field) */\n> +\tif (scmd->device->lun >= 8)\n\nThis should be 'max_luns' of the associated scsi device, and the driver\nshould set the appropriate max_luns value for this specific device\n(via blacklist flags etc).\n\nCheers,\n\nHannes","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=ub0mCXDM;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=JV0R4ncL;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=nwn2uSaM;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=RsMsE7Gw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-ide+bounces-5559-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"ub0mCXDM\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"JV0R4ncL\";\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"nwn2uSaM\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=\"RsMsE7Gw\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=195.135.223.130","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=suse.de","smtp-out1.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=nwn2uSaM;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RsMsE7Gw"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g425J4d1Wz1xvV\n\tfor ; Mon, 27 Apr 2026 21:53:24 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 93B213000FF3\n\tfor ; Mon, 27 Apr 2026 11:53:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2E9C039FCC4;\n\tMon, 27 Apr 2026 11:53:14 +0000 (UTC)","from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B1A31714F\n\tfor ; Mon, 27 Apr 2026 11:53:11 +0000 (UTC)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby smtp-out1.suse.de (Postfix) with ESMTPS id 141006A902;\n\tMon, 27 Apr 2026 11:53:09 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DAA30593B0;\n\tMon, 27 Apr 2026 11:53:08 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA\n\tid uODuMyRO72mRcwAAD6G6ig\n\t(envelope-from ); Mon, 27 Apr 2026 11:53:08 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777290794; cv=none;\n b=fOBZXxaqhgthW0cg4KqsR6WuxGlw1FN/c++ncn5VqnvbDdr7E9/HE9lH45uiDWh6I8OxpDDb/9R25UaOBPid5Ozr90z4ui2rsWyhQjp1A0mt9vuyXdY2mcOEHhnVDjoYYCIOzltvqwHpxZStkrt5z0lzvP2xPVsXX1TfN/NdgPc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777290794; c=relaxed/simple;\n\tbh=ScNGFZhKzbxPe9SQr468eN8NcONUVzyLAtaDAVFlpls=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=pWYFbD+gaPhv+sFYfoLTq0eS62CaAITwUZqESQA/3AZ1RB4tx+EGWvCA8mj7DQ2HrmJvdJwawu+xi58bGfR13iLnRJphFlUWxFZunAlk3ddAetERVLvxPmIsMNy6rLO1KLcT2onn4HwdpXdUaKxy1llhy7sphTE8ha5uT/QMuXU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=suse.de;\n spf=pass smtp.mailfrom=suse.de;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=ub0mCXDM;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=JV0R4ncL;\n dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.b=nwn2uSaM;\n dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n header.b=RsMsE7Gw; arc=none smtp.client-ip=195.135.223.130","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777290790;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=RJ0zmdQVFh5ysw0l1XD+Z5F9O29OXzLAU5pcnX+cgvg=;\n\tb=ub0mCXDMKfofFMDZMOAlBHX0NpexYl//aJPzWsoPoAYdp5+Fp5HeBbIILJF8VkWVUFzLtJ\n\tXx3NT9m9RPhAMbZDeulunl2aTTMY+OIGtsJ6DXUUjZIPMLpEtWyioXiDupySnSgefow+ol\n\ttSOZSg4TRaeQU44WgBfJbW35gIlGpcc=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777290790;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=RJ0zmdQVFh5ysw0l1XD+Z5F9O29OXzLAU5pcnX+cgvg=;\n\tb=JV0R4ncLGogWC3Hr0ewlUDOxHRjEv9oyWv66lttRV59fqgp4x7S/XNCw1+KdzEpfllf2HW\n\t57AmuSmONVR1pKDA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n\tt=1777290789;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=RJ0zmdQVFh5ysw0l1XD+Z5F9O29OXzLAU5pcnX+cgvg=;\n\tb=nwn2uSaMB6gIYFXtVPtx+J0ySzo2z4T6tcoa5WSsJkvm49VyqrV+8coxNOIfmcCYtPBqtM\n\tm7FNDZGKLV9GjgBZaMnmdXbyLiHD8LRYBbRQYOi68ZxLD+p9VhGUhX3Tnd3hLmH+ckcJJA\n\tnZdagf+IIAX64X6OS+GMLQmXlWlK4vg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1777290789;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\t mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=RJ0zmdQVFh5ysw0l1XD+Z5F9O29OXzLAU5pcnX+cgvg=;\n\tb=RsMsE7GwGTfjju6lAox/Jl8wmCa7SqhrXOvINnpRGQ9ojmL4ogp9fc60dun7AIV4pFXYxg\n\t6d4q2sNk/rywJADA=="],"Message-ID":"","Date":"Mon, 27 Apr 2026 13:53:08 +0200","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/7] ata: libata-scsi: route non-zero LUN commands for\n multi-LUN ATAPI","To":"Phil Pemberton , linux-ide@vger.kernel.org,\n linux-scsi@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, Damien Le Moal ,\n Niklas Cassel ,\n \"James E . J . Bottomley\" ,\n \"Martin K . Petersen\" ","References":"<20260426190920.2051289-1-philpem@philpem.me.uk>\n <20260426190920.2051289-4-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Hannes Reinecke ","In-Reply-To":"<20260426190920.2051289-4-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Rspamd-Action":"no action","X-Rspamd-Server":"rspamd2.dmz-prg2.suse.org","X-Spamd-Result":"default: False [-4.51 / 50.00];\n\tBAYES_HAM(-3.00)[100.00%];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tNEURAL_HAM_SHORT(-0.20)[-1.000];\n\tMIME_GOOD(-0.10)[text/plain];\n\tMX_GOOD(-0.01)[];\n\tFUZZY_RATELIMITED(0.00)[rspamd.com];\n\tARC_NA(0.00)[];\n\tMIME_TRACE(0.00)[0:+];\n\tRCVD_VIA_SMTP_AUTH(0.00)[];\n\tTO_DN_SOME(0.00)[];\n\tRCPT_COUNT_SEVEN(0.00)[8];\n\tRCVD_TLS_ALL(0.00)[];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tFROM_EQ_ENVFROM(0.00)[];\n\tFROM_HAS_DN(0.00)[];\n\tMID_RHS_MATCH_FROM(0.00)[];\n\tRCVD_COUNT_TWO(0.00)[2];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tDKIM_TRACE(0.00)[suse.de:+]","X-Rspamd-Queue-Id":"141006A902","X-Spam-Flag":"NO","X-Spam-Score":"-4.51","X-Spam-Level":""}}]