[{"id":3682410,"web_url":"http://patchwork.ozlabs.org/comment/3682410/","msgid":"","list_archive_url":null,"date":"2026-04-26T14:59:10","subject":"Re: [PATCH] smb/client: remove unused smb3_parse_opt()","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"merged into cifs-2.6.git for-next\n\n\nOn Sun, Apr 26, 2026 at 6:40 AM David Disseldorp wrote:\n>\n> Commit abdb1742a3123 (\"cifs: get rid of mount options string parsing\")\n> removed the last caller.\n>\n> Signed-off-by: David Disseldorp \n> ---\n> fs/smb/client/cifsproto.h | 1 -\n> fs/smb/client/fs_context.c | 31 -------------------------------\n> 2 files changed, 32 deletions(-)\n>\n> diff --git a/fs/smb/client/cifsproto.h b/fs/smb/client/cifsproto.h\n> index 884bfa1cf0b42..b7cd67b64a833 100644\n> --- a/fs/smb/client/cifsproto.h\n> +++ b/fs/smb/client/cifsproto.h\n> @@ -89,7 +89,6 @@ int cifs_handle_standard(struct TCP_Server_Info *server,\n> struct mid_q_entry *mid);\n> char *smb3_fs_context_fullpath(const struct smb3_fs_context *ctx, char dirsep);\n> int smb3_parse_devname(const char *devname, struct smb3_fs_context *ctx);\n> -int smb3_parse_opt(const char *options, const char *key, char **val);\n> int cifs_ipaddr_cmp(struct sockaddr *srcaddr, struct sockaddr *rhs);\n> bool cifs_match_ipaddr(struct sockaddr *srcaddr, struct sockaddr *rhs);\n> int cifs_discard_remaining_data(struct TCP_Server_Info *server);\n> diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c\n> index a46764c247107..6433eb2093dce 100644\n> --- a/fs/smb/client/fs_context.c\n> +++ b/fs/smb/client/fs_context.c\n> @@ -536,37 +536,6 @@ cifs_parse_smb_version(struct fs_context *fc, char *value, struct smb3_fs_contex\n> return 0;\n> }\n>\n> -int smb3_parse_opt(const char *options, const char *key, char **val)\n> -{\n> - int rc = -ENOENT;\n> - char *opts, *orig, *p;\n> -\n> - orig = opts = kstrdup(options, GFP_KERNEL);\n> - if (!opts)\n> - return -ENOMEM;\n> -\n> - while ((p = strsep(&opts, \",\"))) {\n> - char *nval;\n> -\n> - if (!*p)\n> - continue;\n> - if (strncasecmp(p, key, strlen(key)))\n> - continue;\n> - nval = strchr(p, '=');\n> - if (nval) {\n> - if (nval == p)\n> - continue;\n> - *nval++ = 0;\n> - *val = kstrdup(nval, GFP_KERNEL);\n> - rc = !*val ? -ENOMEM : 0;\n> - goto out;\n> - }\n> - }\n> -out:\n> - kfree(orig);\n> - return rc;\n> -}\n> -\n> /*\n> * Remove duplicate path delimiters. Windows is supposed to do that\n> * but there are some bugs that prevent rename from working if there are\n> --\n> 2.51.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JSPoYPSG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11131-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"JSPoYPSG\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.219.49","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3VGR1WS3z1yHg\n\tfor ; Mon, 27 Apr 2026 00:59:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 2C2CE30087B8\n\tfor ; Sun, 26 Apr 2026 14:59:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 97784366563;\n\tSun, 26 Apr 2026 14:59:24 +0000 (UTC)","from mail-qv1-f49.google.com (mail-qv1-f49.google.com\n [209.85.219.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id F10FA36606E\n\tfor ; Sun, 26 Apr 2026 14:59:22 +0000 (UTC)","by mail-qv1-f49.google.com with SMTP id\n 6a1803df08f44-8a3342d301aso92816656d6.2\n for ;\n Sun, 26 Apr 2026 07:59:22 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777215564; cv=pass;\n b=M2TwRlwl+p6vGrSnoUTkEdvFGoCRuInUJSSO/1x46HtR/pmGyoGmkuUETlpGRAZWmJxJu1ZQAVfDUrvhZXduUFqC2zjU2STWpTThRsut1Rz18YahrHQApR9+chtBRbstgSTu1681KILDrQHwssEdXfKuH3Rc9tKnz9BZaeFWv9k=","i=1; a=rsa-sha256; t=1777215561; cv=none;\n d=google.com; s=arc-20240605;\n b=R+5r/5RZxKV0SXNsJiWuyjsWxeHC6N4kalN7P8yFLFhOzWRK7XnheeeGMUY3g6hY0j\n jhsxEefe/rA01ULKUBkPfwPMknK6Ax4hUeAMZGuNxuoyGhUuv3dm79AFwyq6glIW8FbW\n M6Idmfs241LdRIdlLvwW5386su5yTBkqmU2wDPoWWGIMDBuzqPmH5nNwMzhlWkc2CKGj\n qkDI03CWfSKFtyPTNcrD6dpCGn+sSlUijJp2IP3JxU0OM//JkrPuL/qRvXCfUwbQt5e0\n ZgVc6eH6rz5afTUpRF4HZYCPj80heHDj7/ryV1beJ/kYS7la70619WwVpHFBe72UuVuC\n p2dQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777215564; c=relaxed/simple;\n\tbh=FyclejuoWn+ZBtJ70nHrI/yW4N8y/zuPq8g0XnPXNik=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t Cc:Content-Type;\n b=KxJJndqWjChyE8fWUJXYGP8aP6ZbhZdPgpILleDCZvW38okt+ZQ5yMT01E6PyMpqHCgoFxyyf3RA349CjCpOIn22JfFLNHn/tUIW8BtThNJk5pNZjgR+Eb28GL09gEMKglyGLsd3UnS4Qu615nhIJnn8ApbwAsKZaWBtxJa/AfU=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=zF0mSkpCTd9gf0y2Vh/4eRYgli1GbY5jW0zYMELFAZU=;\n fh=GydoE0dVrH5U3riezLVKMH3u3AyK4m1H8UYvAkR9/9Y=;\n b=XI96Jm6U9U/Y1Ym+OnKT1w8qxeORyDIa7LE6Q9FVkmoxtP4axuElixg+6i8bI7vAVt\n pFyQLZG7+ZhXY9LwDYt3N8fzpKEzhsb3Wit9aFubmhQAbbQfKDM5euBhSrVZ+0yPqzBi\n DcM2bEP9PglIlzEC2wv571AvK2l91VDm9SYq5/23i8kvB53y25evfXMMzMfdjTozKqsI\n 6lPyEbVpMTKWvR8ccCJCeDBRdDyH04AibGPidKvNBets+pL5cw3xqFKVPLxB5NlBl+ix\n 6zVpTBtQBUgF6XpIQ236sL1p+qwwtLtcCTF+WaEuH0OGPC1JtHtQ0zzenUooGQYewWcf\n ecKg==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=JSPoYPSG; arc=pass smtp.client-ip=209.85.219.49","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777215561; x=1777820361;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zF0mSkpCTd9gf0y2Vh/4eRYgli1GbY5jW0zYMELFAZU=;\n b=JSPoYPSGsc0JYGdvpPFVtsVOdCiGgdc9w394x9mS8iT7NhIqqBJqgPaMKEGohPcQY5\n a3vHcKQJQxHLPaaEODrARQlflEMteyWeYXeO3MsdO+9ei0SqQW+qCfDM88/Xuv5B1rin\n kU1SOiXTjP4+kYZd1UDDSy0m3Czmy1wgzLcxEv4HOiFLRjltze8fKSR1oPAZgV5RO4XI\n XfHvj90qDfbpul3cknEHV64LYQihwHkW1hpolB4Mk/iO45LmBak0aftSkOZkb9P7MCan\n mn1d4Q8+EOM7vusMNHc+YVdBlej89esq+diW7uV0gHrnRrYLjcPz86BwCr+Lb7e4ZqZ9\n I8zQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777215561; x=1777820361;\n h=content-transfer-encoding:cc:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zF0mSkpCTd9gf0y2Vh/4eRYgli1GbY5jW0zYMELFAZU=;\n b=ioArYaijMB4WPwUcgNmhKICqI/5XGgoGONcUNvsjjmehms19C3zwfi6VMaGLUJfkdO\n MexX1ciw+lBRNxCJbclDiSH5/75O4nXBXBtFwTUAs1gNUpa9zFdTy1k+rSeswwBm3b1Y\n QHF/JiwVOAJRpBwxI8nk/sJNXqdde7crD8Smr/uyq8qgy9trFjoNrpIacY4ICsofRgGD\n PADktB9dN+SQldPj0fmWHqBJRoK0c9OkO6eR1kvHT/cY1kaaq9AL0bMPVkTWocMZ6sue\n tPm3Ju3edf9z3+xhNm4di3l1uyOn9LjiQmfLK1fuwH02AjtpjcTOCQyaHAIRayX7iDVl\n bkJg==","X-Gm-Message-State":"AOJu0YxbTEZ9YFdtVCdBt2TdFpsgujtksIlz2Y54q/45fWvPYBsrJZBP\n\tYjoOMc9fWNu7sMzqdfLjufjY+/LJ5rcisqRoAWecxjkqBKrFhiQpjllvu72elgU8mUR+MVA19dj\n\tIQo/GPK59pC2VFQnCB4/I/iMh63mJ7AKlYA==","X-Gm-Gg":"AeBDiev+s0w/pRBx4B2ihlbS5zxm+4c6lVzjiq5/mWcer4V4H79gUg51nt5LQIXD6xM\n\tLAjJx3mb2jHaTuhxH3RZoD7PPtyzTZhokcKYkwBQo0nskQ2CtfyA4OhY/EiRvyfphQxkRrwo/jb\n\tUQMKT5lIQUPEI/jprOfcUraGLzEKxtY/wC3porI79l9fm5i2eLa98MTy6zZJ98+iUFkm5bUl6f6\n\tuc9nts2VHZSpzHEQ7iOzU7u5CqFVDcdF+qbrx7VIMDbhWpM93G9sGkPeIYQxSHpNAkZ0JfvACGQ\n\tB3q58FZahlzZNs3nT+BWxaopb3JKEWbDSmLeJJTWkqNtAzv0FinzfvCMyNgx/lbLQj656E4CKet\n\t/XPCIxngAOrOVVSdeBCHSvOBh3LUvygIN8u/qrDT7OkYMIjvNhLMw07WcZXC/TfE1b+aMbORDxr\n\tObd+MuQsniXt0v+cnui0Op7P3tpGhBy90=","X-Received":"by 2002:a0c:e008:0:b0:8ac:8cbb:49bd with SMTP id\n 6a1803df08f44-8b028114e9bmr592609036d6.38.1777215561570; Sun, 26 Apr 2026\n 07:59:21 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260426113937.30818-1-ddiss@suse.de>","In-Reply-To":"<20260426113937.30818-1-ddiss@suse.de>","From":"Steve French ","Date":"Sun, 26 Apr 2026 09:59:10 -0500","X-Gm-Features":"AVHnY4In-YCUMovybsGDnc6igsUH1JOaZJREkKU7lgEcnJzuPFUKw0h3-QvHlIQ","Message-ID":"\n ","Subject":"Re: [PATCH] smb/client: remove unused smb3_parse_opt()","Cc":"linux-cifs@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]