[{"id":3682376,"web_url":"http://patchwork.ozlabs.org/comment/3682376/","msgid":"<20260426054214.3882-1-linuxtestproject.agent@gmail.com>","list_archive_url":null,"date":"2026-04-26T05:42:14","subject":"Re: [LTP] syscalls/mmap09: Drop hardcoded /tmp path","submitter":{"id":93132,"url":"http://patchwork.ozlabs.org/api/people/93132/","name":null,"email":"linuxtestproject.agent@gmail.com"},"content":"Hi Darren,\n\nOn Sun, 26 Apr 2026, Darren Chang wrote:\n> syscalls/mmap09: Drop hardcoded /tmp path\n\n> - fd = SAFE_OPEN(\"/tmp/mmaptest\", O_RDWR | O_CREAT, 0666);\n> + fd = SAFE_OPEN(\"mmaptest\", O_RDWR | O_CREAT, 0666);\n\nCorrect fix — .needs_tmpdir = 1 already chdirs into the temp directory,\nso the relative path is the right approach.\n\nReviewed-by: LTP AI Reviewer \n\nPre-existing issues noticed in the surrounding code (not introduced\nby this patch):\n\n- mmap09.c:57 — cleanup() guards SAFE_CLOSE with `if (fd)`, but fd is a\n static int that defaults to 0 (stdin). Use `if (fd >= 0)` with fd\n initialized to -1.\n\n---\nNote:\n\nOur agent completed the review of the patch.\n\nThe agent can sometimes produce false positives although often its\nfindings are genuine. If you find issues with the review, please\ncomment this email or ignore the suggestions.\n\nRegards,\nLTP AI Reviewer","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ErYubdZ8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Fvh67ntz1xvV\n\tfor ; Sun, 26 Apr 2026 15:42:24 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id E28AC3E254E\n\tfor ; Sun, 26 Apr 2026 07:42:21 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id C5C923E196B\n for ; Sun, 26 Apr 2026 07:42:17 +0200 (CEST)","from mail-qk1-x742.google.com (mail-qk1-x742.google.com\n [IPv6:2607:f8b0:4864:20::742])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 5CD571400450\n for ; Sun, 26 Apr 2026 07:42:17 +0200 (CEST)","by mail-qk1-x742.google.com with SMTP id\n af79cd13be357-8e8c0c2d2bcso505619885a.1\n for ; Sat, 25 Apr 2026 22:42:17 -0700 (PDT)","from\n runnervmeorf1.1baynwzsqolufha0zuf3dtedeg.ex.internal.cloudapp.net\n ([52.237.143.49]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8e7d64cce76sm2419161185a.14.2026.04.25.22.42.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 25 Apr 2026 22:42:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777182136; x=1777786936; darn=lists.linux.it;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=+KY5CiHWRURA5VeIprY7xlKAZeRrxpQZ8Z5dgvqo9Ik=;\n b=ErYubdZ8ZUeOxryXudDRTvmvxiO7PMn5/P+4NDEn1ATmW1A/V+N258wk1cQtcbWz68\n bhba/EuBGQ18HkXk4uQR006+UeXLKP1aVqGumDGWnFq23qtH6TKvhTtRfFNykHUEUssG\n gk8T/cPXpq6PxkfSvMhv8uGbXew68n6m/C1Hoq9mtXSCdENQF3TRwn4LeouZW4Ub6iSd\n Z34UiHXaieHzMvtEdmy+afADiOCCczDUMa+HtfkZaDx7Yog04X+z6wPh33341wCnBqI7\n p1hgR0KqmHhQqwiEu/5P/zGYzTxiZOtEXZqjTy2oiCbFzN/rtt0S5dpQ2zpcPtO/08A1\n l2bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777182136; x=1777786936;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=+KY5CiHWRURA5VeIprY7xlKAZeRrxpQZ8Z5dgvqo9Ik=;\n b=lj+Gtl6Veco34zUOHsVj9cFNJkW8r4zPLkWfCxCyS2itmlBL+ZsSTWhJA0CqUrEGeT\n kQp/snJpOCRGiPQH1KFih4tcn0BCAavWr1tWEmqhfQKpnkJ3JTkLQqAMQUR9OylXvtCm\n 7ANwS+dtqyFAb8YCSdZLex/xfkgfoIAOzzUus4JhEdCOAoZ8FQSyRgTJR8NdlQdO7u2B\n OWEERoN6u2GnO1DQWfJy6RXTkKqiuS9I+ZGs/k1qvl7g+TS5gs2SnyQ+enLCkoZ+OjF8\n 4hsV5mJ8sZaRyr3lubeb4lXY4wanJEK0tpDTJrr8NmcmXSM8YGG8XjKVNBPrkJw+KIpA\n 1J8w==","X-Gm-Message-State":"AOJu0YwnzqZ+6dG3hKIxeY9p623iGxyPhLs8eGkkFdRatOboW6A5vDqB\n kxoX6BGm494v5wTAIeyTBNpVgBmi9cxDZPQP3FTOm3/glNC/larePD+H","X-Gm-Gg":"AeBDiev9XIjkn3v+Hj8+/Xsfs8HANehZXZTKisQlvhuzGTb7LclgU09FkkA16ZiebUZ\n j4pLT9mrV4Cf7t4hPfnYL1RcCXL+9QH+0lcVkeniMobXtjGNmjozj3KKeru+Vum0JuWc0QKLY3l\n hDrh5dXGzKI8K9NTlDmjXMakHCRK27rwy8KRxuokVtwiSxrb72zUVUojM4aw6y9SzpYB2qJiYUx\n G0Tnxmd8msoQVqQbZThaFrgXRX42rnUC+5pr7WQGyX7EMvpl9FvDOfhsXua8QJWkFIZoujxOlHz\n SXH+vfNNiKBSWmffeXVUEPkBW+qwCC7hr7g4aO7cSNHrEqagfTC1vNHBFkgq1GaGs5jq6dScETL\n 8uxM+NH9QnBkH6JCnGM5JmRmnqlPe5yKWU0bwbzTiqrHwHpGt0Fssvb8MD2jnmTlV5SzAUoBhqM\n tFM09Eiyw7u0y9ScR8qC3ROP1eWvJCEVLWistdr7lqc0QdyNGrzXu5txZOEI7iB1wdGBt4tJkt1\n yfK8RrVvvUae8a/ZDJLSy61oX2o6Gn1IphAjaqCngCcE9AbZw==","X-Received":"by 2002:a05:620a:459e:b0:8cd:b6b7:1e6c with SMTP id\n af79cd13be357-8e7916b1065mr5291590685a.35.1777182135993;\n Sat, 25 Apr 2026 22:42:15 -0700 (PDT)","From":"linuxtestproject.agent@gmail.com","To":"Darren Chang ","Date":"Sun, 26 Apr 2026 05:42:14 +0000","Message-ID":"<20260426054214.3882-1-linuxtestproject.agent@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260426035823.3634607-1-chihsheng@google.com>","References":"<20260426035823.3634607-1-chihsheng@google.com>","MIME-Version":"1.0","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS\n shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] syscalls/mmap09: Drop hardcoded /tmp path","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"ltp@lists.linux.it, LTP AI Reviewer ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]