[{"id":3682313,"web_url":"http://patchwork.ozlabs.org/comment/3682313/","msgid":"","list_archive_url":null,"date":"2026-04-25T17:16:02","subject":"RE: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","submitter":{"id":79631,"url":"http://patchwork.ozlabs.org/api/people/79631/","name":"Biju Das","email":"biju.das.jz@bp.renesas.com"},"content":"Hi John,\n\nThanks for the patch.\n\n> -----Original Message-----\n> From: John Madieu \n> Sent: 25 April 2026 16:50\n> Subject: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in IRQ handler\n> \n> isl1208_rtc_interrupt() is of irqreturn_t type but two paths return a negative i2c errno instead of an\n> IRQ_* value:\n> \n> - The SR-poll loop on timeout: `return sr;`\n> - The post-alarm cleanup path: `return err;`\n> \n> genirq's note_interrupt() casts the return to unsigned int and flags any value above\n> IRQ_HANDLED|IRQ_WAKE_THREAD as a bogus return, logging \"irq event N: bogus return value X\" each time it\n> happens.\n> \n> Return IRQ_NONE when the SR read failed (no progress, can't claim the interrupt) and IRQ_HANDLED when\n> toggle_alarm failed.\n> \n> Fixes: cf044f0ed526 (\"drivers/rtc/rtc-isl1208.c: add alarm support\")\n> Signed-off-by: John Madieu \n> ---\n> drivers/rtc/rtc-isl1208.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index f71a6bb77b2a..c93998c53e7a\n> 100644\n> --- a/drivers/rtc/rtc-isl1208.c\n> +++ b/drivers/rtc/rtc-isl1208.c\n> @@ -654,7 +654,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n> \t\tif (time_after(jiffies, timeout)) {\n> \t\t\tdev_err(&client->dev, \"%s: reading SR failed\\n\",\n> \t\t\t\t__func__);\n> -\t\t\treturn sr;\n> +\t\t\treturn IRQ_NONE;\n\nMaybe you can use a goto statement?? that will take care of handled IRQ's\n\n\t\tgoto err_irq:\n\nerr_irq:\n\treturn handled ? IRQ_HANDLED : IRQ_NONE;\n\n> \t\t}\n> \t}\n> \n> @@ -666,7 +666,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n> \t\t/* Disable the alarm */\n> \t\terr = isl1208_rtc_toggle_alarm(client, 0);\n> \t\tif (err)\n> -\t\t\treturn err;\n> +\t\t\treturn IRQ_HANDLED;\n\nSame as above.\n\nCheers,\nBiju\n\n> \n> \t\tfsleep(275);\n> \n> --\n> 2.25.1","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=t0CFjqcx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6422-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"t0CFjqcx\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.74.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2xLg5s3vz1yHS\n\tfor ; Sun, 26 Apr 2026 03:16:11 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 4DBF33008222\n\tfor ; Sat, 25 Apr 2026 17:16:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0C23135AC2F;\n\tSat, 25 Apr 2026 17:16:08 +0000 (UTC)","from OS0P286CU010.outbound.protection.outlook.com\n (mail-japanwestazon11011047.outbound.protection.outlook.com [40.107.74.47])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 246D234F489;\n\tSat, 25 Apr 2026 17:16:05 +0000 (UTC)","from TY3PR01MB11346.jpnprd01.prod.outlook.com (2603:1096:400:3d0::7)\n by OS3PR01MB10341.jpnprd01.prod.outlook.com (2603:1096:604:1f8::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.24; Sat, 25 Apr\n 2026 17:16:02 +0000","from TY3PR01MB11346.jpnprd01.prod.outlook.com\n ([fe80::87d1:4928:d55:97de]) by TY3PR01MB11346.jpnprd01.prod.outlook.com\n ([fe80::87d1:4928:d55:97de%4]) with mapi id 15.20.9846.022; Sat, 25 Apr 2026\n 17:16:02 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777137367; cv=fail;\n b=tmTnxYq22Z6aVf61wJfOZcCg4D+JCnRq5s9WQ1HwanBa16gqoYIfeX1sbm25eHan75rYDAZZT2N0yrRqUb69KRm+GFMB8IaGBdNDBW7dR6KIgI3qU+H4rFCzz0P280ZkyzJkT3JfqfuQ9WH0o3uDCFSzyuks9z12rawqR/03drw=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=VmrOIVxaxWajnR3Vef2DBHkKxvl3ODw0AY2vGQ30DQmY3bd+YFXIuNbwNRRkwWC/ft8sOJoEQYJmAEeondN2BxPhuP5hpdQ/bQsNzeRIneCl2z0k74Q2DzDCpbXvQRqGssTeONOTLgi20eAWlT/WgqygrdooJ2b8GhvdiyMNwn+OjLlI7iEOST6PN8otoxwmW3J/+OkrP8FAAonUftWoChwpdDEjRnGAe16AI3IsMHhDUuT4o7CS5TBpmqto88GbeEknsNXHZpZKF18mt6j6lcF9aLwyEjWpz0Zj1yY224qlfFuUPiH7E5HxbE4321OavsYAeZ7YMuwryY6Uaw124Q=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777137367; c=relaxed/simple;\n\tbh=TiH9ndzZ/tqLs3VwKBI2PiWDj3URHFORlicajGgIGGk=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=ccRfVw4MReozPlVj7sF9is2H1u3wBdbmReYTwymUPh3NLgCl+Chkgy1PhLL0JZx6xTBHqmRKUkvuaeoKPTGmkbq5/YZqNWQLzLbOp6fC3axJPBuw3IZ8a2ngLcmlESDsMligreDKT85tWNFH7rc1V997Bss0lCzQF81MfM+lSGI=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=rDivjbGAMdy3k6rG53QEG37bzIOkTdh5vDRf2Df3pfo=;\n b=MKqWyk5bcVgSMr8r5BXL+kFuIlTKr3uQLR8dmQj4JE0xXxyKV3BdqvMW4z+aFnFk6iNe/Xd8mHwncEoNy7ePvBebDOFISdkx48jPXr1qyH1Q8JFs+FMzgcjwDva2aavUMBTZSnQhgaVKIHfik6ERisTSNUOfOHVbmOT8hMJ3fgITuT7tW6gMphCehXnY1hmeioaYvSm7Ccum396zVUIZGGlry1UO/lIYmPaRTJPUV12acCCPMdlV+6CeSly0A/CqpVaHVUeeZVbAwpUtHBEye0V3H8P8l9Rhy6hMXkWLyOuAu06vUnr1iv/MTy4fDuS1udnjvYPEMjC5YP4ocL0srA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com;\n spf=pass smtp.mailfrom=bp.renesas.com;\n dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=t0CFjqcx; arc=fail smtp.client-ip=40.107.74.47","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=bp.renesas.com; dmarc=pass action=none\n header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=rDivjbGAMdy3k6rG53QEG37bzIOkTdh5vDRf2Df3pfo=;\n b=t0CFjqcxONVfvZps9pZrvjZv5jw5wHHnT89Rovcf9gwyhaJzCnh08NPzpsXOmsTS5ZZ2L03l7UHd3zZdIUgxIlvSvJNHIUwGBQAWqeoigInF8TVRzZMYjcmbkzPQGLWLIcIXCg0uIOOP2sv8iqhbhaNejbeFI4OW0v7Cvcuwkws=","From":"Biju Das ","To":"John Madieu ,\n\t\"alexandre.belloni@bootlin.com\" ","CC":"\"ryan@bluewatersys.com\" ,\n\t\"akpm@linux-foundation.org\" ,\n\t\"m.grzeschik@pengutronix.de\" ,\n\t\"Denis.Osterland@diehl.com\" ,\n\t\"linux-rtc@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"john.madieu@gmail.com\" ","Subject":"RE: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","Thread-Topic":"[PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","Thread-Index":"AQHc1MtpASnRMIE8KkmYq1oUowxYhrXwA9Iw","Date":"Sat, 25 Apr 2026 17:16:02 +0000","Message-ID":"\n ","References":"<20260425154959.2796261-1-john.madieu.xa@bp.renesas.com>\n <20260425154959.2796261-2-john.madieu.xa@bp.renesas.com>","In-Reply-To":"<20260425154959.2796261-2-john.madieu.xa@bp.renesas.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=t0CFjqcx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6422-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"t0CFjqcx\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.74.47","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TY3PR01MB11346:EE_|OS3PR01MB10341:EE_","x-ms-office365-filtering-correlation-id":"236ee80a-f115-447a-21fe-08dea2ee53ae","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|376014|1800799024|366016|38070700021|56012099003|22082099003|18002099003;","x-microsoft-antispam-message-info":"\n 2S/7yljFeccpLEzCyRpAS2MfzCt6gV2wpo53ZRHNQSBa96QRz6V3w5qWQ73VHb2bubwOSnCjJq6bYbUPmR+GhDdSDXez3nwDqp561Ruv/E9W5+B3QDknvf7IR2pkE6gJo16BjKi6igNjacJt96ry76J5b5GhzyDtj5cyReYrg7J+ButpAht28XTVHgYW7zaU4LQ9LXHXcGLyVE/3U/MZwAd9aB3mdlXPLH9iEkahedjkscSZUaCVW5Z4u0KyAbYpvvJaB3yBVqHTzAGbO9RCdzcObs8gTJq9kPbborbjtVi2wzJkj9EjA3grfda/zbKkxWHqM1JeKr1VZ3z1qPcw49NpZwv+dp1HydFcUbnz/gpsAoIgyxp1XF6B5p3BUsKC0kMBHQhoxfOUC2eLexCPzdyiOWKoCICIJpvYAttwEVAHKR6ChIlpVuoU2Ezd9/U7sVBHuCtyKaM4hQQfQ0EA0wk0K7hR5tnshm+C2ga8mC+B9MsHzE2yJ4BRBTi1ccH/YoNZmkdrD4v6ftMuTqvrAigzy3mIvxK6yXoLbqllBHTC+pOPB+KL+28ZCDosP0hOPukfizGi6g0vk97ZjW0Vq/r/WWUH2OTccCSmWmBQvukKP09olCK0IEHiig4Fx8WtHyimqWSEi6LCldF0j2wFRetoJaSe6k0ZzMQIq0g80DZl7QwWy5Yna0JNUDmFMwdg5n5b1Bnz7GuhIumcQCpkU5zw7RaFdVNNLlnnKoXmPUdRWW4tS/aRLIQKy4Zmpr7uwF5JBxnmJ9pjCHk3oN/dra8IHmlLbDRJ4z7+Ean4O+k=","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY3PR01MB11346.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(38070700021)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n +jxvJKQ0ogwrem/wA0v9e2FyN+ibfGPIgxAGowxdPYHQvd+qS0wuuZo2SASHRuUDlLkdhA6qLFs+jNnDOVSSFUtU+47fYZ3xrtJm+WSD1SXPZZPGy7uf18xL24tLoUcCWJe5OINkh7JoB04NRHYN0GMtWiCddX7uL1MSc3EO1WFa5ekPbYaVnKmyUdHvyJIaRA0f73d+t5qTY3zwaZExWaVgrWc4H5dsD87sXTd4m7ac16N1ibkMMrmG53kzMrB/I7SeazFGZky/McwjDdxhU/M4Tw1MIB50PUogvCPtBn36QEieTuQCDMsOsm07g9BTr4oYoY/u4qPHIxM0tf/Pmnvnq111yru5GW5il14IeVO6r00D7c2L7O6meVCQq64i9hEkqISD5cjNYC+/pc6ys0oU7pA7WnGy0OATqz5fhJMfbu0/4YCFwfHAWLCuWF7iG5PE7XTYyzYhNglD5YW597QtdUNOWOV2sbQJShK48OK3IORn8VNik4+iynwTUOWIQ3JXNA4S3eDy2JzanOD1AnYLjx3bW/Z6rUF5spP98KceT4b9SJJG74Z46bBAL2LNQuvnC0/AL9GxJyErrUC7+TkI0JPZJf9H99+LfJBh3IebJ4JAEyyb9utXAdcuzAa9bhTjnFqhHYxpX+CfDAdtex+mNqrl8Fhn+Fa9wqX0wB+Pjr4K4vLODenlA3SAEDnba+cpVzfnIkYH6Mtg15pMNiaMtiYm9hd5l8Y+F2f0HlGSnmduj9bMTXmAy+faDnsQizg+VcnqO2X/v9SMVFfXN8qG46tIXmRxLGWGF8lB7Wwk3eIuOKJEPcyLIWEFqk1y0pzkDRJT4N7RkAGjSR+Lr5DNDmupqcZ1PyIWvU26qWbDFElyhFoJtTAVLRuOUcwaVyEMUVq94P0PieyG/d/qu030oud414wFow5e4sY6jMRxGpQNn99nMlCHXKGXpabPkmph1fB79gYUJ+X2rMMq7t64IfcumKjyLBQ63/Ky8P3ztAhTXEOoWgwqWmtWv85hSYixzAAisasU8x8E3RtGpZFSBx2MXqMK/eaIFF4P1Od7khM2criMdUCITjitQ24q1Dd9eMK+OlLHFV13gfrIGsgk53zhW8wMKgbNbfUs0AKxWmcLsh3cYlL6bIzb3RhzLb+6ASI3nAP9F36EGKD4Mmv6pnh2Txg5OmbBeShTVGSvKeG2VFXoLXOopLPmf3wHbJS+tqOo/kpQjKlr94VECrre7rk5vQiBU9prHbJmjh21bnDytuSYkU3SZ4bnX/F/ArC0e4euLIRRDDzHuMCm2GV12ziFVA2QQIOp9C7vMe0OHcFzu1z0xLt3JTjH0V0+cuWNQGYeRzR+u8EuSag5NrsINGvBCgpa4pTBueQnDKwbqzgSYD+dOEeIdZwkIV4tL16NqfHwmJEPTIo9N0VW4u/bc+LK7KjGS6LfaCB2hcR1SB3D7E6p8TlrrEk0p3TgdZvd2VFt0+r1yNoPNUTR2kpopLHCyKWwmpNEa1MVNAPVLxa1F0G++uXjWa4w94SKpg0V9D0iaIxlTfMLCfUXtrbR6jfWxVZD4A94klYJzIEn2yevJuhNq6sV1fRM4y13C0LS33ioKsS3QSQew52XJSNRj4LJIJWwq6XzMWsD29IWL9JNOPwzsjS1tQ7hpYUvG85dJwquqUNYPjK/7aPFDUAMXnw/dfrFwHM3S+pDeYp/hcgrXE7MeTSMoc9Pji9jFZIx52aUx69cgXKWifgIvw==","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-OriginatorOrg":"bp.renesas.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TY3PR01MB11346.jpnprd01.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 236ee80a-f115-447a-21fe-08dea2ee53ae","X-MS-Exchange-CrossTenant-originalarrivaltime":"25 Apr 2026 17:16:02.2474\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"53d82571-da19-47e4-9cb4-625a166a4a2a","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n OMvH4jXJV/V6xD+Rjnb52FikhRo96/D+fjD69zNbuODLOGLpEcJ67hJgPmY9Lmwn/uRrXF6rYVRWz8ajmv2gkbsDcdRXjL9Rx9FhROA8t2s=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"OS3PR01MB10341"}},{"id":3682427,"web_url":"http://patchwork.ozlabs.org/comment/3682427/","msgid":"","list_archive_url":null,"date":"2026-04-26T17:48:06","subject":"RE: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","submitter":{"id":89876,"url":"http://patchwork.ozlabs.org/api/people/89876/","name":"John Madieu","email":"john.madieu.xa@bp.renesas.com"},"content":"Hi Biju,\n\nThanks fort he review.\n\n> -----Original Message-----\n> From: Biju Das \n> Sent: Samstag, 25. April 2026 19:16\n> To: John Madieu ;\n> alexandre.belloni@bootlin.com\n> Subject: RE: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t\n> in IRQ handler\n> \n> Hi John,\n> \n> Thanks for the patch.\n> \n> > -----Original Message-----\n> > From: John Madieu \n> > Sent: 25 April 2026 16:50\n> > Subject: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t\n> > in IRQ handler\n> >\n> > isl1208_rtc_interrupt() is of irqreturn_t type but two paths return a\n> > negative i2c errno instead of an\n> > IRQ_* value:\n> >\n> > - The SR-poll loop on timeout: `return sr;`\n> > - The post-alarm cleanup path: `return err;`\n> >\n> > genirq's note_interrupt() casts the return to unsigned int and flags\n> > any value above IRQ_HANDLED|IRQ_WAKE_THREAD as a bogus return, logging\n> > \"irq event N: bogus return value X\" each time it happens.\n> >\n> > Return IRQ_NONE when the SR read failed (no progress, can't claim the\n> > interrupt) and IRQ_HANDLED when toggle_alarm failed.\n> >\n> > Fixes: cf044f0ed526 (\"drivers/rtc/rtc-isl1208.c: add alarm support\")\n> > Signed-off-by: John Madieu \n> > ---\n> > drivers/rtc/rtc-isl1208.c | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c\n> > index f71a6bb77b2a..c93998c53e7a\n> > 100644\n> > --- a/drivers/rtc/rtc-isl1208.c\n> > +++ b/drivers/rtc/rtc-isl1208.c\n> > @@ -654,7 +654,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n> > \t\tif (time_after(jiffies, timeout)) {\n> > \t\t\tdev_err(&client->dev, \"%s: reading SR failed\\n\",\n> > \t\t\t\t__func__);\n> > -\t\t\treturn sr;\n> > +\t\t\treturn IRQ_NONE;\n> \n> Maybe you can use a goto statement?? that will take care of handled IRQ's\n> \n> \t\tgoto err_irq:\n> \n> err_irq:\n> \treturn handled ? IRQ_HANDLED : IRQ_NONE;\n\nAgreed. I'll do it your way in v2.\n\n> \n> > \t\t}\n> > \t}\n> >\n> > @@ -666,7 +666,7 @@ isl1208_rtc_interrupt(int irq, void *data)\n> > \t\t/* Disable the alarm */\n> > \t\terr = isl1208_rtc_toggle_alarm(client, 0);\n> > \t\tif (err)\n> > -\t\t\treturn err;\n> > +\t\t\treturn IRQ_HANDLED;\n> \n> Same as above.\n> \n\nI'll set handled = 1 so that goto can return IRQ_HANDLED.\n\nRegards,\nJohn\n\n> Cheers,\n> Biju\n> \n> >\n> > \t\tfsleep(275);\n> >\n> > --\n> > 2.25.1","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-rtc@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=c5d5ubX4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6425-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"c5d5ubX4\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.74.24","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Z1M16Whz1y2d\n\tfor ; Mon, 27 Apr 2026 03:48:23 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D67FF3006513\n\tfor ; Sun, 26 Apr 2026 17:48:18 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3781226CE39;\n\tSun, 26 Apr 2026 17:48:16 +0000 (UTC)","from OS0P286CU010.outbound.protection.outlook.com\n (mail-japanwestazon11011024.outbound.protection.outlook.com [40.107.74.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 339C42EB10;\n\tSun, 26 Apr 2026 17:48:13 +0000 (UTC)","from TY6PR01MB17377.jpnprd01.prod.outlook.com (2603:1096:405:35b::6)\n by TYCPR01MB11095.jpnprd01.prod.outlook.com (2603:1096:400:3c3::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.26; Sun, 26 Apr\n 2026 17:48:10 +0000","from TY6PR01MB17377.jpnprd01.prod.outlook.com\n ([fe80::f373:26d6:86c4:6aa3]) by TY6PR01MB17377.jpnprd01.prod.outlook.com\n ([fe80::f373:26d6:86c4:6aa3%6]) with mapi id 15.20.9846.025; Sun, 26 Apr 2026\n 17:48:06 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777225696; cv=fail;\n b=tSUEI8COGRXXCqZwhwda2mOYv5lrCS6I6SFs4kcyPAg47BBtkdAyg4SD/B2Yx/HPtx9/fbWdMJk64Ew+iAFS0jt+hMcwCQgJx3BnmmYYnstVGGmplnPr6h8p9YhwGD4toece8yHbCjNEcpbjwlGtXDKMZJlL+KyYf9jQpilMTjg=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=K/+KfqU+W6BJkqk0Se6EEIJJmmYgxCSmPk6SiuByjqiY/ZWhbbMcuOsCi/MkVkT9wWiRX+filbukVo5d6dQ2ZWrQdNuKvP7l6vGryJ6B8KGcZsQ4/jVwjUyNFF4NfnzDRJ8WDlUseUoHq95lZiLpivUk1Y2LJ+MY5Z0DE7KYQvrWXErcKEdrvEfDqpH+WG7bLpPu72sb4eHTE63vDXQScmisqTojlg9Fp+Trg9eEB/wpEv+o/KeJL19GozGyX69eBrGPzrzFlQoq46U+yODdBvEBD+2i7JWeSyUhMvr0NY+4rIkfIK27xEfKzpR8OJi98/LMEHHABtm3fUTkJwBekg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777225696; c=relaxed/simple;\n\tbh=JyCFK9Ia9b40JmeGzmege4IPqMEQYQfgTKflBrzLIo4=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=IDWAV/PpyHo32r/uTxDmPmY1hzrNrBa26umLV5+/j9JBwmtJPd4390055lkiNjdH6uwKezJCuDYXUbMGeoJ3llN94VG46JseYeuVXaFIS68DcPMlHlEEdGd8Xq6kR8N9xUxXDWsjfPWJ6fwkLf2kaPJKfmncGBrk8YQBONOo5es=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OnTs2iqYmVPncbq0k8H7H+mszASVa4nXU84cLFbY1Hg=;\n b=dalEFCrnV7WRmUXnFdPOXufjKZZDEcsqs46JwdYkK/osmU+2oEEGMbHm1881+QKd7LynSVUrZAHAfIGQlM8k5RwQE9l31m6OtddG4FtcZiGlmUP6RHY7U3OqiMs1s2MvqQ/CyfVj3/rGYXpB8BTP87YfuYUXSOxJP/kqZljtTquA0feC6A1MH4KvyEV9s0FYuLjbkZwrIcCFBcEZFd7xOA+Zni92OulEr9V85IkK/qvvyabkqLp0A2tGkRngw015OClcOB/pD8RS0cTCv8SmtomW5PF034EUH+Aef8nwD2mMSB3/v4IaogddYHXyOSEDKrOlj1KqBg9+9Aj+OcQVqQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com;\n spf=pass smtp.mailfrom=bp.renesas.com;\n dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=c5d5ubX4; arc=fail smtp.client-ip=40.107.74.24","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=bp.renesas.com; dmarc=pass action=none\n header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OnTs2iqYmVPncbq0k8H7H+mszASVa4nXU84cLFbY1Hg=;\n b=c5d5ubX4OHmeWZx+VOkkIenA51PfXlojozquio1L9SIaW5Rc1iOk5fi4zauuxNalyCUMcFILTJzdYJIBsyyrjlG0bFWA4ETzXyfxlTFJKhUCXC8yHz1Am3f8Ar6c3UsAKx6/eK4anIUiURL+DtVDXvRTGzfpQQJCYdtaZpNfIXE=","From":"John Madieu ","To":"Biju Das , \"alexandre.belloni@bootlin.com\"\n\t","CC":"\"ryan@bluewatersys.com\" ,\n\t\"akpm@linux-foundation.org\" ,\n\t\"m.grzeschik@pengutronix.de\" ,\n\t\"Denis.Osterland@diehl.com\" ,\n\t\"linux-rtc@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"john.madieu@gmail.com\" ","Subject":"RE: [PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","Thread-Topic":"[PATCH 1/2] rtc: isl1208: Fix returning errno as irqreturn_t in\n IRQ handler","Thread-Index":"AQHc1MtoAScwmeohuUK2OTpHOTfMXLXwBMsAgAGZ1SA=","Date":"Sun, 26 Apr 2026 17:48:06 +0000","Message-ID":"\n ","References":"<20260425154959.2796261-1-john.madieu.xa@bp.renesas.com>\n <20260425154959.2796261-2-john.madieu.xa@bp.renesas.com>\n ","In-Reply-To":"\n ","Accept-Language":"en-US, en-GB","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=c5d5ubX4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6425-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"c5d5ubX4\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.107.74.24","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TY6PR01MB17377:EE_|TYCPR01MB11095:EE_","x-ms-office365-filtering-correlation-id":"f36f04fb-f493-4694-b59c-08dea3bbf8ff","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|366016|376014|1800799024|56012099003|18002099003|22082099003|38070700021;","x-microsoft-antispam-message-info":"\n c/1+upQTttnnwiquf9Xf7Dr9Rf//Gy66VRTJlisFkX8lpVBhraIc+uxRKBaW+KqoiRtjJAG8owCIqUrIm0iv4/fIUbpVrz8bOk4JyH1dWLc83a2ARdr3CDbBZ0Ca9wLxllB5ySzXEMCon4QLJk0mn8mQ/hKnn3BBP6/F7aRC+becXSfMy0pFmIZCIFmajEOoAwlyg7l1X966SqVQMVBYsl5WdS6v9cPxIOvV9YibhfMISQXnK6dn/ne1NuZ+4VLEEAR4FmkzvUtgMxjmI324CKBLbJFLl1TpTv+wltHvTOCikUwDgcrsmxHTjNJadFhHp8tyL6/Q5OYAm9eWXaMoJfCvND6OX+mwLzFGMv680cTBHMNH9jkd5grWcrcJlgh3Oz0egL9l+UeAnjoK9OEc2tYiThyCvh6qyiYhxUgFioALjTKu4FTfRfhdvvxgAtq5nfEPk67ZfoNTYyEB5P1KBLa823/0BJRaYHTYhWgbGAQpiP/aKnFHO5PlVxeUHd2aDwqN33mhI3U6zjxtCKG/lqQcX0GPsEMjEwIqqLFMuaE8TMI/Ubgw6ph3eE2gm9ilQrHDGRE5QR326Xn8WgWgmLrLWlBfioKEcaiwIwUpvwtlfspEo6d/HJ/MC7VdqliAl5gqb0TVXaC6Dq3g85RCuk5HyQ+YAF7v3YCsyTHzclIyzJmgEk7oNnogZOyL47oy747zlREi5fvq4xuxLDvBluVsaXlDZaia4R7UBLRgHHm2Kkm7Qbi2Uu+Jj6Vjih2KpUCXJH2/86c7fDUAQ72jodWkhKc6kKdvUOP8M3x3OjU=","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY6PR01MB17377.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(56012099003)(18002099003)(22082099003)(38070700021);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n cWW8x/7Bsd2/pI3cRrnAB8xx8dKJvikuGKEoacfrGza3Q2f9lX+ubBrORBUCK7pJhFbnhV3vSWMyZMBdCoz1pVNB5Pt3w1egO8S9ngr7Z0OdIk5uNq+LEHlXX/pgQqHnHRO9+M+mTRoQds9WcIGYmLCA3owQqe8mcMqSxJKsVToOB7uWez+sRBWAydFLGRNya0Ce3rpWpr3RF71ZaqBUr3yWhPQkdENEo1wQWgkjwbe6rQw9oSuKBMU/EL+0pbhvsMupsSxT7fh0hQ689tDJJbtpVxEd0vk3lNPiUkofXmSvSqA/70Zg5c2qC7o5N1CpvTzABiFjRomfi6XAlFuWESHeG0fLRyBv82u2kIcBsJfBHTnm5FVIEXm7loL2GSDwWWb+ZYfiTCM1lNcztudgPXfcvK3BGFRAG/sf9E/VU7/7GfNUPNiDLoqKPdzDWxaiuJECu/NNU8xMocSzkRcpqEypvKIOtAX2wPKMfux8aqc1N+6DvjMtmn7++QdGJAADp71aaQ4HeYIZy9rZRRgAyeSvbxzoH6w0k6wc3piG3QhewV6Fv0f0Gv920YKtdPx0q86Gtd05re0uVnclqPDwGDwUhqd9V5ahr00zyyU6d5edD9aLpGMyAoQ/Grm2PmRE5AsqDSabqavQ4qJRyeXdREMlWZV5ZweFBbcaJ0sKuY1KRYe1rkF0QfeCi5e1Xeuz0yafZsnQ5PjXqEuiJt/q/TityysB6YwAqna6OQ2eIvs1no/lKWJ+Qf696zG+h3MPij3HYAngLtkAhljiDlxOwlVkHGBrKZ1EUBXbBBuc1YmTfw0mVj3BQWU6u/JIl+6cLw0nTwMvL1mGuiyLYawnUR0YLaKv9aT+SFvviSB/3P9q0uxs/SKinic3NO4Qvk9UiwFDOZ4hB+3lk5D/o69wy5CHygMzOLkhieT9EgtAVXQtTL0VOECYOO1K6Aizo3RO6ACJ6pBzfE8fB0tHpznjV57OHdTMetnf4LfJaoGfpIooL2iTMIuCKBOCD44acEn350kWBuSK4OADYpTYJzjJ8+g/VVndxNHWKHjlhJtbzP2Q3vqtHWtZPOOX/I3K7pyhS0sq/MtTTjW+2qA8GMXqh93wmZj+/4uo59M0xunRNkOVfvOPmqWMGVRmQjFxHPtAn3zKhmfCrShIG2UFk1I2yKipTXUZb5jweyjnL4CPEWkKStsArj9SNG6RvGuq5gkduDLdxuGT5fA5XqWHllYCE33tPsH++POO5uKDqjkOdPtkLnq9M36FVaLuJfEt1UTSSNo/mAhtEiPmFYwepR9RR7iAr0F/95j+1IZK7o3dIMSRUeVydQaLyQi4iK3xMoU+NcG8lAlHbqI/xHQkaDQ2jm+d5KBhnuU0GTpBMliwBvv+6nO9sZXZHcme8QqdbaZZ7NVt5l+Hzxb9hy5uK03zNsmfbV4BTW6zA47MGqHGVOpreC2PhJiTBvY/zbBa7sPmnrIy0m8OuQNPTdWWmLvfGUX2YksN92cKukw89HRGR4k2RAdQpuoisaPpAuNuklU2/IgaFE/48voaOIVZ+NwTI6HHR0wM+dgYxZmT1GjMTxhxcdGbsqtW6hIbzPr5U7YiFLPh+TC9vLJnRxNQmCGw7l3im9Aj6tWNhq+Ux1zawkAy4TYodNzBT3lTGbifUWengWnxYnh4CR4rzLkxQvwYRSM/YsBQ5aphiRUg5X7Nn3egJLj+qLxdENfK1pfPsUVnnSzUsd0iyFseWfyZMXtm9vlu+pwH0aVx5ucFghu9Ji4=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","Precedence":"bulk","X-Mailing-List":"linux-rtc@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-OriginatorOrg":"bp.renesas.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TY6PR01MB17377.jpnprd01.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n f36f04fb-f493-4694-b59c-08dea3bbf8ff","X-MS-Exchange-CrossTenant-originalarrivaltime":"26 Apr 2026 17:48:06.4432\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"53d82571-da19-47e4-9cb4-625a166a4a2a","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n azgZy2TMJRvC8dvkfSO0THZ7FFfhRo9EC21gnLVrJuL62eWgaH2KaPc1TgEE2GC4l7GsuN+xdSokT0VIe5OdmVT7MmGTvFfJenKxnrJpl44=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYCPR01MB11095"}}]