[{"id":3683330,"web_url":"http://patchwork.ozlabs.org/comment/3683330/","msgid":"","list_archive_url":null,"date":"2026-04-28T09:57:15","subject":"Re: [ovs-dev] [PATCH ovn 1/2] northd: Add ls_has_localnet_port()\n helper.","submitter":{"id":91032,"url":"http://patchwork.ozlabs.org/api/people/91032/","name":"Mairtin O'Loingsigh","email":"moloings@redhat.com"},"content":"On Fri, Apr 24, 2026 at 05:35:57PM +0200, Dumitru Ceara via dev wrote:\n> Replace all open-coded vector_is_empty(&od->localnet_ports)\n> checks with a single ls_has_localnet_port() predicate. This\n> makes the intent clearer and provides a single place to change\n> if the localnet port tracking ever moves to a different data\n> structure.\n> \n> No functional change.\n> \n> Assisted-by: Claude Opus 4.6, Claude Code\n> Signed-off-by: Dumitru Ceara \n> ---\n> northd/en-multicast.c | 2 +-\n> northd/northd.c | 16 ++++++++--------\n> northd/northd.h | 6 ++++++\n> 3 files changed, 15 insertions(+), 9 deletions(-)\n> \n> diff --git a/northd/en-multicast.c b/northd/en-multicast.c\n> index a7dfd71c47..b2775516a9 100644\n> --- a/northd/en-multicast.c\n> +++ b/northd/en-multicast.c\n> @@ -710,7 +710,7 @@ ovn_igmp_group_aggregate_ports(struct ovn_igmp_group *igmp_group,\n> free(entry);\n> }\n> \n> - if (!vector_is_empty(&igmp_group->datapath->localnet_ports)) {\n> + if (ls_has_localnet_port(igmp_group->datapath)) {\n> ovn_multicast_add_ports(mcast_groups, igmp_group->datapath,\n> &igmp_group->mcgroup,\n> vector_get_array(&igmp_group->datapath->localnet_ports),\n> diff --git a/northd/northd.c b/northd/northd.c\n> index 0b52db6cf6..02c7e7e54e 100644\n> --- a/northd/northd.c\n> +++ b/northd/northd.c\n> @@ -1788,7 +1788,7 @@ peer_needs_cr_port_creation(struct ovn_port *op)\n> {\n> if ((op->nbrp->n_gateway_chassis || op->nbrp->ha_chassis_group)\n> && vector_len(&op->od->l3dgw_ports) == 1 && op->peer && op->peer->nbsp\n> - && vector_is_empty(&op->peer->od->localnet_ports)) {\n> + && !ls_has_localnet_port(op->peer->od)) {\n> return true;\n> }\n> \n> @@ -2837,7 +2837,7 @@ ovn_port_update_sbrec(struct ovsdb_idl_txn *ovnsb_txn,\n> smap_clone(&options, &op->nbsp->options);\n> \n> if (queue_id) {\n> - if (!vector_is_empty(&op->od->localnet_ports)) {\n> + if (ls_has_localnet_port(op->od)) {\n> struct ovn_port *port = vector_get(&op->od->localnet_ports,\n> 0, struct ovn_port *);\n> const char *physical_network = smap_get(\n> @@ -3954,7 +3954,7 @@ should_add_router_port_garp(const struct ovn_port *op, const char *chassis)\n> vector_len(&op->peer->od->l3dgw_ports));\n> }\n> }\n> - } else if (chassis && !vector_is_empty(&op->od->localnet_ports)) {\n> + } else if (chassis && ls_has_localnet_port(op->od)) {\n> add_router_port_garp = true;\n> }\n> \n> @@ -6263,7 +6263,7 @@ build_lswitch_port_sec_op(struct ovn_port *op, struct lflow_table *lflows,\n> WITH_IO_PORT(op->key), WITH_HINT(&op->nbsp->header_));\n> \n> if (!lsp_is_localnet(op->nbsp) &&\n> - vector_is_empty(&op->od->localnet_ports)) {\n> + !ls_has_localnet_port(op->od)) {\n> return;\n> }\n> \n> @@ -6277,7 +6277,7 @@ build_lswitch_port_sec_op(struct ovn_port *op, struct lflow_table *lflows,\n> ds_cstr(match), ds_cstr(actions), op->lflow_ref,\n> WITH_IO_PORT(op->key),\n> WITH_HINT(&op->nbsp->header_));\n> - } else if (!vector_is_empty(&op->od->localnet_ports)) {\n> + } else if (ls_has_localnet_port(op->od)) {\n> const struct ovn_port *lp = vector_get(&op->od->localnet_ports, 0,\n> struct ovn_port *);\n> ds_put_format(match, \"outport == %s && inport == %s\",\n> @@ -10897,7 +10897,7 @@ build_lswitch_dhcp_options_and_response(struct ovn_port *op,\n> }\n> \n> bool is_external = lsp_is_external(op->nbsp);\n> - if (is_external && (vector_is_empty(&op->od->localnet_ports) ||\n> + if (is_external && (!ls_has_localnet_port(op->od) ||\n> !op->nbsp->ha_chassis_group)) {\n> /* If it's an external port and there are no localnet ports\n> * and if it doesn't belong to an HA chassis group ignore it. */\n> @@ -11322,7 +11322,7 @@ build_lswitch_ip_unicast_lookup(struct ovn_port *op,\n> \n> if (peer_lrp_is_centralized &&\n> !vector_is_empty(&op->peer->od->l3dgw_ports) &&\n> - !vector_is_empty(&op->od->localnet_ports)) {\n> + ls_has_localnet_port(op->od)) {\n> add_lrp_chassis_resident_check(op->peer, match);\n> } else if (op->cr_port) {\n> /* If the op has a chassis resident port, it means\n> @@ -17226,7 +17226,7 @@ build_lrouter_ipv4_ip_input(struct ovn_port *op,\n> \n> if (od_is_centralized(op->od) &&\n> !vector_is_empty(&op->od->l3dgw_ports) && op->peer\n> - && !vector_is_empty(&op->peer->od->localnet_ports)) {\n> + && ls_has_localnet_port(op->peer->od)) {\n> add_lrp_chassis_resident_check(op, match);\n> }\n> \n> diff --git a/northd/northd.h b/northd/northd.h\n> index e86d39f9aa..80f8e76870 100644\n> --- a/northd/northd.h\n> +++ b/northd/northd.h\n> @@ -507,6 +507,12 @@ ovn_datapath_is_stale(const struct ovn_datapath *od)\n> return !od->nbr && !od->nbs;\n> };\n> \n> +static inline bool\n> +ls_has_localnet_port(const struct ovn_datapath *od)\n> +{\n> + return !vector_is_empty(&od->localnet_ports);\n> +}\n> +\n> /* Pipeline stages. */\n> #define PIPELINE_STAGES \\\n> /* Logical switch ingress stages. */ \\\n> -- \n> 2.53.0\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n> \nLGTM\n\nAcked-by: Mairtin O'Loingsigh ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=G/rdOcR2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=G/rdOcR2","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4bT50zTXz1xvV\n\tfor ; Tue, 28 Apr 2026 19:57:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3699A41220;\n\tTue, 28 Apr 2026 09:57:27 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id s05CzyuOmJe2; Tue, 28 Apr 2026 09:57:26 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 45E0741210;\n\tTue, 28 Apr 2026 09:57:26 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 247E5C04FB;\n\tTue, 28 Apr 2026 09:57:26 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id B4D24C04FA\n for ; Tue, 28 Apr 2026 09:57:24 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id A6CD44120D\n for ; Tue, 28 Apr 2026 09:57:24 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 92tAd9NOphGz for ;\n Tue, 28 Apr 2026 09:57:23 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9720A4120B\n for ; Tue, 28 Apr 2026 09:57:23 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-cam-Nfl_MFm-sPL2BuEq6Q-1; Tue,\n 28 Apr 2026 05:57:20 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9FEF519560A6\n for ; Tue, 28 Apr 2026 09:57:19 +0000 (UTC)","from moloings-thinkpadp1gen7.rmtie.csb (unknown [10.22.64.75])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id A742830078C0; Tue, 28 Apr 2026 09:57:18 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections -\n client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 45E0741210","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9720A4120B"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=moloings@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9720A4120B","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777370241;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=ZUQZLWTRFYiE7WjeADf95ht8X2GtvR7VIUBPsMkp6vE=;\n b=G/rdOcR2V7yREMBTj4pH7lX9t5SyyfTk80FxF7VGSUS8p4In9PKBigXmFegJVqpWDX+kxz\n ea+R0hZB6v+ORo+Jq/+CruFFKJJxXMMrIHe2TCUXS1NQ47hiLQLn71G3Oe8aV8ai15d9Ih\n FaqQOslRhd1G7/Ii/PVyBq9/vtss558=","X-MC-Unique":"cam-Nfl_MFm-sPL2BuEq6Q-1","X-Mimecast-MFC-AGG-ID":"cam-Nfl_MFm-sPL2BuEq6Q_1777370239","Date":"Tue, 28 Apr 2026 10:57:15 +0100","To":"Dumitru Ceara ","Cc":"ovs-dev@openvswitch.org","Message-ID":"","References":"<20260424153558.1084949-1-dceara@redhat.com>\n <20260424153558.1084949-2-dceara@redhat.com>","MIME-Version":"1.0","In-Reply-To":"<20260424153558.1084949-2-dceara@redhat.com>","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"RNghL0oFu6LBFXs4gDsXp9f_yV5X6nfaYJzHDwr-_IM_1777370239","X-Mimecast-Originator":"redhat.com","Content-Disposition":"inline","Subject":"Re: [ovs-dev] [PATCH ovn 1/2] northd: Add ls_has_localnet_port()\n helper.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Mairtin O'Loingsigh via dev ","Reply-To":"Mairtin O'Loingsigh ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "}}]