[{"id":3682077,"web_url":"http://patchwork.ozlabs.org/comment/3682077/","msgid":"","list_archive_url":null,"date":"2026-04-24T15:12:38","subject":"Re: [PATCH v5 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support","submitter":{"id":84903,"url":"http://patchwork.ozlabs.org/api/people/84903/","name":"Neil Armstrong","email":"neil.armstrong@linaro.org"},"content":"On 4/24/26 16:17, Ronald Claveau via B4 Relay wrote:\n> From: Ronald Claveau \n> \n> Replace the hardcoded MAX_LEVEL constant and fan register\n> with values read from platform_data (fan_reg, max_level),\n> as new MCUs need different values.\n> \n> Optionally acquire and enable a \"fan\" regulator supply\n> at probe time and on resume,\n> so boards that gate fan power through a regulator are handled.\n> \n> Signed-off-by: Ronald Claveau \n> ---\n> drivers/thermal/khadas_mcu_fan.c | 37 ++++++++++++++++++++++++++++++-------\n> 1 file changed, 30 insertions(+), 7 deletions(-)\n> \n> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c\n> index d35e5313bea41..5603fa099a858 100644\n> --- a/drivers/thermal/khadas_mcu_fan.c\n> +++ b/drivers/thermal/khadas_mcu_fan.c\n> @@ -13,13 +13,15 @@\n> #include \n> #include \n> #include \n> -\n> -#define MAX_LEVEL 3\n> +#include \n> \n> struct khadas_mcu_fan_ctx {\n> \tstruct khadas_mcu *mcu;\n> +\tunsigned int fan_reg;\n> \tunsigned int level;\n> +\tunsigned int max_level;\n> \tstruct thermal_cooling_device *cdev;\n> +\tstruct regulator *power;\n> };\n> \n> static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> @@ -27,8 +29,7 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> {\n> \tint ret;\n> \n> -\tret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG,\n> -\t\t\t level);\n> +\tret = regmap_write(ctx->mcu->regmap, ctx->fan_reg, level);\n> \tif (ret)\n> \t\treturn ret;\n> \n> @@ -40,7 +41,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx,\n> static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev,\n> \t\t\t\t\tunsigned long *state)\n> {\n> -\t*state = MAX_LEVEL;\n> +\tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> +\n> +\t*state = ctx->max_level;\n> \n> \treturn 0;\n> }\n> @@ -61,7 +64,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev,\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = cdev->devdata;\n> \n> -\tif (state > MAX_LEVEL)\n> +\tif (state > ctx->max_level)\n> \t\treturn -EINVAL;\n> \n> \tif (state == ctx->level)\n> @@ -78,6 +81,7 @@ static const struct thermal_cooling_device_ops khadas_mcu_fan_cooling_ops = {\n> \n> static int khadas_mcu_fan_probe(struct platform_device *pdev)\n> {\n> +\tconst struct khadas_mcu_fan_pdata *pdata = dev_get_platdata(&pdev->dev);\n> \tstruct khadas_mcu *mcu = dev_get_drvdata(pdev->dev.parent);\n> \tstruct thermal_cooling_device *cdev;\n> \tstruct device *dev = &pdev->dev;\n> @@ -87,7 +91,21 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)\n> \tctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);\n> \tif (!ctx)\n> \t\treturn -ENOMEM;\n> +\n> \tctx->mcu = mcu;\n> +\tctx->fan_reg = pdata->fan_reg;\n> +\tctx->max_level = pdata->max_level;\n> +\n> +\tctx->power = devm_regulator_get(dev->parent, \"fan\");\n> +\tif (IS_ERR(ctx->power))\n> +\t\treturn PTR_ERR(ctx->power);\n> +\n> +\tret = regulator_enable(ctx->power);\n> +\tif (ret) {\n> +\t\tdev_err(dev, \"Failed to enable fan power supply: %d\\n\", ret);\n> +\t\treturn ret;\n> +\t}\n> +\n> \tplatform_set_drvdata(pdev, ctx);\n> \n> \tcdev = devm_thermal_of_cooling_device_register(dev->parent,\n> @@ -124,12 +142,17 @@ static int khadas_mcu_fan_suspend(struct device *dev)\n> \n> \tctx->level = level_save;\n> \n> -\treturn 0;\n> +\treturn regulator_disable(ctx->power);\n> }\n> \n> static int khadas_mcu_fan_resume(struct device *dev)\n> {\n> \tstruct khadas_mcu_fan_ctx *ctx = dev_get_drvdata(dev);\n> +\tint ret;\n> +\n> +\tret = regulator_enable(ctx->power);\n> +\tif (ret)\n> +\t\treturn ret;\n> \n> \treturn khadas_mcu_fan_set_level(ctx, ctx->level);\n> }\n> \n\nReviewed-by: Neil Armstrong ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=F4qoZJqq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17177-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=\"F4qoZJqq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.48","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linaro.org"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2GnF6GSWz1yDD\n\tfor ; Sat, 25 Apr 2026 01:18:25 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0F328307C47E\n\tfor ; Fri, 24 Apr 2026 15:13:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3C0E83DA7FF;\n\tFri, 24 Apr 2026 15:12:44 +0000 (UTC)","from mail-wm1-f48.google.com (mail-wm1-f48.google.com\n [209.85.128.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE15288C3D\n\tfor ; Fri, 24 Apr 2026 15:12:41 +0000 (UTC)","by mail-wm1-f48.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so130611845e9.2\n for ; Fri, 24 Apr 2026 08:12:41 -0700 (PDT)","from ?IPV6:2a01:e0a:106d:1080:608c:c052:cffc:495b?\n ([2a01:e0a:106d:1080:608c:c052:cffc:495b])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4412150a071sm25224946f8f.21.2026.04.24.08.12.38\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 24 Apr 2026 08:12:39 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777043563; cv=none;\n b=ADGBb7zK8rABx+KPEYkWyGV6EalqdGGzXwRQTqPpCLAheSXIsBi0MFHUwi6/6tJKfYK5CBH8l/Vw28VfOK+BJRWEYdjm9d2THbOfIkNzxWWy0fN2VAh4ULRupFfrj5q7lVOCymWPIQcxzOXjBOHTHVNhO7r/UrB0KsGRC35yqTk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777043563; c=relaxed/simple;\n\tbh=5XDKAxu8Xq1TVY6QbxiDtMURF8o8Sc8i5C25fq9XWJ4=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=rqPAJG2GM1a1uoxkep1rDO2aNeZgqVSIwy4HMrMn3mI9ELRrbKRUMq1LhW02ek+JGrO4FgN8KkgwnoRuWWAKyHAZ6jy+9qkaHz+r07MpQ1k/wrFcmWRsT6R+VXJfGVmDHT+ovnev3vXuciJ6dttiPzSXb1NIdkE5hFcLy8bsCjE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linaro.org;\n spf=pass smtp.mailfrom=linaro.org;\n dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org\n header.b=F4qoZJqq; arc=none smtp.client-ip=209.85.128.48","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777043560; x=1777648360;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:from:to:cc:subject:date:message-id\n :reply-to;\n bh=JlPy3eW0kbNMua8eHVUnVBy11sqyRv1hpFqPENpVf9I=;\n b=F4qoZJqqmUrs2GX+PhdaDhKCnKPgXYiqVW0zFoZLGGcvZ/mjoM0XN8PlXRgzVick2D\n mRMoG7AeM6gF9D2ZBPt2x+6ICp5i7KFR2Zi2d+TT/RER9bOF491cYVuutkZOVx8PUYR0\n dYPmD3ss0MVLnhiQ8h9DhQAo7zP/JZHH/QZMtxc/8sj9zBaR82UVMmhxuC0sdpEVEsAE\n 84wl87TiFxlUVlNbfDhJSuo4sw4D0yq09u0KjpFJTh4Uzw+pnHxlzZ0wvuOuN2aKXtRS\n FzDZc6qipjfnN92ZpHbXkHnWDI6uK7FZVjui/NCH6ISK0mTuuAgrCv3S3gKLGnN13FiJ\n ZBLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777043560; x=1777648360;\n h=content-transfer-encoding:in-reply-to:organization:autocrypt\n :content-language:references:cc:to:subject:reply-to:from:user-agent\n :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=JlPy3eW0kbNMua8eHVUnVBy11sqyRv1hpFqPENpVf9I=;\n b=Si7wbhIKV6x8Lmq3gnn1CC5Sw1iCaplAMp+0PX1EwBaeNGr65U6s/Wqic0L8ETOicg\n x6UzZ3T94/Luoqs+KXO7GTfj0nuQUo8hkMcEUnTzXT33cZ53hqEjsVj0l1ef8TlVkp7N\n OIInD8zsMRtG99vzGcr0M8R8HTV2yQgaknZFWs58vn8x1nFLAuOU2hg/bzpXOMq+R90+\n UCK/qecdBv7flyDkq3MI5qHmaY0QDOgnvi3VvH55YfJV6YMVO91oZK4MWZNkx/AhrroZ\n x5IvZ2bgiWeqk35suYb5q/OTZbE0xln4jUSRi1TYr4nWdmnoYrOjW/wnrPG81zIt0XP0\n 2ryA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+mxl/83X+XvgQA1BnvtfeWf1hDwuawA9TAndg2nEqggI4HT7W69nlXj3QhXU4LjD7gdBiZynpfkbM=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yx3b0qY/ofy3I3kWqV9v3K2e7Cn4PWwE47OOtPD2yMAHnS201WG\n\tBtzk5u3hquYqIOrqi11LNrvXZCBIR7RN+WsSsjZlImY6dR/tE5dBEvawTl8S9EC3E8o=","X-Gm-Gg":"AeBDieuWNwV8Cr85jlmUbFpdV0bCAK8nGz5u2zYxHAC0lofbkG9U3o3wRY46g7oU0aW\n\tftguQM++eyBD3OKm9naj56gm8oeSkWkwR80DHvjdtYkLpGHyRzfEXLHNWGATnYjGLe+9F/D915p\n\tpF3mNgnR2uNIwXWU3lqYjmVTQG7BhgdnenHQITlhGqu6quikyrWHN0EanhVASeuE+vty6LwViWx\n\tnAcg5yfPuhGpDyFRcDSZ+jGfsGbPWcWYIFf4/C3osDpMatXNae73/oTvy1XhJbAqFiMDCjN8+cZ\n\tQT5sUr0xZX9P4Ei0g2jvjAsjHq7B6eSKMr34iSIoDDmWBkFW9W8dP97iTfyt7CgGGC+XiK94w6d\n\tgDZ7escDAlxD3ij7gN+xOv3B03F0ynmPUB0uzjUSks49PkVj29035M7YDUKPn3lKmppH/kmkItf\n\tD6YGPYXuyqPcNJdvcwO7jw1nooWFTNhm/K/7BjJPZYLYHxVLki3FAgk4CxkLRRf3UDdA/NSnn/P\n\tuK9t52UKq6bxlvkAA==","X-Received":"by 2002:a05:600d:16:b0:489:19e9:b139 with SMTP id\n 5b1f17b1804b1-48919e9b29fmr249420635e9.1.1777043559595;\n Fri, 24 Apr 2026 08:12:39 -0700 (PDT)","Message-ID":"","Date":"Fri, 24 Apr 2026 17:12:38 +0200","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Neil Armstrong ","Reply-To":"Neil Armstrong ","Subject":"Re: [PATCH v5 5/8] thermal: khadas-mcu-fan: Add fan config from\n platform data Add regulator support","To":"linux-kernel-dev@aliel.fr, Lee Jones ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley , Andi Shyti ,\n Kevin Hilman , Jerome Brunet ,\n Martin Blumenstingl ,\n Beniamino Galvani ,\n \"Rafael J. Wysocki\" ,\n Daniel Lezcano , Zhang Rui ,\n Lukasz Luba , Liam Girdwood ,\n Mark Brown ","Cc":"linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org","References":"<20260424-add-mcu-fan-khadas-vim4-v5-0-afcfa7157b23@aliel.fr>\n <20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr>","Content-Language":"en-US, fr","Autocrypt":"addr=neil.armstrong@linaro.org; keydata=\n xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP\n GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4\n BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9\n qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik\n 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB\n AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA\n OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk\n Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04\n YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ\n GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw\n UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa\n GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r\n yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp\n QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+\n SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY\n 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM\n Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX\n oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn\n M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3\n 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS\n KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy\n 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT\n QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g","Organization":"Linaro","In-Reply-To":"<20260424-add-mcu-fan-khadas-vim4-v5-5-afcfa7157b23@aliel.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit"}}]