[{"id":3683369,"web_url":"http://patchwork.ozlabs.org/comment/3683369/","msgid":"","list_archive_url":null,"date":"2026-04-28T10:34:22","subject":"Re: [PATCH v1 01/20] dt-bindings: pinctrl: Add\n starfive,jhb100-sys0-pinctrl","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"Hi Changhuang,\n\nthanks for your patch!\n\nOn Fri, Apr 24, 2026 at 1:13 PM Changhuang Liang\n wrote:\n\n> Add pinctrl bindings for StarFive JHB100 SoC System-0(sys0) pinctrl\n> controller.\n>\n> Signed-off-by: Changhuang Liang \n(...)\n> + properties:\n> + pinmux:\n> + description: |\n> + The list of GPIOs and their function select.\n> + The PINMUX macros are used to configure the\n> + function selection.\n> +\n> + bias-disable: true\n> +\n> + bias-pull-up:\n> + type: boolean\n> +\n> + bias-pull-down:\n> + type: boolean\n> +\n> + drive-strength:\n> + enum: [ 2, 4, 8, 12 ]\n> +\n> + drive-strength-microamp:\n> + enum: [ 2000, 4000, 8000, 12000 ]\n> +\n> + input-enable: true\n> +\n> + input-disable: true\n> +\n> + input-schmitt-enable: true\n> +\n> + input-schmitt-disable: true\n> +\n> + slew-rate:\n> + enum: [ 0, 1 ]\n> + default: 0\n> + description: |\n> + 0: slow (half frequency)\n> + 1: fast\n> +\n> + starfive,debounce-width:\n> + $ref: /schemas/types.yaml#/definitions/uint32\n> + default: 0\n> + description:\n> + Debounce width 0 = Disabled, Others = 80ns*N stages\n\nThe argument to the existing\ninput-debounce is expressed in microseconds. Just recalculate\nthat value to your \"width\"? If you need more granularity add a\ngeneric property input-debound-nanoseconds = <...>;\n\nThe code you submitted contains these undocumented properties,\ncopied from the driver review:\n\n> +static const struct pinconf_generic_params jhb100_custom_bindings[] = {\n> + { \"starfive,gmac-vsel\", STARFIVE_PIN_CONFIG_GMAC_VSEL, 0 },\n\nCan't you use the existing \"power-source\" instead? It's fine if it's only\napplicable to a few pins. This is overly specific.\n\n> + { \"starfive,drive-i2c-fast-mode\", STARFIVE_PIN_DRIVE_I2C_FAST_MODE, 0 },\n> + { \"starfive,drive-i2c-fast-mode-plus\", STARFIVE_PIN_DRIVE_I2C_FAST_MODE_PLUS, 0 },\n\nIt's not special that things are for i2c. Use the generic\nslew-rate for these two, it describes how fast something is.\n\n> + { \"starfive,i2c-open-drain-pull-up-ohm\", STARFIVE_PIN_OPEN_DRAIN_PULLUP_SELECT, 0 },\n\nUse the existing drive-open-drain; with the existing bias-pull-up = ;\ntwo properties. No need to be fancy and create a new property for this.\n\n> + { \"starfive,vga-rte\", STARFIVE_PIN_VGA_RTE_SELECT, 0 },\n\nNo idea what this is...\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=IadyuzCc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35688-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"IadyuzCc\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4cV60Ln9z1yJH\n\tfor ; Tue, 28 Apr 2026 20:43:26 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7C1913004D1C\n\tfor ; Tue, 28 Apr 2026 10:34:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0487A3EDADB;\n\tTue, 28 Apr 2026 10:34:36 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A3CFA225A38\n\tfor ; Tue, 28 Apr 2026 10:34:35 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7D846C2BCB9\n\tfor ; Tue, 28 Apr 2026 10:34:35 +0000 (UTC)","by mail-lj1-f182.google.com with SMTP id\n 38308e7fff4ca-392445f11c5so4928511fa.1\n for ;\n Tue, 28 Apr 2026 03:34:35 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777372475; cv=none;\n b=Bc4wanWghxCwGbh0peJcJLatPu+9GNsvLiRibk2OHAHUsNBgtybQHkifwGfJHI8U/PCgdufUjBQKlC0LLeSvWYzgLGMJYI8A73jEnz98agAB0CdiD3S4erAi3zJ5nSZhcLd0Is3qb3j/0ntSRYHVT2mfNol84W88RgJWK70gDF0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777372475; c=relaxed/simple;\n\tbh=gfkP8u/is+YdXUFtrO/ofQ1MfyxFL2J12FWjzi6PQRE=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=E/L2dCfXWTcGu+4DKgpVihu6jQr5f3NibSgJtqx0HEbGybjFi1xJ5YpZOoyy9fdBe26oHDcArZff2mXSVyPjJmMLo2zWAr3ni/OaIwwNxam2Uv18wglM7aRk6gQF2iTzaqa96ybmX0vLL9WC21JU4a2b47S+SXItpQ/PHvnYNqU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=IadyuzCc; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777372475;\n\tbh=gfkP8u/is+YdXUFtrO/ofQ1MfyxFL2J12FWjzi6PQRE=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=IadyuzCcEFJRKbK1/nNcNjLcPqQVstV9hLpn7AAkd6qYTkJFJMlogQgOEPeqrgWck\n\t Fqg96jElAD2FXMXcsqG6d7vqpIZPq3iaC5FuOnHEr6VCoRgmVruv1z+h0f15AG+tow\n\t NgjExlmnunaOXmqQwSacVbgwUorzt+VgqfTNKiaptnQNEbzSuzZXuK3L55ZD0zHQNB\n\t oLajaIuOvF4zywmbGTpjgt/SV7Jwq6vDERMdqH3QRbFcfnO4q+3nneqnVvLUph7voD\n\t lKpO9RZCIwNMgijsqVAQPywrc8VANaQbJJJHunh6wBFfWfFYZ2nGxrb8TAAudzVEbs\n\t mP/AmRSUBQ6uQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9e5DkagcTDMw/aWKIvHOPFXYmkvLGyATiYDwV4A/2892BlCkiM5aTC94e+sMuR9S+L/08Zn1hWPSYO@vger.kernel.org","X-Gm-Message-State":"AOJu0YyxDxCFL6XCG+HXtWXz8TnbaO1bYFg2ZCj5DSXKGeCwaiqp+tiB\n\tntwTUEedAKsSJdqkmV6fBF0YeBppVmy9YXD/tLLbwkShU8+CCArUtacTsfvm89OUkj+/dwJCEA6\n\tL3Gc/VNj7kzCBRQV/EhhcMFuxNQIU6zQ=","X-Received":"by 2002:a05:651c:4406:10b0:38e:8aff:b657 with SMTP id\n 38308e7fff4ca-392403e0b2cmr6629161fa.22.1777372474178; Tue, 28 Apr 2026\n 03:34:34 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260424111330.702272-1-changhuang.liang@starfivetech.com>\n <20260424111330.702272-2-changhuang.liang@starfivetech.com>","In-Reply-To":"<20260424111330.702272-2-changhuang.liang@starfivetech.com>","From":"Linus Walleij ","Date":"Tue, 28 Apr 2026 12:34:22 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AVHnY4JRDyRgCHQroy6EcXp3lxK1Vk4EH6R59HQQOsESeJNnC-Dck6eQQIL6w6Q","Message-ID":"\n ","Subject":"Re: [PATCH v1 01/20] dt-bindings: pinctrl: Add\n starfive,jhb100-sys0-pinctrl","To":"Changhuang Liang ","Cc":"Rob Herring , Krzysztof Kozlowski ,\n\tConor Dooley , Emil Renner Berthing ,\n Paul Walmsley ,\n\tAlbert Ou , Palmer Dabbelt ,\n\tAlexandre Ghiti , Philipp Zabel ,\n\tBartosz Golaszewski , linux-gpio@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-riscv@lists.infradead.org,\n\tLianfeng Ouyang ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]