[{"id":3682078,"web_url":"http://patchwork.ozlabs.org/comment/3682078/","msgid":"<8dcdad92-2981-4d57-b605-871c748424c9@linaro.org>","list_archive_url":null,"date":"2026-04-24T15:23:59","subject":"Re: [PATCH v5 07/18] hw/usb/hcd-ehci: Introduce common properties\n macro for sysbus and pci","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 24/4/26 10:05, Jamin Lin wrote:\n> EHCI properties are currently defined separately in both sysbus and\n> PCI implementations, leading to duplicated code for common fields\n> such as \"maxframes\".\n> \n> Introduce DEFINE_EHCI_COMMON_PROPERTIES() to consolidate shared\n> property definitions and reuse them across both EHCISysBusState\n> and EHCIPCIState.\n> \n> This reduces code duplication and keeps property definitions\n> consistent between different EHCI device variants.\n> \n> No functional change.\n> \n> Signed-off-by: Jamin Lin \n> ---\n> hw/usb/hcd-ehci.h | 3 +++\n> hw/usb/hcd-ehci-pci.c | 2 +-\n> hw/usb/hcd-ehci-sysbus.c | 2 +-\n> 3 files changed, 5 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=MoMIt0CE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2Gwj2pW7z1yD5\n\tfor ; Sat, 25 Apr 2026 01:24:51 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGIO0-0006q5-Ll; Fri, 24 Apr 2026 11:24:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wGINz-0006pA-G1\n for qemu-ppc@nongnu.org; Fri, 24 Apr 2026 11:24:07 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wGINx-0000x2-DQ\n for qemu-ppc@nongnu.org; Fri, 24 Apr 2026 11:24:06 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488e1a8ac40so97846345e9.2\n for ; Fri, 24 Apr 2026 08:24:04 -0700 (PDT)","from [192.168.69.210] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc375dsm54738446f8f.14.2026.04.24.08.24.00\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 24 Apr 2026 08:24:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777044243; x=1777649043; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=1AU33mHcOoBqcvM7nu571k0mM8qZPnKiwu43LZRhmtM=;\n b=MoMIt0CEsAPiw2R2cvNbFhAbdVCG4Ao6jPMMYKClH4FkGF5Hl4K8wS0z/v1VI1c1rR\n CrWqOX6jHXjw0IGRFMBU97MlTOKC/ZWGN5FPAkm2LzfmUOAzgANLN5NpN+srJbrnFRmj\n A07fGDIQHyUqY0+2+oNWm0Ms0IfwuuF2U2tMK+BVjhputlkF8O3k92TtPUPSxI4RU02M\n hkTH+A009O32+PTZ0O141cJ+syeqggYy2qm0//2vIMhk+rLXe5vIIs4JHIjit20NXQl4\n 4ksc/6ErVFtrYdRQNhFI925f/K3VsyLchCoWX0pigTAOL3sIjqrxxSvBufkRNUIU1k8C\n Dk2g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777044243; x=1777649043;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=1AU33mHcOoBqcvM7nu571k0mM8qZPnKiwu43LZRhmtM=;\n b=Bs+P7xkLFubVEEdywbaNtqMLp3r792SJ/zGI/OaH181GZ0MeJ4eII21Yrse3ClDuKj\n kBkbSKLdLJVepkE5Efn4+wyAw1atbCi667pi8moa3MulGPEhlq2vU0WNrlz4XXw+05SJ\n fgRLpyLjWWAZ4Lw+G1TEFvHzKXN3P12RlnyFK69XfahMfIH9N2fPCNq6uAvalfvb0qnY\n pImpIVochd51I4F4yCnSzjk2hBZ6f6KVMwHpZ1R7tM7IoVpNsLihx9jYLfU7dcktBTxU\n +O5s8N+hOBcUehRvgzVxukozih3TX6wBLEA8r13BfZzRDpNVtlK/L2388jPyzrpaqUh4\n aVlA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9X4amlQsmWuRkuaGB8bpCPgFI32oE4myuRjfr13d397xK0fKa+822kY3NSlMT9g2c10xi+NwX4Mg==@nongnu.org","X-Gm-Message-State":"AOJu0YzbAvATWyUP0f1pZK3GDMUufT4Mabh3gKJBKGwIk4GVwmUprGSY\n Y2QAge7AZFmZYe9Hoycr3HgqraYJfvqxpcNcw/3AhQc0YxF2cSXhv3zaf3fH87owr/s=","X-Gm-Gg":"AeBDiet9WcrPoFT6MF4KzCnmwdAyEy72iY6dWpTUQ7gI/xV4a52wXKofYNyhxyd7mQX\n CPM9Uwz3DmGVMNw0Kt5ukEnzeAlvx1MqrxxgWFCDGKYRaRndiHHi72SiNPR2lwFyzyPD+U57tlz\n JOzL/8Co/4gUv1dgjF0WaKTE87pe4zyg/mazqESlizH+ylf3eSVYihT4nCxPhxmYl+96RfwjeKm\n dOQ9Jm/U2jE6uztZsNxX4jSTUZaY9vxR+8moLx0BlO5p7Zb/4pmsrnk/SftuhOjtaB79x6Ptu1G\n 2pYYFm2PrcDEd5MNgGkSgrPp2jET6oO7wNtEQiT/YYuu7+ojowq7Rx+CjRn2SFBCJHT/uTbNvnN\n hUvYPpQV26fgP8QvneXXkSsBeDkqWH0zeSnPZkmltE8GathPnPGVecL7HmxC1dmtM+/8DEZ6KAt\n 2f52hKAWJVOxbx7AsJRbq1kFhgAxekVELdFbwm9uQh0JJ6nudNyuy9Bj82R6+iliJCTXkQXvxXf\n ohw","X-Received":"by 2002:a05:600c:3f0c:b0:48a:563c:c8e0 with SMTP id\n 5b1f17b1804b1-48a563cd16bmr222575785e9.1.1777044242862;\n Fri, 24 Apr 2026 08:24:02 -0700 (PDT)","Message-ID":"<8dcdad92-2981-4d57-b605-871c748424c9@linaro.org>","Date":"Fri, 24 Apr 2026 17:23:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 07/18] hw/usb/hcd-ehci: Introduce common properties\n macro for sysbus and pci","Content-Language":"en-US","To":"Jamin Lin ,\n \"peterx@redhat.com\" ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Peter Maydell ,\n Steven Lee , Troy Lee ,\n Kane Chen ,\n Andrew Jeffery , Joel Stanley ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n \"Michael S. Tsirkin\" , Paolo Bonzini ,\n Richard Henderson ,\n Laurent Vivier , Nicholas Piggin ,\n Harsh Prateek Bora ,\n Ilya Leoshkevich , David Hildenbrand ,\n Cornelia Huck , Eric Farman ,\n Matthew Rosato , Halil Pasic ,\n Christian Borntraeger ,\n \"open list:ASPEED BMCs\" ,\n \"open list:All patches CC here\" ,\n \"open list:sPAPR pseries\" ,\n \"open list:S390 TCG CPUs\" ","Cc":"Troy Lee , \"farosas@suse.de\" ,\n \"flwu@google.com\" ,\n \"nabihestefan@google.com\" ","References":"<20260424080508.53992-1-jamin_lin@aspeedtech.com>\n <20260424080508.53992-8-jamin_lin@aspeedtech.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260424080508.53992-8-jamin_lin@aspeedtech.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]