[{"id":3681983,"web_url":"http://patchwork.ozlabs.org/comment/3681983/","msgid":"","list_archive_url":null,"date":"2026-04-24T11:18:31","subject":"Re: [PATCH] ata: pata_parport: switch to dynamic root device","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 4/24/26 19:38, Johan Hovold wrote:\n> Driver core expects devices to be dynamically allocated and will, for\n> example, complain loudly when no release function has been provided.\n> \n> Use root_device_register() to allocate and register the root device\n> instead of open coding using a static device.\n> \n> Note that this also fixes a reference leak in the unlikely event that\n> device_register() ever fails.\n> \n> Signed-off-by: Johan Hovold \n\nLooks OK to me.\n\nReviewed-by: Damien Le Moal \n\nI suspect that this should go in for 7.1, right ?","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mY/8svIx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-ide+bounces-5529-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"mY/8svIx\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g29Sd5G2Jz1yDD\n\tfor ; Fri, 24 Apr 2026 21:18:41 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 687953002D11\n\tfor ; Fri, 24 Apr 2026 11:18:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8D0B83AC0FF;\n\tFri, 24 Apr 2026 11:18:35 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C5639283C;\n\tFri, 24 Apr 2026 11:18:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8BE7DC19425;\n\tFri, 24 Apr 2026 11:18:33 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777029515; cv=none;\n b=m7KcZiVc8cuK7PTRF+utrpDiM2jLsJIn2hybQzBqLhJep4ErHDF5YY3IzzlJtRWmn85dZ6nGQZ0JxBbxneDauXeDejJn7G+dAssYNUlKtoj7uNR57F7sG9VrTIquDoEVopQ/O8pu03d0IglvWVMvN+26728BGyVdezTKL2eBxkg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777029515; c=relaxed/simple;\n\tbh=ehukMGIJo+X8R1y4/oB/v2gPHP/oOer+ZAKLEWbafxE=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=jjTn50bmYsahojBOy9XTt7nDEqL/6q8GGfJYPocxTSpTF8lUQkvdi1pM6pdjkuKVV3ycAuPytDGFcEuHakiGdk21BXM3+W26ohqPi22I0yZMN/Q6WuYG3E3Q6BgdN7qqWB9jPKoWygBfDr1M9gluASyRFRseg/PzZqj/EJ75XQA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=mY/8svIx; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777029514;\n\tbh=ehukMGIJo+X8R1y4/oB/v2gPHP/oOer+ZAKLEWbafxE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=mY/8svIxRYnYgLjppPgVSedCEV/9L3GztasrI0D1skQBqIZQVrv657b8v72zSK8Ka\n\t zgQagdOMIKpi3ISS0xC4fol6H+9/osCll+A8APHURiy+97js20Kk1Xq9JBKMRYAIw/\n\t LgVQAk7YmPq14X6vJOAz2zYh5dR6OnQ3QiFexeNGV1GnSd1BkMDRXC0r/W06p+tVlQ\n\t r46M66HyL4tDIeIY631Pt1vS2+QwYE/y8ScG1hV5Ud/08OpWqAUufh98hVRsmVrg0q\n\t eyHBUXiHkiPkYW5miIrDwxadCrHLT6vxv2VTaG9cblJxRK8Z4X11AZb1vyVQBnomtG\n\t neEhaYTaiylvQ==","Message-ID":"","Date":"Fri, 24 Apr 2026 20:18:31 +0900","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ata: pata_parport: switch to dynamic root device","To":"Johan Hovold , Niklas Cassel ","Cc":"linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20260424103830.2616828-1-johan@kernel.org>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260424103830.2616828-1-johan@kernel.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}}]