[{"id":3681990,"web_url":"http://patchwork.ozlabs.org/comment/3681990/","msgid":"<aetVkymHe-Gy3vBk@x1.local>","list_archive_url":null,"date":"2026-04-24T11:35:47","subject":"Re: [PATCH v5 09/18] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit with migration compatibility","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Apr 24, 2026 at 08:05:21AM +0000, Jamin Lin wrote:\n>  hw/usb/hcd-ehci.h   | 17 +++++++----\n>  hw/core/machine.c   |  5 +++-\n>  hw/usb/hcd-ehci.c   | 72 ++++++++++++++++++++++++++++++++-------------\n>  hw/usb/trace-events | 24 +++++++--------\n>  4 files changed, 78 insertions(+), 40 deletions(-)\n\nI skimmed the migration relevant bits, it looks all fine now, thanks.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iNM93zja;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=TAAmKCsg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g29sC4L3yz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 21:36:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGEpB-0000qi-8Y; Fri, 24 Apr 2026 07:35:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wGEp9-0000qC-NU\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 07:35:55 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peterx@redhat.com>) id 1wGEp8-0006Gy-9W\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 07:35:55 -0400","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-596-L7cZg6NXM-CfpSq8xazS2Q-1; Fri, 24 Apr 2026 07:35:51 -0400","by mail-qk1-f199.google.com with SMTP id\n af79cd13be357-8d5b5d607d1so1519042085a.3\n for <qemu-devel@nongnu.org>; Fri, 24 Apr 2026 04:35:51 -0700 (PDT)","from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8b02ae5eaf1sm186134476d6.30.2026.04.24.04.35.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 24 Apr 2026 04:35:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777030553;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=zYlyk/FU8jAvtu3n9b+43GgXp9tSPuBcVYejaiINyT8=;\n b=iNM93zjaT/hMVidW8cA9UYcL71dfSPZN5GeBC+pld8S0Q/7QyHn64xc3zJ2CU3alEKFf+I\n I9jgnvaVMyylpeKYcs4SNg4IF0l2x5ZEYtJHmUgFiR4opLlYZ8X22QH9nnjyottPjJEISM\n FaJNJNHrgHaOk83et+zkJIuxQAZYOss=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1777030551; x=1777635351; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=zYlyk/FU8jAvtu3n9b+43GgXp9tSPuBcVYejaiINyT8=;\n b=TAAmKCsg+lZ3UBExBnpYg+dFT9MzLz5lWJ+a/RSLflJlKHjnZMHR9Nfo3L1JWsqj6V\n uaV9TjIIiNtvimiTnphDez113DSSsTnBzEOw3gR7hieWZxgfdF4gTrUtN2/3vae1IPT5\n mVcgi/xLmqASlu2uGkV4919wh7YaXuCWZnJSTqaOyolxDfGYlnp29syJWydkI4qD77rp\n 7UTEgyEwgGnI4XXqHDzkqUBOu3UjQCIMTn/HcETKRKu3mcn9LiHIc+7g98pDfFfSKFCt\n 7JZxT+IfRefxRwTCBCeU1gClsF7JmNGJ5LE2351mb39ICie4/ww+ySPPnPk5T/zDTG10\n 3NQA=="],"X-MC-Unique":"L7cZg6NXM-CfpSq8xazS2Q-1","X-Mimecast-MFC-AGG-ID":"L7cZg6NXM-CfpSq8xazS2Q_1777030551","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777030551; x=1777635351;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=zYlyk/FU8jAvtu3n9b+43GgXp9tSPuBcVYejaiINyT8=;\n b=Rn4sDYthW0UeRJ+bxRtkNtCIc1LaDpieButtzzsFWna2s9RDkgCsgtpQeG0/E8Z5sQ\n /+yTDxSiM517OAgZpMQdno0eCmVvkzmu4qwmuxwy5FtZ9AuPfcP8PGRM4Vo7XzQ7amix\n mNMQLyXQ9WE/p3KIwlLf+QLR/FEdLkDXwt5LoBGazQ7NCvD1ql/QFwbf7f5APd2sifjR\n NOkt6W6sqwCqCpkogr1deyTtQ8+G5Uwhldum01ihlDECx0BXs2BVULmSPohslOwunDxC\n 86Xt1PyRhsm+P983U4KvUtXzcEV3RqR+srqN3OWYf1nMysmcI279G4OwWh7isRAjQaO4\n ay7w==","X-Forwarded-Encrypted":"i=1;\n AFNElJ85nb7RqCajAN8nccPvlPBu24MI6NrSMW/IO1HS80AHlV5qaQABHLfVTU2DN8MMt1DhqUxw76kweXJs@nongnu.org","X-Gm-Message-State":"AOJu0Yy6INyzAwhfJKLRoXXHhWnweWEgROlLen4va3PnR7utGoOPpLx3\n tjkPE3WCE8ZT/buV7i77nQqTLhKvEn4tHW4ILTFgBM+Z1f11XB3kKxufa6Fc2t8DyUyFnLwaTRT\n Av0qlXX9Ppa5e1RQx3QlLjZomam02sk1tXtl9kVL8hlNNZ1MvjermyaFG","X-Gm-Gg":"AeBDietjq068YDBK4IaPI3Z/U3xhcYhhzURNtU19+8nrDI/5P1EQPb5aT4JBNkmH3K/\n c9X2+CT2hGobFDoHMTmBYai7qunwl9x8wUeFMLNka/XdE6HxvvZGaIdV9CbB3bnGiW/sUCCtDbp\n UdaAaVD85Jkpx+yvad6yotsYvG6Ji+bS8ZI23i+byANaqgsCy6la0jv++cYhODfcs9vyprVJDAw\n ipNZcnMmEG5IHsMpY/t033/wVGor7Iz7kqynBFA3tJJVyIyocCyNyJfbW2l/bGuvCMTG3OGycRR\n 4qfJNrP9PBs6dEqKr6ukMs03714WMZ7uPtZN4eqSXb9Ll+M5rVedzhXKkoh2NMOwNUryBHgihOR\n QugUBmfoBWXTTAF/ZMid06vX625eQAONKQ/TM4N1XxOODFmKP4y5gvzb/qg==","X-Received":["by 2002:a05:620a:319c:b0:8ee:18e7:9406 with SMTP id\n af79cd13be357-8ee18f6e17amr2519719185a.29.1777030551115;\n Fri, 24 Apr 2026 04:35:51 -0700 (PDT)","by 2002:a05:620a:319c:b0:8ee:18e7:9406 with SMTP id\n af79cd13be357-8ee18f6e17amr2519708985a.29.1777030550418;\n Fri, 24 Apr 2026 04:35:50 -0700 (PDT)"],"Date":"Fri, 24 Apr 2026 07:35:47 -0400","From":"Peter Xu <peterx@redhat.com>","To":"Jamin Lin <jamin_lin@aspeedtech.com>","Cc":"\"philmd@linaro.org\" <philmd@linaro.org>,\n =?utf-8?q?C=C3=A9dric?= Le Goater <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n \"Michael S. Tsirkin\" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Laurent Vivier <laurent@vivier.eu>, Nicholas Piggin <npiggin@gmail.com>,\n Harsh Prateek Bora <harshpb@linux.ibm.com>,\n Halil Pasic <pasic@linux.ibm.com>,\n Christian Borntraeger <borntraeger@linux.ibm.com>,\n Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>,\n Cornelia Huck <cohuck@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>,\n \"open list:sPAPR pseries\" <qemu-ppc@nongnu.org>,\n \"open list:S390 Virtio-ccw\" <qemu-s390x@nongnu.org>,\n Troy Lee <troy_lee@aspeedtech.com>, \"farosas@suse.de\" <farosas@suse.de>,\n \"flwu@google.com\" <flwu@google.com>,\n \"nabihestefan@google.com\" <nabihestefan@google.com>","Subject":"Re: [PATCH v5 09/18] hw/usb/hcd-ehci: Change descriptor addresses to\n 64-bit with migration compatibility","Message-ID":"<aetVkymHe-Gy3vBk@x1.local>","References":"<20260424080508.53992-1-jamin_lin@aspeedtech.com>\n <20260424080508.53992-10-jamin_lin@aspeedtech.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260424080508.53992-10-jamin_lin@aspeedtech.com>","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]