[{"id":3681823,"web_url":"http://patchwork.ozlabs.org/comment/3681823/","msgid":"<6dd8e62b-97e3-4261-92c7-ba3a02ae6397@kernel.org>","date":"2026-04-24T07:34:43","subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","submitter":{"id":92023,"url":"http://patchwork.ozlabs.org/api/people/92023/","name":"David Hildenbrand (Arm)","email":"david@kernel.org"},"content":"On 4/24/26 04:55, Muchun Song wrote:\n> Use a small helper to centralize altmap freeing after verifying that all\n> vmemmap pages were released. This keeps the check consistent between the\n> normal teardown path and the memory hotplug error paths.\n> \n> Suggested-by: David Hildenbrand (Arm) \n> Signed-off-by: Muchun Song \n> ---\n\nThanks!\n\nAcked-by: David Hildenbrand (Arm) \n\nAndrew usually prefers sending non-fixes separately, but he can tell us how he\nprefers it in this case here.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oJIR4PtA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20043-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oJIR4PtA;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=david@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g24VV1kCTz1yDD\n\tfor ; Fri, 24 Apr 2026 17:34:58 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g24VV0yr6z2xwH;\n\tFri, 24 Apr 2026 17:34:58 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g24VN5TJ0z2xfR\n\tfor ; Fri, 24 Apr 2026 17:34:52 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 122FF4449D;\n\tFri, 24 Apr 2026 07:34:50 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EA5D6C19425;\n\tFri, 24 Apr 2026 07:34:44 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777016098;\n\tcv=none;\n b=isvuMlTrwXqkPN/dvhnR2VTaEUD5NUsh0DdNaJJ1fdwbQn3CkzaURUabMiGQ5BMo6et8QIK0YKyuKUZFqwKoKokKwRdGyjrzLiFFsMzotSQ6Ke7EpC1Q5qR/91wFSFnzKqSFgy/Ty+gseatala36bwVpy2M0La8CJ1tQXkgfB01komYPL9VziayaIOjuXV5Pbbh0wr4LIpoTVxyTzyCGb+V/0qDp/Ru+myQ+OSA4co2nY/y2CJX0X1DkA1D0L1yfZR2dw3MEHtz/zA0FNKxugemRQsrj3Ov3ZhxV5cWn6a2k2qex8y5k63K7ge5eifIqUF9FT61tfrb/81quBeyodA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777016098; c=relaxed/relaxed;\n\tbh=dJdObXEbkahQYZLDnmZ+m0VPGz1sbGsEE1rZKCn5pOs=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=l6l0COZs4rW+fCJkbQvH0q2Pt3Pz66AqWzma3b2XDUaZI3P1lBAaNKKmxJdy8PKdHPk972v6JIxx6r6P2UTCxkcjurcOpygpqGklfj7pxjRffIFtiKZzubdqcy6uCXNIOtznWTmLCRdHkzLR6tzO1vhMR9yCr5FWeNnMBTUakzt0cy3Z7H544zx03DQ/h9woWoI82fFpiZjKK+/lCWyCJdqMzgg/Zj39iNRLHX3w//x3zlsr7vYNlnCqocu6flBY7Ahv4ERsjFefatUgkmlGFrvmd4G88XhpmaKto8e3wd03WEHh3Yi2pIzRrJ270FgVP+li9F8UvH1KZKPxOAKa1w==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=oJIR4PtA; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=david@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777016089;\n\tbh=NGQdePNFp6hyo74+R+XMpXlJRT/ZhqyV2fpxjwJ+zcc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=oJIR4PtAGwQD47DsXDZcjQwU406yilrd7N07yZZWCTThqtXZ+E8VMJIMyxVQcIUm/\n\t nxI1l2rdPNJYsCBYEl5PhsfAL6UI+U1KwzjOmLV0jGP7VvBb7vP9H7DViktrFZXg0/\n\t 326lMtT/SxGyrzSPICixgGw6fqKsRZXmeIJokaqS4g8uBHiEg6hCyEjbjDrVLVIEEr\n\t dk/HqmnYYuJvk1ePSWInp4PFWW5LYcxbAvyjfrmyZ+YZsfnc3JfiPJFm4X9LvX80q8\n\t js8PYKWZZsLmL+TQeeoJEfF+/qG/s5BLOteVgmMsxVY16Virerc4SNo7UaousfS8KQ\n\t 26QG2mT0/xlTQ==","Message-ID":"<6dd8e62b-97e3-4261-92c7-ba3a02ae6397@kernel.org>","Date":"Fri, 24 Apr 2026 09:34:43 +0200","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","To":"Muchun Song ,\n Andrew Morton ,\n Muchun Song , Oscar Salvador ,\n Michael Ellerman ,\n Madhavan Srinivasan ","Cc":"Lorenzo Stoakes ,\n \"Liam R . Howlett\" ,\n Vlastimil Babka , Mike Rapoport ,\n Suren Baghdasaryan , Michal Hocko ,\n Nicholas Piggin , Christophe Leroy ,\n aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","References":"<20260424025547.3806072-1-songmuchun@bytedance.com>\n <20260424025547.3806072-8-songmuchun@bytedance.com>","From":"\"David Hildenbrand (Arm)\" ","Content-Language":"en-US","Autocrypt":"addr=david@kernel.org; keydata=\n xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ\n dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL\n QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp\n XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK\n Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9\n PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt\n WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc\n UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv\n jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb\n B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk\n ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik\n AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN\n 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD\n g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz\n ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x\n 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7\n /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4\n jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ\n DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R\n HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC\n 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7\n LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR\n 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt\n VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk\n /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy\n iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ\n 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21\n zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg\n azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY\n FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D\n sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO\n 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e\n EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts\n IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC\n 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV\n Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS\n sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx\n yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9\n 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg\n r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ\n 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ\n CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY\n qIws/H2t","In-Reply-To":"<20260424025547.3806072-8-songmuchun@bytedance.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3681944,"web_url":"http://patchwork.ozlabs.org/comment/3681944/","msgid":"<20260424032039.a43516455eb1ef7c7fd7867e@linux-foundation.org>","date":"2026-04-24T10:20:39","subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/people/107/","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"content":"On Fri, 24 Apr 2026 09:34:43 +0200 \"David Hildenbrand (Arm)\" wrote:\n\n> On 4/24/26 04:55, Muchun Song wrote:\n> > Use a small helper to centralize altmap freeing after verifying that all\n> > vmemmap pages were released. This keeps the check consistent between the\n> > normal teardown path and the memory hotplug error paths.\n> > \n> > Suggested-by: David Hildenbrand (Arm) \n> > Signed-off-by: Muchun Song \n> > ---\n> \n> Thanks!\n> \n> Acked-by: David Hildenbrand (Arm) \n> \n> Andrew usually prefers sending non-fixes separately,\n\nPatches which are destined for the current -rc cycle (and possibly\n-stable) (aka \"hotfixes\") take a different route into mainline from\nregular next-merge-window material. They go into different branches\nand they have different timing.\n\nIf a patchset has a mixture of hotfixes (upstream next week) and\nregular patches (upstream mid June) then I have to pull the series\napart, stage some things into one branch and other things in another\nbranch, rework the cover letter etc etc. Problems with this are:\n\n- what goes upstream doesn't map well onto what was presented on the\n mailing list.\n\n- the hotfixes (upstream next week) may have dependencies on the\n regular patches (upstream mid June). This is backwards.\n\nMuch depends on the urgency of the hotfixes.\n\nIn this case, iirc, the determination is \"not very urgent at all\". So\nthe series is OK as-is - it's all \"upstream mid June\".\n\nThis is still a bit suboptimal because when the -stable maintainers get\nonto backporting the cc:stable patches (after mid June), they may\nencounter merge/build/runtime issues due to the absence of the\nnon-hotfix patches from this series.\n\nSo generally, it is best for authors to have a think about these\ntiming/priority issues and to present the patches in a suitable fashion\n- hotfixes/-stable patches in one series then non-hotfixes in a second,\nlater series. This way their presentation matches what goes upstream\nand we reduce the possibility of problems when the -stable maintainers\nget onto backporting.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org\n header.a=rsa-sha256 header.s=korg header.b=KBJaGO89;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20060-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-foundation.org","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org\n header.a=rsa-sha256 header.s=korg header.b=KBJaGO89;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=akpm@linux-foundation.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g289q2bXQz1yD5\n\tfor ; Fri, 24 Apr 2026 20:20:47 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g289n62Q8z2yYs;\n\tFri, 24 Apr 2026 20:20:45 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g289m5lJTz2xnl\n\tfor ; Fri, 24 Apr 2026 20:20:43 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 366686001A;\n\tFri, 24 Apr 2026 10:20:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 53ADBC19425;\n\tFri, 24 Apr 2026 10:20:40 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777026045;\n\tcv=none;\n b=eF+00553HQ+K/Fuj0FNSTb0S74mtrwKVkefDls0J8Myb4+v6k87ZpPN0p0gi5OkzyIn1RZzCLqty/xnGj98fuHuTB6bTZtxaJwZZu7iR/Etitnh7L/5YDKN3UQOykKN3mnzFaAPUIXtQ9IERjJiZARwdEZ09XIt32FfACa2XAJg3I3QqpBq/BUCHf18zUAzDI/qfaw751iiARmJaejMN+hN2e3vt0DDZwB9VXx+Uzk3mpcuojNCEL1VKigIwjtF2ksUyWrgngmld+drZRpa0VvfaRfuGien+45U4om8iB7bplgW52VTNmfMXxxNkOSYcebBRV1tDloMPuQ5vjv6CUg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777026045; c=relaxed/relaxed;\n\tbh=v7HsCofWu1Fj4KM5mfTpvHEQ8XWMsqEKDLZEW1mgiAw=;\n\th=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:\n\t Mime-Version:Content-Type;\n b=g6RJkO+48ceCSitWNlDXTZIzw8K9AQVWUUiDTgfYDZccpwvKIVrzNYev4z2PxVx1+d/WCSwoxDX1qDW2l8ZlQ9gfeP6uEipelXupIUgskPLw2SsHZGCcrivgDHSgQMTnhAAJGydIczPAicc4yxh4+5UkaicEnV9FgXOc/AvjgErEKJ554RJWa+OqhDycAaAc8IITET0EC+0YCyIwOhCdlEE14ZenG5xY1c47MAxU9jjGj2GTUHUwPrVDg6jWX0RAxSXNQRkD2j32qeMESM5ksctfAz8kythlfFdWXzEXYyO74lh8TbitmPH0jMPqW4uGeHcrN8U68HUB1q7M7/ULRw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-foundation.org;\n dkim=pass (1024-bit key;\n unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org\n header.a=rsa-sha256 header.s=korg header.b=KBJaGO89; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=akpm@linux-foundation.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux-foundation.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;\n\ts=korg; t=1777026040;\n\tbh=0RadErNyVmV3gi8KLyDo2YKUadazcNECWm6ket0mhpw=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n\tb=KBJaGO89V8KafZomOFN7DV16OlCVvzwC7VKvSQQilKTbrOJuibl2b3+ADa2f1ziq4\n\t RmfX6P7YFFkox0Lnq6RqR/GLRf087p374Y7C+2E8ZHRH3MoEzmu10z+fTHqYsBl9xK\n\t 4834ULDinadjU00M0zGkABFZBA64qCd2z1++Z5YM=","Date":"Fri, 24 Apr 2026 03:20:39 -0700","From":"Andrew Morton ","To":"\"David Hildenbrand (Arm)\" ","Cc":"Muchun Song , Muchun Song\n , Oscar Salvador , Michael\n Ellerman , Madhavan Srinivasan ,\n Lorenzo Stoakes , \"Liam R . Howlett\"\n , Vlastimil Babka , Mike\n Rapoport , Suren Baghdasaryan , Michal\n Hocko , Nicholas Piggin , Christophe\n Leroy , aneesh.kumar@linux.ibm.com,\n joao.m.martins@oracle.com, linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","Message-Id":"<20260424032039.a43516455eb1ef7c7fd7867e@linux-foundation.org>","In-Reply-To":"<6dd8e62b-97e3-4261-92c7-ba3a02ae6397@kernel.org>","References":"<20260424025547.3806072-1-songmuchun@bytedance.com>\n\t<20260424025547.3806072-8-songmuchun@bytedance.com>\n\t<6dd8e62b-97e3-4261-92c7-ba3a02ae6397@kernel.org>","X-Mailer":"Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3682002,"web_url":"http://patchwork.ozlabs.org/comment/3682002/","msgid":"<8C537157-7EE6-4542-A922-6D34C3A88F47@linux.dev>","date":"2026-04-24T11:58:32","subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","submitter":{"id":84878,"url":"http://patchwork.ozlabs.org/api/people/84878/","name":"Muchun Song","email":"muchun.song@linux.dev"},"content":"> On Apr 24, 2026, at 18:20, Andrew Morton wrote:\n> \n> On Fri, 24 Apr 2026 09:34:43 +0200 \"David Hildenbrand (Arm)\" wrote:\n> \n>> On 4/24/26 04:55, Muchun Song wrote:\n>>> Use a small helper to centralize altmap freeing after verifying that all\n>>> vmemmap pages were released. This keeps the check consistent between the\n>>> normal teardown path and the memory hotplug error paths.\n>>> \n>>> Suggested-by: David Hildenbrand (Arm) \n>>> Signed-off-by: Muchun Song \n>>> ---\n>> \n>> Thanks!\n>> \n>> Acked-by: David Hildenbrand (Arm) \n>> \n>> Andrew usually prefers sending non-fixes separately,\n> \n> Patches which are destined for the current -rc cycle (and possibly\n> -stable) (aka \"hotfixes\") take a different route into mainline from\n> regular next-merge-window material. They go into different branches\n> and they have different timing.\n> \n> If a patchset has a mixture of hotfixes (upstream next week) and\n> regular patches (upstream mid June) then I have to pull the series\n> apart, stage some things into one branch and other things in another\n> branch, rework the cover letter etc etc. Problems with this are:\n> \n> - what goes upstream doesn't map well onto what was presented on the\n> mailing list.\n> \n> - the hotfixes (upstream next week) may have dependencies on the\n> regular patches (upstream mid June). This is backwards.\n> \n> Much depends on the urgency of the hotfixes.\n> \n> In this case, iirc, the determination is \"not very urgent at all\". So\n> the series is OK as-is - it's all \"upstream mid June\".\n> \n> This is still a bit suboptimal because when the -stable maintainers get\n> onto backporting the cc:stable patches (after mid June), they may\n> encounter merge/build/runtime issues due to the absence of the\n> non-hotfix patches from this series.\n> \n> So generally, it is best for authors to have a think about these\n> timing/priority issues and to present the patches in a suitable fashion\n> - hotfixes/-stable patches in one series then non-hotfixes in a second,\n> later series. This way their presentation matches what goes upstream\n> and we reduce the possibility of problems when the -stable maintainers\n> get onto backporting.\n\nThanks for the clarification! Since I'm heading into the next revision\nanyway, I’ll go ahead and split the series.\n\nI'll drop the non-fix patches for now and focus this series on the\nbugfixes to ensure a smooth merge. The regular patches will follow\nin a separate submission later.\n\nThanks,\nMuchun.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=Pp+Vu8IM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20079-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=91.218.175.185","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=Pp+Vu8IM;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.dev\n (client-ip=91.218.175.185; helo=out-185.mta0.migadu.com;\n envelope-from=muchun.song@linux.dev; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2BNF2bKHz1xvV\n\tfor ; Fri, 24 Apr 2026 21:59:57 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4g2BNF06Tyz2ybQ;\n\tFri, 24 Apr 2026 21:59:57 +1000 (AEST)","from out-185.mta0.migadu.com (out-185.mta0.migadu.com\n [91.218.175.185])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4g2BN91VhMz2yTQ\n\tfor ; Fri, 24 Apr 2026 21:59:51 +1000 (AEST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1777031996;\n\tcv=none;\n b=XInv8QGtwHVhkpqNo7zP2jh9R72ewK7CI7SJBm2UXxV8PqLLVEbjOc3M4STvQuAFTJQQ9t7eIlLxZIj+fBJxkNqKBAVffE1DP33jsBSHmE1TG2lc9ClTOtX2NhMLvHFnK6n3DIUbuQLvVAnznS/JjWYTIzZ/oClOX1o3SKoxX9C6aurV3+sQqd8T1mg1kP3UCNCoG3y7JhR2VKCPbdhuwOsTd38pD27q6jukuPooYy8O9tjlCED0dUAL3bwE5L6YDIggmTQlw9rGxuqPB62uIT/lb+t3ZVpt8awdviCgUoxf/lkBV1C5u7LMA1RqlQONo3myiWeC3+jS2ri51xTkmg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1777031996; c=relaxed/relaxed;\n\tbh=IHQYPzAV990Uhew6eBIq9GNsVsyr4/52nVfMb6QSTqQ=;\n\th=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:\n\t Message-Id:References:To;\n b=I4H+1unaXBe7DS8+8hHjW6XUfPBSFMElVTNiRYgH9L5tN3ZQXeHXKhfYHYjYCJkrncWs2b4PCw0I2NZ58gk+TTBgy51SPggijYWRKnGbVOrPqfyJ7qz5OIMgmff74GOAjJDudiM7Y+elWY6OWXzV//LlZymK5cM5Eozw37gWZ4jjT4+ndmBsVdf/M3lF7e1npqBwpCIbYigq7R3rjRV4jnIZ47R1Wr+exXGOhpjXwQtQuZ8vvsLqLjT0+aaPM83ta4rdt6O7Spp87qVrBMZGYsGxBmjmoNw0xxYQqAnFY8qK47cCT720GlaAi3+nY/kGsXwdDVeoo8MvDTfW6vmOuA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key;\n unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256\n header.s=key1 header.b=Pp+Vu8IM; dkim-atps=neutral;\n spf=pass (client-ip=91.218.175.185; helo=out-185.mta0.migadu.com;\n envelope-from=muchun.song@linux.dev;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.dev","Content-Type":"text/plain;\n\tcharset=utf-8","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;\n\tt=1777031967;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=IHQYPzAV990Uhew6eBIq9GNsVsyr4/52nVfMb6QSTqQ=;\n\tb=Pp+Vu8IMlRT1HXTy/rykslM1Plape2KDpGMSDX3NKXZ68euahDQGlPY8zAIrMbOEcYapEb\n\tZGM7yA3d+S/yRj2l5FezOlNTDHGJWWQLHweIq05WAmXtCWycRusfEBhThWETI5BGIIT0th\n\t3cJOz5zV5HFizSDxO8DsXIHMwEIoprI=","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","Mime-Version":"1.0 (Mac OS X Mail 16.0 \\(3864.500.181\\))","Subject":"Re: [PATCH v6 7/7] mm/memory_hotplug: Factor out altmap freeing\n checks","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"Muchun Song ","In-Reply-To":"<20260424032039.a43516455eb1ef7c7fd7867e@linux-foundation.org>","Date":"Fri, 24 Apr 2026 19:58:32 +0800","Cc":"\"David Hildenbrand (Arm)\" ,\n Muchun Song ,\n Oscar Salvador ,\n Michael Ellerman ,\n Madhavan Srinivasan ,\n Lorenzo Stoakes ,\n \"Liam R . Howlett\" ,\n Vlastimil Babka ,\n Mike Rapoport ,\n Suren Baghdasaryan ,\n Michal Hocko ,\n Nicholas Piggin ,\n Christophe Leroy ,\n aneesh.kumar@linux.ibm.com,\n joao.m.martins@oracle.com,\n linux-mm@kvack.org,\n linuxppc-dev@lists.ozlabs.org,\n linux-kernel@vger.kernel.org","Content-Transfer-Encoding":"quoted-printable","Message-Id":"<8C537157-7EE6-4542-A922-6D34C3A88F47@linux.dev>","References":"<20260424025547.3806072-1-songmuchun@bytedance.com>\n <20260424025547.3806072-8-songmuchun@bytedance.com>\n <6dd8e62b-97e3-4261-92c7-ba3a02ae6397@kernel.org>\n <20260424032039.a43516455eb1ef7c7fd7867e@linux-foundation.org>","To":"Andrew Morton ","X-Migadu-Flow":"FLOW_OUT","X-Spam-Status":"No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]