[{"id":3681835,"web_url":"http://patchwork.ozlabs.org/comment/3681835/","msgid":"","list_archive_url":null,"date":"2026-04-24T07:49:25","subject":"Re: [to-be-committed] Do not use DEFAULT_CFLAGS in ieee.exp\n [PR125003]","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Thu, Apr 23, 2026 at 7:22 PM Andrew Pinski\n wrote:\n>\n> From: feedable \n>\n> ieee.exp tries to inherit flags from DEFAULT_CFLAGS, which is sometimes set and sometimes unset\n> When it is set, it is set to \"-ansi -pedantic-errors\", which causes spurious failures.\n>\n> Introduce a new variable, DEFAULT_IEEE_CFLAGS, which is independent of\n> DEFAULT_CFLAGS, but which boards may still override if needed.\n> It includes the default of \"-w -fno-inline\" as it was in the old style testcases.\n>\n> Then the target specific flags should not be stored out in DEFAULT_IEEE_CFLAGS but they\n> are needed for the default flags passed to the compiler. They can't be stored out to\n> DEFAULT_IEEE_CFLAGS as for x86, depending on if -m32 or -m64 is first, -ffloat-store might\n> be included for -m64 or not. We don't want it to be there for -m64.\n>\n> This is what I am going to push after testing it. The changes were on top of feedable's current\n> patch as I reviewed them. It was just easier to fix up feedable's current patch rather than go through another review cycle.\n>\n> PR testsuite/125003\n>\n> gcc/testsuite/ChangeLog:\n>\n> * gcc.c-torture/execute/ieee/ieee.exp: Rewrite the default flags\n> and set DEFAULT_IEEE_CFLAGS if not already set.\n>\n> Co-authored-by: Andrew Pinski \n> ---\n> .../gcc.c-torture/execute/ieee/ieee.exp | 31 ++++++++++---------\n> 1 file changed, 16 insertions(+), 15 deletions(-)\n>\n> diff --git a/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp b/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp\n> index 2f2d7c432f2..451693a6023 100644\n> --- a/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp\n> +++ b/gcc/testsuite/gcc.c-torture/execute/ieee/ieee.exp\n> @@ -33,41 +33,42 @@ if { [istarget \"vax-*-*\"] || [ istarget \"powerpc-*-*spe\"] || [istarget \"pdp11-*-\n>\n>\n> # If a testcase doesn't have special options, use these.\n> -global DEFAULT_CFLAGS\n> -set MY_CFLAGS \"\"\n> -if [info exists DEFAULT_CFLAGS] then {\n> - set MY_CFLAGS $DEFAULT_CFLAGS\n> +global DEFAULT_IEEE_CFLAGS\n> +if ![info exists DEFAULT_IEEE_CFLAGS] then {\n> + set DEFAULT_IEEE_CFLAGS \"-w -fno-inline\"\n> }\n>\n> -lappend MY_CFLAGS \"-w\"\n> -lappend MY_CFLAGS \"-fno-inline\"\n> +set IEEE_CFLAGS $DEFAULT_IEEE_CFLAGS\n> +\n> +# The following flags are target-specific, a board may want to override these\n\nPushed with one minor change to the comment above. Removed the \"a\nboard may want to override these\" part.\n\nThanks,\nAndrea\n\n>\n> # We must use -ffloat-store/-mieee to ensure that excess precision on some\n> # machines does not cause problems\n> if { ([istarget \"i?86-*-*\"] || [istarget \"x86_64-*-*\"])\n> - && [check_effective_target_ia32] } then {\n> - lappend MY_CFLAGS -ffloat-store\n> + && [check_effective_target_ia32] } then {\n> + lappend IEEE_CFLAGS -ffloat-store\n> }\n> if [istarget \"m68k-*-*\"] then {\n> - lappend MY_CFLAGS -ffloat-store\n> + lappend IEEE_CFLAGS -ffloat-store\n> }\n> -if { [istarget \"alpha*-*-*\"]\n> - || [istarget \"sh*-*-*\"] } then {\n> - lappend MY_CFLAGS -mieee\n> +if { [istarget \"alpha*-*-*\"] || [istarget \"sh*-*-*\"] } then {\n> + lappend IEEE_CFLAGS -mieee\n> }\n> if [istarget rx-*-*] then {\n> - lappend MY_CFLAGS -mnofpu\n> + lappend IEEE_CFLAGS -mnofpu\n> }\n>\n> +# These flags are not target-specific, always set them\n> +\n> if { ![check_effective_target_signal] } {\n> - lappend MY_CFLAGS -DSIGNAL_SUPPRESS\n> + lappend IEEE_CFLAGS -DSIGNAL_SUPPRESS\n> }\n>\n>\n> # main test loop\n> set saved-dg-do-what-default ${dg-do-what-default}\n> set dg-do-what-default \"run\"\n> -gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\\[cS\\]]] \"\" $MY_CFLAGS\n> +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.\\[cS\\]]] \"\" $IEEE_CFLAGS\n> set dg-do-what-default ${saved-dg-do-what-default}\n>\n> # All done.\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=MCzKjTr+;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=OYYBwvJP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=MCzKjTr+;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=OYYBwvJP","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g24rS2rZMz1yJF\n\tfor ; Fri, 24 Apr 2026 17:50:31 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id E9E274BB24E7\n\tfor ; Fri, 24 Apr 2026 07:50:28 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id 5FC7F4B99F77\n for ; Fri, 24 Apr 2026 07:49:40 +0000 (GMT)","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63O2dUUd1532385\n for ; Fri, 24 Apr 2026 07:49:39 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqr26jva0-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Fri, 24 Apr 2026 07:49:39 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2da19227bc1so15303054eec.1\n for ; Fri, 24 Apr 2026 00:49:39 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org E9E274BB24E7","OpenDKIM Filter v2.11.0 sourceware.org 5FC7F4B99F77"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 5FC7F4B99F77","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 5FC7F4B99F77","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777016980; cv=pass;\n b=e0Vv59iL5Wa3AnfeCd1KJwyr4qy3p2wnkCsKIPyTLba5ATTusS+UIhLqdtv6eSuGelz8EtH6gLbVZsTzPKcpUfy05r1jR6w4BHkvR1WrmryxzyrjaF+TKwe2OYlCOVEwhjUUNOs6HyL7pxqQboos9a25h+asFI79qsJgUaPgZWI=","i=1; a=rsa-sha256; t=1777016978; cv=none;\n d=google.com; s=arc-20240605;\n b=Mq5+ClUc+qxmA4Xa3GdhoGpUaC7CnBSRJypL1V+UnzcAkBCzjPAs4kQyNRJ1Q7E2uW\n yDQPRc5AO8coraZ8eAqUN94Tq46UHXeJzhrlku4xBMaFZ+4SEhW1P7lAB82Gad0xWAEl\n gc/BomtPFh2bKz+pYqR8YnkptDzIRLEC+AUizZfHhY1G7DWcpCBHABrc/ha7hFJRWtGy\n P7LJw9yEVQi6uAMu7lH9YrZ72JC30AEjGCSlB5greA1X+ueU+Yv3C6D9ZDkDFoyfEp2n\n XRESNKrq6esEJF44IvlOKvN/oK6q+l3i+q5CfdIJd11hyRDhyxJf70bwbHUhOOrmAFnq\n Zs9Q=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777016980; c=relaxed/simple;\n bh=BXcWtxFpK8iKBbja+WcVvTMp1WD6tRTEbgoRbN9VLSM=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=GqWj4G1hTswrXh0GM+leou0nOPL/aapFnOnLHSqbuCWg1uagKJBG5JhWeSPg1gQZ7vLwmGkEOCDBUqao9P+o8dtiMeXP3baqoXA8MGoLVNIQikhMsR1RVbnZ7FLHf9dYNrP0St7cLmOXNIKA65afqvYXBhupWGItwlJs4ns3pgI=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=lrrWg5xLSuvcP2CLDVkZK3Aq9kTGGJwdynu8gAhrDaw=;\n fh=8r0aJ6F4A2qLNZFQwhFYvmGCZRO2ij+TtB1tTae3Q3c=;\n b=PIaxEvaFi3+gWGTXv/FLXlrND8nSrwXcfqiZ16yrAs1V7SmDsyuMRJZFXw8W/fvkEz\n 6A3SBTJ0z7hLkiXAT1AP0bvPMwOMN4CVr4EA0qVBMjAMNIPW6Bwrd7WS0ATBmeyc8B5u\n UsuInJg8hUBpCEC9QpATt5s4PT2kuuPJnGjGHvDOcqb3roxZ/ItpINMhwMwta1rMq47Z\n UMvn10nYoGYhy6UHKZI+IIZYOu2GsO8qwY6iLIdjo+oxhIWqA1+HnGflsMpC2PtCDfQr\n 6vUrugRz1D4fCNrct+wx8mnd66tRrjs/lqu/43CA5U4r01XmeOvD45wVVWYR+QYfRbYR\n SltA==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n lrrWg5xLSuvcP2CLDVkZK3Aq9kTGGJwdynu8gAhrDaw=; b=MCzKjTr+gr1e0JkQ\n JeO1QSLXfwBlE9ockbu0pwpLFCJrzykJcZOx4k1a3uZrHsMhMXbpGPX6ravMWVbm\n /ga+SPhZX10AsOZ91zwJ+EhiTjBYmlbESfNfRzJeDbejwiN3l0aLdBGpywfFqB8z\n 2DmgITXEsaIDombErEh1QZd4XlWH//Bqmyuk7+wjl2eWE5eUnRGpCnQw73DH0JOe\n iD/WXfVqeZ/krs+AJ/ew9K5du1qBo8jRoYuxnVrvTLVgjCB4swjX6OOwbB5E38DT\n 8ZccNswSX9QVj3kqYjS+I6ug0g+b2f5L6F64SxLcrj56OaKVM3ykd4pt+ZxTDcPR\n 0o4xWg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777016978; x=1777621778; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=lrrWg5xLSuvcP2CLDVkZK3Aq9kTGGJwdynu8gAhrDaw=;\n b=OYYBwvJP2ZxQwnavib5B18YrsRasHF4ygRLnpPaW5Xpo1yFoEF04vO1995fymQsjVY\n /wblh5wBIsN7/VP2rCYMqwLQ/P/YfWdrCr1+qwi9gCdc+7/eyamEFQJiggJM8YdZDgHF\n qL6e1A2KdbwYf0XI9F+RvEYuLNMnsm2p1OF3Z9Z/enzO4HHXHfi0sQZL8aHlOjcUDNmU\n P+dqP7Djw0b0+E9Av+UHSCUezph2aNW72qRK0Dpbbi2VlytNEu/pLlaOOyoxhljWI2uU\n /cySvvt4q/o+is4+K/ERvx+No1yiNxOn5tU7lv07QKEri+Fc5p6IBHLLBN4TmLL5Hrzw\n XmGQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777016978; x=1777621778;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=lrrWg5xLSuvcP2CLDVkZK3Aq9kTGGJwdynu8gAhrDaw=;\n b=p2RlQ0zZt2toUcVYn/XdiJdAkN4cbkIgy/C3M3Lu1PyynNwG3YsUFr8YlbbDw2yTcN\n iCJHsa/GDG4JwntH4SXua9luoCFBIQqWaFdzixlPprepAcSuvCNRIWG3czjOUhc/qGD/\n gbfDAsPmGnI9IjfJ4NOMkqGroo56QJ3vt51Gaf2g8Ge6zlMaE9rsmNOvfGHISrrCAzKl\n etQznAubzYR7wGHqZ4tRWw6LZlTr/yKyO7UJkInRrhQoizhGUaXfp7Z79qbzFEY4kThW\n tjlAURW5OvuhqN4YT9aEGKd8zj4Jvkz60e0mqVHM/XW3qiJPS0YqxdMe2BfQqOqEVHQk\n D27g==","X-Gm-Message-State":"AOJu0YzSpzk1jwQ5mPFJhIyaijUEiSLy1GoBA6ir1jg4Qto08f3jxM31\n M6qjJg5MLtcOp/t0PVYCEBXf+my1/ThIJ1J5P1yP7M6Zxtiezgyd/kVzTgnjVsmqSOTLHaMcw9k\n lijyaSD3KH1SfR2fBs0rIjZcZhvqR/EyhFoetFWRw8TQu3K8P4qff/rcbf92g2Qio0q392jl+aA\n t2WgrGp7oBeFBZtQ9AxM8YRys7tqMte3fPGVXoGKNCnC+5TA==","X-Gm-Gg":"AeBDietsuCWS42eFIM9BETkESrsG+Vv1wA9UnGK9txeQKn3YR34H6X8TvLuP7evlbE7\n JAI4PU7F4cUjaNwQLwr+Ga1/C+p+uBBmKm95xWlZWqc9NWVZ+4WS+CSjps2AE2x0BFPpLotutMK\n ITLuKx7GuAuPtmyQAylLQHg4jV5EjgRkeVf09l5UHrDk+ZECaeu2TL/voznXyv7hVfMOblsQP6Q\n YVUVKxUFMfrrQ==","X-Received":["by 2002:a05:7300:a49a:b0:2c5:b23e:48a6 with SMTP id\n 5a478bee46e88-2e478e0c684mr17176782eec.23.1777016977818;\n Fri, 24 Apr 2026 00:49:37 -0700 (PDT)","by 2002:a05:7300:a49a:b0:2c5:b23e:48a6 with SMTP id\n 5a478bee46e88-2e478e0c684mr17176773eec.23.1777016977218; Fri, 24 Apr 2026\n 00:49:37 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260424022231.2644077-1-andrew.pinski@oss.qualcomm.com>","In-Reply-To":"<20260424022231.2644077-1-andrew.pinski@oss.qualcomm.com>","From":"Andrew Pinski ","Date":"Fri, 24 Apr 2026 00:49:25 -0700","X-Gm-Features":"AQROBzAxp2U3T1rWFwQGT5uh_dt11-TOXZEB25oawJaqwcLdhM-9E376fvMcHfk","Message-ID":"\n ","Subject":"Re: [to-be-committed] Do not use DEFAULT_CFLAGS in ieee.exp\n [PR125003]","To":"gcc-patches@gcc.gnu.org","Cc":"feedable ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-ORIG-GUID":"o_l6nncSpnPAHIgN4F6sQX0B34-_A5PE","X-Authority-Analysis":"v=2.4 cv=QLhYgALL c=1 sm=1 tr=0 ts=69eb2093 cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8\n a=t45UYpUmqEx5rBYxN8kA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22","X-Proofpoint-GUID":"o_l6nncSpnPAHIgN4F6sQX0B34-_A5PE","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDI0MDA3MCBTYWx0ZWRfXzLL5YVjANPOF\n 3BrLGe6uUFqs/briRvTlqucTCm33sab+1bwnSUwnd2mID9fz6phUFbpP2oas+6te8vpoiiSrsPC\n kN7ufJ9NScjl2Wh8+E3Aw5Br2nLIETw64A7CTykoXK8hfSMXm229fesVsDVEw9eHQ6IdgC7pTSq\n 9fZTX6YhNUpjyzR/xkd6kC9BjLFn/6YoOPa57hf+sFmJypFVyCXOLGMUAHl3e5pD51lUFr6EaZZ\n d1JBa1wBT8NNgQtO849lCBkU5RCt0qbMwtc2Bv4DFrrMpaOHKyh1LD6Nggibu5UE3u7Ho70Z0Mq\n 8TzYa5b3ukNvRasN4naxBXW8bxuUe0WaBPsAIDggK9CZrcmGi7ljkA6GyzKqN22lovc80+hBFjC\n egSBZuCFwImhJhMamxzHYc/bxKLVP/evI1+RzI9K0RYl1EKyA7cz2JkFFWgyKC+zTsLQPobAInV\n S3H3h4Xn+xBGiGRYmWw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0\n lowpriorityscore=0 malwarescore=0 adultscore=0 clxscore=1015\n priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604240070","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]