[{"id":3681841,"web_url":"http://patchwork.ozlabs.org/comment/3681841/","msgid":"","list_archive_url":null,"date":"2026-04-24T07:54:40","subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","submitter":{"id":92191,"url":"http://patchwork.ozlabs.org/api/people/92191/","name":"Bartosz Golaszewski","email":"brgl@kernel.org"},"content":"On Fri, Apr 24, 2026 at 12:32 AM Maxwell Doose wrote:\n>\n> Remove the *pdev intermediate variable and directly dereference the\n> pointer. While at it, replace sprintf() calls with sysfs_emit() to\n> harden the driver.\n>\n> Signed-off-by: Maxwell Doose \n> ---\n> drivers/gpio/gpio-sim.c | 8 +++-----\n> 1 file changed, 3 insertions(+), 5 deletions(-)\n>\n> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c\n> index 13b87c8e6d0c..3c230f94eea2 100644\n> --- a/drivers/gpio/gpio-sim.c\n> +++ b/drivers/gpio/gpio-sim.c\n> @@ -691,15 +691,13 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,\n> char *page)\n> {\n> struct gpio_sim_device *dev = to_gpio_sim_device(item);\n> - struct platform_device *pdev;\n>\n> guard(mutex)(&dev->lock);\n>\n> - pdev = dev->probe_data.pdev;\n> - if (pdev)\n> - return sprintf(page, \"%s\\n\", dev_name(&pdev->dev));\n> + if (dev->probe_data.pdev)\n> + return sysfs_emit(page, \"%s\\n\", dev_name(&dev->probe_data.pdev->dev));\n\nDo you believe the code looks better with more layered dereferences?\n\n>\n> - return sprintf(page, \"gpio-sim.%d\\n\", dev->id);\n> + return sysfs_emit(page, \"gpio-sim.%d\\n\", dev->id);\n\nsprintf() is safe here as we cannot possibly exceed PAGE_SIZE with\nthis format but if you really want to do this, than please send a\nseparate patch converting all configfs show callbacks in the driver.\n\nBart\n\n> }\n>\n> CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name);\n> --\n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kTC+iHVI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35460-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"kTC+iHVI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g24yT6Jmmz1xvV\n\tfor ; Fri, 24 Apr 2026 17:55:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D95C230214C4\n\tfor ; Fri, 24 Apr 2026 07:54:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1807C351C2A;\n\tFri, 24 Apr 2026 07:54:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8260336D9EA\n\tfor ; Fri, 24 Apr 2026 07:54:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D476BC2BCB4\n\tfor ; Fri, 24 Apr 2026 07:54:55 +0000 (UTC)","by mail-lf1-f51.google.com with SMTP id\n 2adb3069b0e04-5a402dea4a5so8058530e87.2\n for ;\n Fri, 24 Apr 2026 00:54:55 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777017296; cv=none;\n b=rpxDdryCc5lOeA/86I75/Grt7TL/Bxjes5jEmdefvWoehmPtxUaw6lDsrPaXhm64A1AhTV3BKVw4wmIs8C/G0CtzhVo1sqtASZIkDX/a9BCETjeBSGrILG0UIZvLCgXMV8ZP6q4CZzS12SBZ4EEgQRMUa5SQJGQpZ0nvTqenQM0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777017296; c=relaxed/simple;\n\tbh=g9Ia9AQkqIb/ztY4s7TTlNjI7b7+nksnVzYqlknRFTk=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=ruQnxtG0Eco5tW7QUDwCK2CDSlWhg5h9cMEvW4WKW8QzU77xDDE6sUYy7w9Lmt6TBQ7qL2G+EQIjcOnIkSCbL8+WIuXdgTDTvyvf70QRpxvNNI5n3NA5S0aOZDVlgMAu8hC/sZ7l3NnXsJO+KQqXgDJwPASRQWZ7QaiIPH7AXuw=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=kTC+iHVI; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777017295;\n\tbh=g9Ia9AQkqIb/ztY4s7TTlNjI7b7+nksnVzYqlknRFTk=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=kTC+iHVIpacsO/tvVGoMyteE961ak0UowwF5iSa0kf/Qepp6vtX9Nw15Xr2Gu6dgD\n\t VJDFUmbapXsW0g8nYx26dNBJ8qEUuALuUqA0EaLn6tl5xjhUzvtQbyPOtcvjrXeIRq\n\t akWb+IXFxrKc5AYx3VTUTJ4qPX3YZoiFcUY2ZxVOWt9sznOKDBNuVXad72T0fShuND\n\t +8NZ9rPyqUlc8uJa2pUSzH5N5vGVikmb55n78X2ElRZvd+8bK3y1I3xxNRO40MQGUX\n\t Ej/3qw2EmGExesJC8S6CuZaM7aYm27hcSLKPrXV4D9oWBBhE5+dmF3CygIhJ9UD+yu\n\t A1oC845P9f7Jg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8qqizYZkAt2k9Xalsbgkj0uN4LaTISuFy4JhL7eKBP7t0Av2iEC+YOh4epkburvg8pbN5Uvxzvd3jU@vger.kernel.org","X-Gm-Message-State":"AOJu0YwMO8+91UNx3dLWQjtB6dZauOH+yfsUVEYcmXVQqOiRjz698UWU\n\tRG4AgpeSt48mUQp+A9tt737m2GU2sfDL5pBV/9iqm+kwBOelUTZ6onqTvD3ZikgU5oIDLmsLFk0\n\tHdKbVX2p79Vtxs5rnV6HfFMYesMlttBBuKV1eX6u/tw==","X-Received":"by 2002:a05:6512:4142:b0:5a4:e6:8fce with SMTP id\n 2adb3069b0e04-5a4172f609dmr7740788e87.38.1777017294511; Fri, 24 Apr 2026\n 00:54:54 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260423223230.47001-1-m32285159@gmail.com>","In-Reply-To":"<20260423223230.47001-1-m32285159@gmail.com>","From":"Bartosz Golaszewski ","Date":"Fri, 24 Apr 2026 09:54:40 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzCvZ_XsVQjiGQ0HPe6ZzmVFtHKCeYp2kCq62XsGvjmnytQbHoVSi9Ua7Go","Message-ID":"\n ","Subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","To":"Maxwell Doose ","Cc":"linusw@kernel.org, linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3682025,"web_url":"http://patchwork.ozlabs.org/comment/3682025/","msgid":"","list_archive_url":null,"date":"2026-04-24T13:05:18","subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","submitter":{"id":93193,"url":"http://patchwork.ozlabs.org/api/people/93193/","name":"Maxwell Doose","email":"m32285159@gmail.com"},"content":"On Fri, Apr 24, 2026 at 2:54 AM Bartosz Golaszewski wrote:\n>\n> Do you believe the code looks better with more layered dereferences?\n>\n\nI think some people might value the more explicit dereferencing, and with this\nwe also won't need to handle the overhead of assigning another pointer, but if\nyou want this removed thats fine by me.\n\n> sprintf() is safe here as we cannot possibly exceed PAGE_SIZE with\n> this format but if you really want to do this, than please send a\n> separate patch converting all configfs show callbacks in the driver.\n\nI can do that, but I'd prefer to separate the functional changes with\nthis one, so\nexpect another patch that fixes these. I'll remove those sysfs_emit changes for\nnow so that the commit history will be clean for when I come back with this\nsecond patch.\n\nbest regards,\nmaxwell","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Wi2wRom0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35501-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Wi2wRom0\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.224.44","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2CrC2DMpz1yD5\n\tfor ; Fri, 24 Apr 2026 23:05:47 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7460E300251C\n\tfor ; Fri, 24 Apr 2026 13:05:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BCB893BED75;\n\tFri, 24 Apr 2026 13:05:34 +0000 (UTC)","from mail-yx1-f44.google.com (mail-yx1-f44.google.com\n [74.125.224.44])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id AA4233C1991\n\tfor ; Fri, 24 Apr 2026 13:05:31 +0000 (UTC)","by mail-yx1-f44.google.com with SMTP id\n 956f58d0204a3-651d692e833so8056580d50.3\n for ;\n Fri, 24 Apr 2026 06:05:31 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777035934; cv=pass;\n b=lyQGqyvswFxVbP4tm8GRHLdu94sZpxdrHcOaMvtXwWP/gnAhEpuCvYISmwtvH0abk4KNFlGRIbD9nWC/NgO8kzmrwLP5LXvESkHh3QI7ip9BaoVwCI/0kplrdxSKKg1qnB64LQBnS6U+s/MMNSLL3Lt0tdu4QwUkxtHMd33WG9c=","i=1; a=rsa-sha256; t=1777035930; cv=none;\n d=google.com; s=arc-20240605;\n b=h/UgJPr7NtIHncCMXs5rUe4tS6bk1uJ6qNbWIhS/HKD5Lvg2AVrhdbVbyCj9/968Yn\n uFXyO0BuvjEYJTA8G16bsHj3Ia/LLI+/P05vVRhHJ5fl1BF2lspceTtButZnRfaSz0zE\n poXP+iM04AquAL/D6CVyRI7SoVN+csH6IBO1Mk77ExUJft8qK/JmeWaHKWgsnsZ7fXnf\n ukQTQDjbRQHOQpgk8umqrdgG4pDrdu1fe2rSVWWLk8/SwbCofhAQP5EvQuu2hrlGtQbN\n 1DmHIZl1ln34/RAbUlKl7fC5TqJT87VdCAxjsqNFAOvHobr7FG8Dmcf2GUEgFwuSGW06\n CCow=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777035934; c=relaxed/simple;\n\tbh=xP3uyFP6PCIyxBG3Zcx0H6OBWjVbS6/RbD4216wf3Ek=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=Eurrdg2x/Ul6/5H/0rqnZMj6oof+UeHHJksPLV4ay8D+5fGTHuPVN/4I8g/UYOmN3FGxDZo67zBnlDp82WCMvQfhIJ4XPzt8K686E+6pVAJPm5OHSCLr/ffYOWTWYxOaHkW2+q3sf0R9gw7BwYO50uspBWKQ2bFyJZ7sK9OvgxI=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=xP3uyFP6PCIyxBG3Zcx0H6OBWjVbS6/RbD4216wf3Ek=;\n fh=TpPiv9fI9kuV/XpuuZ1mj+D/0Z/duI51I27ywgeV9Ko=;\n b=kDZ2FJe+vK1b2XUKwu2EFHerl3T/vf/GfA13xGw54qWDhJhiPIZJV/H03ce/O8ye44\n bOYlDfl5elzfZdqgXqJj5gQv+GyLKXdPJg3pnBOAlgUcT6fxFkJcsBrSUYUw2nr9Q4d2\n +4ZUq5USnfiK/j8Fm4YuZyrjb22LkTAtenX9Nk7yA2rIDqPzuKpTP16VWp/MPbM2LKKO\n 5YCJqCTOH9pmGZsyP0VpOaFFFefrJd9QEOoqwndNEOnpAQFHT5nwPtq0dkxWFr9iBa5j\n W3inb+zX4fZad13Wa1SNX+12/87FtZhSkkqSSdcG0WczSvjBeF9sQCJTjiUJ7lfMsJr3\n YigQ==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Wi2wRom0; arc=pass smtp.client-ip=74.125.224.44","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777035930; x=1777640730;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xP3uyFP6PCIyxBG3Zcx0H6OBWjVbS6/RbD4216wf3Ek=;\n b=Wi2wRom0Z4FnlZ1HeePBuCtjTlbu5AJ+Jtq/VHsQQGqiekFDI480hgNH7Xi7jNMTni\n MkGlOL/bOD3Rh/iihk/IASe6/cNK0ajovpf+U2OrMWYrsMTVbyoeaRGDFGgkzMRzJ50Z\n 4xl06cc2xQx1GC8dvjh7bmgtk84b3CNkexKA76bpFcXSIW69R874PhwKa3rjZbN2OM/9\n bcgsjiHae1MX+DXSARmiDiP6dj0UfHeu7iUDPZbo3uvyyhrtheGZHbxL6Olrw+QT4OE2\n EWjXz/Ghu1NdMXQyBUHCB5P5sKYsT47LIKFRMlybfRQqwFaIxy8foB4G1YgWBjnGAIX4\n f/rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777035930; x=1777640730;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=xP3uyFP6PCIyxBG3Zcx0H6OBWjVbS6/RbD4216wf3Ek=;\n b=m56mYo6+WhVBGcKMhX1gR4mfRnF0FCVWEOd4HOmKYnziKbPczskcCnF6P6h4VUIeZk\n pepKqL/5gnaJRVC7Qa6C4iKaE7i9w0u5McjGq/EfnPxeLKWA25cDxwvIOhb+8H5zCRLZ\n cB3TfB6XPdUnDe+XbnI7PRNUJRpApi0jRgsrbHOnbIMMR0aGV1oWKW22IIH7cMPdrpJl\n NLyDC2NwKOxB0VHMlfB1AKOUKmBONcjmXxdtIaBG5i/BOBuB3y8K3DycpKePT3w4vG7Q\n Y2TSQsh8Q2TwsVIGT/a+5SzE9OZcLk1LS6T9Jm5nzxVvvca++nhx7jEkpZgVEvP+K0Jr\n HI+A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/QfprhNGIoY/nVEGpqrqit0/ud/+88O+cMlbt3jUSiDHqOJBGHXHI7gn1O62csA1uezyIyk4ny7Jfh@vger.kernel.org","X-Gm-Message-State":"AOJu0YyaYvpBIWmLanh6DUtqwRmqk0nGpVC5hJgmnwxwvxyHUzHI6IcU\n\tp8AdEApxQ5U+x99ep8bFkJnrhSP5UWRosTn4rh/TGLWK7QYZ7aWRCdYMT4VjyvwoKyQoHRLybX2\n\t58FWBhcei1RiaFiJEiF99wvvhADYUFAs=","X-Gm-Gg":"AeBDieun08smOWKlxTGzrnPS4mwG4/mBScx72cwKUIk/e9tgzYBK67gs3kDEG+t7PCa\n\tmPHA6NN+IQxMD8bm0U7vy3fyTVNeNqMN8HJS9x/vQUtUm91NF8j7lxThDYPF8hsPxokU0oxiGYO\n\tJt8TBdH1zFCZbbmCFjgg1xOXLVjw23p2sIAkj8FWGWrTDoqZRhCAFFXyTAe5eLzkxav3XTeyVUp\n\tXcoIKv53G539U52VqC5ik48vQmC3uPjNj5vQlvx4e+bmhUZ1alLc6kb41wRoyxFCJIv5zPUewSb\n\tADK6EUKEY42Ks3vJZzf3JuEJWhi/j5506S1k3HZryeA4kb1wHL+00LHODQbUI30=","X-Received":"by 2002:a53:ac91:0:b0:654:acd4:9c1a with SMTP id\n 956f58d0204a3-654acd4abbemr6065313d50.13.1777035930429; Fri, 24 Apr 2026\n 06:05:30 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260423223230.47001-1-m32285159@gmail.com>\n ","In-Reply-To":"\n ","From":"Maxwell Doose ","Date":"Fri, 24 Apr 2026 08:05:18 -0500","X-Gm-Features":"AQROBzCaIZ_mULZtyVuLGNn3d_JBGwJ2sBPStqLG3wLvtEeox9vUCw9kkCvZlpc","Message-ID":"\n ","Subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","To":"Bartosz Golaszewski ","Cc":"linusw@kernel.org, linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3682028,"web_url":"http://patchwork.ozlabs.org/comment/3682028/","msgid":"","list_archive_url":null,"date":"2026-04-24T13:13:26","subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","submitter":{"id":92191,"url":"http://patchwork.ozlabs.org/api/people/92191/","name":"Bartosz Golaszewski","email":"brgl@kernel.org"},"content":"On Fri, Apr 24, 2026 at 3:05 PM Maxwell Doose wrote:\n>\n> On Fri, Apr 24, 2026 at 2:54 AM Bartosz Golaszewski wrote:\n> >\n> > Do you believe the code looks better with more layered dereferences?\n> >\n>\n> I think some people might value the more explicit dereferencing, and with this\n> we also won't need to handle the overhead of assigning another pointer, but if\n> you want this removed thats fine by me.\n>\n\nI prefer to keep it as is.\n\n> > sprintf() is safe here as we cannot possibly exceed PAGE_SIZE with\n> > this format but if you really want to do this, than please send a\n> > separate patch converting all configfs show callbacks in the driver.\n>\n> I can do that, but I'd prefer to separate the functional changes with\n> this one, so\n> expect another patch that fixes these. I'll remove those sysfs_emit changes for\n> now so that the commit history will be clean for when I come back with this\n> second patch.\n>\n\nSure, let's drop the first part and do the conversion of the configfs\nshow callbacks\n\nBart","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lFJse0rv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35502-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"lFJse0rv\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2D1P0YH1z1xvV\n\tfor ; Fri, 24 Apr 2026 23:13:45 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 150D3300CFE8\n\tfor ; Fri, 24 Apr 2026 13:13:42 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2C2213D4131;\n\tFri, 24 Apr 2026 13:13:41 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B783B9DBA\n\tfor ; Fri, 24 Apr 2026 13:13:40 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 9B7DAC19425\n\tfor ; Fri, 24 Apr 2026 13:13:40 +0000 (UTC)","by mail-lf1-f52.google.com with SMTP id\n 2adb3069b0e04-59dcdf60427so6997298e87.3\n for ;\n Fri, 24 Apr 2026 06:13:40 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777036421; cv=none;\n b=A6JUKPQfqOhIPQgN2DacmDbuwmeIgvWuPJpALKF3PAnelKLAuTlkmjYP9Th6rdG+3Izx8qhg6y3hLhqIxiADa73KsyJ84ufLjW7oB7f2gByzrLc+kX6r72iL3Un9B8xUw3PujDtoxt0W25G0Y5mODoZQWsHRI4CUFXpDXQrss08=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777036421; c=relaxed/simple;\n\tbh=m6JrLYpdLV0CnSK2p3Kloba+kD76EVcgb4SkHM7WUL8=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=VUBAB7hlEgL3FzlHNtP+XH8HtTHLPUteiKHgc1H8JOZsvu0gKEyc9/zyxERag6rWTdoL4LShgR+ISoMHUvMWT/jVzD3YbMYOI6bc96Tt/YOJwGvdBkIargHBvOWZTKR6dbfDo2zDBl2YIOG6nG7F4V3i9XcSpXNHigVxh2xM4ak=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=lFJse0rv; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777036420;\n\tbh=m6JrLYpdLV0CnSK2p3Kloba+kD76EVcgb4SkHM7WUL8=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=lFJse0rv1GNstCer6UxIjuM2Xnns+3RTRTinqeT3lWzFrdLKOIBl/sYXkE26NgBy2\n\t 1lULqyNOsdPxOQC+MOuaMNPdn2cCI1CgZRePWCpRuNtPckXebmEw4wJfxyTVAQcakM\n\t R45gWX9rK2G5A4SXU3kM0IMOGlEvLmpetgyiBoOukgBUcSxys4nsv6tJ+M6m2iXPma\n\t 1SYHZLdWariiXNHHiNAGE+/JSznudffrZW8yqiNnVg41017MZMxM4nMO1ws+C6UFMr\n\t 282M0hbJMY+CcDvUnLm6LW7s4Q1v7OplQT2rO6FMr3a3T2k6mJ9SDadqt3taAHMo99\n\t r7jCDmAW/cTpQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8wgMlmYrMH4186DBs+rAWY5KEhiRovJNKESUeyXZGXuP9Llw5fSpOd+T/e5HrgWZ+r07/1tcM4cxAa@vger.kernel.org","X-Gm-Message-State":"AOJu0YwT3Pgs8tHbg0rRsfMxdoQsA8AuoghxTx95A2MuVUpFsd1lF7YY\n\tHug74orEs+TVDbrDKvLSmJvMoVw4uarBGaABzhlfkL7jbTPxl/srJd3S+JivtCFxyYrQ5seRGdl\n\tOtABC8zfCcWysLX+mxBgXALz55UAmqxDNHIrLg57huA==","X-Received":"by 2002:ac2:4c4b:0:b0:5a4:afc:e7fc with SMTP id\n 2adb3069b0e04-5a4172ca6b1mr9820510e87.5.1777036419301; Fri, 24 Apr 2026\n 06:13:39 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260423223230.47001-1-m32285159@gmail.com>\n \n ","In-Reply-To":"\n ","From":"Bartosz Golaszewski ","Date":"Fri, 24 Apr 2026 15:13:26 +0200","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzA1KytdKnDKYg3K2YC1FPSnbd4oyhasAmfGuoULuOTafUwHw-1BZAs6i1Q","Message-ID":"\n ","Subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","To":"Maxwell Doose ","Cc":"linusw@kernel.org, linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3682034,"web_url":"http://patchwork.ozlabs.org/comment/3682034/","msgid":"","list_archive_url":null,"date":"2026-04-24T13:22:26","subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","submitter":{"id":93193,"url":"http://patchwork.ozlabs.org/api/people/93193/","name":"Maxwell Doose","email":"m32285159@gmail.com"},"content":"On Fri, Apr 24, 2026 at 8:13 AM Bartosz Golaszewski wrote:\n>\n> On Fri, Apr 24, 2026 at 3:05 PM Maxwell Doose wrote:\n> > I think some people might value the more explicit dereferencing, and with this\n> > we also won't need to handle the overhead of assigning another pointer, but if\n> > you want this removed thats fine by me.\n> >\n>\n> I prefer to keep it as is.\n>\n> >\n> > I can do that, but I'd prefer to separate the functional changes with\n> > this one, so\n> > expect another patch that fixes these. I'll remove those sysfs_emit changes for\n> > now so that the commit history will be clean for when I come back with this\n> > second patch.\n> >\n>\n> Sure, let's drop the first part and do the conversion of the configfs\n> show callbacks\n>\n> Bart\n\nSounds good. I'll get that patch out this afternoon, otherwise I'll be\naway for most\nof the weekend and I'll get it out Sunday evening.\n\nbest regards,\nmaxwell","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=htfiYNkG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35504-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"htfiYNkG\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=74.125.224.43","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2DD31RnXz1yD5\n\tfor ; Fri, 24 Apr 2026 23:22:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 5F371301E585\n\tfor ; Fri, 24 Apr 2026 13:22:40 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B6CDC3CAE84;\n\tFri, 24 Apr 2026 13:22:39 +0000 (UTC)","from mail-yx1-f43.google.com (mail-yx1-f43.google.com\n [74.125.224.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A26C3290A6\n\tfor ; Fri, 24 Apr 2026 13:22:38 +0000 (UTC)","by mail-yx1-f43.google.com with SMTP id\n 956f58d0204a3-652f220595fso8167942d50.0\n for ;\n Fri, 24 Apr 2026 06:22:38 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777036959; cv=pass;\n b=DD3+jxFTEXm8OYK16axFzVAdvIsAdGhcM0RoZ8iEgkHs7dd/4icL2m/fxgD1HYuSGMgg0G97nMrd8NXJizB4CuH3Q89kAuSV8RTJsUq652Pn5gKAXoNFNkKQayua1/INvrgeaYP7dLuRbVUH8AO2MVSgjRgDE2EW5s3d0iYZlzk=","i=1; a=rsa-sha256; t=1777036957; cv=none;\n d=google.com; s=arc-20240605;\n b=llOlXGtlEIn+RDSnI2czD82gJ+artxQMTXAL+YqmQ1bFDjea+np8z82dl6Nt3Lfat+\n 2b5vgsEk1g5k6FtCuxdYgDYlGUxy56WQSA1WmXT6Vhb5pbr+h5cc8BoQ0jzpMbYBtw0K\n yBm7MQhjbsy6ybj/W20ihhiXbnuabADitflLcOwsN3BOGzHX8vvzWt5THtJ5jXf1QA3b\n AzkSaQKLtDAUoPVhDqx7dA8jmX4XIvnpS4hIwAyWNt8DJxxs/G8pYXlD6Tm8Kt8I+tMS\n k5HYwwA5CaDaJteds/oiEMFLou5Y3td+Pf/25MwgBSp6ZGOEachJR55Ip6+/mmiJy9cw\n 1zuA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777036959; c=relaxed/simple;\n\tbh=i3VBkDDnT1fe4npHcuSMiiD5KLy9rWkufI1EQIFp5JE=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=E/Gl07aLHUtjq9pPXfUdhBVLwwhyCg1+8EtfT8VjLItbFCc+OoG2W83Ws3z8P/Z23Bi/2BNOBldkJ9vSbPq4nywxL0k8QDff2whbjxRTCPMSOHZ9awL7ZyoVsINukVU3Z+njwnZr1Nqke2aSmcXTHsh/8B6Fb+RL0KYuGImlXoQ=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=i3VBkDDnT1fe4npHcuSMiiD5KLy9rWkufI1EQIFp5JE=;\n fh=UnZ34nHPISuD47rzRcqffTD6L5prVBWm6ZzbOwNv0b4=;\n b=Tyk7sP1K29eeVxQar39FHeiciaSiIZSi3fP7g1u0uQy6TmIDA+Oitfw0asFAYam1v2\n lfAXiT51dS8keXomxSgSGZkj5PQnhGjM/QebMX/kW+YUXniubnkTsLDrfAJ0Rr59Jv8Q\n e3oIv5R0AzZbP4ZXq/LlmKyMyZphZNW+/okSlE72T1vptXExSkmnk3hTUK/pP1KMNfyU\n ukj78TBE6h9gS7UwmEGTy0joUirRiKSBAu23E6QbEVgIFZ7Xs30vj+Z9WgLz2lS2c3y+\n 2VSqy1QfufeuqSb9OVjYwYN/xaZ9+5FcD74zvbNEaQrh+dYNWqX6L8UBdvXSoJs6ae3U\n Nq3Q==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=htfiYNkG; arc=pass smtp.client-ip=74.125.224.43","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777036957; x=1777641757;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=i3VBkDDnT1fe4npHcuSMiiD5KLy9rWkufI1EQIFp5JE=;\n b=htfiYNkG9fw5I0aruoe+hsMN3ul9w36rUjAslZ1szbl052beEaL+7chxjBP7oVdLLa\n AXiNoKRNzjMGAvDClk+iJ4ZK584KOQJOK3eSmYMm5ux0wLtdDh/bz22ZHIWo9RKw0tn2\n U+Z8kIVaAJNu8CQA3J1MOx792mU0f6XjaCisCN1VVJ8WRDXrZQ1s0S3zE7dA3TDCq5yW\n ZWf+9JPsmggBzR0ye1XZYIqUKQ9ADFyQFDXFsTzpncv4UUX7Misb/vOV8vq37GfeBU5z\n Ek08konTdjR9v3mol09ztzuhnUs8Isw+B32t+Xj/KEwt10hl2jiTDa97BDKx+eE+ob0y\n 5p0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777036957; x=1777641757;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=i3VBkDDnT1fe4npHcuSMiiD5KLy9rWkufI1EQIFp5JE=;\n b=JLttK3NtzYJSjZ4aVMwkDAvljPsHGOnPRY0y8Zhq/814u+/lFbMlpf9mw18X7SINCN\n CBvT6HwcDqUzxHcam+DzdxA03IuiWgleTRd2cZtQvVVaS3oC2a5PQwJL6lBW3LZwS8i/\n aoYZ5NdOqtKyyeHRLR+rg1VkomSVsGc8bvexEA4NET08qURmpzYzYLh9gXun7hdgist3\n 2dMEoy5tJK/V//pAGFUwWr/5yf4iYwrAaCKE8t0G2+29lA60/b78AF9sUKaTPRMBfbBn\n KU9akm8OSUaQWKYcPBrshA+KDKofRE4ZMRNdx80YBhcypNfXN6hOpPPOPY3aP82bmKIC\n 44JA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/vaOALyg/RrYiyiXAbQ+pazxmfUw81Ybi/gPv9vXjF+rA+gCu4ll0bXXcelQEgWjuq+ZXcUWn7+eyO@vger.kernel.org","X-Gm-Message-State":"AOJu0YxDK3ZACVza8Srbi3wJDtUyMQWAEnuLLmDwJGIuoZV7b5VPOVqi\n\tQPoBPJhshxSJVWBO/s7kJYTBh2AkKXU/Sv5Jo4XKxwbjSJY/3jzaiHjqg/L16V2cXQHb/e2ZgtG\n\t9AbI7MYYjxFNbTMaf1RbaxVC64nJtZUg=","X-Gm-Gg":"AeBDievVKKN2II3B9JRqLQWC7Fujm/voSfMZNsY9dwVbCE0gNmsT3+jhR5OuL7asmut\n\tz6xKYwxxMiDxINjbv3hhUn6zvXINw9zDxyIF6vMd5xe6i5IM8xoOj7PcuYjLbKl5h+v9fghTY2p\n\tEZoB5oOtxFZintOQACtaN2K6QABV/dZ9Y2tfCzryRHdSa+d9Wyi68i8iYi4VRC2rIA73sNOw+TI\n\tu22smM3IUKJtiWd5B645Ax9bp7EmmV71mtQG3rkIiNpi2GZdQGjVPzu+PpasoFpGWHCnfyMEMQG\n\toqHem+eWLoSL1tJ7nrO6b6S4RZS5JIg=","X-Received":"by 2002:a05:690e:130d:b0:650:2ff9:d651 with SMTP id\n 956f58d0204a3-653107b8828mr28757367d50.5.1777036957520; Fri, 24 Apr 2026\n 06:22:37 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260423223230.47001-1-m32285159@gmail.com>\n \n \n ","In-Reply-To":"\n ","From":"Maxwell Doose ","Date":"Fri, 24 Apr 2026 08:22:26 -0500","X-Gm-Features":"AQROBzDKnNOycij-uX6mokr1Bzn454_lviA08YK4t5z00e9tOpF5UCx41FuYytI","Message-ID":"\n ","Subject":"Re: [PATCH] gpio: sim: Remove intermediate pointer variable and\n harden function","To":"Bartosz Golaszewski ","Cc":"linusw@kernel.org, linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]