[{"id":3681830,"web_url":"http://patchwork.ozlabs.org/comment/3681830/","msgid":"","list_archive_url":null,"date":"2026-04-24T07:43:52","subject":"Re: [PATCH 2/2] contrib/plugins/uftrace_symbols.py: handle missing\n source line from addr2line","submitter":{"id":86526,"url":"http://patchwork.ozlabs.org/api/people/86526/","name":"Manos Pitsidianakis","email":"manos.pitsidianakis@linaro.org"},"content":"On Fri, 24 Apr 2026 00:38, Pierrick Bouvier wrote:\n>Some symbols have only a file information, and no line information. In\n>this case, addr2line reports '?'. Replace with 0 to guarantee consistent\n>data for consumers.\n>\n>Signed-off-by: Pierrick Bouvier \n>---\n\nReviewed-by: Manos Pitsidianakis \n\n> contrib/plugins/uftrace_symbols.py | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n>diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py\n>index 895fa1a6b7a..a71865805c5 100755\n>--- a/contrib/plugins/uftrace_symbols.py\n>+++ b/contrib/plugins/uftrace_symbols.py\n>@@ -70,7 +70,10 @@ def find_symbols_locations(elf_file, symbols):\n> file, line = out[i].split(':')\n> # addr2line may return 'line (discriminator [0-9]+)' sometimes,\n> # remove this to keep only line number.\n>- line = line.split(' ')[0]\n>+ if line == '?':\n>+ line = 0\n>+ else:\n>+ line = int(line.split(' ')[0])\n> s.set_loc(file, line)\n> \n> class BinaryFile:\n>-- \n>2.47.3\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HMseTqvE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g24jL5Cvdz1yHv\n\tfor ; Fri, 24 Apr 2026 17:44:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGBCw-0002ic-PW; Fri, 24 Apr 2026 03:44:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wGBCs-0002iN-7q\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 03:44:10 -0400","from mail-wm1-x331.google.com ([2a00:1450:4864:20::331])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wGBCq-0005MH-LE\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 03:44:09 -0400","by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-4890098abbaso56221475e9.0\n for ; Fri, 24 Apr 2026 00:44:08 -0700 (PDT)","from meli-email.org (athedsl-338307.home.otenet.gr. [85.72.177.33])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc375dsm52481053f8f.14.2026.04.24.00.44.06\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 24 Apr 2026 00:44:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777016647; x=1777621447; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:in-reply-to\n :references:user-agent:subject:cc:to:from:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=3EnesgIeeNTPrEUM822wrdXyIeBqadCh7YpZ7ZJRa50=;\n b=HMseTqvEcNSwpcUbDdzPfmIoc3XwOQ3yM0Z4XByGfkFLbrG2f14yFXR0pA+RrME8Py\n sLx5SCpdl5eBA7DKo6WNAnV/Rd4xur2LIDLNlCAjC05ZrduwerGL+6UxxT2Kkn0mpkU5\n mhtCmTnF1Obm1+oGAsB0Ao8yN6x95mT9Honhi5DL5Gq44/zcHuJljQeBSgjJEPXBD6Ke\n 1xp14w+9AsFog22G/trcRq2PYLNoBTY0uEi/5vqiPqRyZF0WKSvK0ml1RnJLl3814csq\n PaYv/NwkcsXcMxovSnW/yiSmHqpoARgp/eBFGS1qHCS1AaTW4eIkrdaWR5Zbb7/OHfrb\n J7dA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777016647; x=1777621447;\n h=content-transfer-encoding:mime-version:message-id:in-reply-to\n :references:user-agent:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=3EnesgIeeNTPrEUM822wrdXyIeBqadCh7YpZ7ZJRa50=;\n b=qftPosyC1nh1oGWdGdb+Rk6hV3OX9zzjzHxV2kSPr/Zj6FLijaPpnIPEglqJz0FmmC\n ZZenUs9TafuFxUyGPwbdQHnAShhZ61ANnkmhppQVjzWSc4Or0lrfhs3lSSLy4VD06YOe\n VN80G5BJh0FSjTE1qUKROmgqBFI/+pAEtWg7e1HwCGAOex2h8FaQPtft4qbBK8Fk2kl+\n TAhwhr+tTKU7/BtRnfwIfyf0YFDsFfd72WtAKsoTIPP6Bi9ef0Ij5JS/Scr9zpFmrGyB\n LZ5Ymsie/xOm2z9TEbHlz69pjhFLi2QicVXPMUBs/YvQnW1bLB2jNvkxlhX7Je8Qr3NB\n d2oQ==","X-Gm-Message-State":"AOJu0YxG8uAB8gVPp10Ceg/ehCXyvv5V6PB4pCDs6AcVuLWy9+ad4ZMN\n a6LIHkVaUTnf1aZQlkJX9dCgFaHX361tEQJwkEsWbUhGYR0L5Ur4Q37XcRY3eqL8/oI+mPKRO0x\n /cICgDuA=","X-Gm-Gg":"AeBDieuCAz+4os0L6Dwbug9qdFLLr/ljRSMuP8OcPJ1BnXLtCfxDsROYf1JiqpFikLb\n 9WYvJbmPjvziQnsYbkQGql93+RRooWTMauOXeVE5eEFUQzkOBr1wLzf0rSI5w0IvxSVoZ3na2uS\n 6n69/11qHrpBkCfz78bSAX+Y3MGZHaH4KZDE0WAeQLsV7s4FWYEaEH258JxhOpSHUaZsVXmlVZ5\n +N/kbXq2sWT1G0JD58qScWY3KQNVGI16cu2OB6ZTEx5z6JlQPWEhUL6CJ4ZXRvRNqOhISTYqAWy\n MOrrCXRbhrEzZQj2Ll5dX4P/VLDRTazqWIv6+xSV9ob+NRjSQTVEay9/puLJJsH9aYufezPElDB\n Unh75dJyP4skGv2Y/9Tl5nxA4fSaUXXxv4AQOCxl3S7RGTdfVPDnYevAtiJ79g75slcTthxbWXR\n N28po3M1vdpBFxWsfKWCXpIG5QWVVdrUQUlgoJJF4ueMojYQRDGcJe201L13smN0hv1XThjD+I1\n R8Rw/hjaENajElzwenZ18e0cIeYPG+r6RAOljsDZ7jhxxae7KipQT2i/otSRLDO/rS/1EgR","X-Received":"by 2002:a05:600c:a105:b0:485:3a03:ceca with SMTP id\n 5b1f17b1804b1-488fb7826femr306684265e9.23.1777016646890;\n Fri, 24 Apr 2026 00:44:06 -0700 (PDT)","Date":"Fri, 24 Apr 2026 10:43:52 +0300","From":"Manos Pitsidianakis ","To":"qemu-devel@nongnu.org,\n Pierrick Bouvier ","Cc":"Pierrick Bouvier , Alex Benn\n\t=?utf-8?b?w6k=?= e , Philippe Mathieu-Daud\n\t=?utf-8?b?w6kg?= ,\n Matheus Tavares Bernardino ","Subject":"Re: [PATCH 2/2] contrib/plugins/uftrace_symbols.py: handle missing\n source line from addr2line","User-Agent":"meli/0.8.13","References":"<20260423213838.780814-1-pierrick.bouvier@oss.qualcomm.com>\n <20260423213838.780814-3-pierrick.bouvier@oss.qualcomm.com>","In-Reply-To":"<20260423213838.780814-3-pierrick.bouvier@oss.qualcomm.com>","Message-ID":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=utf-8; format=flowed","Received-SPF":"pass client-ip=2a00:1450:4864:20::331;\n envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x331.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]