[{"id":3681783,"web_url":"http://patchwork.ozlabs.org/comment/3681783/","msgid":"<87pl3ox4a3.fsf@pond.sub.org>","list_archive_url":null,"date":"2026-04-24T06:26:28","subject":"Re: [PATCH v5 3/3] qapi/iothread: introduce poll-weight parameter\n for aio-poll","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Jaehoon Kim writes:\n\n> Introduce a configurable poll-weight parameter for adaptive polling\n> in IOThread. This parameter replaces the hardcoded POLL_WEIGHT_SHIFT\n> constant, allowing runtime control over how much the most recent\n> event interval affects the next polling duration calculation.\n>\n> The poll-weight parameter uses a shift value where larger values\n> decrease the weight of the current interval, enabling more gradual\n> adjustments. When set to 0, a default value of 3 is used (meaning\n> the current interval contributes approximately 1/8 to the weighted\n> average).\n>\n> This patch also removes the hardcoded default value checks from\n> adjust_polling_time(). Instead, poll-grow, poll-shrink, and\n> poll-weight now use default values initialized in iothread.c\n> during IOThread creation.\n>\n> Signed-off-by: Jaehoon Kim \n> Reviewed-by: Stefan Hajnoczi \n\nQAPI schema\nAcked-by: Markus Armbruster ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JQBCB8SN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g23143m2vz1xvV\n\tfor ; Fri, 24 Apr 2026 16:27:50 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wGA06-0007AW-IK; Fri, 24 Apr 2026 02:26:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wG9zw-000787-46\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 02:26:45 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wG9zt-0004y0-EA\n for qemu-devel@nongnu.org; Fri, 24 Apr 2026 02:26:43 -0400","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-L1YkjpH4MR-soD48EwxxwA-1; Fri,\n 24 Apr 2026 02:26:34 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 160D01956089; Fri, 24 Apr 2026 06:26:32 +0000 (UTC)","from blackfin.pond.sub.org (unknown [10.44.22.30])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 1A9F31800446; Fri, 24 Apr 2026 06:26:30 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n id 7C2D721E6A28; Fri, 24 Apr 2026 08:26:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777011997;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=As3D+yvgCFGoqM3li5vFKulPxLGehH6KxlEEDMA2/M8=;\n b=JQBCB8SNHNBhI/LMWXlE9xbghPObj/lMC5AXFhV+xLpEFhl0RI/k0azkX922+2kAuwdRij\n 6p9PXNLJiCzOvVtiUoZH5thzbz/o3G7Ov8gIn3juYv4zMmGeCHLlDjG7RynqAugVWIuVTn\n xN75ZnojN6wnBTHo1uIiptXGjTKbia8=","X-MC-Unique":"L1YkjpH4MR-soD48EwxxwA-1","X-Mimecast-MFC-AGG-ID":"L1YkjpH4MR-soD48EwxxwA_1777011992","From":"Markus Armbruster ","To":"Jaehoon Kim ","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, pbonzini@redhat.com,\n stefanha@redhat.com, fam@euphon.net, eblake@redhat.com,\n berrange@redhat.com, eduardo@habkost.net, dave@treblig.org,\n sw@weilnetz.de, mjrosato@linux.ibm.com, farman@linux.ibm.com","Subject":"Re: [PATCH v5 3/3] qapi/iothread: introduce poll-weight parameter\n for aio-poll","In-Reply-To":"<20260423195918.661299-4-jhkim@linux.ibm.com> (Jaehoon Kim's\n message of \"Thu, 23 Apr 2026 14:59:18 -0500\")","References":"<20260423195918.661299-1-jhkim@linux.ibm.com>\n <20260423195918.661299-4-jhkim@linux.ibm.com>","Date":"Fri, 24 Apr 2026 08:26:28 +0200","Message-ID":"<87pl3ox4a3.fsf@pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]