[{"id":3681651,"web_url":"http://patchwork.ozlabs.org/comment/3681651/","msgid":"","list_archive_url":null,"date":"2026-04-23T19:34:06","subject":"Re: [PATCH 3/3] qio: Fix qom-list-properties crash on net listener\n object","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Apr 23, 2026 at 02:32:12PM -0400, Peter Xu wrote:\n> The QIO net listener object will crash with raw object_new() then\n> dereference the object, like what QMP command qom-list-properties would do.\n> Fix it by moving mutex init into instance_init().\n> \n> Cc: Daniel P. Berrangé \n> Link: https://lore.kernel.org/r/87a4uvw066.fsf@pond.sub.org\n> Reported-by: Markus Armbruster \n> Signed-off-by: Peter Xu \n> ---\n> io/net-listener.c | 14 +++++++++-----\n> 1 file changed, 9 insertions(+), 5 deletions(-)\n\nReviewed-by: Daniel P. Berrangé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=bTva8HcZ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=Bk8rMYlJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1mX91ps3z1y2d\n\tfor ; Fri, 24 Apr 2026 05:35:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wFzoa-0002w0-9E; Thu, 23 Apr 2026 15:34:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFzoX-0002vW-IE\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:34:17 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wFzoU-0005Xc-EL\n for qemu-devel@nongnu.org; Thu, 23 Apr 2026 15:34:17 -0400","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-685-ebY3KaIyN5G2MLD5fXyrtg-1; Thu, 23 Apr 2026 15:34:11 -0400","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-486fa07f2bbso50190155e9.2\n for ; Thu, 23 Apr 2026 12:34:11 -0700 (PDT)","from redhat.com ([2a02:8012:f011:0:f1ce:ac56:d2cd:7c2e])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7a06f3sm198648655e9.22.2026.04.23.12.34.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 23 Apr 2026 12:34:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776972852;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GkLfao2xAgaGyUdnT/LSwmf9hfjaa+/2pnA8xvVqh2A=;\n b=bTva8HcZ/htK4tgVkSDA4oJmcR9gPu9Zsj22ubKtDGS+XF6b/vGy1MWDBlQw9+n0Mkgngp\n WHus1dYWB5k2Nt6BGJIDuSFaUAZ14GKq5RUA4KXsdgzVXZGxZeSu4dddhJ3bearL6IDRGB\n YIvQTXrm4RTumvlh7rEW8EKUAP0V14U=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776972850; x=1777577650; darn=nongnu.org;\n h=user-agent:in-reply-to:content-transfer-encoding\n :content-disposition:mime-version:references:reply-to:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=GkLfao2xAgaGyUdnT/LSwmf9hfjaa+/2pnA8xvVqh2A=;\n b=Bk8rMYlJqCzy8HcGW1kBkGL+x4h4BAWapTrdkvZrb67wCyP4jgdnrw+1HCpEZV3t14\n dOemLR3E86i6fYFd1Oi2NDFjVY/bR2rjp33xx6fIF415qvBMd4IkBl5OvSQq6Mr/4bry\n mAz4tt3ck7quoztXDekOrXFHynB+mJi0sIWckGr/MHIzOFtAhNWNN1DuJqxP5aF1KNzG\n 9ecJTbM8A0UGXmS1tIUt+tvRUysIkH9SynvwWKbHyETM9V+fC1cT7raHjIKdfVUBKuvo\n MKAfs/NWRouQCiogXe/oNotOCIVNh7uxYFSSsycAtuWk3wtS0BSA+BM0YZYTAnjyp4bS\n XJ1Q=="],"X-MC-Unique":"ebY3KaIyN5G2MLD5fXyrtg-1","X-Mimecast-MFC-AGG-ID":"ebY3KaIyN5G2MLD5fXyrtg_1776972850","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776972850; x=1777577650;\n h=user-agent:in-reply-to:content-transfer-encoding\n :content-disposition:mime-version:references:reply-to:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GkLfao2xAgaGyUdnT/LSwmf9hfjaa+/2pnA8xvVqh2A=;\n b=bATKRCFyv8ZaXwocEZOP+aHgmow/x0qAggbR5fT2vbK0ZVxtRgi8U5TT3oUuHk/UYL\n nxdpt/A8rCnApqTKEdJIJijpT51Vg+cO8OiYv8R8ZmI9T5LT28tHWSYbt6lZX3MHho2b\n tw3ZS3q+ubRFeHshakxDLpHdwmM/Xpb03pLzcF8mv576I6eXbOvmKHNWQYP7jBTc2gcy\n l+txl0Tr9cKz0gSrNVqRNyRtME7ETekiLbYhVlCAvUqzsWkXysandeVESl2vvotkS1sK\n ft/KZMWH1Ob+uZ2zBh+6FG6zYyLNTUT287X71g7NnwEhcmUzwHMMAEr4V1Zwsd8D0/eq\n 9Jow==","X-Gm-Message-State":"AOJu0YwEvfAYFgC4/2rvor+bbURTl8banBc4JJ1NnyrjMI0zRd4ZaQDJ\n w4XknmHdjm+Io5HB2IB8+7FN3hqx0uvatW/eGTuUjsPMna5MFRoa6VbOk3/NlLgjJKEJDqQvnJ7\n fIXwbG8sYRUpDdY+/w+iKEEzMD9ky2Cp2vqs7fUYHDJDe5wuQ4ZRCPFov","X-Gm-Gg":"AeBDievY8ffw57L3BOWAKigXuHTis2AKMQ5o9W2vZR7WUJOKoAE2HIgmtifsHXhoPtf\n VnHBbtB5z9esNAvuLosP4FWZEXnswvMZnKrDfmdAwC3660BwwO/kkd8Ed55zDy5j2RWxFZhD3m1\n f5sd4q03FpXxAhgG9te0flP2wdz/jgaHAKjcASF2HOQITorqgfg59S973MTCWpnG6ckapq5J4Bc\n myGSelPnLi4orTWlQpESjUnha7C2N3O+SqRE9mfPuBQZSmjWbEhYI5X1QNai2Eszki59eIExQQG\n 7hwJchfiPWSx9kdc46FVgj8y3fuHO9klGxGpkl16aQxNyHxQ/rlEAFMHHtfuze07XRfd8DKQMaF\n CUbGwyq8/bbUtfq5BiBAD/LHNhB0nHQ==","X-Received":["by 2002:a05:600c:888b:b0:488:c80c:c236 with SMTP id\n 5b1f17b1804b1-488fb73d525mr338717565e9.5.1776972850094;\n Thu, 23 Apr 2026 12:34:10 -0700 (PDT)","by 2002:a05:600c:888b:b0:488:c80c:c236 with SMTP id\n 5b1f17b1804b1-488fb73d525mr338717255e9.5.1776972849649;\n Thu, 23 Apr 2026 12:34:09 -0700 (PDT)"],"Date":"Thu, 23 Apr 2026 20:34:06 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","To":"Peter Xu ","Cc":"qemu-devel@nongnu.org, Paolo Bonzini , Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n Li Zhijian , Fabiano Rosas ,\n Zhang Chen , Juraj Marcin ,\n Jason Wang , Markus Armbruster ","Subject":"Re: [PATCH 3/3] qio: Fix qom-list-properties crash on net listener\n object","Message-ID":"","References":"<20260423183212.468047-1-peterx@redhat.com>\n <20260423183212.468047-4-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260423183212.468047-4-peterx@redhat.com>","User-Agent":"Mutt/2.3.1 (2026-03-20)","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]