[{"id":3681604,"web_url":"http://patchwork.ozlabs.org/comment/3681604/","msgid":"","list_archive_url":null,"date":"2026-04-23T17:54:46","subject":"Re: [PATCH] tree-ssa-strlen: Replace with gimple_build [PR122989]","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Thu, Apr 23, 2026 at 10:43 AM Avinal Kumar wrote:\n>\n> Replace convert_to_ptrofftype, force_gimple_operand_gsi,\n> gimple_build_assign, and gsi_insert_call function calls\n> with gimple_convert_to_ptrofftype and gimple_build.\n>\n> Signed-off-by: Avinal Kumar \n> ---\n> Hello, this is my first patch to GCC. I ran the style check and it passes,\n> but the style feels a bit odd to me. I couldn't find a better commit message\n> and body for this change. Please suggest if they should be improved.\n\nThe main thing that seems missing is the changelog. Did you do a build\nand test also?\nOtherwise this looks good.\n\nThanks,\nAndrea\n\n\n>\n> Thanks,\n> Avinal\n>\n> gcc/tree-ssa-strlen.cc | 18 +++++++-----------\n> 1 file changed, 7 insertions(+), 11 deletions(-)\n>\n> diff --git a/gcc/tree-ssa-strlen.cc b/gcc/tree-ssa-strlen.cc\n> index c698998f5d8..70d45e36b3f 100644\n> --- a/gcc/tree-ssa-strlen.cc\n> +++ b/gcc/tree-ssa-strlen.cc\n> @@ -877,17 +877,13 @@ get_string_length (strinfo *si)\n> gimple_set_vuse (lenstmt, gimple_vuse (stmt));\n> gsi_insert_before (&gsi, lenstmt, GSI_SAME_STMT);\n> tem = gimple_call_arg (stmt, 0);\n> - if (!ptrofftype_p (TREE_TYPE (lhs)))\n> - {\n> - lhs = convert_to_ptrofftype (lhs);\n> - lhs = force_gimple_operand_gsi (&gsi, lhs, true, NULL_TREE,\n> - true, GSI_SAME_STMT);\n> - }\n> - lenstmt = gimple_build_assign\n> - (make_ssa_name (TREE_TYPE (gimple_call_arg (stmt, 0))),\n> - POINTER_PLUS_EXPR,tem, lhs);\n> - gsi_insert_before (&gsi, lenstmt, GSI_SAME_STMT);\n> - gimple_call_set_arg (stmt, 0, gimple_assign_lhs (lenstmt));\n> + lhs = gimple_convert_to_ptrofftype (&gsi, true, GSI_SAME_STMT,\n> + gimple_location (stmt), lhs);\n> + tem = gimple_build (&gsi, true, GSI_SAME_STMT,\n> + gimple_location (stmt), POINTER_PLUS_EXPR,\n> + TREE_TYPE (gimple_call_arg (stmt, 0)),\n> + tem, lhs);\n> + gimple_call_set_arg (stmt, 0, tem);\n> lhs = NULL_TREE;\n> /* FALLTHRU */\n> case BUILT_IN_STRCPY:\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=nicuqua1;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=QGDOo6vc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=nicuqua1;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=QGDOo6vc","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g1kK36q6cz1yDD\n\tfor ; Fri, 24 Apr 2026 03:55:35 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 47BC74BA9011\n\tfor ; Thu, 23 Apr 2026 17:55:33 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id 796364BA9011\n for ; Thu, 23 Apr 2026 17:55:01 +0000 (GMT)","from pps.filterd (m0279865.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63NFY7NO179234\n for ; Thu, 23 Apr 2026 17:55:00 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqe62ju0x-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Thu, 23 Apr 2026 17:55:00 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2ba9a744f7dso9144631eec.0\n for ; Thu, 23 Apr 2026 10:55:00 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 47BC74BA9011","OpenDKIM Filter v2.11.0 sourceware.org 796364BA9011"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 796364BA9011","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 796364BA9011","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776966901; cv=pass;\n b=NLlMCAW3lfyFdIguDaHl/t7wauUk5Demefiptx7Vx/ijbhj8G8ooW+hkDyTSF+jpwRn5e1hNRAxkq456NQ6/dj3q32rd3N9JmwNReVJmkZnjs+pShW9SuVSdXIRrwkZw2VjhpDlMICMfdOsRD3SGWL67/6K9Mn9VGKX4XfXnayg=","i=1; a=rsa-sha256; t=1776966899; cv=none;\n d=google.com; s=arc-20240605;\n b=BieVAONxidyEGk7rK1QqqSPo9+8h5HNYCbSdWNxhKc15Mp9s4fS03XNqcr8ujhPHpl\n B/ocF5RgQj7g7juDLPeQfNg85O9mgx8LZyw/RVd8q4vofIwkbhGNnpVdOCBZnctp6Ew3\n RFN8BOX3lrPyziNG9LHldQCqjKXWNUdJa1BO1yImwu7YxC2pWqmTf00hJgDk3ciOrYKn\n Bbci0oph+hEI6h0wVpE6uzsQZsugEEMoQ+0//g6fcMYOrw1x6h6yPMgrw1yAW9oe1p2m\n FVxCcv10EA69GZ5t8I1G3fZ3gD8bqbdd7zWW8C/ljb/Xg6ywBny2hHDuy05xkT9sU6BP\n Jeug=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776966901; c=relaxed/simple;\n bh=0MUYFdFUI+7EzQ2sKA5Pkuiwu6MH5jmMEZIwijACUZ8=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=aE40c33x52d/36AviHyl77fnKrAWhdF5tdzNjpo6s4uZ0Lwb9AB5DkOf6nvPd3CHwcg0Nwte+cPGjooJlBwhDplfqENHLiT1WK8j9ZbhEXZYsPDyrSoRIdLvVW+5FX+vdQ2Fl5IDNqKhPeohrgxAX3T71L4d/Z38ZtH7VU83124=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=SkSqnJIKFJccGtzzarltZR7rtnS4SrG5UggZg7Ycww4=;\n fh=JDakSnM4Jbb2Jc4yB2MgNBsdzZpJwtSDf3Mkwl72JxA=;\n b=Jb/LmeRyJUsKTg/UNrqIKGqA/N5qb3db/QkcVYjh1sqv4C+Ekx6RgBRWDot+T+2dCG\n ioTrojJz672GJcbLeU6lhU0B0DFCTMv9b8Rup0Dab7poQ/ciZqteEIQLBmDzl6hj5oi/\n 5Hk9lMbuway8ZucbuUydtkgdvy8rnrphXlYZwgcNV2E9hSdP4d1hdKDFVpNLMUwdppF8\n X+xGNpGgTgRXWiDQVho1BTyRohwu3Lx7EfqDIJvGEEBDH+kndRb9EiuE8DwMPzeKX8aB\n XXLTQKE2uhLrX2jpkvgCAApjDvzknGGDku8Z0EqmbWDZGHA4QSG/6q80yZm2JzyPWQxM\n 8aRw==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n SkSqnJIKFJccGtzzarltZR7rtnS4SrG5UggZg7Ycww4=; b=nicuqua1+3xHB+Td\n XpUht7Al9j0YHgQ7qMBBPb0b0fUQ+sjHOUbb51vi7PIBLQUJ+u9KQt2wuGf5DOIG\n WMWDwkh4tUtKSN763SQSDTa0pNIeriSo240Sk+rJtySEIeBT+e82swZ1HIWyhMSJ\n WkFr/a0ypC3XZNjfTd8ZXBpdO+S8viyK5gJyHZ3tnMt4DPf8kvsi7OxVJstflqMt\n IZfUZY3K2nW64UbJBvw/x47HoDBirCmEPyY97W39+FIPDgDAmekY4n2qXr92V6W9\n PE65UoOVnp0gwRXjHR3hZpc3VfMn5s9QjgjKml+Xo5GfWVInhYL9EGAdd4YVel6v\n UncOSQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776966899; x=1777571699; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=SkSqnJIKFJccGtzzarltZR7rtnS4SrG5UggZg7Ycww4=;\n b=QGDOo6vcvde3Hc9C3ixUCqPHeQ65n41I3MImWQHVFW+Ip5i/kJVvi14uNt4UQMMMLj\n maKHrngLKSToXtG09uii+RShQ1AsNVmNuqdsUR8epDlzuGUaR+RZp8cz/y/PQc2QjyTF\n PnIXlCgj/aXsBddC9gYLU6Fx6+vyg9jKoU3FXuN63cgZ/lUbTh34QahzJtkmXFYCpc8R\n yekW8+TvIMkgheAKhgqjVlQJvmCujuIyLZD+1rJz0RRfJYauoltrC7XqSB5XUoFmQQA5\n JcvAAo16YVEqHa1j7bTj3+LV5KpJhMrfCWq9L/LTDsUGr+1sDd9ccsBRQz0K6Qdv8c6Z\n 4lJg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776966899; x=1777571699;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=SkSqnJIKFJccGtzzarltZR7rtnS4SrG5UggZg7Ycww4=;\n b=sc7d8DUjZOFuhnhEj+LZ466AFAQTY2DXYN1s2K42qLoKPqkrCE2StGb7rpOZfFFtX5\n Eg49Fkyc7BwI1u9zqazdTAvALBNHDhG2QDGsNBwywuppjoicWwrYK/idSGdObk2+cedA\n xcUVLUY8XxZrLtjHUj4WsR8pxqZK+WzrmdvNHoqr4aloByUCY4MS5kITu8GvTE4vt51H\n 4QsHqzfDmC642io8U2R+MjlrDvc1H6ffNIwbNHzBev+sRgGVCRvUb3sIgUpE19HJdiQ6\n xeIz2O7izYwi2moTnMhuGY9czkPfuyUIxvQDFm9DTst/EPVCbajSvkhTuS2cwJRRHKUF\n l56w==","X-Gm-Message-State":"AOJu0YxQZ/0IQG2yxZqOtCVbnjV7pfkCIyokHNcxxYuYf3gqt3SLWbID\n mKwpBgSM5wATMRLNO2KbJftWdQHiDkgnnZJsDP2RqRHL9hxihJ0aELbwfsuvfZ7/QNtpD+7yuUI\n SL7HQ4isjk+RCZ5S/HuYLcMEN5pNYLQoTKi1dkCeQzhZ65u9BNwXmBYJgdZmCLrIbhFEa9fQubT\n mpeAyvUv9k9hOkD25XPvBSl4BMzUNcUWkmO8A=","X-Gm-Gg":"AeBDievOT800JYdiXlz/iWifRao9LHBz+T8xkiXY6mGpOhNK5IhW1eax4TD4/NjCNR/\n rdHG2qVCQvCY4xTAxQBTXkr4qw6gvvuIIJMwI0t2o+TcpEZYXlFodHYA3rwxB7YV5weK0Xjk3uP\n E5jzzS2al2TAJeOQYZqXMA4CAQfknOeWxPCu6MP34MPetZniUbM2lHLc6DuOjftHp1rFmaJ2B7D\n +gDsPbtzKTa7g==","X-Received":["by 2002:a05:7301:1292:b0:2c0:c415:cfd6 with SMTP id\n 5a478bee46e88-2e47873bca2mr15424348eec.13.1776966899398;\n Thu, 23 Apr 2026 10:54:59 -0700 (PDT)","by 2002:a05:7301:1292:b0:2c0:c415:cfd6 with SMTP id\n 5a478bee46e88-2e47873bca2mr15424323eec.13.1776966898827; Thu, 23 Apr 2026\n 10:54:58 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260423174330.1463462-1-avinal.xlvii@gmail.com>","In-Reply-To":"<20260423174330.1463462-1-avinal.xlvii@gmail.com>","From":"Andrew Pinski ","Date":"Thu, 23 Apr 2026 10:54:46 -0700","X-Gm-Features":"AQROBzDQ7fzDEbUq-YYfSO1Ek7adJoXuX5fz5q4DePbIlokulxGY6Wgz6tRLVNA","Message-ID":"\n ","Subject":"Re: [PATCH] tree-ssa-strlen: Replace with gimple_build [PR122989]","To":"Avinal Kumar ","Cc":"gcc-patches@gcc.gnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-GUID":"5r82DykhMSY-XcPGf4HaPrBsXHkqPDzS","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDIzMDE3MyBTYWx0ZWRfX4Wnb61GuM803\n g0nCxJhTgy9+5YdWAExJivmBgVB9LyeJHKHFOkiyPHCAU7sXWUZtzifEXyWeIujj0vFDilmx5Al\n V6pJiMu/no5OMawnGveiotzUm+3mmlNM6RBjrR3zX3gbtQNyAP9onMjotJFaS5BVNExqLJOPWR5\n nRXmF+LJ9KPOJyV5j6TH9sL6PF30k96RiJAhcMg1ZiCMYU1AAF5xn9GHFwWGwSk5GKphmvbefVF\n kDfQ6YfwIEIC7O0V2mWRwMCjDKUQvKc5zyrFyL74MpA996Jmbw9ODQ6mwW7goShbyhlkBybVlMB\n kLmT6B73jGmHAx8lSi7meAKmdBu6ArCn8ujY4scG50+zgjl9mDvwSVx2Ddj293iY6QLtz9pWDJk\n iEG7DAcRGCEsBd+gdqgOlCNnRIfqNq5MgKw9MOWkydn/sIfv+2rimvrcGo8Au/MF9ziFw7GdGIr\n h2sFNG55LsWiVibzh0A==","X-Proofpoint-ORIG-GUID":"5r82DykhMSY-XcPGf4HaPrBsXHkqPDzS","X-Authority-Analysis":"v=2.4 cv=Nv7htcdJ c=1 sm=1 tr=0 ts=69ea5cf4 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=Um2Pa8k9VHT-vaBCBUpS:22 a=pGLkceISAAAA:8 a=jHjsz9qEg7tvC5Z3yF0A:9\n a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0\n clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230173","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]